[jira] [Updated] (OFBIZ-6632) Incorrect comparison in TemporalExpressionWorker.java
[ https://issues.apache.org/jira/browse/OFBIZ-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6632: - Fix Version/s: (was: Upcoming Branch) > Incorrect comparison in TemporalExpressionWorker.java > - > > Key: OFBIZ-6632 > URL: https://issues.apache.org/jira/browse/OFBIZ-6632 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 14.12, Upcoming Branch >Reporter: Vyom Jain >Assignee: Michael Brohl > Fix For: 14.12.01, 12.04.06, 13.07.03 > > Attachments: OFBIZ-6632-Fixed-exprAssocType-values.patch > > > Line 128 in TemporalExpressionWorker.java does incorrect comparison > {code} > if ("SUBSTITUTION".equals(childExpression.get("exprAssocType"))) { > {code} should be > {code} > if ("SUBSTITUTE".equals(childExpression.get("exprAssocType"))) { > {code} > Also documentation of field exprAssocType in entity definition of > TemporalExpressionAssoc needs to be fixed. INCLUDED & EXCLUDED should be > INCLUDE & EXCLUDE respectively. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6632) Incorrect comparison in TemporalExpressionWorker.java
[ https://issues.apache.org/jira/browse/OFBIZ-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6632: - Fix Version/s: (was: Release Branch 14.12) 14.12.01 > Incorrect comparison in TemporalExpressionWorker.java > - > > Key: OFBIZ-6632 > URL: https://issues.apache.org/jira/browse/OFBIZ-6632 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 14.12, Upcoming Branch >Reporter: Vyom Jain >Assignee: Michael Brohl > Fix For: 14.12.01, 12.04.06, 13.07.03, Upcoming Branch > > Attachments: OFBIZ-6632-Fixed-exprAssocType-values.patch > > > Line 128 in TemporalExpressionWorker.java does incorrect comparison > {code} > if ("SUBSTITUTION".equals(childExpression.get("exprAssocType"))) { > {code} should be > {code} > if ("SUBSTITUTE".equals(childExpression.get("exprAssocType"))) { > {code} > Also documentation of field exprAssocType in entity definition of > TemporalExpressionAssoc needs to be fixed. INCLUDED & EXCLUDED should be > INCLUDE & EXCLUDE respectively. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6632) Incorrect comparison in TemporalExpressionWorker.java
[ https://issues.apache.org/jira/browse/OFBIZ-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6632: --- Fix Version/s: 13.07.03 12.04.06 Backported in R13.07 r1704064 R12.04 r1704065 > Incorrect comparison in TemporalExpressionWorker.java > - > > Key: OFBIZ-6632 > URL: https://issues.apache.org/jira/browse/OFBIZ-6632 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 14.12, Upcoming Branch >Reporter: Vyom Jain >Assignee: Michael Brohl > Fix For: Release Branch 14.12, 12.04.06, 13.07.03, Upcoming Branch > > Attachments: OFBIZ-6632-Fixed-exprAssocType-values.patch > > > Line 128 in TemporalExpressionWorker.java does incorrect comparison > {code} > if ("SUBSTITUTION".equals(childExpression.get("exprAssocType"))) { > {code} should be > {code} > if ("SUBSTITUTE".equals(childExpression.get("exprAssocType"))) { > {code} > Also documentation of field exprAssocType in entity definition of > TemporalExpressionAssoc needs to be fixed. INCLUDED & EXCLUDED should be > INCLUDE & EXCLUDE respectively. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6632) Incorrect comparison in TemporalExpressionWorker.java
[ https://issues.apache.org/jira/browse/OFBIZ-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6632: - Affects Version/s: (was: Trunk) Upcoming Branch Release Branch 14.12 > Incorrect comparison in TemporalExpressionWorker.java > - > > Key: OFBIZ-6632 > URL: https://issues.apache.org/jira/browse/OFBIZ-6632 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 14.12, Upcoming Branch >Reporter: Vyom Jain >Assignee: Michael Brohl > Attachments: OFBIZ-6632-Fixed-exprAssocType-values.patch > > > Line 128 in TemporalExpressionWorker.java does incorrect comparison > {code} > if ("SUBSTITUTION".equals(childExpression.get("exprAssocType"))) { > {code} should be > {code} > if ("SUBSTITUTE".equals(childExpression.get("exprAssocType"))) { > {code} > Also documentation of field exprAssocType in entity definition of > TemporalExpressionAssoc needs to be fixed. INCLUDED & EXCLUDED should be > INCLUDE & EXCLUDE respectively. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6632) Incorrect comparison in TemporalExpressionWorker.java
[ https://issues.apache.org/jira/browse/OFBIZ-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Becker updated OFBIZ-6632: - Sprint: Community Day 3 - 2015 > Incorrect comparison in TemporalExpressionWorker.java > - > > Key: OFBIZ-6632 > URL: https://issues.apache.org/jira/browse/OFBIZ-6632 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Vyom Jain > Attachments: OFBIZ-6632-Fixed-exprAssocType-values.patch > > > Line 128 in TemporalExpressionWorker.java does incorrect comparison > {code} > if ("SUBSTITUTION".equals(childExpression.get("exprAssocType"))) { > {code} should be > {code} > if ("SUBSTITUTE".equals(childExpression.get("exprAssocType"))) { > {code} > Also documentation of field exprAssocType in entity definition of > TemporalExpressionAssoc needs to be fixed. INCLUDED & EXCLUDED should be > INCLUDE & EXCLUDE respectively. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6632) Incorrect comparison in TemporalExpressionWorker.java
[ https://issues.apache.org/jira/browse/OFBIZ-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Becker updated OFBIZ-6632: - Attachment: OFBIZ-6632-Fixed-exprAssocType-values.patch Fixed the entitymodel.xml comment and the comparison in TemporalExpressionWorker and added constants for the three mentioned values. Maybe a Java Enum or the use of the OFBiz Enumeration for referential integrity in database may be a more complete solution. > Incorrect comparison in TemporalExpressionWorker.java > - > > Key: OFBIZ-6632 > URL: https://issues.apache.org/jira/browse/OFBIZ-6632 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Vyom Jain > Attachments: OFBIZ-6632-Fixed-exprAssocType-values.patch > > > Line 128 in TemporalExpressionWorker.java does incorrect comparison > {code} > if ("SUBSTITUTION".equals(childExpression.get("exprAssocType"))) { > {code} should be > {code} > if ("SUBSTITUTE".equals(childExpression.get("exprAssocType"))) { > {code} > Also documentation of field exprAssocType in entity definition of > TemporalExpressionAssoc needs to be fixed. INCLUDED & EXCLUDED should be > INCLUDE & EXCLUDE respectively. -- This message was sent by Atlassian JIRA (v6.3.4#6332)