[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901361#action_12901361 ] Erwan de FERRIERES commented on OFBIZ-3659: --- Hi all, what is missing on this issue to be integrated ? Cheers, Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854837#action_12854837 ] Bob Morley commented on OFBIZ-3659: --- Adrian -- That is precisely what I did and I don't really see what you are getting at. I just went and grabbed the fantastic mr. convert as well ... It is not distinctively different from what we are doing, if you ignore the fact that we can not use ant junit targets because we have to invoke our tests through start. They have a nicely isolated dependency grab; but the compile depends on it ... the only piece I see is it can be shutoff based on a a sysclasspath. What am I missing? Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854842#action_12854842 ] Adrian Crum commented on OFBIZ-3659: The metrics are not run unless you invoke Maven - mvn site:site. The normal build does not include metrics. So, we could have something similar (hopefully without Maven) that produces metrics outside a basic build. Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854791#action_12854791 ] Scott Gray commented on OFBIZ-3659: --- My only concern is that an automatic and transparent download may not constitute an optional dependency (since the user isn't really given an option). Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854794#action_12854794 ] Adrian Crum commented on OFBIZ-3659: Downloading Cobertura should be a part of the test process, not the build process. Ideally, we should have a new ant target - reports or metrics - that would include this and other code-quality reports. Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854800#action_12854800 ] Bob Morley commented on OFBIZ-3659: --- I agree; my initial approach was to include the download in the test process. The trouble is the cobertura jar is required to do our compile; if it is not present then our implementation of the instrumenter is not compiled and included in the (I think) base jar. There is another ant target for the reports already existing; this bug does not do anything with that -- this is the ability to compile with Cobertura so that when the test process executes it can instrument and generate the code coverage metrics. We can do some refactoring on the pluggable instrumentation implementation so that it has a separate build process from the main build. That is to say when you execute tests we could do an init-tests target that would download cobertura and build our integration class at that time. If you guys want me to bite off that then that is fine -- but what I would ask is that we remove the line that calls download-cobertura in my patch so that the other two targets are available to call manually. Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854803#action_12854803 ] Bob Morley commented on OFBIZ-3659: --- Scott -- is there a way we can parametrize the download process such that our automated ASF build will do the download (to ultimately get our frequent code coverage metrics) but have it remain manual for developers / end-users? That is really what I would want anyway (with no impact to developers / end-users). Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854804#action_12854804 ] Adrian Crum commented on OFBIZ-3659: Bob, Take a look at how Apache Commons does things. They download and execute a number of reporting tools that aren't included in the final library. It's pretty slick and extremely convenient. Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854806#action_12854806 ] Scott Gray commented on OFBIZ-3659: --- Adrian - Just because it's a local copy doesn't mean you're not going to distribute it and if you don't know that the metrics library is there then how would you know to exclude it? Example: Someone may decide to distribute a precompiled version of OFBiz for the convenience of the community. Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854807#action_12854807 ] Scott Gray commented on OFBIZ-3659: --- Bob: Buildbot can run any number of tasks in sequence, currently I think it does: svn co ... ant run-install ant run-tests ant docs-all then some other stuff for the nightly builds Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854808#action_12854808 ] Adrian Crum commented on OFBIZ-3659: Scott, If the user is running a separate ant task that downloads and executes a third-party library, then the user will be aware of it. We can even include that bit of information in the ant task's description. Compiling OFBiz != Downloading and executing code metrics. Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854811#action_12854811 ] Scott Gray commented on OFBIZ-3659: --- Adrian, You obviously haven't looked at the patch so I guess we're talking about different things. In the patch Compiling OFBiz == Downloading code metrics tools. Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854812#action_12854812 ] Adrian Crum commented on OFBIZ-3659: Scott, I looked at the patch, and I commented on it - Ideally, we should have a new ant target - reports or metrics - that would include this and other code-quality reports. Then Bob said - We can do some refactoring on the pluggable instrumentation implementation so that it has a separate build process from the main build. Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854815#action_12854815 ] Scott Gray commented on OFBIZ-3659: --- Okay, I still think it should be it's own manual step though and not automated. The new targets created in the patch look good to me, I just don't want them called from any processing targets. Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12854819#action_12854819 ] Bob Morley commented on OFBIZ-3659: --- Scott -- I have just left the two targets here that can be invoked manually. After verifying and doing a check-in, can you modify the Buildbot to do an ant download-cobertura after the svn checkout (but before the run-install). Adrian -- I hunted around Apache Commons; but not being very familiar I was not sure what I was looking for. I looked at IO because it had an old Cobertura report generated from 2008; but it appears they no longer generate code coverage that way. Commons Lang has code coverage but they use Bamboo/Clover. The one build file that had download-dependency target (it was for junit) was very nice, but all it really did was have their run-tests have dependency on it ... Whatever we do, if we are going to move the deployment of the jar so it is not a pre-req for our build, we will have to refactor so we can build our Cobertura integration pieces after the fact. This could manifest in a run-coverage-tests target, or something else -- but some work would have to be done. Download cobertura code coverage jar so it can be used to compile and execute tests with Key: OFBIZ-3659 URL: https://issues.apache.org/jira/browse/OFBIZ-3659 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bob Morley Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process. Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container). Net result is when we run our tests we will now get very nice code coverage metrics being generated. There is an existing target to generate the cobertura report (html) which is not automatically being executed. Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
