[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982517#action_12982517 ] Sascha Rodekamp commented on OFBIZ-4092: Oh yes that's really amazing, i like the new Flat Gray. Many Thanks *Ryan* and *Adrian* for your effort!!! Cheers Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982762#action_12982762 ] Ryan Foster commented on OFBIZ-4092: The _MACOSX folder is a hidden system folder for Apple. Not necessary. Feel free to blow that away. My original intent was actually to create a generic login screen style, similar to the way the BizznessTime theme, but that task got lost in the shuffle. I'll see if I can get you a new patch that addresses that within the next couple of days. All in all, I think everything looks great. I look forward to community feedback. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982778#action_12982778 ] Bruno Busco commented on OFBIZ-4092: This new Flat grey theme looks really good! Thank you guys. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982332#action_12982332 ] Jacques Le Roux commented on OFBIZ-4092: I like it, very fast acces to features, thanks guys! Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12981788#action_12981788 ] Adrian Crum commented on OFBIZ-4092: Ryan, Is there any chance you could upload what you have so far? Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982030#action_12982030 ] Adrian Crum commented on OFBIZ-4092: Thanks Ryan! I will work on finalizing the theme this weekend and get it committed. I understand an artist would have a problem with seeing scrollbars when font sizes are increased to a large size, but in the end the users of OFBiz have a job to do and work to get done. They won't mind the scrollbars if it means they can read the screen. Btw, on my HD widescreen monitor I can crank up the font size to 26 without any scrollbars. So, I'll probably put that back. The only other mods I will make will be bug fixes. I like what you've done, and I believe the updated theme will benefit the community. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982035#action_12982035 ] Adrian Crum commented on OFBIZ-4092: Ryan, Just curious - the subdued colors and app navigation selected style I suggested didn't look good to you? Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980770#action_12980770 ] Adrian Crum commented on OFBIZ-4092: Some thoughts on the text transformations... The upper case transformation looks good on main navigation and the application title. The lower case transformation on the application navigation looks bad. Most of the screen contains ul case text, and having one set of links that are all lower case makes that section of the screen look like it doesn't belong there. The same is true for the upper case buttons - they don't quite fit in with the rest of the screen. My recommendation would be to keep the upper case transformations on main navigation and application title, and drop the rest. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980862#action_12980862 ] Ryan Foster commented on OFBIZ-4092: I agree with you on the casing for the navigation and title. The casing on the buttons, and in fact the buttons themselves, are a different issue entirely. The reason why I changed the casing with CSS is because there is no consistency in casing in the markup and labels. Some button labels and values are all caps, some are lowercase, some are normal case; it's all over the map. Button styling in OFBiz has been something that has bugged me for years and I think it would be very beneficial to look at this as a separate issue in the near future. There are currently 13, yes 13!, different button styles currently defined right now. Just look at lines 2556 through 2573 in maincss.css. We have: .buttontext, .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit, .loginButton, .button-style-1, .button-style-2, .button, button, input[type=reset], input[type=submit], input[type=button] it's kind of ridiculous. Why can't we simply have 1 button class and call it some obvious like .button or .btn? We have been having a great discussion on UI labeling consistency, Edit vs. Update vs. Save, etc. which is awesome, but I think all of that is meaningless if the buttons themselves don't look the same. Okay, I'll end my rant there. Can you tell this is something of a hot button issue with me, pun completely intended ;) Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980872#action_12980872 ] Adrian Crum commented on OFBIZ-4092: I understand your frustration. When the new styles were created the old styles were deprecated and we started to remove them - but that effort eventually fizzled out. In addition, we just introduced more styles with JQuery. I agree it's a mess and we should create a new issue for that. Or we could just delete the deprecated styles from the style sheet and let the elements that use them break - that might motivate others to stop using them. I started a Wiki page to document current styles and their intended use, but it hasn't been kept up-to-date: https://cwiki.apache.org/OFBIZ/ofbiz-maincsscss-html-element-collection-styles.html Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883 ] Ryan Foster commented on OFBIZ-4092: I tried deleting deprecated styles and letting things break when I created the BizznessTime theme... mostly just pissed people off. :) Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980884#action_12980884 ] Jacques Le Roux commented on OFBIZ-4092: Yes, I agree we should really do an effort regarding this aspect an other closely related. As Adrian outlined, consistence is a key point! Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
In addition, when deprecating or selecting styles to be used we should better use style names that describe what the button IS in the screen and not HOW it should appear. So style names like .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit, .button-style-1, .button-style-2, should not be used. Style names like: .buttontext, .loginButton, .button, input[type=reset], input[type=submit], input[type=button] are OK. In this way the theme can make a button larger or smaller than another button according to its function. My two cents. -Bruno 2011/1/12 Ryan Foster (JIRA) j...@apache.org [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883] Ryan Foster commented on OFBIZ-4092: I tried deleting deprecated styles and letting things break when I created the BizznessTime theme... mostly just pissed people off. :) Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
Bruno, I'll see your 2 cents, and raise you a dollar. I agree, the naming of an element should never dictate how it looks or behaves; that is what properties are for. You are opening up a can of worms with me when you start down that path, so careful what you wish for. Buttons aren't the only offenders when it comes to that, the problem starts with the main decorator. The layout of the backend and the front end center around the fact that we have column layouts with classNames of .left, .right, and .center. What if I don't want .left on the left anymore?... Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Jan 12, 2011, at 1:01 PM, Bruno Busco wrote: In addition, when deprecating or selecting styles to be used we should better use style names that describe what the button IS in the screen and not HOW it should appear. So style names like .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit, .button-style-1, .button-style-2, should not be used. Style names like: .buttontext, .loginButton, .button, input[type=reset], input[type=submit], input[type=button] are OK. In this way the theme can make a button larger or smaller than another button according to its function. My two cents. -Bruno 2011/1/12 Ryan Foster (JIRA) j...@apache.org [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883] Ryan Foster commented on OFBIZ-4092: I tried deleting deprecated styles and letting things break when I created the BizznessTime theme... mostly just pissed people off. :) Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Discussion: CSS styles (was: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme)
We need the smallSubmit style so we can style links to look like submit buttons. Maybe we could change the CSS class to a.smallSubmit to make sure it is used only for a elements. The button-style-1 and button-style-2 style names are pretty generic - they don't indicate how the button should appear (aside from the obvious - that they should look like buttons). Originally, the rows of buttons below the page title had two styles that indicated two types of buttons: those that linked to other pages within the application (intra-app) and others that linked to pages outside the application (inter-app). That distinction has been lost in recent changes. A similar thing was done with the table header styles - there are two styles to choose from, depending on how you use them. The style names don't indicate what they look like. I don't think there is anything wrong with having more than one style to choose from. If we were to cut back too much on the selection, then the UI would start to look bland or monotonous. I created a Wiki page that listed some of the deprecated styles and another page that describes the new styles and how they should be used. Those pages are effective only when people take the time to read them. -Adrian On 1/12/2011 12:01 PM, Bruno Busco wrote: In addition, when deprecating or selecting styles to be used we should better use style names that describe what the button IS in the screen and not HOW it should appear. So style names like .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit, .button-style-1, .button-style-2, should not be used. Style names like: .buttontext, .loginButton, .button, input[type=reset], input[type=submit], input[type=button] are OK. In this way the theme can make a button larger or smaller than another button according to its function. My two cents. -Bruno 2011/1/12 Ryan Foster (JIRA)j...@apache.org [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883] Ryan Foster commented on OFBIZ-4092: I tried deleting deprecated styles and letting things break when I created the BizznessTime theme... mostly just pissed people off. :) Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Discussion: CSS styles (was: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme)
Consistency is not synonymous with monotonous. Hey, that sounds like a good catch phrase... Consistency is not synonymous with monotonous™ But seriously, if different elements perform the same way then they should look the same and be called the same thing. There is no reason why we can't have button class=btn, input type=submit class=btn, and a class=btn if they all do the same thing. That doesn't make the UI bland, it makes it consistent and familiar. I'm all for having options, but they should be done with a purpose. For instance, we could a primary button style, a secondary button style and a tertiary button style, but these should be combinations, not individual style. For example: a href=# class=btn primary a href=# class=btn secondary a href=# class=btn tertiary That way, we could apply a consistent button style and then make adjustments if we need to based on what action the button performs, Save vs. Cancel, etc. But simply having a button-style-1, and a button-style-2 because maybe we want to have a blue button and a green button is not a good reason, no is it a good idea. Having 2 buttons that perform the same, but look different just confuses the user and makes an already complex application even more difficult to use. Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Jan 12, 2011, at 1:30 PM, Adrian Crum wrote: We need the smallSubmit style so we can style links to look like submit buttons. Maybe we could change the CSS class to a.smallSubmit to make sure it is used only for a elements. The button-style-1 and button-style-2 style names are pretty generic - they don't indicate how the button should appear (aside from the obvious - that they should look like buttons). Originally, the rows of buttons below the page title had two styles that indicated two types of buttons: those that linked to other pages within the application (intra-app) and others that linked to pages outside the application (inter-app). That distinction has been lost in recent changes. A similar thing was done with the table header styles - there are two styles to choose from, depending on how you use them. The style names don't indicate what they look like. I don't think there is anything wrong with having more than one style to choose from. If we were to cut back too much on the selection, then the UI would start to look bland or monotonous. I created a Wiki page that listed some of the deprecated styles and another page that describes the new styles and how they should be used. Those pages are effective only when people take the time to read them. -Adrian On 1/12/2011 12:01 PM, Bruno Busco wrote: In addition, when deprecating or selecting styles to be used we should better use style names that describe what the button IS in the screen and not HOW it should appear. So style names like .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit, .button-style-1, .button-style-2, should not be used. Style names like: .buttontext, .loginButton, .button, input[type=reset], input[type=submit], input[type=button] are OK. In this way the theme can make a button larger or smaller than another button according to its function. My two cents. -Bruno 2011/1/12 Ryan Foster (JIRA)j...@apache.org [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883] Ryan Foster commented on OFBIZ-4092: I tried deleting deprecated styles and letting things break when I created the BizznessTime theme... mostly just pissed people off. :) Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
That's great guys, but it would be better if you could keep your comments in the OFBIZ-4092 Really easier later when looking back to have things centralized somewhere (I saw Adrian tried to create a new thread...) Thanks Jacques Ryan Foster wrote: Bruno, I'll see your 2 cents, and raise you a dollar. I agree, the naming of an element should never dictate how it looks or behaves; that is what properties are for. You are opening up a can of worms with me when you start down that path, so careful what you wish for. Buttons aren't the only offenders when it comes to that, the problem starts with the main decorator. The layout of the backend and the front end center around the fact that we have column layouts with classNames of .left, .right, and .center. What if I don't want .left on the left anymore?... Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Jan 12, 2011, at 1:01 PM, Bruno Busco wrote: In addition, when deprecating or selecting styles to be used we should better use style names that describe what the button IS in the screen and not HOW it should appear. So style names like .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit, .button-style-1, .button-style-2, should not be used. Style names like: .buttontext, .loginButton, .button, input[type=reset], input[type=submit], input[type=button] are OK. In this way the theme can make a button larger or smaller than another button according to its function. My two cents. -Bruno 2011/1/12 Ryan Foster (JIRA) j...@apache.org [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883] Ryan Foster commented on OFBIZ-4092: I tried deleting deprecated styles and letting things break when I created the BizznessTime theme... mostly just pissed people off. :) Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980201#action_12980201 ] Adrian Crum commented on OFBIZ-4092: Ryan, A few more suggestions: 1. app-navigation h1-h3 class, try color: #959595; 2. h1 and page-title classes, try color: #557996; I like how your initial version toned down the contrasting colors, and these suggestions follow that concept. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980217#action_12980217 ] Ryan Foster commented on OFBIZ-4092: I agree with you. I'm starting to stray from my original design concept which was meant to be subtle, sophisticated and conservative. Things are starting to pop out a bit too much in places. Time to rein it in ;). I'll take a look at this today. We are definitely very close. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980331#action_12980331 ] Ryan Foster commented on OFBIZ-4092: I'll do my best to take a look at what you have and finalize my changes today. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979626#action_12979626 ] Ryan Foster commented on OFBIZ-4092: Oops, sorry Adrian. I actually just did all these same things from your latest patch over the weekend. No big deal, I'll just patch your patch and go from there. What other items do you have on your priority list that you are working on so we are not stepping on each others toes? Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979632#action_12979632 ] Ryan Foster commented on OFBIZ-4092: I'm not sure that hard-coding the column count to 7 is that big of a deal. That 7 is actually a max of 7, not a hard seven. The script loops through the list items and fills the columns from top to bottom, left to right until it reaches the end of the list. So, if there are only 8 applications in the list, you will only have 2 columns, 12 apps means 3 columns, etc. 7 was chosen because that is the break point of the horizontal fold. Anymore that 7 columns and a horizontal scrollbar is created on an 800px width browser viewport. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979640#action_12979640 ] Adrian Crum commented on OFBIZ-4092: Ryan, No worries. I also worked on making the masthead and main-navigation resizable - so they grow and shrink with font size changes. I would prefer to defer to you - you're the master, I'm the grasshopper. I will wait for your update before proceeding further. The main thing is to use Firefox, turn off JavaScript, change the default font to 24 or higher, resize the screen and see what happens. The layout in the patch you provided breaks badly under those conditions. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979639#action_12979639 ] Ryan Foster commented on OFBIZ-4092: I also noticed you changed the design objectives to include a statement that javascript should not be required. If that is the case, then I will really have to step back and think about my approach for graceful degradation on the main navigation since the key design principle for this section is based on the fact that the list falls into columns. I am curious as to why you feel this should be a key objective. Since the framework web apps themselves are heavily dependent on javascript in certain areas, shouldn't it be assumed that the user will always have javascript available? If they don't, they are going have a lot more issues with functionality than just having a visual display that is a little off. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979641#action_12979641 ] Adrian Crum commented on OFBIZ-4092: I added the 4th item because it was a part of the original Flat Grey theme, but I forgot to include it when I created this issue. As far as I know, the screen widget renderers check to see if JavaScript is enabled and output the appropriate markup. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979652#action_12979652 ] Ryan Foster commented on OFBIZ-4092: hmm... Is there a way we can do something similar using FreeMarker in appbar.ftl instead of using Javascript? Could we create a macro that reads the numbers of apps then outputs a series of lists in the appropriate amount of columns. If that is possible that would actually be a better solution since then we wouldn't have to wait until the page fully loads and the DOM is ready before applying the column styling. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979657#action_12979657 ] Adrian Crum commented on OFBIZ-4092: It's in my patch. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979870#action_12979870 ] Ryan Foster commented on OFBIZ-4092: duh, I guess I should have actually read your patch first before I started thinking out loud. Your solution looks great. I made couple of small tweaks to it to remove some markup that I thought wasn't really necessary. For instance, we don't really need to enclose each app title in in a p tag since the a is already set to display block. I also put a set height to the li tag and removed the empty p tags with spaces from the last li. Please don't take this personally, but one of my biggest pet peeves is using spaces and breaks in markup to control layout. Let's try to avoid that as much as possible. I have incorporated the changes from your last patch and made a few more design changes as well in my latest patch. 1. added additional styling to the main navigation to highlight the select app a bit more. 2. expanded on your change to the selected app navigation link to give it even more distinction 3. enhanced the styling of the tab-bar area. 4. added some misc. CSS3 styling enhancements to main nav and app nav areas for browsers that support text-shadow. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979955#action_12979955 ] Adrian Crum commented on OFBIZ-4092: Also note that I changed the bevels in the main-navigation so their shadow matches the other elements. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12978243#action_12978243 ] Bruno Busco commented on OFBIZ-4092: I have an idea for the tab bar. We all agree that it does not show well when it comes to two or three rows. Well, we could only show the tabs that fit in one row and add a tab as last tab. When hovering on the tab the remaining tabs appear like a pull down menu allowing the user to select one of them. The actually selected tab should always be showed as the fist element on the left. What do you think? Could it be done with some jquery script? Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12977470#action_12977470 ] Ryan Foster commented on OFBIZ-4092: I suggest making a few small markup changes in order to bring this theme up to date. For instance, the secondary app bar in the footer uses the deprecated center/center tag. Things like this should be cleaned up. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12977485#action_12977485 ] Ryan Foster commented on OFBIZ-4092: I have attached screen grabs of my WIP. Here is a quick breakdown of changes: 1. Remove top tab navigation and replace with a column list navigation. 2. Move user preferences to footer. 3. Move secondary apps to top nav and integrate with main apps in column list navigation 4. Remove unnecessary CSS and XHTML validation icons from footer (I don't think that the markup has validated 100% for a while. C'est la vie, but let's no draw attention to it) 5. Removed collapsed header preference and instead keep header collapsed permanently to save space. 6. Update general look and feel. 7. Update form and buttons styles Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, partyDetail.png, partyManager.png, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12977493#action_12977493 ] Adrian Crum commented on OFBIZ-4092: Ryan - this looks great! I would like to test it on my local copy tonight. I'm mostly concerned with how it will behave in a framework-only installation (that's what got me started on this subject). Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12977501#action_12977501 ] Ryan Foster commented on OFBIZ-4092: Thanks. Good luck. Let me know if you run into any problems. I sure there will be a bug or two, as I have to admit that I just got a spark of an idea and just banged this all out last night. I haven't done thorough browser tested yet, but it looks good so far on FF, Safari, and Chrome. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12976956#action_12976956 ] Adrian Crum commented on OFBIZ-4092: Some suggestions from the dev mailing list (one of these was made a while back): 1. Title bars less dark - so you don't have the dark horizontal bands in screens with screenlets. 2. Keep the main navigation tab bar on top. 3. Make the main navigation a collapsible column. 4. Keep the markup the same so Selenium tests will still pass. The community is welcome to comment and offer more suggestions. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.