[jira] Updated: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1698: --- Attachment: cleanlabels_1.zip Jacques, yes I am still interesting in this issue. In the attached file cleanlabels_1.zip I have included a new version of the script which now scans some new added UiLabels files and fixes the quot; problem. The problem on the file header I did not manage to fix it and so I changed the files manually. I have run the script on the latest trunk and included the patch in the zip file. About your suggestion about moving automatically the labels in the proper file looking at the name I do not have time to implement it but I think it is better to commit this patch that removes all the duplications (636 have been found and rempved). Then without duplications the moving of the labels will be simpler and could also be done manually. Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip, cleanlabels_1.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1698: --- Attachment: cleanlabels.patch.zip Hi Jacques, i have updated the script with your suggestion about the files hierarchy and have attached the cleanlabels.patch.zip that includes the (large) patch, the updated script that has been used and the script report file. According to the script report the patch removes 887 redundant label definitions. Of course a deep test must be done to be sure that all labels are still found. Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1698: --- Attachment: (was: cleanlabels.py) Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1698: --- Attachment: cleanlabels.py Jacques, i have written the python script attached (cleanlabels.py) that does a complete scan of the specified files for label duplication. If a duplication is found it merges all new languages eventually found and then deletes the label duplications. To use the script simply copy it in the ofbiz root folder and run it. I have made some assumption regarding the file dependencies (you can check the labelFileList variable. The dependency can be changed by simply swapping the file names in the list. The upper files are the most fundamental files and then mode dependent ones come. I have run the script against my ofbiz trunk rev.636622 and 888 duplicated labels have been removed. This is the report i get from the script. = Number of processed files : 31 Number of processed labels : 9003 Number of removed labels : 888 = Using the changed label files all labels are now displayed correctly in italian becouse no duplication is found and the languages have been merged. A thing that should be still done on the xml files after the script execution is a sort for languages becouse during merge the new languages are simply added at the bottom of languages list (i have not found a way to easily sort it). I hope this script will be usefull. Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.py A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1698: --- Summary: Locale labels in language different from the fallback sometime are not displayed (was: Locale labels in language dirrerent from the fallback sometime are not displayed) Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
