[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376437#comment-15376437
 ] 

Jacques Le Roux commented on OFBIZ-7532:


Hi PIerre, yes sure sounds interesting

Please Charles update your patch. I have removed widget-form-ns.xsd, we have 
only widget-form-xsd which contains both. Thanks!

> Form Display Field improvement to manage multiple number format
> ---
>
> Key: OFBIZ-7532
> URL: https://issues.apache.org/jira/browse/OFBIZ-7532
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Charles STELTZLEN
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-7532.patch
>
>
> On display field used in forms, there is a "type" "accounting-number" which 
> is used to format number like property configuration :  
> #,##0.;(#,##0.).
> This JIRA propose to extend this idea by using a "type" "number" and an 
> additional attribute called "format-pattern". This field will be used by form 
> renderer to get the good property. It use FlexibleString to manage variable 
> in this field and so allow to have different format for the same column 
> according to some conditions.
> example:  format-pattern="accounting"/>
> The "format-pattern" will be stored in arithmetic.properties.
> example:
> # the default number format 
> default.number.format = ##0.00
> accounting.number.format = #,##0.;(#,##0.)
> quantity.number.format = ##0.00
> integer-quantity.number.format = #0
> percentage.number.format = ##.##%
> export.number.format = #.00
> In ModelFormField.java, the system gets property using 
> EntityUtilProperties.getPropertyValue to ba able to quickly add a new format.
> I think that it will require a discussion on Dev mailing-list to validate the 
> choices.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7532) Form Display Field improvement to manage multiple number format

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-7532:
--

Assignee: Jacques Le Roux

> Form Display Field improvement to manage multiple number format
> ---
>
> Key: OFBIZ-7532
> URL: https://issues.apache.org/jira/browse/OFBIZ-7532
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Charles STELTZLEN
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-7532.patch
>
>
> On display field used in forms, there is a "type" "accounting-number" which 
> is used to format number like property configuration :  
> #,##0.;(#,##0.).
> This JIRA propose to extend this idea by using a "type" "number" and an 
> additional attribute called "format-pattern". This field will be used by form 
> renderer to get the good property. It use FlexibleString to manage variable 
> in this field and so allow to have different format for the same column 
> according to some conditions.
> example:  format-pattern="accounting"/>
> The "format-pattern" will be stored in arithmetic.properties.
> example:
> # the default number format 
> default.number.format = ##0.00
> accounting.number.format = #,##0.;(#,##0.)
> quantity.number.format = ##0.00
> integer-quantity.number.format = #0
> percentage.number.format = ##.##%
> export.number.format = #.00
> In ModelFormField.java, the system gets property using 
> EntityUtilProperties.getPropertyValue to ba able to quickly add a new format.
> I think that it will require a discussion on Dev mailing-list to validate the 
> choices.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373413#comment-15373413
 ] 

Pierre Smits commented on OFBIZ-7532:
-

[~jacques.le.roux] You wanted more discussions regarding this issue, but it has 
not led to more interactions. Is this going to be incorporated in the code base?

> Form Display Field improvement to manage multiple number format
> ---
>
> Key: OFBIZ-7532
> URL: https://issues.apache.org/jira/browse/OFBIZ-7532
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Charles STELTZLEN
>Priority: Minor
> Attachments: OFBIZ-7532.patch
>
>
> On display field used in forms, there is a "type" "accounting-number" which 
> is used to format number like property configuration :  
> #,##0.;(#,##0.).
> This JIRA propose to extend this idea by using a "type" "number" and an 
> additional attribute called "format-pattern". This field will be used by form 
> renderer to get the good property. It use FlexibleString to manage variable 
> in this field and so allow to have different format for the same column 
> according to some conditions.
> example:  format-pattern="accounting"/>
> The "format-pattern" will be stored in arithmetic.properties.
> example:
> # the default number format 
> default.number.format = ##0.00
> accounting.number.format = #,##0.;(#,##0.)
> quantity.number.format = ##0.00
> integer-quantity.number.format = #0
> percentage.number.format = ##.##%
> export.number.format = #.00
> In ModelFormField.java, the system gets property using 
> EntityUtilProperties.getPropertyValue to ba able to quickly add a new format.
> I think that it will require a discussion on Dev mailing-list to validate the 
> choices.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7532) Form Display Field improvement to manage multiple number format

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371096#comment-15371096
 ] 

Pierre Smits edited comment on OFBIZ-7532 at 7/11/16 4:25 PM:
--

I see nothing wrong with this issue. It is a sound improvement.

And the patch looks equally fine.

We don't need to discuss a trivial aspect like the validation of choices. There 
are lots of best practices that can be found. It only needs one to start with. 
The rest can be covered through follow-up JIRA issues.

I don't believe we need contributors second-guessing their judgement after they 
have created their issues with the best of intentions, by doing a do-over of 
the issue in a mail thread in the dev mailing list.

The only thing I find missing in the patch is addressing the properties for 
multi-tenant usage, meaning an enhancement of the seed data set with respect to 
the SystemProperty value(s) desired. See OFBIZ-6164


was (Author: pfm.smits):
I see nothing wrong with this issue. It is a sound improvement.

And the patch looks equally fine.

We don't need discuss a trivial aspect like the validation of choices. There 
are lots of best practices that can be found. It only needs one to start with. 
The rest can be covered through follow-up JIRA issues.

I don't believe we need contributors second-guessing their judgement after they 
have created their issues with the best of intentions, by doing a do-over of 
the issue in a mail thread in the dev mailing list.

The only thing I find missing in the patch is addressing the properties for 
multi-tenant usage, meaning an enhancement of the seed data set with respect to 
the SystemProperty value(s) desired. See OFBIZ-6164

> Form Display Field improvement to manage multiple number format
> ---
>
> Key: OFBIZ-7532
> URL: https://issues.apache.org/jira/browse/OFBIZ-7532
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Charles STELTZLEN
>Priority: Minor
> Attachments: OFBIZ-7532.patch
>
>
> On display field used in forms, there is a "type" "accounting-number" which 
> is used to format number like property configuration :  
> #,##0.;(#,##0.).
> This JIRA propose to extend this idea by using a "type" "number" and an 
> additional attribute called "format-pattern". This field will be used by form 
> renderer to get the good property. It use FlexibleString to manage variable 
> in this field and so allow to have different format for the same column 
> according to some conditions.
> example:  format-pattern="accounting"/>
> The "format-pattern" will be stored in arithmetic.properties.
> example:
> # the default number format 
> default.number.format = ##0.00
> accounting.number.format = #,##0.;(#,##0.)
> quantity.number.format = ##0.00
> integer-quantity.number.format = #0
> percentage.number.format = ##.##%
> export.number.format = #.00
> In ModelFormField.java, the system gets property using 
> EntityUtilProperties.getPropertyValue to ba able to quickly add a new format.
> I think that it will require a discussion on Dev mailing-list to validate the 
> choices.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Form Display Field improvement to manage multiple number format

[Pierre Smits]

Hi Charles,

See my comment in https://issues.apache.org/jira/browse/OFBIZ-7532.

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Jul 11, 2016 at 3:43 PM, Charles STELTZLEN <
charles.steltz...@nereide.biz> wrote:

> Hi,
>
> On display field used in Forms, there is a "type" "accounting-number"
> which is used to format number like 'accounting-number.format' property
> configuration (arithmetic.properties) :  #,##0.;(#,##0.).
>
> The proposal is to extend this idea by using a "type" "number" and an
> additional attribute called "format-pattern". This field will be used by
> form renderer to get the good property. It use FlexibleString to manage
> variable in this field and so allow to have different format for the same
> column according to some conditions.
>
> example:
>
>format-pattern="accounting"/>
>
> The "format-pattern" will be stored in the arithmetic.properties.
>
> example:
>
>   # the default number format
>   default.number.format = ##0.00
>   accounting.number.format = #,##0.;(#,##0.)
>   quantity.number.format = ##0.00
>   integer-quantity.number.format = #0
>   percentage.number.format = ##.##%
>   export.number.format = #.00
>
> In ModelFormField.java, the system gets property using
> EntityUtilProperties.getPropertyValue to be able to quickly add a new
> format.
>
> A JIRA exists on this proposition (opened to soon as Jacques mentionned ) :
> https://issues.apache.org/jira/browse/OFBIZ-7532
> Do think that this proposal is a good one ?
>
> Best regards,
> Charles
>
>
>

[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371096#comment-15371096
 ] 

Pierre Smits commented on OFBIZ-7532:
-

I see nothing wrong with this issue. It is a sound improvement.

And the patch looks equally fine.

We don't need discuss a trivial aspect like the validation of choices. There 
are lots of best practices that can be found. It only needs one to start with. 
The rest can be covered through follow-up JIRA issues.

I don't believe we need contributors second-guessing their judgement after they 
have created their issues with the best of intentions, by doing a do-over of 
the issue in a mail thread in the dev mailing list.

The only thing I find missing in the patch is addressing the properties for 
multi-tenant usage, meaning an enhancement of the seed data set with respect to 
the SystemProperty value(s) desired. See OFBIZ-6164

> Form Display Field improvement to manage multiple number format
> ---
>
> Key: OFBIZ-7532
> URL: https://issues.apache.org/jira/browse/OFBIZ-7532
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Charles STELTZLEN
>Priority: Minor
> Attachments: OFBIZ-7532.patch
>
>
> On display field used in forms, there is a "type" "accounting-number" which 
> is used to format number like property configuration :  
> #,##0.;(#,##0.).
> This JIRA propose to extend this idea by using a "type" "number" and an 
> additional attribute called "format-pattern". This field will be used by form 
> renderer to get the good property. It use FlexibleString to manage variable 
> in this field and so allow to have different format for the same column 
> according to some conditions.
> example:  format-pattern="accounting"/>
> The "format-pattern" will be stored in arithmetic.properties.
> example:
> # the default number format 
> default.number.format = ##0.00
> accounting.number.format = #,##0.;(#,##0.)
> quantity.number.format = ##0.00
> integer-quantity.number.format = #0
> percentage.number.format = ##.##%
> export.number.format = #.00
> In ModelFormField.java, the system gets property using 
> EntityUtilProperties.getPropertyValue to ba able to quickly add a new format.
> I think that it will require a discussion on Dev mailing-list to validate the 
> choices.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Form Display Field improvement to manage multiple number format

[Charles STELTZLEN]

Hi,

On display field used in Forms, there is a "type" "accounting-number" 
which is used to format number like 'accounting-number.format' property 
configuration (arithmetic.properties) :  #,##0.;(#,##0.).


The proposal is to extend this idea by using a "type" "number" and an 
additional attribute called "format-pattern". This field will be used by 
form renderer to get the good property. It use FlexibleString to manage 
variable in this field and so allow to have different format for the 
same column according to some conditions.


example:

  format-pattern="accounting"/>


The "format-pattern" will be stored in the arithmetic.properties.

example:

  # the default number format
  default.number.format = ##0.00
  accounting.number.format = #,##0.;(#,##0.)
  quantity.number.format = ##0.00
  integer-quantity.number.format = #0
  percentage.number.format = ##.##%
  export.number.format = #.00

In ModelFormField.java, the system gets property using 
EntityUtilProperties.getPropertyValue to be able to quickly add a new 
format.


A JIRA exists on this proposition (opened to soon as Jacques mentionned 
) :https://issues.apache.org/jira/browse/OFBIZ-7532

Do think that this proposal is a good one ?

Best regards,
Charles

[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342685#comment-15342685
 ] 

Jacques Le Roux commented on OFBIZ-7532:


bq. I think that it will require a discussion on Dev mailing-list to validate 
the choices.
The best practice is to discuss before creating the Jira ;)

> Form Display Field improvement to manage multiple number format
> ---
>
> Key: OFBIZ-7532
> URL: https://issues.apache.org/jira/browse/OFBIZ-7532
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Charles STELTZLEN
>Priority: Minor
> Attachments: OFBIZ-7532.patch
>
>
> On display field used in forms, there is a "type" "accounting-number" which 
> is used to format number like property configuration :  
> #,##0.;(#,##0.).
> This JIRA propose to extend this idea by using a "type" "number" and an 
> additional attribute called "format-pattern". This field will be used by form 
> renderer to get the good property. It use FlexibleString to manage variable 
> in this field and so allow to have different format for the same column 
> according to some conditions.
> example:  format-pattern="accounting"/>
> The "format-pattern" will be stored in arithmetic.properties.
> example:
> # the default number format 
> default.number.format = ##0.00
> accounting.number.format = #,##0.;(#,##0.)
> quantity.number.format = ##0.00
> integer-quantity.number.format = #0
> percentage.number.format = ##.##%
> export.number.format = #.00
> In ModelFormField.java, the system gets property using 
> EntityUtilProperties.getPropertyValue to ba able to quickly add a new format.
> I think that it will require a discussion on Dev mailing-list to validate the 
> choices.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7532) Form Display Field improvement to manage multiple number format

[Charles STELTZLEN (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles STELTZLEN updated OFBIZ-7532:
-
Attachment: OFBIZ-7532.patch

> Form Display Field improvement to manage multiple number format
> ---
>
> Key: OFBIZ-7532
> URL: https://issues.apache.org/jira/browse/OFBIZ-7532
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Charles STELTZLEN
>Priority: Minor
> Attachments: OFBIZ-7532.patch
>
>
> On display field used in forms, there is a "type" "accounting-number" which 
> is used to format number like property configuration :  
> #,##0.;(#,##0.).
> This JIRA propose to extend this idea by using a "type" "number" and an 
> additional attribute called "format-pattern". This field will be used by form 
> renderer to get the good property. It use FlexibleString to manage variable 
> in this field and so allow to have different format for the same column 
> according to some conditions.
> example:  format-pattern="accounting"/>
> The "format-pattern" will be stored in arithmetic.properties.
> example:
> # the default number format 
> default.number.format = ##0.00
> accounting.number.format = #,##0.;(#,##0.)
> quantity.number.format = ##0.00
> integer-quantity.number.format = #0
> percentage.number.format = ##.##%
> export.number.format = #.00
> In ModelFormField.java, the system gets property using 
> EntityUtilProperties.getPropertyValue to ba able to quickly add a new format.
> I think that it will require a discussion on Dev mailing-list to validate the 
> choices.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7532) Form Display Field improvement to manage multiple number format

[Charles STELTZLEN (JIRA)]

Charles STELTZLEN created OFBIZ-7532:


 Summary: Form Display Field improvement to manage multiple number 
format
 Key: OFBIZ-7532
 URL: https://issues.apache.org/jira/browse/OFBIZ-7532
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Charles STELTZLEN
Priority: Minor


On display field used in forms, there is a "type" "accounting-number" which is 
used to format number like property configuration :  #,##0.;(#,##0.).

This JIRA propose to extend this idea by using a "type" "number" and an 
additional attribute called "format-pattern". This field will be used by form 
renderer to get the good property. It use FlexibleString to manage variable in 
this field and so allow to have different format for the same column according 
to some conditions.

example: 

The "format-pattern" will be stored in arithmetic.properties.

example:
# the default number format 
default.number.format = ##0.00
accounting.number.format = #,##0.;(#,##0.)
quantity.number.format = ##0.00
integer-quantity.number.format = #0
percentage.number.format = ##.##%
export.number.format = #.00

In ModelFormField.java, the system gets property using 
EntityUtilProperties.getPropertyValue to ba able to quickly add a new format.

I think that it will require a discussion on Dev mailing-list to validate the 
choices.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)