Re: JUnit 5?
Thank you Girish for copying in OFBIZ-11870,
I still not had the time to think at your question :)
Jacques
Le 06/07/2020 à 07:39, Girish Vasmatkar a écrit :
Hi All
OFBiz integration tests are based on classes extending the TestCase class.
Should we not allow for a hybrid way of writing integration test cases
based on classes that do not extend TestCase while also allowing old ways
(extending TestCase and test methods starting with test) of writing test
cases?
Is there any particular reason why we are still using TestCase class?
Best
Girish
On Sun, Jul 5, 2020 at 1:44 PM Jacques Le Roux
wrote:
Thanks Eugen,
That's quite interesting, could you please put your comment in the Jira?
TIA
Jacques
Le 05/07/2020 à 09:36, Eugen Stan a écrit :
Hello Jacques,
I think it makes sense to make the transition.
In James we do have it ongoing.
Junit5 people have documented the upgrade process and you can make it
gradually and have both.
Use ` git grep org.junit.Test | wc -l `to count the non-migrated tests.
This is what we have based on the migration samples
https://github.com/junit-team/junit5-samples#gradle-migration-
https://github.com/junit-team/junit5-samples/blob/main/junit5-migration-gradle/build.gradle
https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.1'
testImplementation 'org.junit.jupiter:junit-jupiter-params:5.5.1'
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.1'
testCompileOnly 'junit:junit:4.13'
testRuntimeOnly 'org.junit.vintage:junit-vintage-engine:5.5.1'
}
test {
useJUnitPlatform()
}
La 05.07.2020 10:01, Jacques Le Roux a scris:
I created https://issues.apache.org/jira/browse/OFBIZ-11870 for that
Jacques
Le 04/09/2018 à 09:15, Jacques Le Roux a écrit :
Hi,
I stumbled upon this tweet
https://twitter.com/junitteam/status/1036707906706698243
Had a quick look at
https://junit.org/junit5/docs/5.3.0/release-notes/
https://www.baeldung.com/junit-5-migration
I did not rememberf, so searched if we discussed moving from JUnit 4
to JUnit 5, but did not find anything.
Did we discuss it, if so what were the conclusions? If not, should we
not discuss it?
Thanks
https://twitter.com/junitteam/status/1036707906706698243witter.com/junitteam/status/1036707906706698243
Jacques
Re: JUnit 5?
Hi All
OFBiz integration tests are based on classes extending the TestCase class.
Should we not allow for a hybrid way of writing integration test cases
based on classes that do not extend TestCase while also allowing old ways
(extending TestCase and test methods starting with test) of writing test
cases?
Is there any particular reason why we are still using TestCase class?
Best
Girish
On Sun, Jul 5, 2020 at 1:44 PM Jacques Le Roux
wrote:
> Thanks Eugen,
>
> That's quite interesting, could you please put your comment in the Jira?
>
> TIA
>
> Jacques
>
> Le 05/07/2020 à 09:36, Eugen Stan a écrit :
> > Hello Jacques,
> >
> > I think it makes sense to make the transition.
> >
> > In James we do have it ongoing.
> >
> > Junit5 people have documented the upgrade process and you can make it
> > gradually and have both.
> >
> > Use ` git grep org.junit.Test | wc -l `to count the non-migrated tests.
> >
> > This is what we have based on the migration samples
> > https://github.com/junit-team/junit5-samples#gradle-migration-
> >
> >
> https://github.com/junit-team/junit5-samples/blob/main/junit5-migration-gradle/build.gradle
> >
> >
> > https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4
> >
> >
> >
> > testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.1'
> > testImplementation 'org.junit.jupiter:junit-jupiter-params:5.5.1'
> > testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.1'
> > testCompileOnly 'junit:junit:4.13'
> > testRuntimeOnly 'org.junit.vintage:junit-vintage-engine:5.5.1'
> > }
> >
> > test {
> > useJUnitPlatform()
> > }
> >
> >
> >
> >
> > La 05.07.2020 10:01, Jacques Le Roux a scris:
> >> I created https://issues.apache.org/jira/browse/OFBIZ-11870 for that
> >>
> >> Jacques
> >>
> >> Le 04/09/2018 à 09:15, Jacques Le Roux a écrit :
> >>> Hi,
> >>>
> >>> I stumbled upon this tweet
> >>>
> >>> https://twitter.com/junitteam/status/1036707906706698243
> >>>
> >>> Had a quick look at
> >>>
> >>> https://junit.org/junit5/docs/5.3.0/release-notes/
> >>>
> >>> https://www.baeldung.com/junit-5-migration
> >>>
> >>> I did not rememberf, so searched if we discussed moving from JUnit 4
> >>> to JUnit 5, but did not find anything.
> >>>
> >>> Did we discuss it, if so what were the conclusions? If not, should we
> >>> not discuss it?
> >>>
> >>> Thanks
> >>>
> >>> >>>
> https://twitter.com/junitteam/status/1036707906706698243witter.com/junitteam/status/1036707906706698243
> >>>
> >>> Jacques
> >>>
> >>>
>
Re: JUnit 5?
Thanks Eugen,
That's quite interesting, could you please put your comment in the Jira?
TIA
Jacques
Le 05/07/2020 à 09:36, Eugen Stan a écrit :
Hello Jacques,
I think it makes sense to make the transition.
In James we do have it ongoing.
Junit5 people have documented the upgrade process and you can make it
gradually and have both.
Use ` git grep org.junit.Test | wc -l `to count the non-migrated tests.
This is what we have based on the migration samples
https://github.com/junit-team/junit5-samples#gradle-migration-
https://github.com/junit-team/junit5-samples/blob/main/junit5-migration-gradle/build.gradle
https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.1'
testImplementation 'org.junit.jupiter:junit-jupiter-params:5.5.1'
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.1'
testCompileOnly 'junit:junit:4.13'
testRuntimeOnly 'org.junit.vintage:junit-vintage-engine:5.5.1'
}
test {
useJUnitPlatform()
}
La 05.07.2020 10:01, Jacques Le Roux a scris:
I created https://issues.apache.org/jira/browse/OFBIZ-11870 for that
Jacques
Le 04/09/2018 à 09:15, Jacques Le Roux a écrit :
Hi,
I stumbled upon this tweet
https://twitter.com/junitteam/status/1036707906706698243
Had a quick look at
https://junit.org/junit5/docs/5.3.0/release-notes/
https://www.baeldung.com/junit-5-migration
I did not rememberf, so searched if we discussed moving from JUnit 4
to JUnit 5, but did not find anything.
Did we discuss it, if so what were the conclusions? If not, should we
not discuss it?
Thanks
https://twitter.com/junitteam/status/1036707906706698243witter.com/junitteam/status/1036707906706698243
Jacques
Re: JUnit 5?
Hello Jacques,
I think it makes sense to make the transition.
In James we do have it ongoing.
Junit5 people have documented the upgrade process and you can make it
gradually and have both.
Use ` git grep org.junit.Test | wc -l `to count the non-migrated tests.
This is what we have based on the migration samples
https://github.com/junit-team/junit5-samples#gradle-migration-
https://github.com/junit-team/junit5-samples/blob/main/junit5-migration-gradle/build.gradle
https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.1'
testImplementation 'org.junit.jupiter:junit-jupiter-params:5.5.1'
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.1'
testCompileOnly 'junit:junit:4.13'
testRuntimeOnly 'org.junit.vintage:junit-vintage-engine:5.5.1'
}
test {
useJUnitPlatform()
}
La 05.07.2020 10:01, Jacques Le Roux a scris:
> I created https://issues.apache.org/jira/browse/OFBIZ-11870 for that
>
> Jacques
>
> Le 04/09/2018 à 09:15, Jacques Le Roux a écrit :
>> Hi,
>>
>> I stumbled upon this tweet
>>
>> https://twitter.com/junitteam/status/1036707906706698243
>>
>> Had a quick look at
>>
>> https://junit.org/junit5/docs/5.3.0/release-notes/
>>
>> https://www.baeldung.com/junit-5-migration
>>
>> I did not rememberf, so searched if we discussed moving from JUnit 4
>> to JUnit 5, but did not find anything.
>>
>> Did we discuss it, if so what were the conclusions? If not, should we
>> not discuss it?
>>
>> Thanks
>>
>> > https://twitter.com/junitteam/status/1036707906706698243witter.com/junitteam/status/1036707906706698243
>>
>> Jacques
>>
>>
--
Eugen Stan
+40720 898 747 / netdava.com
<>
signature.asc
Description: OpenPGP digital signature
Re: JUnit 5?
I created https://issues.apache.org/jira/browse/OFBIZ-11870 for that Jacques Le 04/09/2018 à 09:15, Jacques Le Roux a écrit : Hi, I stumbled upon this tweet https://twitter.com/junitteam/status/1036707906706698243 Had a quick look at https://junit.org/junit5/docs/5.3.0/release-notes/ https://www.baeldung.com/junit-5-migration I did not rememberf, so searched if we discussed moving from JUnit 4 to JUnit 5, but did not find anything. Did we discuss it, if so what were the conclusions? If not, should we not discuss it? Thanks https://twitter.com/junitteam/status/1036707906706698243witter.com/junitteam/status/1036707906706698243 Jacques
JUnit 5?
Hi, I stumbled upon this tweet https://twitter.com/junitteam/status/1036707906706698243 Had a quick look at https://junit.org/junit5/docs/5.3.0/release-notes/ https://www.baeldung.com/junit-5-migration I did not rememberf, so searched if we discussed moving from JUnit 4 to JUnit 5, but did not find anything. Did we discuss it, if so what were the conclusions? If not, should we not discuss it? Thanks https://twitter.com/junitteam/status/1036707906706698243witter.com/junitteam/status/1036707906706698243 Jacques
