Re: svn commit: r1866286 - in /ofbiz/ofbiz-framework/trunk/applications/product: config/ minilang/shipment/issuance/ minilang/shipment/receipt/ minilang/shipment/shipment/ servicedef/

2019-10-02 Thread Suraj Khurana 
Thanks a lot Nicolas for your contribution.

Cheers !!
--
Best Regards,
Suraj Khurana
Technical Consultant
HotWax Systems






On Tue, Sep 3, 2019 at 8:15 PM Nicolas Malin 
wrote:

> -_-' ...
>
> Suraj, you blur my sunny day, but it's a good motivation to finish it ;)
>
> I worked on this last forgot issue [1], and it's hard part ! But I
> finalized it and I updated it with 3 dependencies [2] that contains
> framework improvements.
>
> If some people have some time to spend, it's would be nice if we can
> close this subject this week :)
>
> Cheers,
>
> Nicolas
>
> [1] https://issues.apache.org/jira/browse/OFBIZ-10636
> [2] https://issues.apache.org/jira/browse/OFBIZ-11180
>   https://issues.apache.org/jira/browse/OFBIZ-11182
>   https://issues.apache.org/jira/browse/OFBIZ-11183
>
> On 9/3/19 8:29 AM, Suraj Khurana wrote:
> > Hello folks,
> >
> > I checked and we have only one ticket remaining in this parent
> >  ticket.
> > Also, I converted OFBIZ-6996 into a child of OFBIZ-8408.
> >
> > Cheers,
> > --
> > Best Regards,
> > Suraj Khurana
> > Technical Consultant
> > HotWax Systems
> >
> >
> >
> >
> >
> >
> >
> > On Mon, Sep 2, 2019 at 10:39 PM Swapnil M Mane 
> > wrote:
> >
> >> Great, thanks so much Nicolas!
> >>
> >>
> >> Best regards,
> >> Swapnil M Mane,
> >> ofbiz.apache.org
> >>
> >>
> >>
> >> On Mon, Sep 2, 2019 at 8:54 PM Nicolas Malin 
> >> wrote:
> >>
> >>> Hi all,
> >>>
> >>> With this last commit, I think we finish the conversion for CRUD in
> >>> mini-lang to entity-auto :)
> >>>
> >>> \o/
> >>>
> >>> Now next step mini-lang to groovy !
> >>>
> >>> Cheers,
> >>>
> >>> Nicolas
> >>>
> >>> On 9/2/19 5:13 PM, nma...@apache.org wrote:
>  Author: nmalin
>  Date: Mon Sep  2 15:13:47 2019
>  New Revision: 1866286
> 
>  URL: http://svn.apache.org/viewvc?rev=1866286&view=rev
>  Log:
>  Improved: Convert Shipment Crud simple service to entity-auto
>  (OFBIZ-6996)
>  I converted all available shipment entities crud currently on simple
> >>> service to entity-auto service :
> * ItemIssuanceRole
> * ShipmentItem
> * ShipmentPackageContent
> * ShipmentPackageRouteSeg
> * ShipmentRouteSegment
> * QuantityBreak
> 
>  I also transformed a simple method call to a permission service:
> >>> checkCanChangeShipmentStatus, who check for a shipment is it on good
> >> status
> >>> for the change.
>  With this last conversion, the permission control set on the service
> >>> definition instead of core service
>  Modified:
> 
> >>
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
> >>
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
> >>
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
> >>
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml
> >>
> ofbiz/ofbiz-framework/trunk/applications/product/servicedef/secas_shipment.xml
> >>
> ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml
>  Modified:
> >>
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
>  URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml?rev=1866286&r1=1866285&r2=1866286&view=diff
> >>
> ==
>  ---
> >>
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
> >>> (original)
>  +++
> >>
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
> >>> Mon Sep  2 15:13:47 2019
>  @@ -1489,6 +1489,10 @@
> åˆ›å»ºå¿«é€Ÿæ·»åŠ å ˜åž‹æ•°æ ®æ—¶å
> >>> ‘生交易错误：${errMessage}。
>  >>> xml:lang="zh-TW">æ–°å»ºå¿«é€Ÿå¢žåŠ è®Šåž‹è³‡æ–™æ™‚ç™¼ç”Ÿäº¤æ˜“éŒ¯èª¤:
> >>> ${errMessage}.
> 
>  +
>  +Cannot perform this operation when the
> >>> shipment [${testShipment.shipmentId}] is in the
> >>> ${testShipmentStatus.description} [${testShipment.statusId}]
> >>> status."
>  +Impossible de réaliser l'opération
> >>> demandée quand l'expédition [${testShipment.shipmentId}] est dans le
> >>> statut ${testShipmentStatus.description}
> >> [${testShipment.statusId}]
>  +
>  >>> key="variantevents.variantProductId_required_but_missing_enter_an_id">
> variantProductId wir benötigt, fehlt
> >>> aber, bitte geben Sie eine ID für die neue Produktvariante an.
> variantProductId is required but
> >> missing,
> >>> please enter an id for the new variant product.
>  Modified:
> >>
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
>  URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/

Re: svn commit: r1866286 - in /ofbiz/ofbiz-framework/trunk/applications/product: config/ minilang/shipment/issuance/ minilang/shipment/receipt/ minilang/shipment/shipment/ servicedef/

2019-09-03 Thread Nicolas Malin 

-_-' ...

Suraj, you blur my sunny day, but it's a good motivation to finish it ;)

I worked on this last forgot issue [1], and it's hard part ! But I 
finalized it and I updated it with 3 dependencies [2] that contains 
framework improvements.


If some people have some time to spend, it's would be nice if we can 
close this subject this week :)


Cheers,

Nicolas

[1] https://issues.apache.org/jira/browse/OFBIZ-10636
[2] https://issues.apache.org/jira/browse/OFBIZ-11180
 https://issues.apache.org/jira/browse/OFBIZ-11182
 https://issues.apache.org/jira/browse/OFBIZ-11183

On 9/3/19 8:29 AM, Suraj Khurana wrote:

Hello folks,

I checked and we have only one ticket remaining in this parent
 ticket.
Also, I converted OFBIZ-6996 into a child of OFBIZ-8408.

Cheers,
--
Best Regards,
Suraj Khurana
Technical Consultant
HotWax Systems







On Mon, Sep 2, 2019 at 10:39 PM Swapnil M Mane 
wrote:


Great, thanks so much Nicolas!


Best regards,
Swapnil M Mane,
ofbiz.apache.org



On Mon, Sep 2, 2019 at 8:54 PM Nicolas Malin 
wrote:


Hi all,

With this last commit, I think we finish the conversion for CRUD in
mini-lang to entity-auto :)

\o/

Now next step mini-lang to groovy !

Cheers,

Nicolas

On 9/2/19 5:13 PM, nma...@apache.org wrote:

Author: nmalin
Date: Mon Sep  2 15:13:47 2019
New Revision: 1866286

URL: http://svn.apache.org/viewvc?rev=1866286&view=rev
Log:
Improved: Convert Shipment Crud simple service to entity-auto
(OFBIZ-6996)
I converted all available shipment entities crud currently on simple

service to entity-auto service :

   * ItemIssuanceRole
   * ShipmentItem
   * ShipmentPackageContent
   * ShipmentPackageRouteSeg
   * ShipmentRouteSegment
   * QuantityBreak

I also transformed a simple method call to a permission service:

checkCanChangeShipmentStatus, who check for a shipment is it on good

status

for the change.

With this last conversion, the permission control set on the service

definition instead of core service

Modified:


ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml
ofbiz/ofbiz-framework/trunk/applications/product/servicedef/secas_shipment.xml
ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml

Modified:

ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml

URL:

http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml?rev=1866286&r1=1866285&r2=1866286&view=diff
==

---

ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml

(original)

+++

ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml

Mon Sep  2 15:13:47 2019

@@ -1489,6 +1489,10 @@
   åˆ›å»ºå¿«é€Ÿæ·»åŠ å ˜åž‹æ•°æ ®æ—¶å

‘生交易错误：${errMessage}。

   
xml:lang="zh-TW">æ–°å»ºå¿«é€Ÿå¢žåŠ è®Šåž‹è³‡æ–™æ™‚ç™¼ç”Ÿäº¤æ˜“éŒ¯èª¤:
${errMessage}.

   
+
+Cannot perform this operation when the

shipment [${testShipment.shipmentId}] is in the
${testShipmentStatus.description} [${testShipment.statusId}]
status."

+Impossible de réaliser l'opération

demandée quand l'expédition [${testShipment.shipmentId}] est dans le
statut ${testShipmentStatus.description}

[${testShipment.statusId}]

+
   
key="variantevents.variantProductId_required_but_missing_enter_an_id">

   variantProductId wir benötigt, fehlt

aber, bitte geben Sie eine ID für die neue Produktvariante an.

   variantProductId is required but

missing,

please enter an id for the new variant product.

Modified:

ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml

URL:

http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml?rev=1866286&r1=1866285&r2=1866286&view=diff
==

---

ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml

(original)

+++

ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml

Mon Sep  2 15:13:47 2019

@@ -22,10 +22,6 @@ under the License.
   xmlns="http://ofbiz.apache.org/Simple-Method";

xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method
http://ofbiz.apache.org/dtds/simple-methods.xsd";>

   
   
short-description="Create ItemIssuance">

-
-
method-name="checkCanChangeShipmentStatusPacked"


xml-resource="component://product/minilang/ship

Re: svn commit: r1866286 - in /ofbiz/ofbiz-framework/trunk/applications/product: config/ minilang/shipment/issuance/ minilang/shipment/receipt/ minilang/shipment/shipment/ servicedef/

2019-09-02 Thread Suraj Khurana 
Hello folks,

I checked and we have only one ticket remaining in this parent
 ticket.
Also, I converted OFBIZ-6996 into a child of OFBIZ-8408.

Cheers,
--
Best Regards,
Suraj Khurana
Technical Consultant
HotWax Systems







On Mon, Sep 2, 2019 at 10:39 PM Swapnil M Mane 
wrote:

> Great, thanks so much Nicolas!
>
>
> Best regards,
> Swapnil M Mane,
> ofbiz.apache.org
>
>
>
> On Mon, Sep 2, 2019 at 8:54 PM Nicolas Malin 
> wrote:
>
> > Hi all,
> >
> > With this last commit, I think we finish the conversion for CRUD in
> > mini-lang to entity-auto :)
> >
> > \o/
> >
> > Now next step mini-lang to groovy !
> >
> > Cheers,
> >
> > Nicolas
> >
> > On 9/2/19 5:13 PM, nma...@apache.org wrote:
> > > Author: nmalin
> > > Date: Mon Sep  2 15:13:47 2019
> > > New Revision: 1866286
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1866286&view=rev
> > > Log:
> > > Improved: Convert Shipment Crud simple service to entity-auto
> > > (OFBIZ-6996)
> > > I converted all available shipment entities crud currently on simple
> > service to entity-auto service :
> > >   * ItemIssuanceRole
> > >   * ShipmentItem
> > >   * ShipmentPackageContent
> > >   * ShipmentPackageRouteSeg
> > >   * ShipmentRouteSegment
> > >   * QuantityBreak
> > >
> > > I also transformed a simple method call to a permission service:
> > checkCanChangeShipmentStatus, who check for a shipment is it on good
> status
> > for the change.
> > > With this last conversion, the permission control set on the service
> > definition instead of core service
> > >
> > > Modified:
> > >
> >
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
> > >
> >
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
> > >
> >
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
> > >
> >
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml
> > >
> >
> ofbiz/ofbiz-framework/trunk/applications/product/servicedef/secas_shipment.xml
> > >
> >
> ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml
> > >
> > > Modified:
> >
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
> > > URL:
> >
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml?rev=1866286&r1=1866285&r2=1866286&view=diff
> > >
> >
> ==
> > > ---
> >
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
> > (original)
> > > +++
> >
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
> > Mon Sep  2 15:13:47 2019
> > > @@ -1489,6 +1489,10 @@
> > >   åˆ›å»ºå¿«é€Ÿæ·»åŠ å ˜åž‹æ•°æ ®æ—¶å
> > ‘生交易错误：${errMessage}。
> > >> xml:lang="zh-TW">æ–°å»ºå¿«é€Ÿå¢žåŠ è®Šåž‹è³‡æ–™æ™‚ç™¼ç”Ÿäº¤æ˜“éŒ¯èª¤:
> > ${errMessage}.
> > >   
> > > +
> > > +Cannot perform this operation when the
> > shipment [${testShipment.shipmentId}] is in the
> > ${testShipmentStatus.description} [${testShipment.statusId}]
> > status."
> > > +Impossible de réaliser l'opération
> > demandée quand l'expédition [${testShipment.shipmentId}] est dans le
> > statut ${testShipmentStatus.description}
> [${testShipment.statusId}]
> > > +
> > >> key="variantevents.variantProductId_required_but_missing_enter_an_id">
> > >   variantProductId wir benötigt, fehlt
> > aber, bitte geben Sie eine ID für die neue Produktvariante an.
> > >   variantProductId is required but
> missing,
> > please enter an id for the new variant product.
> > >
> > > Modified:
> >
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
> > > URL:
> >
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml?rev=1866286&r1=1866285&r2=1866286&view=diff
> > >
> >
> ==
> > > ---
> >
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
> > (original)
> > > +++
> >
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
> > Mon Sep  2 15:13:47 2019
> > > @@ -22,10 +22,6 @@ under the License.
> > >   xmlns="http://ofbiz.apache.org/Simple-Method";
> > xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method
> > http://ofbiz.apache.org/dtds/simple-methods.xsd";>
> > >   
> > >> short-description="Create ItemIssuance">
> > > -
> > > - > method-name="checkCanChangeShipmentStatusPacked"
> >
> xml-resource="component://product/minilang/shipment/shipment/ShipmentServices.xml"/>
> > > -
> > > -
> > >> value-field="newEntity"/>
> >

Re: svn commit: r1866286 - in /ofbiz/ofbiz-framework/trunk/applications/product: config/ minilang/shipment/issuance/ minilang/shipment/receipt/ minilang/shipment/shipment/ servicedef/

2019-09-02 Thread Swapnil M Mane 
Great, thanks so much Nicolas!


Best regards,
Swapnil M Mane,
ofbiz.apache.org



On Mon, Sep 2, 2019 at 8:54 PM Nicolas Malin 
wrote:

> Hi all,
>
> With this last commit, I think we finish the conversion for CRUD in
> mini-lang to entity-auto :)
>
> \o/
>
> Now next step mini-lang to groovy !
>
> Cheers,
>
> Nicolas
>
> On 9/2/19 5:13 PM, nma...@apache.org wrote:
> > Author: nmalin
> > Date: Mon Sep  2 15:13:47 2019
> > New Revision: 1866286
> >
> > URL: http://svn.apache.org/viewvc?rev=1866286&view=rev
> > Log:
> > Improved: Convert Shipment Crud simple service to entity-auto
> > (OFBIZ-6996)
> > I converted all available shipment entities crud currently on simple
> service to entity-auto service :
> >   * ItemIssuanceRole
> >   * ShipmentItem
> >   * ShipmentPackageContent
> >   * ShipmentPackageRouteSeg
> >   * ShipmentRouteSegment
> >   * QuantityBreak
> >
> > I also transformed a simple method call to a permission service:
> checkCanChangeShipmentStatus, who check for a shipment is it on good status
> for the change.
> > With this last conversion, the permission control set on the service
> definition instead of core service
> >
> > Modified:
> >
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
> >
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
> >
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
> >
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml
> >
> ofbiz/ofbiz-framework/trunk/applications/product/servicedef/secas_shipment.xml
> >
> ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml
> >
> > Modified:
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
> > URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml?rev=1866286&r1=1866285&r2=1866286&view=diff
> >
> ==
> > ---
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
> (original)
> > +++
> ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
> Mon Sep  2 15:13:47 2019
> > @@ -1489,6 +1489,10 @@
> >   åˆ›å»ºå¿«é€Ÿæ·»åŠ å ˜åž‹æ•°æ ®æ—¶å
> ‘生交易错误：${errMessage}。
> >xml:lang="zh-TW">æ–°å»ºå¿«é€Ÿå¢žåŠ è®Šåž‹è³‡æ–™æ™‚ç™¼ç”Ÿäº¤æ˜“éŒ¯èª¤:
> ${errMessage}.
> >   
> > +
> > +Cannot perform this operation when the
> shipment [${testShipment.shipmentId}] is in the
> ${testShipmentStatus.description} [${testShipment.statusId}]
> status."
> > +Impossible de réaliser l'opération
> demandée quand l'expédition [${testShipment.shipmentId}] est dans le
> statut ${testShipmentStatus.description} [${testShipment.statusId}]
> > +
> >key="variantevents.variantProductId_required_but_missing_enter_an_id">
> >   variantProductId wir benötigt, fehlt
> aber, bitte geben Sie eine ID für die neue Produktvariante an.
> >   variantProductId is required but missing,
> please enter an id for the new variant product.
> >
> > Modified:
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
> > URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml?rev=1866286&r1=1866285&r2=1866286&view=diff
> >
> ==
> > ---
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
> (original)
> > +++
> ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
> Mon Sep  2 15:13:47 2019
> > @@ -22,10 +22,6 @@ under the License.
> >   xmlns="http://ofbiz.apache.org/Simple-Method";
> xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method
> http://ofbiz.apache.org/dtds/simple-methods.xsd";>
> >   
> >short-description="Create ItemIssuance">
> > -
> > - method-name="checkCanChangeShipmentStatusPacked"
> xml-resource="component://product/minilang/shipment/shipment/ShipmentServices.xml"/>
> > -
> > -
> >value-field="newEntity"/>
> >field="newEntity.itemIssuanceId"/>
> >result-name="itemIssuanceId"/>
> > @@ -64,48 +60,9 @@ under the License.
> >   
> >result-name="affectAccounting"/>
> >   
> > - short-description="Update ItemIssuance">
> > -
> > - method-name="checkCanChangeShipmentStatusPacked"
> xml-resource="component://product/minilang/shipment/shipment/ShipmentServices.xml"/>
> > -
> > -
> > - value-field="lookedUpValue"/>
> > -
> > -
> > -
> > - short-description="Delete ItemIssuance">
> > -
> > - method-name

Re: svn commit: r1866286 - in /ofbiz/ofbiz-framework/trunk/applications/product: config/ minilang/shipment/issuance/ minilang/shipment/receipt/ minilang/shipment/shipment/ servicedef/

2019-09-02 Thread Jacques Le Roux 

Congratulations and thanks Nicolas!

Jacques

Le 02/09/2019 à 17:24, Nicolas Malin a écrit :

Hi all,

With this last commit, I think we finish the conversion for CRUD in mini-lang 
to entity-auto :)

\o/

Now next step mini-lang to groovy !

Cheers,

Nicolas

On 9/2/19 5:13 PM, nma...@apache.org wrote:

Author: nmalin
Date: Mon Sep  2 15:13:47 2019
New Revision: 1866286

URL: http://svn.apache.org/viewvc?rev=1866286&view=rev
Log:
Improved: Convert Shipment Crud simple service to entity-auto
(OFBIZ-6996)
I converted all available shipment entities crud currently on simple service to 
entity-auto service :
  * ItemIssuanceRole
  * ShipmentItem
  * ShipmentPackageContent
  * ShipmentPackageRouteSeg
  * ShipmentRouteSegment
  * QuantityBreak

I also transformed a simple method call to a permission service: checkCanChangeShipmentStatus, who check for a shipment is it on good status for 
the change.

With this last conversion, the permission control set on the service definition 
instead of core service

Modified:
ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml
ofbiz/ofbiz-framework/trunk/applications/product/servicedef/secas_shipment.xml
ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml

Modified: 
ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml?rev=1866286&r1=1866285&r2=1866286&view=diff

==
--- 
ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
 Mon Sep  2 15:13:47 2019
@@ -1489,6 +1489,10 @@
  创建快速添加
变型数据时发生交易错误：${errMessage}。
  新建快速增加
變型資料時發生交易錯誤: ${errMessage}.
  
+    
+    Cannot perform this operation when the shipment [${testShipment.shipmentId}] is in the 
${testShipmentStatus.description} [${testShipment.statusId}] status."
+    Impossible de réaliser l'opération demandée quand l'expédition [${testShipment.shipmentId}] est dans le statut 
${testShipmentStatus.description} [${testShipment.statusId}]

+    
  
  variantProductId wir benötigt, fehlt aber, bitte 
geben Sie eine ID für die neue Produktvariante an.
  variantProductId is required but missing, please enter 
an id for the new variant product.

Modified: 
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml?rev=1866286&r1=1866285&r2=1866286&view=diff

==
--- 
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
 Mon Sep  2 15:13:47 2019
@@ -22,10 +22,6 @@ under the License.
  xmlns="http://ofbiz.apache.org/Simple-Method"; xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method 
http://ofbiz.apache.org/dtds/simple-methods.xsd";>

  
  
-    
-    xml-resource="component://product/minilang/shipment/shipment/ShipmentServices.xml"/>

-    
-
  
  
  
@@ -64,48 +60,9 @@ under the License.
  
  
  
-    
-    
-    xml-resource="component://product/minilang/shipment/shipment/ShipmentServices.xml"/>

-    
-
-    
-    
-    
-    
-    
-    
-    xml-resource="component://product/minilang/shipment/shipment/ShipmentServices.xml"/>

-    
-
-    
-    
-    
-
-    
-    
-    
-    xml-resource="component://product/minilang/shipment/shipment/ShipmentServices.xml"/>

-    
-    
-    
-    
-    
-    
-
-    
-    
-    xml-resource="component://product/minilang/shipment/shipment/ShipmentServices.xml"/>

-    
-    
-    
-    
    
  
-    
-    xml-resource="component://product/minilang/shipment/shipment/ShipmentServices.xml"/>

-    
    
  
@@ -132,9 +89,6 @@ under the License.
  
    
-    
-    xml-resource="component://product/minilang/shipment/shipment/ShipmentServices.xml"/>

-    
    
  
@@ -464,7 +418,7 @@ under the License.
  
  
  
-    
+    
 

Re: svn commit: r1866286 - in /ofbiz/ofbiz-framework/trunk/applications/product: config/ minilang/shipment/issuance/ minilang/shipment/receipt/ minilang/shipment/shipment/ servicedef/

2019-09-02 Thread Nicolas Malin 

Hi all,

With this last commit, I think we finish the conversion for CRUD in 
mini-lang to entity-auto :)


\o/

Now next step mini-lang to groovy !

Cheers,

Nicolas

On 9/2/19 5:13 PM, nma...@apache.org wrote:

Author: nmalin
Date: Mon Sep  2 15:13:47 2019
New Revision: 1866286

URL: http://svn.apache.org/viewvc?rev=1866286&view=rev
Log:
Improved: Convert Shipment Crud simple service to entity-auto
(OFBIZ-6996)
I converted all available shipment entities crud currently on simple service to 
entity-auto service :
  * ItemIssuanceRole
  * ShipmentItem
  * ShipmentPackageContent
  * ShipmentPackageRouteSeg
  * ShipmentRouteSegment
  * QuantityBreak

I also transformed a simple method call to a permission service: 
checkCanChangeShipmentStatus, who check for a shipment is it on good status for 
the change.
With this last conversion, the permission control set on the service definition 
instead of core service

Modified:
 
ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
 
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
 
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
 
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml
 
ofbiz/ofbiz-framework/trunk/applications/product/servicedef/secas_shipment.xml
 
ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml

Modified: 
ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml?rev=1866286&r1=1866285&r2=1866286&view=diff
==
--- 
ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/applications/product/config/ProductErrorUiLabels.xml
 Mon Sep  2 15:13:47 2019
@@ -1489,6 +1489,10 @@
  创建快速添加
变型数据时发生交易错误：${errMessage}。
  新建快速增加
變型資料時發生交易錯誤: ${errMessage}.
  
+
+Cannot perform this operation when the shipment 
[${testShipment.shipmentId}] is in the ${testShipmentStatus.description} [${testShipment.statusId}] 
status."
+Impossible de réaliser l'opération demandée quand 
l'expédition [${testShipment.shipmentId}] est dans le statut ${testShipmentStatus.description} 
[${testShipment.statusId}]
+
  
  variantProductId wir benötigt, fehlt aber, bitte 
geben Sie eine ID für die neue Produktvariante an.
  variantProductId is required but missing, please enter 
an id for the new variant product.

Modified: 
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml?rev=1866286&r1=1866285&r2=1866286&view=diff
==
--- 
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/issuance/IssuanceServices.xml
 Mon Sep  2 15:13:47 2019
@@ -22,10 +22,6 @@ under the License.
  xmlns="http://ofbiz.apache.org/Simple-Method"; 
xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method 
http://ofbiz.apache.org/dtds/simple-methods.xsd";>
  
  
-
-
-
-
  
  
  
@@ -64,48 +60,9 @@ under the License.
  
  
  
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
  
  

  
-
-
-
  
  

  
@@ -132,9 +89,6 @@ under the License.
  
  
  

-
-
-
  
  

  
@@ -464,7 +418,7 @@ under the License.
  
  
  
-
+
  
  
  
@@ -565,8 +519,9 @@ under the License.
  
  
  

-
-
+
+
+
  
  
  


Modified: 
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml?rev=1866286&r1=1866285&r2=1866286&view=diff
==
--- 
ofbiz/ofbiz-framework/trunk/applications/product/minilang/shipment/rece