[GitHub] incubator-omid pull request #26: A bug fix in [OMID-74].

[ohadshacham]

GitHub user ohadshacham opened a pull request:

https://github.com/apache/incubator-omid/pull/26

A bug fix in [OMID-74].

The update of the write set is incorrect since the family deletion 
qualifier needs to be added instead of a row marker. Therefore, this commit 
fixes this case.
This is crucial since the write set information is needed for adding shadow 
cells, when transaction successfully commits, and for garbage collection when 
transaction aborts.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ohadshacham/incubator-omid OMID-74-reopen

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-omid/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit d6ed73fc4cf34c84a4f283011521a746f257d66e
Author: Ohad Shacham 
Date:   2018-03-15T12:33:57Z

A bug fix in [OMID-74].
The update of the write set is incorrect since the family deletion 
qualifier needs to be added instead of a row marker. Therefore, this commit 
fixes this case.
This is crucial since the write set information is needed for adding shadow 
cells, when transaction successfully commits, and for garbage collection when 
transaction aborts.




---

[GitHub] incubator-omid pull request #27: reopen [OMID-70] in order to bind WorldCloc...

[ohadshacham]

GitHub user ohadshacham opened a pull request:

https://github.com/apache/incubator-omid/pull/27

reopen [OMID-70] in order to bind WorldClockOracleImpl in TSOMockModule.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ohadshacham/incubator-omid OMID-70-reopen

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-omid/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #27


commit 0eca99f9911a0e23fa099531c59a231098b97fa5
Author: Ohad Shacham 
Date:   2018-03-15T14:22:35Z

reopen [OMID-70] in order to bind WorldClockOracleImpl in TSOMockModule.




---

[jira] [Commented] (OMID-70) World time based timestamp generator

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/OMID-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400462#comment-16400462
 ] 

ASF GitHub Bot commented on OMID-70:


GitHub user ohadshacham opened a pull request:

https://github.com/apache/incubator-omid/pull/27

reopen [OMID-70] in order to bind WorldClockOracleImpl in TSOMockModule.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ohadshacham/incubator-omid OMID-70-reopen

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-omid/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #27


commit 0eca99f9911a0e23fa099531c59a231098b97fa5
Author: Ohad Shacham 
Date:   2018-03-15T14:22:35Z

reopen [OMID-70] in order to bind WorldClockOracleImpl in TSOMockModule.




> World time based timestamp generator
> 
>
> Key: OMID-70
> URL: https://issues.apache.org/jira/browse/OMID-70
> Project: Apache Omid
>  Issue Type: Sub-task
>Reporter: Ohad Shacham
>Assignee: Ohad Shacham
>Priority: Major
>
> Adding world time base timestamp generator. The generator should maintain 
> monotonicity and persists the maximal timestamp in each interval (for high 
> availability).
> 
> The motivation for this feature is the integration with Apache Phoenix.
> Phoenix's customers requires mapping from timestamp to world time in order to 
> debug their logs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Reopened] (OMID-70) World time based timestamp generator

[Ohad Shacham (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OMID-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ohad Shacham reopened OMID-70:
--

Need to bind WorldClockOracleImpl in TSOMockModule

> World time based timestamp generator
> 
>
> Key: OMID-70
> URL: https://issues.apache.org/jira/browse/OMID-70
> Project: Apache Omid
>  Issue Type: Sub-task
>Reporter: Ohad Shacham
>Assignee: Ohad Shacham
>Priority: Major
>
> Adding world time base timestamp generator. The generator should maintain 
> monotonicity and persists the maximal timestamp in each interval (for high 
> availability).
> 
> The motivation for this feature is the integration with Apache Phoenix.
> Phoenix's customers requires mapping from timestamp to world time in order to 
> debug their logs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Omid release branch 0.9.0.0 - Release candidate 1

[Flavio Junqueira]

It was indeed a version issue with protoc. I'm now getting the following error:

$ mvn package -Dhbase-0
...
Reactor Summary:
[INFO] 
[INFO] Omid 0.9.0.0 ... SUCCESS [  0.034 s]
[INFO] Common . SUCCESS [  4.744 s]
[INFO] State Machine .. SUCCESS [  1.075 s]
[INFO] Commit Table ... SUCCESS [  1.085 s]
[INFO] Metrics  SUCCESS [  0.156 s]
[INFO] Transaction Client . SUCCESS [  1.653 s]
[INFO] HBase Common ... SUCCESS [  1.481 s]
[INFO] HBase Commit Table . SUCCESS [ 26.825 s]
[INFO] Codahale Metrics ... SUCCESS [  0.137 s]
[INFO] Benchmarks . SUCCESS [  2.801 s]
[INFO] Timestamp Storage .. SUCCESS [ 16.628 s]
[INFO] HBase tools  FAILURE [  0.110 s]
[INFO] TSO and TO Servers . SKIPPED
[INFO] Shims Aggregator for HBase . SKIPPED
[INFO] Shims layer for HBase 0.x .. SKIPPED
[INFO] Shims layer for HBase 1.x .. SKIPPED
[INFO] HBase Client ... SKIPPED
[INFO] HBase Coprocessors . SKIPPED
[INFO] Omid Client Examples ... SKIPPED
[INFO] Omid Packaging 0.9.0.0 . SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 57.118 s
[INFO] Finished at: 2018-03-15T14:59:47+01:00
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.5:compile (default-compile) on 
project omid-hbase-tools: Compilation failure: Compilation failure: 
[ERROR] 
/Users/fpj/Downloads/apache-omid-incubating-0.9.0.0-src/hbase-tools/src/main/java/org/apache/omid/tools/hbase/OmidTableManager.java:[33,23]
 cannot find symbol
[ERROR]   symbol:   class HBaseShims
[ERROR]   location: package org.apache.omid
[ERROR] 
/Users/fpj/Downloads/apache-omid-incubating-0.9.0.0-src/hbase-tools/src/main/java/org/apache/omid/tools/hbase/OmidTableManager.java:[153,13]
 cannot find symbol
[ERROR]   symbol:   variable HBaseShims
[ERROR]   location: class org.apache.omid.tools.hbase.OmidTableManager
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :omid-hbase-tools


> On 15 Mar 2018, at 11:06, Ohad Shacham  wrote:
> 
> Hi Flavio,
> I can't see your output. Did you install Protobuf 2.5.0?
> Thx,Ohad
>On Thursday, March 15, 2018, 11:56:11 AM GMT+2, Flavio Junqueira 
>  wrote:  
> 
> I'm not being able to build from sources, it looks like an issue with protoc. 
> Is it a version incompatibility? Output is attached.
> 
> -Flavio
> 
> 
> 
>> On 13 Mar 2018, at 20:46, Ohad Shacham  wrote:
>> 
>> Add  -Phbase-1 to your maven command. It should solve the error.
>> 
>> 
>> Sent from Yahoo Mail for iPhone
>> 
>> 
>> On Tuesday, March 13, 2018, 21:43, James Taylor  
>> wrote:
>> 
>> Rat check passes when I run "mvn -Prelease_profile -Phbase-1 install" which
>> is good.
>> 
>> However, "mvn clean install" fails (on my Mac) with the following error:
>> 
>> [INFO]
>> 
>> [INFO] Building HBase tools 0.9.0.0
>> [INFO]
>> 
>> [INFO]
>> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ omid-hbase-tools
>> ---
>> [INFO] Deleting
>> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0.0-src/hbase-tools/target
>> [INFO]
>> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
>> omid-hbase-tools ---
>> [INFO] Using 'UTF-8' encoding to copy filtered resources.
>> [INFO] skip non existing resourceDirectory
>> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0.0-src/hbase-tools/src/main/resources
>> [INFO]
>> [INFO] --- maven-compiler-plugin:3.5:compile (default-compile) @
>> omid-hbase-tools ---
>> [INFO] Changes detected - recompiling the module!
>> [INFO] Compiling 1 source file to
>> 

[jira] [Updated] (OMID-94) Tune Omid for Phoenix testing environment

[Ohad Shacham (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OMID-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ohad Shacham updated OMID-94:
-
Issue Type: Sub-task  (was: New Feature)
Parent: OMID-82

> Tune Omid for Phoenix testing environment
> -
>
> Key: OMID-94
> URL: https://issues.apache.org/jira/browse/OMID-94
> Project: Apache Omid
>  Issue Type: Sub-task
>Reporter: Ohad Shacham
>Assignee: Ohad Shacham
>Priority: Major
>
> Changing accessibility levels and other small modifications are needed for 
> running Phoenix testing environment with Omid as its transaction processor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OMID-94) Tune Omid for Phoenix testing environment

[Ohad Shacham (JIRA)]

Ohad Shacham created OMID-94:


 Summary: Tune Omid for Phoenix testing environment
 Key: OMID-94
 URL: https://issues.apache.org/jira/browse/OMID-94
 Project: Apache Omid
  Issue Type: New Feature
Reporter: Ohad Shacham


Changing accessibility levels and other small modifications are needed for 
running Phoenix testing environment with Omid as its transaction processor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OMID-74) Efficient column family deletion in Row level conflict analysis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/OMID-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400323#comment-16400323
 ] 

ASF GitHub Bot commented on OMID-74:


GitHub user ohadshacham opened a pull request:

https://github.com/apache/incubator-omid/pull/26

A bug fix in [OMID-74].

The update of the write set is incorrect since the family deletion 
qualifier needs to be added instead of a row marker. Therefore, this commit 
fixes this case.
This is crucial since the write set information is needed for adding shadow 
cells, when transaction successfully commits, and for garbage collection when 
transaction aborts.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ohadshacham/incubator-omid OMID-74-reopen

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-omid/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit d6ed73fc4cf34c84a4f283011521a746f257d66e
Author: Ohad Shacham 
Date:   2018-03-15T12:33:57Z

A bug fix in [OMID-74].
The update of the write set is incorrect since the family deletion 
qualifier needs to be added instead of a row marker. Therefore, this commit 
fixes this case.
This is crucial since the write set information is needed for adding shadow 
cells, when transaction successfully commits, and for garbage collection when 
transaction aborts.




> Efficient column family deletion in Row level conflict analysis
> ---
>
> Key: OMID-74
> URL: https://issues.apache.org/jira/browse/OMID-74
> Project: Apache Omid
>  Issue Type: Sub-task
>Reporter: Ohad Shacham
>Assignee: Ohad Shacham
>Priority: Major
>
> The idea is to use a qualifier to denote that all the columns of a specific 
> family were deleted. 
> Current implementation reads from HBase the entire family and then writes a 
> tombstone to each one of its cells. The new implementation does not need to 
> perform the read and only writes the qualifier to denote that the family was 
> deleted. This is true only for Row level conflict detection since in Cell 
> level we need to read the cells and add these to the write set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Omid release branch 0.9.0.0 - Release candidate 1

[Flavio Junqueira]

I'm not being able to build from sources, it looks like an issue with protoc. 
Is it a version incompatibility? Output is attached.

-Flavio




> On 13 Mar 2018, at 20:46, Ohad Shacham  wrote:
> 
> Add  -Phbase-1 to your maven command. It should solve the error.
> 
> 
> Sent from Yahoo Mail for iPhone
> 
> 
> On Tuesday, March 13, 2018, 21:43, James Taylor  
> wrote:
> 
> Rat check passes when I run "mvn -Prelease_profile -Phbase-1 install" which
> is good.
> 
> However, "mvn clean install" fails (on my Mac) with the following error:
> 
> [INFO]
> 
> [INFO] Building HBase tools 0.9.0.0
> [INFO]
> 
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ omid-hbase-tools
> ---
> [INFO] Deleting
> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0.0-src/hbase-tools/target
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
> omid-hbase-tools ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory
> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0.0-src/hbase-tools/src/main/resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.5:compile (default-compile) @
> omid-hbase-tools ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to
> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0.0-src/hbase-tools/target/classes
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0.0-src/hbase-tools/src/main/java/org/apache/omid/tools/hbase/OmidTableManager.java:[33,23]
> cannot find symbol
>   symbol:  class HBaseShims
>   location: package org.apache.omid
> [ERROR]
> /Users/jtaylor/dev/apache/apache-omid-incubating-0.9.0.0-src/hbase-tools/src/main/java/org/apache/omid/tools/hbase/OmidTableManager.java:[153,13]
> cannot find symbol
>   symbol:  variable HBaseShims
>   location: class org.apache.omid.tools.hbase.OmidTableManager
> [INFO] 2 errors
> 
> 
> On Tue, Mar 13, 2018 at 2:17 AM, Ohad Shacham 
> wrote:
> 
>> Hi All,
>> 
>> I would like to call a vote to release Apache Omid (Incubator) 0.9.0.0,
>> release candidate #1.
>> Links to various release artifacts are given below. Please review and vote.
>> 
>> The vote will be open for at least 72 hours and until necessary number of
>> votes are reached.
>> [ ] +1  approve
>> [ ] +0  no opinion
>> [ ] -1  disapprove (and reason why)
>> 
>> Here is my +1
>> 
>> Release notes for the 0.9.0.0 release:
>> https://dist.apache.org/repos/dist/dev/incubator/omid/0.9.0.
>> 0-rc1/RELEASE_NOTES.html
>> 
>> Git tag for the release:https://git-wip-us.apache.org/repos/asf/
>> incubator-omid.git/?p=incubator-omid.git;a=tag;h=
>> 5dd5f86822beb43d08e91d00dd2427b4f130d6c2
>> 
>> Sources for the release:https://dist.apache.org/repos/dist/dev/incubator/
>> omid/0.9.0.0-rc1/apache-omid-incubating-0.9.0.0-src.tar.gzSource release
>> verification: PGP Signature:  https://dist.apache.org/repos/
>> dist/dev/incubator/omid/0.9.0.0-rc1/apache-omid-incubating-
>> 0.9.0.0-src.tar.gz.ascMD5 Hash: https://dist.apache.org/repos/
>> dist/dev/incubator/omid/0.9.0.0-rc1/apache-omid-incubating-
>> 0.9.0.0-src.tar.gz.md5Keys to verify the signature of the release
>> artifact are available at:https://dist.apache.org/
>> repos/dist/dev/incubator/omid/0.9.0.0-rc1/KEYS
>> Thanks,Ohad
> 
> 
>