[GitHub] incubator-omid pull request #19: [OMID-84] Today, all the writes done by a t...

[ebortnikov]

Github user ebortnikov commented on a diff in the pull request:

https://github.com/apache/incubator-omid/pull/19#discussion_r166405079
  
--- Diff: 
hbase-client/src/main/java/org/apache/omid/transaction/HBaseTransaction.java ---
@@ -31,25 +31,31 @@
 public class HBaseTransaction extends AbstractTransaction {
 private static final Logger LOG = 
LoggerFactory.getLogger(HBaseTransaction.class);
 
-public HBaseTransaction(long transactionId, long epoch, 
Set writeSet, AbstractTransactionManager tm) {
-super(transactionId, epoch, writeSet, tm);
+public HBaseTransaction(long transactionId, long epoch, 
Set writeSet, Set conflictFreeWriteSet, 
AbstractTransactionManager tm) {
+super(transactionId, epoch, writeSet, conflictFreeWriteSet, tm);
 }
 
-public HBaseTransaction(long transactionId, long readTimestamp, 
VisibilityLevel visibilityLevel, long epoch, Set writeSet, 
AbstractTransactionManager tm) {
-super(transactionId, readTimestamp, visibilityLevel, epoch, 
writeSet, tm);
+public HBaseTransaction(long transactionId, long readTimestamp, 
VisibilityLevel visibilityLevel, long epoch, Set writeSet, 
Set conflictFreeWriteSet, AbstractTransactionManager tm) {
+super(transactionId, readTimestamp, visibilityLevel, epoch, 
writeSet, conflictFreeWriteSet, tm);
 }
 
+private void cleanCell(HBaseCellId cell) {
--- End diff --

cleanCell --> deleteCell? 


---

[GitHub] incubator-omid pull request #19: [OMID-84] Today, all the writes done by a t...

[ohadshacham]

GitHub user ohadshacham opened a pull request:

https://github.com/apache/incubator-omid/pull/19

[OMID-84] Today, all the writes done by a transaction are taking part…

… in conflict analysis. The purpose of this feature is to let the user 
decide for each write, whether it should take part in the conflict analysis.

The motivation infers from Apache Phoenix that utilizes this feature when 
writing to the secondary index and also when writing to the data table for 
immutable tables (each key is added once and is not modified).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ohadshacham/incubator-omid OMID-84-from-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-omid/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit 8fad7b57e3bb6ce6b69e753252c43c33af5a8eeb
Author: Ohad Shacham 
Date:   2018-01-31T14:52:43Z

[OMID-84] Today, all the writes done by a transaction are taking part in 
conflict analysis. The purpose of this feature is to let the user decide for 
each write, whether it should take part in the conflict analysis.
The motivation infers from Apache Phoenix that utilizes this feature when 
writing to the secondary index and also when writing to the data table for 
immutable tables (each key is added once and is not modified).




---