[GitHub] incubator-omid pull request #31: [OMID-96] Enable compactor on all column fa...

[ohadshacham]

Github user ohadshacham closed the pull request at:

https://github.com/apache/incubator-omid/pull/31


---

[GitHub] incubator-omid pull request #31: [OMID-96] Enable compactor on all column fa...

[yonigottesman]

Github user yonigottesman commented on a diff in the pull request:

https://github.com/apache/incubator-omid/pull/31#discussion_r178794800
  
--- Diff: 
hbase-coprocessor/src/main/java/org/apache/omid/transaction/OmidCompactor.java 
---
@@ -71,7 +73,12 @@
 private boolean retainNonTransactionallyDeletedCells;
 
 public OmidCompactor() {
+this(false);
+}
+
+public OmidCompactor(boolean enableCompactorForAllFamilies) {
 LOG.info("Compactor coprocessor initialized via empty 
constructor");
--- End diff --

replace emtpy with value of enableCompactorForAllFamilies


---

[GitHub] incubator-omid pull request #31: [OMID-96] Enable compactor on all column fa...

[ohadshacham]

GitHub user ohadshacham opened a pull request:

https://github.com/apache/incubator-omid/pull/31

[OMID-96] Enable compactor on all column families during initializati…

…on. This comes in addition to the option of marking each column family 
using HBase metadata.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ohadshacham/incubator-omid OMID-96

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-omid/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit 1c264e3f409d418057f9ab1cc768648357804493
Author: Ohad Shacham 
Date:   2018-03-26T13:07:49Z

[OMID-96] Enable compactor on all column families during initialization. 
This comes in addition to the option of marking each column family using HBase 
metadata.




---