Review Request: Crawler command line bugs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4989/ --- Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary --- 1) In handleOption(), test for multiple options and handle appropriately. 2) Set the value for Unique.filemgrUlr in filemgrUrl bean. 3) UpdateWorkflowStatusToIngest.workflowMgrUrl should be TriggerPostIngestWorkflow.workflowMgrUrl This addresses bug OODT-454. https://issues.apache.org/jira/browse/OODT-454 Diffs - trunk/crawler/src/main/resources/cmd-line-options.xml 1332980 trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java 1305264 Diff: https://reviews.apache.org/r/4989/diff Testing --- Thanks, Thomas
Build failed in Jenkins: oodt-trunk ยป CAS PGE Adaptor Framework #443
See https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/443/
--
[INFO]
[INFO] Building CAS PGE Adaptor Framework
[INFO]task-segment: [install]
[INFO]
[INFO] [remote-resources:process {execution: default}]
Downloading:
http://repo1.maven.org/maven2/net/sf/saxon/saxon-dom/8.7/saxon-dom-8.7.pom
Downloading: http://repo1.maven.org/maven2/net/sf/saxon/saxon/8.7/saxon-8.7.pom
Downloading:
http://repo1.maven.org/maven2/net/sf/saxon/saxon-dom/8.7/saxon-dom-8.7.jar
Downloading: http://repo1.maven.org/maven2/net/sf/saxon/saxon/8.7/saxon-8.7.jar
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 20 source files to
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/target/classes
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] Compiling 8 source files to
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/target/test-classes
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java:[131,51]
cannot find symbol
symbol : class IArgumentMatcher
location: class org.apache.oodt.cas.pge.staging.TestFileStager
[ERROR]
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java:[139,6]
method does not override or implement a method from a supertype
[ERROR]
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java:[147,6]
method does not override or implement a method from a supertype
[ERROR]
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java:[156,17]
reportMatcher(org.easymock.IArgumentMatcher) in org.easymock.EasyMock cannot
be applied to (org.apache.oodt.cas.pge.staging.TestFileStager.ProductIdMatcher)
[INFO] 4 errors
[INFO] -
[JENKINS] Archiving
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/pom.xml
to
/home/hudson/hudson/jobs/oodt-trunk/modules/org.apache.oodt$cas-pge/builds/2012-05-04_00-14-30/archive/org.apache.oodt/cas-pge/0.4-SNAPSHOT/cas-pge-0.4-SNAPSHOT.pom
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Compilation failure
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java:[131,51]
cannot find symbol
symbol : class IArgumentMatcher
location: class org.apache.oodt.cas.pge.staging.TestFileStager
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java:[139,6]
method does not override or implement a method from a supertype
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java:[147,6]
method does not override or implement a method from a supertype
https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-pge/ws/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java:[156,17]
reportMatcher(org.easymock.IArgumentMatcher) in org.easymock.EasyMock cannot
be applied to (org.apache.oodt.cas.pge.staging.TestFileStager.ProductIdMatcher)
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO]
[INFO] Total time: 37 minutes 19 seconds
[INFO] Finished at: Fri May 04 00:52:24 UTC 2012
[INFO] Final Memory: 116M/245M
[INFO]
Build failed in Jenkins: oodt-trunk #443
See https://builds.apache.org/job/oodt-trunk/443/ -- [...truncated 6619 lines...] [INFO] Unable to find resource 'commons-fileupload:commons-fileupload:jar:1.2.1' in repository maven2-repository.dev.java.net (http://download.java.net/maven/2/) Downloading: http://repo1.maven.org/maven2/commons-fileupload/commons-fileupload/1.2.1/commons-fileupload-1.2.1.jar Downloading: http://mirrors.ibiblio.org/pub/mirrors/maven2/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar [WARNING] Unable to get resource 'commons-collections:commons-collections:jar:3.2.1' from repository ibiblio (http://mirrors.ibiblio.org/pub/mirrors/maven2): Authorization failed: Access denied to: http://mirrors.ibiblio.org/pub/mirrors/maven2/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar Downloading: http://download.java.net/maven/2//commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar [INFO] Unable to find resource 'commons-collections:commons-collections:jar:3.2.1' in repository maven2-repository.dev.java.net (http://download.java.net/maven/2/) Downloading: http://repo1.maven.org/maven2/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar Downloading: http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/neethi/neethi/2.0.4/neethi-2.0.4.jar 70K downloaded (jettison-1.2.jar) Downloading: http://mirrors.ibiblio.org/pub/mirrors/maven2/wsdl4j/wsdl4j/1.6.2/wsdl4j-1.6.2.jar 32K downloaded (neethi-2.0.4.jar) [WARNING] Unable to get resource 'org.apache.neethi:neethi:jar:2.0.4' from repository ibiblio (http://mirrors.ibiblio.org/pub/mirrors/maven2): Authorization failed: Access denied to: http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/neethi/neethi/2.0.4/neethi-2.0.4.jar.sha1 Downloading: http://download.java.net/maven/2//org/apache/neethi/neethi/2.0.4/neethi-2.0.4.jar [INFO] Unable to find resource 'org.apache.neethi:neethi:jar:2.0.4' in repository maven2-repository.dev.java.net (http://download.java.net/maven/2/) Downloading: http://repo1.maven.org/maven2/org/apache/neethi/neethi/2.0.4/neethi-2.0.4.jar Downloading: http://mirrors.ibiblio.org/pub/mirrors/maven2/net/sf/ezmorph/ezmorph/1.0.6/ezmorph-1.0.6.jar [WARNING] Unable to get resource 'net.sf.ezmorph:ezmorph:jar:1.0.6' from repository ibiblio (http://mirrors.ibiblio.org/pub/mirrors/maven2): Authorization failed: Access denied to: http://mirrors.ibiblio.org/pub/mirrors/maven2/net/sf/ezmorph/ezmorph/1.0.6/ezmorph-1.0.6.jar Downloading: http://download.java.net/maven/2//net/sf/ezmorph/ezmorph/1.0.6/ezmorph-1.0.6.jar [INFO] Unable to find resource 'net.sf.ezmorph:ezmorph:jar:1.0.6' in repository maven2-repository.dev.java.net (http://download.java.net/maven/2/) Downloading: http://repo1.maven.org/maven2/net/sf/ezmorph/ezmorph/1.0.6/ezmorph-1.0.6.jar Downloading: http://mirrors.ibiblio.org/pub/mirrors/maven2/commons-beanutils/commons-beanutils/1.8.0/commons-beanutils-1.8.0.jar [WARNING] Unable to get resource 'commons-beanutils:commons-beanutils:jar:1.8.0' from repository ibiblio (http://mirrors.ibiblio.org/pub/mirrors/maven2): Authorization failed: Access denied to: http://mirrors.ibiblio.org/pub/mirrors/maven2/commons-beanutils/commons-beanutils/1.8.0/commons-beanutils-1.8.0.jar Downloading: http://download.java.net/maven/2//commons-beanutils/commons-beanutils/1.8.0/commons-beanutils-1.8.0.jar [INFO] Unable to find resource 'commons-beanutils:commons-beanutils:jar:1.8.0' in repository maven2-repository.dev.java.net (http://download.java.net/maven/2/) Downloading: http://repo1.maven.org/maven2/commons-beanutils/commons-beanutils/1.8.0/commons-beanutils-1.8.0.jar Downloading: http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/ws/commons/schema/XmlSchema/1.4.7/XmlSchema-1.4.7.jar 148K downloaded (json-lib-2.3-jdk15.jar) [WARNING] Unable to get resource 'net.sf.json-lib:json-lib:jar:jdk15:2.3' from repository ibiblio (http://mirrors.ibiblio.org/pub/mirrors/maven2): Authorization failed: Access denied to: http://mirrors.ibiblio.org/pub/mirrors/maven2/net/sf/json-lib/json-lib/2.3/json-lib-2.3-jdk15.jar.sha1 Downloading: http://download.java.net/maven/2//net/sf/json-lib/json-lib/2.3/json-lib-2.3-jdk15.jar [INFO] Unable to find resource 'net.sf.json-lib:json-lib:jar:jdk15:2.3' in repository maven2-repository.dev.java.net (http://download.java.net/maven/2/) Downloading: http://repo1.maven.org/maven2/net/sf/json-lib/json-lib/2.3/json-lib-2.3-jdk15.jar 144K downloaded (wsdl4j-1.6.2.jar) [WARNING] Unable to get resource 'wsdl4j:wsdl4j:jar:1.6.2' from repository ibiblio (http://mirrors.ibiblio.org/pub/mirrors/maven2): Authorization failed: Access denied to: http://mirrors.ibiblio.org/pub/mirrors/maven2/wsdl4j/wsdl4j/1.6.2/wsdl4j-1.6.2.jar.sha1 Downloading: http://download.java.net/maven/2//wsdl4j/wsdl4j/1.6.2/wsdl4j-1.6.2.jar [INFO] Unable to find resource 'wsdl4j:wsdl4j:jar:1.6.2' in repository
Re: Review Request: Wengine Task Querier Thread: OODT-310
On 2012-05-02 19:20:13, brian Foster wrote: ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java, line 79 https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line79 When Success/done is passed in, the processor created is incorrect since it has a sub-processor in Queued/waiting Chris Mattmann wrote: Thoughts on how to fix? If 'anydoneStates'/done is passed, then don't add taskProcessor and return the 'done' processor? - Sheryl --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4961/#review7482 --- On 2012-05-02 05:08:45, Chris Mattmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4961/ --- (Updated 2012-05-02 05:08:45) Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl John, and Thomas Bennett. Summary --- Task Querier thread for OODT-310. See javadocs on: https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html This addresses bug OODT-310. https://issues.apache.org/jira/browse/OODT-310 Diffs - ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java 1332505 ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java 1331866 ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java PRE-CREATION Diff: https://reviews.apache.org/r/4961/diff Testing --- Includes unit test, that currently isn't passing. I think I know why (something up with my threading logic and synchronized keywords) but wanted to throw it up for review. I'll likely be working on this tomorrow or the following evening. Thanks, Chris
