Re: Review Request: Suggested refactoring for return statement in getTopNProducts method in LuceneCatalog class

[Ross Laidlaw]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9844/
---

(Updated March 11, 2013, 2:47 a.m.)


Review request for oodt and Chris Mattmann.


Description (updated)
---

The getTopNProducts method has a conditional statement with two possible 
outcomes for return statements.  It should be possible to replace this with a 
single return statement that will still cover all of the same outcomes.


This addresses bug OODT-573.
https://issues.apache.org/jira/browse/OODT-573


Diffs
-

  
/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LuceneCatalog.java
 1454129 

Diff: https://reviews.apache.org/r/9844/diff/


Testing
---

After making the changes, I ran the unit tests for the filemgr package.  All 
tests passed.  These include tests in the TestLuceneCatalog class, which has 
two calls to the getTopNProducts method.  But the tests don't check for a null 
value returned from getTopNProducts, so it might be desirable to add another 
test for this scenario.


Thanks,

Ross Laidlaw

Re: Review Request: Suggested refactoring for return statement in getTopNProducts method in LuceneCatalog class

[Ross Laidlaw]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9844/
---

(Updated March 11, 2013, 2:45 a.m.)


Review request for oodt and Chris Mattmann.


Description
---

The getTopNProducts method has a conditional statement with two possible 
outcomes for return statements.  It should be possible to replace this with a 
single return statement that will still cover all of the same options.


This addresses bug OODT-573.
https://issues.apache.org/jira/browse/OODT-573


Diffs
-

  
/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LuceneCatalog.java
 1454129 

Diff: https://reviews.apache.org/r/9844/diff/


Testing
---

After making the changes, I ran the unit tests for the filemgr package.  All 
tests passed.  These include tests in the TestLuceneCatalog class, which has 
two calls to the getTopNProducts method.  But the tests don't check for a null 
value returned from getTopNProducts, so it might be desirable to add another 
test for this scenario.


Thanks,

Ross Laidlaw

Review Request: Suggested refactoring for return statement in getTopNProducts method in LuceneCatalog class

[Ross Laidlaw]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9844/
---

Review request for oodt and Chris Mattmann.


Description
---

The getTopNProducts method has a conditional statement with two possible 
outcomes for return statements.  It should be possible to replace this with a 
single return statement that will still cover all of the same options.


This addresses bug OODT-573.
https://issues.apache.org/jira/browse/OODT-573


Diffs
-

  
/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LuceneCatalog.java
 1454129 

Diff: https://reviews.apache.org/r/9844/diff/


Testing
---

After making the changes, I ran the unit tests for the filemgr package.  All 
tests passed.  These include tests in the TestLuceneCatalog class, which has 
two calls to the getTopNProducts method.  But the tests don't check for a null 
value returned from getTopNProducts, so it might be desirable to add another 
test for this scenario.


Thanks,

Ross Laidlaw

Re: Research project on integrating geoservices with Apache Airavata

[Mattmann, Chris A (388J)]

Hi Amila,

Thanks!

Regarding the National Climate Assessment, the place to get more info on
our Snow project is:

http://snow.jpl.nasa.gov/

If you have any questions let me know.

Cheers,
Chris


On 3/10/13 10:41 AM, "AMILA RANATUNGA"  wrote:

>Hi,
>
>Thank you very much for co-operation and guidance towards this project and
>your willingness to in cooperate with us. Since we are doing our
>background
>research we are looking into how these projects works and what we can make
>out of those ( Airavata and SIS integration).
>
>The flow you have given get us some understanding about the  Snow project
>for the U.S. National Climate Assessment. We would like to have more
>details about this project if you have so,  to get some overall
>understanding.
>
>Thank You !
>
>
>
>
>
>On Fri, Mar 8, 2013 at 11:18 PM, Mattmann, Chris A (388J) <
>chris.a.mattm...@jpl.nasa.gov> wrote:
>
>> Hey Guys,
>>
>> One other thing I might point you at is the work going on in Apache SIS
>> [1]:
>>
>> http://incubator.apache.org/sis/
>>
>> I recently made a presentation on SIS to the NOAA FOSS meet up here:
>>
>> 
>>http://svn.apache.org/repos/asf/sis/presentations/NOAA-Meetup-Feb21-2013/
>>Ap
>> acheSIS-NOAAMeetup-Final.fodp
>>
>> Right now SIS has support for a Quad Tree, and there is information on
>>how
>> to connect it with Apache OODT:
>>
>> https://cwiki.apache.org/confluence/display/SIS/SIS+Wiki
>>
>> 
>>https://cwiki.apache.org/confluence/display/SIS/OODT+File+Manager+to+SIS+
>>Co
>> nnection+Demo
>>
>>
>> SIS is currently undergoing a humongous change bringing over GeoTK,
>>which
>> is essentially a fully supported
>> Java spatial library originated by Martin Desruisseaux.
>>
>> You may consider doing some Airavata and SIS integration, and
>>potentially
>> looking at some of the OODT integration with geospatial as well.
>>
>> See:
>>
>> http://snow.jpl.nasa.gov/
>>
>> That is an Apache OODT data system integrated with GDAL workflows, and
>> pushing data to GeoServer. Would be great to bring all the projects
>> together here.
>>
>> I'm copying dev@oodt and dev@sis for their feedback. Maybe we could do a
>> few geospatial projects during GSoC between the communities this summer.
>> We did a Geospatial project with Ross Laidlaw as my GSoC student (now on
>> the SIS and OODT PMCs) last summer.
>>
>> Cheers,
>> Chris
>>
>>
>> On 3/7/13 10:20 PM, "Sameera Jayaratna" 
>> wrote:
>>
>> >Hi all,
>> >
>> >We are a group of final year students from the Department of Computer
>> >Science and Engineering, University of Moratuwa, Sri Lanka. We are
>>doing a
>> >research project on Integration of Open Geo-Spatial Consortium¹s WPS
>>[1]
>> >with Apache Airavata under the supervision of Dr. Shahani Markus
>> >Weerawarana.
>> >
>> >The outcome of this project would be a geoscience gateway leveraging
>> >Apache
>> >Airavata and OGC¹s standards-based geo-services. As the initial step we
>> >are
>> >doing a background study on Apache Airavata, scientific workflows,
>> >scientific gateways, geoscience workflows and geo-services. We would
>>like
>> >to explore some solid examples of scientific workflows and resources
>>used
>> >to integrate them apart from what is published on Apache Airavata web
>> >site.
>> >
>> >We would like to receive any thoughts, comments and any other useful
>> >resources.
>> >
>> >[1] http://www.opengeospatial.org/standards/wps
>> >
>> >Thank you.
>> >Sameera.
>> >
>> >--
>> >*Sameera Jayaratna*
>> >*Undergraduate*
>> >*Department of Computer Science And Engineering*
>> >*University of Moratuwa*
>> >*Sri Lanka*
>>
>>

Review Request: Assignments in the setWorkflowInst and setWaitforConditionSatisfy methods need 'this' keyword

[Ross Laidlaw]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9820/
---

Review request for oodt and Chris Mattmann.


Description
---

The assignments in setWorkflowInst and setWaitforConditionSatisfy in the 
IterativeWorkflowProcessorThread class need a 'this' keyword at the beginning 
so that values from the parameters are assigned to member variables.


This addresses bug OODT-571.
https://issues.apache.org/jira/browse/OODT-571


Diffs
-

  
/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/IterativeWorkflowProcessorThread.java
 1454129 

Diff: https://reviews.apache.org/r/9820/diff/


Testing
---


Thanks,

Ross Laidlaw

Jenkins build is back to stable : oodt-trunk #864

[Apache Jenkins Server]

See 

Jenkins build is back to stable : oodt-trunk » CAS Protocol SFTP Implementation #864

[Apache Jenkins Server]

See