Review Request 24140: OODT-723: Fix file manager unit tests in the 'validation' package

[Ross Laidlaw]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24140/
---

Review request for oodt, Lewis McGibbney, Chris Mattmann, Paul Ramirez, and 
Rishi Verma.


Bugs: OODT-723
https://issues.apache.org/jira/browse/OODT-723


Repository: oodt


Description
---

Fixes tests in the 'validation' package for the file manager.  There's a single 
test class in the package called TestXMLValidationLayer.  This patch makes a 
trivial change to the setUp method so that it can locate the 'vallayer' 
directory in the src/test/resources area.  There aren't any 
System.setProperty() calls in this test class so this is a straightforward fix.


Diffs
-

  
/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/validation/TestXMLValidationLayer.java
 1614810 

Diff: https://reviews.apache.org/r/24140/diff/


Testing
---

As described in OODT-722:


The following commands were used to run the tests:

At top-level (trunk directory):

  mvn clean -Dtest=TestXMLValidationLayer -DfailIfNoTests=false test -pl 
filemgr -am


At module level (filemgr directory):

  mvn clean -Dtest=TestXMLValidationLayer test


Test results before applying the patch:
---

Running org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer
Tests run: 7, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 0.038 sec <<< 
FAILURE!

Results :

Tests in error: 
  
testModifyElement(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  testGetElements(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  
testReadProperDescriptionTrimImplicitTrue(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  
testReadBadFormattedDescriptionTrimImplicitTrue(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  
testReadDescriptionTrimExplicitFalse(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  
testReadDescriptionTrimExplicitTrue(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  
testGetElementsForProductType(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)

Tests run: 7, Failures: 0, Errors: 7, Skipped: 0


Test results after applying the patch:
--

Running org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.234 sec

Results :

Tests run: 7, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Ross Laidlaw

Jenkins build is still unstable: oodt-trunk #1415

[Apache Jenkins Server]

See 

Jenkins build became unstable: oodt-trunk » CAS Protocol SFTP Implementation #1415

[Apache Jenkins Server]

See 

Jenkins build is still unstable: oodt-trunk » Catalog and Archive File Management Component #1415

[Apache Jenkins Server]

See 

Re: Review Request 24060: OODT-721: Fix File Manager Tests - Remove Duplicate XML

[Lewis McGibbney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24060/#review49192
---

Ship it!


Ship It!

- Lewis McGibbney


On July 29, 2014, 6:23 p.m., Ross Laidlaw wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24060/
> ---
> 
> (Updated July 29, 2014, 6:23 p.m.)
> 
> 
> Review request for oodt, Lewis McGibbney, Chris Mattmann, Paul Ramirez, and 
> Rishi Verma.
> 
> 
> Bugs: OODT-721
> https://issues.apache.org/jira/browse/OODT-721
> 
> 
> Repository: oodt
> 
> 
> Description
> ---
> 
> This fix is related to ongoing work on OODT-685.  This change has already 
> been detailed/reviewed in https://reviews.apache.org/r/23870/ as part of a 
> larger patch.  After discussions on the mailing lists and in the other 
> reviews, a step-by-step approach has been recommended.  This patch represents 
> an easy first step - removing duplicate XML from three test resources.  Since 
> it's a simple change that has already been reviewed, I'll commit it unless 
> there are any objections.
> 
> 
> Diffs
> -
> 
>   /trunk/filemgr/src/test/resources/cmd-line-actions.xml 1614260 
>   /trunk/filemgr/src/test/resources/cmd-line-options.xml 1614260 
>   /trunk/filemgr/src/test/resources/xmlrpc-struct-factory/product-types.xml 
> 1614260 
> 
> Diff: https://reviews.apache.org/r/24060/diff/
> 
> 
> Testing
> ---
> 
> Due to other issues that will be addressed in subsequent steps, the file 
> manager tests still fail after applying this patch.
> 
> 
> Thanks,
> 
> Ross Laidlaw
> 
>

Re: Review Request 24065: OODT-722: Fix file manager unit tests in the 'repository' package

[Lewis McGibbney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24065/#review49194
---

Ship it!


Ship It!

- Lewis McGibbney


On July 29, 2014, 8:13 p.m., Ross Laidlaw wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24065/
> ---
> 
> (Updated July 29, 2014, 8:13 p.m.)
> 
> 
> Review request for oodt, Lewis McGibbney, Chris Mattmann, Paul Ramirez, and 
> Rishi Verma.
> 
> 
> Bugs: OODT-722
> https://issues.apache.org/jira/browse/OODT-722
> 
> 
> Repository: oodt
> 
> 
> Description
> ---
> 
> Fixes tests in the 'repository' package for the file manager.  There's a 
> single test class in the package called TestXMLRepositoryManager.  This patch 
> makes a trivial change to the constructor so that it can locate the 'repomgr' 
> directory in the src/test/resources area.  There aren't any 
> System.setProperty() calls in this test class so this is a straightforward 
> fix.
> 
> 
> Diffs
> -
> 
>   
> /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/repository/TestXMLRepositoryManager.java
>  1614458 
> 
> Diff: https://reviews.apache.org/r/24065/diff/
> 
> 
> Testing
> ---
> 
> As described in OODT-722:
> 
> 
> The following commands were used to run the tests:
> 
> At top-level (trunk directory):
> 
>   mvn clean -Dtest=TestXMLRepositoryManager -DfailIfNoTests=false test -pl 
> filemgr -am
> 
> 
> At module level (filemgr directory):
> 
>   mvn clean -Dtest=TestXMLRepositoryManager test
> 
> 
> Test results before applying the patch:
> ---
> 
> Failed tests: 
>   
> testGetProductTypes(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  expected:<3> but was:<0>
>   
> testGetProductTypeByName(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  null
>   
> testGetProductTypeById(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  null
>   
> testReadProductTypeWithMetadataWithBlankMet(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  null
>   
> testReadProductTypeWithMetadataWithNoMet(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  null
>   
> testReadProductTypeWithMetadata(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  null
>   
> testReadBadFormattedDescriptionTrimImplicitTrue(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  null
>   
> testReadDescriptionTrimExplicitFalse(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  null
>   
> testReadDescriptionTrimExplicitTrue(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  null
>   
> testReadVersionerClass(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  null
>   
> testReadRepoPath(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  null
> 
> Tests in error: 
>   
> testRepoPathEnvVarReplace(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager):
>  0
> 
> Tests run: 12, Failures: 11, Errors: 1, Skipped: 0
> 
> 
> Test results after applying the patch:
> --
> 
> Results :
> 
> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Ross Laidlaw
> 
>

Re: Review Request 24060: OODT-721: Fix File Manager Tests - Remove Duplicate XML

[Lewis McGibbney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24060/#review49191
---

Ship it!


SHIP IT

- Lewis McGibbney


On July 29, 2014, 6:23 p.m., Ross Laidlaw wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24060/
> ---
> 
> (Updated July 29, 2014, 6:23 p.m.)
> 
> 
> Review request for oodt, Lewis McGibbney, Chris Mattmann, Paul Ramirez, and 
> Rishi Verma.
> 
> 
> Bugs: OODT-721
> https://issues.apache.org/jira/browse/OODT-721
> 
> 
> Repository: oodt
> 
> 
> Description
> ---
> 
> This fix is related to ongoing work on OODT-685.  This change has already 
> been detailed/reviewed in https://reviews.apache.org/r/23870/ as part of a 
> larger patch.  After discussions on the mailing lists and in the other 
> reviews, a step-by-step approach has been recommended.  This patch represents 
> an easy first step - removing duplicate XML from three test resources.  Since 
> it's a simple change that has already been reviewed, I'll commit it unless 
> there are any objections.
> 
> 
> Diffs
> -
> 
>   /trunk/filemgr/src/test/resources/cmd-line-actions.xml 1614260 
>   /trunk/filemgr/src/test/resources/cmd-line-options.xml 1614260 
>   /trunk/filemgr/src/test/resources/xmlrpc-struct-factory/product-types.xml 
> 1614260 
> 
> Diff: https://reviews.apache.org/r/24060/diff/
> 
> 
> Testing
> ---
> 
> Due to other issues that will be addressed in subsequent steps, the file 
> manager tests still fail after applying this patch.
> 
> 
> Thanks,
> 
> Ross Laidlaw
> 
>