Re: Review Request 15030: New RestfulProductQueryServlet
On Nov. 6, 2013, 4:16 p.m., Sean Kelly wrote: This looks utterly beautiful, even for Java code. Thanks for adding this, Luca. Thanks Sean, I will add this to the repository. - Luca --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15030/#review28266 --- On Oct. 29, 2013, 4:28 p.m., Luca Cinquini wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15030/ --- (Updated Oct. 29, 2013, 4:28 p.m.) Review request for oodt and Chris Mattmann. Repository: oodt Description --- Insert a sub-class of QueryServlet that allows clients to use a URL syntax easier than the traditional DIS-style. Diffs - http://svn.apache.org/repos/asf/oodt/trunk/grid/src/main/java/org/apache/oodt/grid/QueryServlet.java 1533206 http://svn.apache.org/repos/asf/oodt/trunk/grid/src/main/java/org/apache/oodt/grid/RestfulProductQueryServlet.java PRE-CREATION Diff: https://reviews.apache.org/r/15030/diff/ Testing --- Tested with the PDS transport-registry service. Both the old URL syntax and the new URL syntax worked. Thanks, Luca Cinquini
Review Request: Native Solr implementation of CAS File Manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10288/ --- Review request for oodt and Chris Mattmann. Description --- This Catalog sub-package provides an extensible set of functionality that allows a CAS File Manager to store and query metadata to/from a standalone Solr server. Diffs - http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/assembly/assembly.xml 1463907 http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/CompleteProduct.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/DefaultProductDeserializer.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/DefaultProductSerializer.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/NameProductIdGenerator.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/OODT_SOLR_README.TXT PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/Parameters.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductDeserializer.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductIdGenerator.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductSerializer.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/QUICK_START_GUIDE.TXT PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/QueryResponse.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrCatalog.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrCatalogFactory.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrClient.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/UUIDProductIdGenerator.java PRE-CREATION http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/filemgr.properties 1464226 http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/schema.xml PRE-CREATION Diff: https://reviews.apache.org/r/10288/diff/ Testing --- Tested ingestion and querying of simple products of type 'GenericFile', as well as products generated by the VFASTR pipeline (but without splitting them in separate documents for Job/Scan/Event information). Included draft documentation for Apache wiki: quick start guide and in-depth architecture guide. Thanks, Luca Cinquini
Review Request: Ordering of products if DataSourceCatalog if product_id is of type string.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8648/ --- Review request for oodt and Chris Mattmann. Description --- Support ordering of results in OODT DataSourceCatalog in case the product_id is a string. In this case, a new column product_datetime of type date is used to order results based on last ingestion. Diffs - http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java 1422929 http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LenientDataSourceCatalog.java 1422909 http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/cas-filemgr-core-schema-oracle.sql 1403860 http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/cas-filemgr-schema-mysql.sql 1403860 Diff: https://reviews.apache.org/r/8648/diff/ Testing --- Tested on CAS FileManager deployment for VFASTR project. Thanks, Luca Cinquini
Re: Review Request: Support for product_id of type string in FM DataSourceCatalog
On Dec. 15, 2012, 7:04 p.m., Chris Mattmann wrote: ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java, line 57 https://reviews.apache.org/r/8616/diff/1/?file=239036#file239036line57 Changes like this I don't get -- even if they are auto generated by Eclipse -- they're extraneous since they are just moved higher up in the file. No problem - I can move the OODT imports on top and the JDK imports on the bottom. As you say, Eclipse likes it better the other way around... On Dec. 15, 2012, 7:04 p.m., Chris Mattmann wrote: ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java, line 399 https://reviews.apache.org/r/8616/diff/1/?file=239036#file239036line399 can we change quoteit to be quoteIt (camel case, Java style?) No problem, done. On Dec. 15, 2012, 7:04 p.m., Chris Mattmann wrote: ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LenientDataSourceCatalog.java, line 96 https://reviews.apache.org/r/8616/diff/1/?file=239038#file239038line96 why is this a FIXME? I should have removed the FIXME, it was a reminder for me about where I changed the original source. Assuring consistency in the product metadata between CAS.productId and the product id is the cirrect thing to do. On Dec. 15, 2012, 7:04 p.m., Chris Mattmann wrote: ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java, line 2250 https://reviews.apache.org/r/8616/diff/1/?file=239036#file239036line2250 It would be great to change this to quoteIt. Yes, changed. - Luca --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8616/#review14542 --- On Dec. 15, 2012, 7 p.m., Chris Mattmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8616/ --- (Updated Dec. 15, 2012, 7 p.m.) Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Thomas Bennett, and Cameron Goodale. Description --- Patch from Luca Cinquini and I to implement support for UUID based Data Source Catalogs. This addresses bug OODT-544. https://issues.apache.org/jira/browse/OODT-544 Diffs - ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java 1422312 ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalogFactory.java 1422312 ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LenientDataSourceCatalog.java PRE-CREATION ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/util/DbStructFactory.java 1422312 Diff: https://reviews.apache.org/r/8616/diff/ Testing --- We have tested this on my transient detection project for V-FASTR. Thanks, Chris Mattmann
