Review Request: Set page size when query is done. Remove sort when trying to just get total number hits.

2012-08-29 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6828/
---

Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Andrew 
Hart, Sheryl John, and Thomas Bennett.


Description
---

Refactoring so that paged queries will not be submitted twice.


This addresses bug OODT-489.
https://issues.apache.org/jira/browse/OODT-489


Diffs
-

  
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LuceneCatalog.java
 1378557 

Diff: https://reviews.apache.org/r/6828/diff/


Testing
---


Thanks,

Paul Ramirez



Re: Review Request: Change SciPgeConfigFileWriter to DynamicConfigFileWriter

2012-06-24 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5428/#review8423
---

Ship it!


+1

- Paul Ramirez


On June 20, 2012, 1 a.m., brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5428/
> ---
> 
> (Updated June 20, 2012, 1 a.m.)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Description
> ---
> 
> I figure this is a good time to change the name of this interface, which was 
> poorly named, since cas-pge has taken a huge overhaulin... Logger is being 
> added to the method arguments and the method name is being changed:
> 
> public File generateFile(String filePath, Metadata metadata, Logger logger,
>  Object... args) throws Exception;
> 
> 
> This addresses bug OODT-467.
> https://issues.apache.org/jira/browse/OODT-467
> 
> 
> Diffs
> -
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
> 1351904 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/util/GenericPgeObjectFactory.java
>  1351904 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/CsvConfigFileWriter.java
>  1351905 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/DynamicConfigFileWriter.java
>  PRE-CREATION 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/SciPgeConfigFileWriter.java
>  1351904 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/TextConfigFileWriter.java
>  1351905 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/XslTransformWriter.java
>  1351905 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1351905 
>   
> trunk/pge/src/test/org/apache/oodt/cas/pge/writers/MockDynamicConfigFileWriter.java
>  PRE-CREATION 
>   
> trunk/pge/src/test/org/apache/oodt/cas/pge/writers/MockSciPgeConfigFileWriter.java
>  1351904 
> 
> Diff: https://reviews.apache.org/r/5428/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> brian Foster
> 
>



[ANNOUNCE] Release of Apache OODT 0.4

2012-06-20 Thread Paul Ramirez
The Apache OODT community is proud to announce our

0.4 release. The website will be updated shortly to reflect

the release and the source should hit the mirrors within the

next 24-48 hours.


Please visit our project website to learn more about Apache

OODT, a data grid framework for transparent discovery of

disparate science resources.


http://oodt.apache.org/


Thanks,

Apache OODT PPMC


Re: Review Request: Add file staging support to CAS-PGE

2012-05-01 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4746/#review7421
---

Ship it!


- Paul


On 2012-04-30 21:23:30, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4746/
> ---
> 
> (Updated 2012-04-30 21:23:30)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> Will introduce a FileStaging abstract class with currently 1 implementation 
> using the FileManager. There will also be a new Config object which allow for 
> file paths or product ids which would you like to stage... this code will be 
> plugged in the XML configuration in a separate patch
> 
> - This patch also include minor changes to log statments in PGETaskInstance
> 
> 
> This addresses bug OODT-443.
> https://issues.apache.org/jira/browse/OODT-443
> 
> 
> Diffs
> -
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETask.java 1302648 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
> 1311492 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java 
> PRE-CREATION 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java 
> 1311492 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 
> 1311492 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java
>  PRE-CREATION 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java 
> PRE-CREATION 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/util/GenericPgeObjectFactory.java
>  PRE-CREATION 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4746/diff
> 
> 
> Testing
> ---
> 
> unit-tests
> 
> 
> Thanks,
> 
> brian
> 
>



Re: Review Request: String search and replace getMetadata("UUID with getMetadata("CAS.ProductId

2012-04-13 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4709/#review6897
---

Ship it!


Other than what the other 2 commenters already mentioned LGTM. 

- Paul


On 2012-04-12 13:33:57, Thomas Bennett wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4709/
> ---
> 
> (Updated 2012-04-12 13:33:57)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and 
> Sheryl John.
> 
> 
> Summary
> ---
> 
> String search and replace getMetadata("UUID with getMetadata("CAS.ProductId
> 
> 
> This addresses bug OODT-440.
> https://issues.apache.org/jira/browse/OODT-440
> 
> 
> Diffs
> -
> 
>   
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java
>  1306745 
> 
> Diff: https://reviews.apache.org/r/4709/diff
> 
> 
> Testing
> ---
> 
> Unit test pass
> Works on my installed OODT ditribution
> 
> 
> Thanks,
> 
> Thomas
> 
>



Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-04 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4628/#review6670
---



trunk/pge/src/main/resources/examples/Crawler/action-beans.xml
<https://reviews.apache.org/r/4628/#comment14432>

I'd define these properties in another file and then include them here. 
This is only a suggestion and not a just but I see the properties as something 
that could likely be changed or set to a fixed value and if we factor it out of 
here we can keep people from touching this file too much. I think this file 
just makes peoples heads spin at first but the properties don't (i.e. it hides 
the Spring goodness in a good way).



trunk/pge/src/main/resources/examples/PgeConfigFiles/pge-config.xml
<https://reviews.apache.org/r/4628/#comment14431>

Put these examples inside comment tags as they wouldn't work as they 
existed anyhow. Also putting a longer description in the comment would help 
(i.e. one or more of these is not as helpful as what it does functionally. Why 
did we remove the files tag? Is this no longer supported? If it is then I 
recommend putting it back in but commented out. 

For instance, I'd expect that instead of metadata keys you want to set more 
of what will be done with that custom metadata would be of use. Also an example 
of multivalued metadata. 


- Paul


On 2012-04-03 21:56:17, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4628/
> ---
> 
> (Updated 2012-04-03 21:56:17)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> CAS-PGE Changes to this issue...
> - Renaming and Metadata extraction removed from CAS-PGE and instead CAS-PGE 
> now uses AutoDetectProductCrawler instead of StdProductCrawler
> 
> 
> This addresses bug OODT-426.
> https://issues.apache.org/jira/browse/OODT-426
> 
> 
> Diffs
> -
> 
>   trunk/pge/pom.xml 1302648 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
> 1302648 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/OutputDir.java 
> 1302648 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java 
> 1302648 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfigBuilder.java 
> 1302648 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfigMetKeys.java 
> 1302648 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/RegExprOutputFiles.java
>  1302648 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/RenamingConv.java 
> 1302648 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
>  1302648 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 
> 1302648 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/ExternExtractorMetWriter.java
>  1302648 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/FilenameExtractorWriter.java
>  1302648 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/PcsMetFileWriter.java 
> 1302648 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/SciPgeConfigFileWriter.java
>  1302648 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/metlist/MetadataListPcsMetFileWriter.java
>  1302648 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/xslt/XslTransformWriter.java
>  1302648 
>   trunk/pge/src/main/resources/examples/Crawler/action-beans.xml PRE-CREATION 
>   trunk/pge/src/main/resources/examples/Crawler/crawler-config.xml 
> PRE-CREATION 
>   trunk/pge/src/main/resources/examples/Crawler/mime-extractor-map.xml 
> PRE-CREATION 
>   trunk/pge/src/main/resources/examples/Crawler/mime-types.xml PRE-CREATION 
>   trunk/pge/src/main/resources/examples/Crawler/naming-beans.xml PRE-CREATION 
>   trunk/pge/src/main/resources/examples/Crawler/precondition-beans.xml 
> PRE-CREATION 
>   
> trunk/pge/src/main/resources/examples/MetadataOutputFiles/metadata-output.xml 
> 1302648 
>   trunk/pge/src/main/resources/examples/PgeConfigFiles/pge-config.xml 1302648 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1302781 
> 
> Diff: https://reviews.apache.org/r/4628/diff
> 
> 
> Testing
> ---
> 
> Several Unit-tests
> 
> 
> Thanks,
> 
> brian
> 
>



Re: Review Request: Get product references before calling retrieveProduct(). Update unit tests testRetrieveFilesById() and testRetrieveFilesByName()

2012-03-29 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4553/#review6517
---

Ship it!


Lgtm

- Paul


On 2012-03-29 12:21:40, Thomas Bennett wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4553/
> ---
> 
> (Updated 2012-03-29 12:21:40)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and 
> Sheryl John.
> 
> 
> Summary
> ---
> 
> Get product references before calling retrieveProduct().
> 1) call setProductReferences method
> 2) remove d.retrieveProduct() outside the if else statement.
> 
> Fix unit tests testRetrieveFilesById() and testRetrieveFilesByName()
> 1) last method call is now getProductReferences not 
> getProductByName/getProductById
> 2) The last method call has the product passed in as the argument. The call 
> has been modified to retrieve the productName/productId correctly from the 
> method call.
> 
> 
> This addresses bug OODT-433.
> https://issues.apache.org/jira/browse/OODT-433
> 
> 
> Diffs
> -
> 
>   
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/RetrieveFilesCliAction.java
>  1306745 
>   
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java
>  1306745 
> 
> Diff: https://reviews.apache.org/r/4553/diff
> 
> 
> Testing
> ---
> 
> * All unit tests now pass
> * filemgr deployed and tested with the filemgr client using both local and 
> remote data transfer factories.
> 
> 
> Thanks,
> 
> Thomas
> 
>



Re: Review Request: OODT-410: DataSourceCatalog compatible with HypersonicSQL

2012-03-16 Thread Paul Ramirez
framework.ComparisonFailure: expected:<[ShouldBeFirstForPage.tx]t> 
> but was:<[tes]t>
> at junit.framework.Assert.assertEquals(Assert.java:81)
> at junit.framework.Assert.assertEquals(Assert.java:87)
> at 
> org.apache.oodt.cas.filemgr.catalog.TestDataSourceCatalog.testFirstProductOnlyOnFirstPage(TestDataSourceCatalog.java:278)
> 
> [chipotle:oodt/trunk/filemgr] mattmann% 
> 
> I need to look more, but something is wiggy here.
> 
> brian Foster wrote:
> When i ditch DataSourceCatalog line number 1793:
> 
>   getProductSql += "ORDER BY p.product_id DESC ";
> 
> TestDataSourceCatalog pass for me

I'd vote to kick ORDER sorts when not needed; it just adds time to the query 
execution.


- Paul


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4358/#review5978
---


On 2012-03-14 23:40:55, Chris Mattmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4358/
> ---
> 
> (Updated 2012-03-14 23:40:55)
> 
> 
> Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas 
> Bennett.
> 
> 
> Summary
> ---
> 
> DataSourceCatalog compatible with HypersonicSQL
> 
> 
> This addresses bug OODT-410.
> https://issues.apache.org/jira/browse/OODT-410
> 
> 
> Diffs
> -
> 
>   
> ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/HsqlDbFriendlyDataSourceCatalog.java
>  PRE-CREATION 
>   
> ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/HsqlDbFriendlyDataSourceCatalogFactory.java
>  PRE-CREATION 
>   
> ./trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java
>  1294690 
> 
> Diff: https://reviews.apache.org/r/4358/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chris
> 
>



Re: Review Request: Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys

2012-03-16 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4359/#review6031
---

Ship it!


+1

- Paul


On 2012-03-15 08:25:38, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4359/
> ---
> 
> (Updated 2012-03-15 08:25:38)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> Will allow for specification of new keys while still supported legacy keys
> 
> 
> This addresses bug OODT-411.
> https://issues.apache.org/jira/browse/OODT-411
> 
> 
> Diffs
> -
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
> 1300799 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
>  1300799 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PcsMetadataKeys.java 
> 1300798 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 
> 1300799 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300799 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java 
> 1300799 
> 
> Diff: https://reviews.apache.org/r/4359/diff
> 
> 
> Testing
> ---
> 
> existing unit-tests for PgeTaskMetKeys
> 
> 
> Thanks,
> 
> brian
> 
>



Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

2012-03-14 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/#review5943
---

Ship it!


That was the only change I saw. Otherwise looks good.


trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java
<https://reviews.apache.org/r/4326/#comment12904>

shouldn't this be:

return Boolean.getBoolean(System.getProperty(USE_LEGACY_PROPERTY)) ? 
legacyName : name;




- Paul


On 2012-03-14 05:18:33, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4326/
> ---
> 
> (Updated 2012-03-14 05:18:33)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> The enum for met keys will allow for backwards compatibility to be toggled 
> on/off easily
> 
> 
> This addresses bug OODT-409.
> https://issues.apache.org/jira/browse/OODT-409
> 
> 
> Diffs
> -
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
> 1300432 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
>  1300432 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 
> PRE-CREATION 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java
>  1300432 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java 
> PRE-CREATION 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4326/diff
> 
> 
> Testing
> ---
> 
> Added/Updated Unit-Tests
> 
> 
> Thanks,
> 
> brian
> 
>



Re: Review Request: Drop Spring logging levels from WARNING to SEVERE

2012-03-14 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4342/#review5942
---

Ship it!


Looks good to me. Next time you can link this to the Jira issue if you want by 
putting the OODT-408 in the bugs field in the review request. 

- Paul


On 2012-03-14 13:33:35, Thomas Bennett wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4342/
> ---
> 
> (Updated 2012-03-14 13:33:35)
> 
> 
> Review request for oodt and brian Foster.
> 
> 
> Summary
> ---
> 
> Drop Spring logging levels from WARNING to SEVERE
>  
> This addresses issue OODT-408:
> https://issues.apache.org/jira/browse/OODT-408
> 
> 
> Diffs
> -
> 
>   /trunk/catalog/src/main/resources/logging.properties 1300513 
>   /trunk/crawler/src/main/resources/logging.properties 1300513 
>   /trunk/filemgr/src/main/resources/logging.properties 1300513 
>   /trunk/resource/src/main/resources/logging.properties 1300513 
>   /trunk/workflow/src/main/resources/logging.properties 1300513 
> 
> Diff: https://reviews.apache.org/r/4342/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas
> 
>



Re: Review Request: Port wengine ControlMetadata to cas-pge's PgeMetadata

2012-03-12 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4269/#review5850
---

Ship it!


Love the varargs!

- Paul


On 2012-03-10 01:32:07, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4269/
> ---
> 
> (Updated 2012-03-10 01:32:07)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> Updates CAS-PGE's PgeMetadata to work similar to WEngine's ControlMetadata
> 
> 
> This addresses bug OODT-403.
> https://issues.apache.org/jira/browse/OODT-403
> 
> 
> Diffs
> -
> 
>   trunk/pge/pom.xml 1298742 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
> 1298742 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
>  1298742 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 
> 1298742 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/PcsMetFileWriter.java 
> 1298742 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeMetadata.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4269/diff
> 
> 
> Testing
> ---
> 
> added unit-test
> 
> 
> Thanks,
> 
> brian
> 
>



Re: Review Request: Updates from branch cas-pge

2012-03-06 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4196/#review5642
---


Looks good most of my comments are a request for some unit tests especially 
where stuff has been refactored and there is new code. Some of the stuff wasn't 
a change as the code was just reformatted.


trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4196/#comment12279>

Why is this gone? I see the new one that runs all. Mark this with 
deprecated? It's protected so only internally used just wondered.



trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4196/#comment12280>

Not really a change just a reformatting.



trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4196/#comment12281>

no change just reformatting



trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4196/#comment12276>

Is this one of the keys you were saying is still needed in the patch?




trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4196/#comment12282>

Where has this functionality moved to?



trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileBasedPgeConfigBuilder.java
<https://reviews.apache.org/r/4196/#comment12285>

This appears to be a refactoring make sure the unit tests written for the 
XMLFilePGEConfigBuilder cover the code here.



trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
<https://reviews.apache.org/r/4196/#comment12284>

Lots of changes needs unit tests



trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PGETaskMetKeys.java
<https://reviews.apache.org/r/4196/#comment12278>

yay constants.



trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java
<https://reviews.apache.org/r/4196/#comment12277>

Yay unused code removed.



trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java
<https://reviews.apache.org/r/4196/#comment12283>

Needs unit tests. Also make sure there is coverage into FileStager. 


- Paul


On 2012-03-06 08:20:36, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4196/
> ---
> 
> (Updated 2012-03-06 08:20:36)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> This includes the changes from wengine-branch cas-pge... still needs to add 
> backwards compatibility for MetKeys (i.e. PCS_* etc)
> 
> 
> Diffs
> -
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
> 1297147 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileBasedPgeConfigBuilder.java
>  PRE-CREATION 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java 
> PRE-CREATION 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java 
> 1297147 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfigBuilder.java 
> 1297147 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfigMetKeys.java 
> 1297147 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
>  1297147 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PGETaskMetKeys.java 
> PRE-CREATION 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 
> 1297147 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java
>  PRE-CREATION 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java 
> PRE-CREATION 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/PcsMetFileWriter.java 
> 1297147 
> 
> Diff: https://reviews.apache.org/r/4196/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> brian
> 
>



Re: Review Request: Add options for CAS-Crawler's SendNotification CrawlerAction

2012-03-05 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4118/#review5611
---

Ship it!


- Paul


On 2012-03-01 02:16:02, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4118/
> ---
> 
> (Updated 2012-03-01 02:16:02)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> It will look something like:
> 
> -n [--notification]
>  -msg [--message]  (required)
>  -sdr [--sender]  (required)
>  -iias [--ignoreInvalidAddresses] (optional)
>  -rcpts [--recipients]  (required)
>  -sub [--subject]  (required)
>  -mh [--mailHost]  (required)
> 
> 
> This addresses bug OODT-400.
> https://issues.apache.org/jira/browse/OODT-400
> 
> 
> Diffs
> -
> 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/EmailNotification.java
>  1294389 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1294389 
> 
> Diff: https://reviews.apache.org/r/4118/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> brian
> 
>



Re: Review Request: OODT-395: SerializableMetadata.toXml() doesn't set namespace on root element

2012-03-02 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4088/#review5558
---

Ship it!


good job

- Paul


On 2012-02-29 20:02:06, Ricky Nguyen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4088/
> ---
> 
> (Updated 2012-02-29 20:02:06)
> 
> 
> Review request for oodt.
> 
> 
> Summary
> ---
> 
> Create metadata root element with a proper namespace and prefix.
> 
> 
> This addresses bug OODT-395.
> https://issues.apache.org/jira/browse/OODT-395
> 
> 
> Diffs
> -
> 
>   
> trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/SerializableMetadata.java
>  1293402 
>   
> trunk/metadata/src/test/org/apache/oodt/cas/metadata/TestSerializableMetadata.java
>  1293402 
> 
> Diff: https://reviews.apache.org/r/4088/diff
> 
> 
> Testing
> ---
> 
> Added unit test in TestSerializableMetadata#testNamespace() to demonstrate 
> bug and fix.
> 
> 
> Thanks,
> 
> Ricky
> 
>



Re: Review Request: OODT-361: Workflow test event fails with NPE

2012-02-28 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4089/#review5430
---

Ship it!


- Paul


On 2012-02-28 20:05:18, Ricky Nguyen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4089/
> ---
> 
> (Updated 2012-02-28 20:05:18)
> 
> 
> Review request for oodt.
> 
> 
> Summary
> ---
> 
> When DateConvert.isoParse is given a null input, it throws NPE.
> Solution is throw ParseException if input is null. WorkflowInstance catches 
> ParseException and ignores it.
> 
> 
> This addresses bug OODT-361.
> https://issues.apache.org/jira/browse/OODT-361
> 
> 
> Diffs
> -
> 
>   trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java 
> 1294802 
> 
> Diff: https://reviews.apache.org/r/4089/diff
> 
> 
> Testing
> ---
> 
> Ran HelloWorld, GoodbyeWorld.
> 
> 
> Thanks,
> 
> Ricky
> 
>



Re: Review Request: Remove old command line option code from commons

2012-02-27 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4071/#review5382
---

Ship it!


Out with the old in with the new. 

- Paul


On 2012-02-27 23:07:29, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4071/
> ---
> 
> (Updated 2012-02-27 23:07:29)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> Has been replaced by CAS-CLI
> 
> 
> This addresses bug OODT-392.
> https://issues.apache.org/jira/browse/OODT-392
> 
> 
> Diffs
> -
> 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/CmdLineOption.java 
> 1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/CmdLineOptionInstance.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/OptionHelpException.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/BeanInfo.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/CmdLineOptionBeanHandler.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/CmdLineOptionHandler.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/StdCmdLineOptionHandler.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/parser/CmdLineOptionParser.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/required/RequiredOption.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/util/CmdLineOptionUtils.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/util/CmdLineOptionsUsagePrinter.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/AllowedArgsCmdLineOptionValidator.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/ArgRegExpCmdLineOptionValidator.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/ClassExistsCmdLineOptionValidator.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/CmdLineOptionValidator.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/FileExistCmdLineOptionValidator.java
>  1294382 
>   
> trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/NoRestrictionsCmdLineOptionValidator.java
>  1294382 
> 
> Diff: https://reviews.apache.org/r/4071/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> brian
> 
>



Re: Review Request: Integrate CAS-Catalog with CAS-CLI

2012-02-27 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4069/#review5383
---

Ship it!


Awesome job finishing out the cli stuff. 

- Paul


On 2012-02-27 22:52:39, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4069/
> ---
> 
> (Updated 2012-02-27 22:52:39)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> Issue tracked here: https://issues.apache.org/jira/browse/OODT-391
> 
> 
> Diffs
> -
> 
>   trunk/catalog/pom.xml 1294375 
>   trunk/catalog/src/main/bin/catserv-client 1294375 
>   trunk/catalog/src/main/bin/catserv-server 1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/cli/action/CatalogServiceCliAction.java
>  PRE-CREATION 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/cli/action/GetSupportedCatalogIdsCliAction.java
>  PRE-CREATION 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/cli/action/LoadCatalogRepositoryCliAction.java
>  PRE-CREATION 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/cli/action/LoadCatalogsCliAction.java
>  PRE-CREATION 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/cli/action/PagedQueryCliAction.java
>  PRE-CREATION 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/cli/action/QueryCliAction.java
>  PRE-CREATION 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/cli/action/ReducedPagedQueryCliAction.java
>  PRE-CREATION 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/cli/action/ReducedQueryCliAction.java
>  PRE-CREATION 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/cli/action/ShutdownCliAction.java
>  PRE-CREATION 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/CatalogServiceCommandLineClient.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/CatalogServiceServerLauncher.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/action/CatalogServiceServerAction.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/action/GetSupportedCatalogIds.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/action/LoadCatalogRepositoryServerAction.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/action/LoadCatalogsServerAction.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/action/PagedQueryServerAction.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/action/QueryServerAction.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/action/ReducedPagedQueryServerAction.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/action/ReducedQueryServerAction.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/action/ShutdownServerAction.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/cli/action/CatalogServiceServerCliAction.java
>  PRE-CREATION 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/cli/action/LaunchXmlRpcServerCliAction.java
>  PRE-CREATION 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/option/PrintSupportedActionsHandler.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/option/PrintSupportedClientsHandler.java
>  1294375 
>   
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/option/PrintSupportedServersHandler.java
>  1294375 
>   trunk/catalog/src/main/resources/catalog-service.properties 1294375 
>   trunk/catalog/src/main/resources/logging.properties 1294375 
>   trunk/catalog/src/main/resources/policy/catserv-beans.xml 1294375 
>   trunk/catalog/src/main/resources/policy/cmd-line-actions.xml PRE-CREATION 
>   trunk/catalog/src/main/resources/policy/cmd-line-options.xml PRE-CREATION 
>   trunk/catalog/src/main/resources/policy/cmd-line-server-actions.xml 
> PRE-CREATION 
>   trunk/catalog/src/main/resources/policy/cmd-line-server-options.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4069/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> brian
> 
>



Re: Review Request: Integrate CAS-CLI into CAS-Crawler

2012-02-26 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3854/#review5347
---


- Paul


On 2012-02-25 22:58:55, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3854/
> ---
> 
> (Updated 2012-02-25 22:58:55)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> Issue tracked here: https://issues.apache.org/jira/browse/OODT-352
> 
> 
> Diffs
> -
> 
>   trunk/crawler/pom.xml 1242996 
>   trunk/crawler/src/main/assembly/assembly.xml 1242996 
>   trunk/crawler/src/main/bin/crawler_launcher 1242996 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/CrawlerLauncher.java 
> 1242996 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 
> 1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java 
> 1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/CrawlerAction.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/CrawlerActionPhases.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/CrawlerActionRepo.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/DeleteFile.java 
> 1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/EmailNotification.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/ExternAction.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/FileBasedAction.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/FileSettings.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/FilemgrUniquenessChecker.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/GroupAction.java 
> 1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/IngestAncillary.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/MimeTypeCrawlerAction.java
>  1242996 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/MoveFile.java 
> 1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/TernaryAction.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/ToggleAction.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/WorkflowMgrStatusUpdate.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/action/CrawlerLauncherCliAction.java
>  PRE-CREATION 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/BeanInfoHandler.java
>  PRE-CREATION 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerActionInfoHandler.java
>  PRE-CREATION 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
>  PRE-CREATION 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/PreconditionInfoHandler.java
>  PRE-CREATION 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/config/ProductCrawlerBean.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/option/CmdLineOptionCrawlerActionInfoHandler.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/option/CmdLineOptionInfoHandler.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/option/CmdLineOptionJavaPropHandler.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/option/CmdLineOptionPreconditionInfoHandler.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/option/CmdLineOptionProductCrawlerInfoHandler.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/structs/exceptions/CrawlerActionException.java
>  1242996 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/util/ActionBeanProperties.java
>  PRE-CREATION 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/util/CasPropertyOverrideConfigurer.java
>  PRE-CREATION 
>   trunk/crawler/src/main/resources/action-beans.xml 1242996 
>   trunk/crawler/src/main/resources/cmd-line-actions.xml PRE-CREATION 
>   trunk/crawler/src/main/resources/cmd-line-option-b

Re: Review Request: Integrate CAS-CLI into CAS-Filemgr

2011-11-28 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2946/#review3535
---

Ship it!


Looks good. The only comment I have is there seems to be a mismatch in the -psa 
and the action names that get listed and the operations that can be triggered. 
Seems like there may need to be a mapping there. When you look up help on an 
action you use the ActionName. When you do an operation its by its flag. 
Although there is seemingly a one to one mapping the command line arguments 
don't seem interchangeable.

- Paul


On 2011-11-28 08:43:27, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2946/
> ---
> 
> (Updated 2011-11-28 08:43:27)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> Issue being tracked at: https://issues.apache.org/jira/browse/OODT-351
> 
> Added command-line options for filemgr:
> 
> $ ./filemgr-client -h
> -
> | Short | Long | Description
> -
> 
>  -op,--operationDeclare that you 
> wish to present an operation
>SubOptions:
>> Required:
>> Optional:
>   -addPT, --addProductType  Triggers 
> AddProductType Action
>   Requirement 
> Rules: 
>
> [AddProductType : REQUIRED] 
>   -dbyid, --deleteProductById   Triggers 
> DeleteProductById Action
>   Requirement 
> Rules: 
>
> [DeleteProductById : REQUIRED] 
>   -dbyn,  --deleteProductByName Triggers 
> DeleteProductByName Action
>   Requirement 
> Rules: 
>
> [DeleteProductByName : REQUIRED] 
>   -ingest,--ingestProduct   Triggers 
> IngestProduct Action
>   Requirement 
> Rules: 
>[IngestProduct 
> : REQUIRED] 
>   -product,--hasProduct  Triggers 
> HasProduct Action
>   Requirement 
> Rules: 
>[HasProduct : 
> REQUIRED] 
>   -ptbyn, --getProductTypeByNameTriggers 
> GetProductTypeByName Action
>   Requirement 
> Rules: 
>
> [GetProductTypeByName : REQUIRED] 
>   -num,   --getNumProducts  Triggers 
> GetNumProducts Action
>   Requirement 
> Rules: 
>
> [GetNumProducts : REQUIRED] 
>   -page1, --getFirstPageTriggers 
> GetFirstPage Action
>   Requirement 
> Rules: 
>[GetFirstPage 
> : REQUIRED] 
>   -next,  --getNextPage Triggers 
> GetNextPage Action
>   Requirement 
> Rules: 
>[GetNextPage : 
> REQUIRED] 
>   -prev,  --getPrevPage Triggers 
> GetPrevPage Action
>   Requirement 
> Rules: 
>[GetPrevPage : 
> REQUIRED] 
>   -last,  --getLastPage Triggers 
> GetLastPage Action
>   Requirement 
&g

Re: Review Request: CAS-CLI CmdLineAction modification to take a printer which CmdLineActions should print output messages to

2011-11-22 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2873/#review3448
---

Ship it!


+1

- Paul


On 2011-11-17 09:21:33, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2873/
> ---
> 
> (Updated 2011-11-17 09:21:33)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Summary
> ---
> 
> issue tracked here: https://issues.apache.org/jira/browse/OODT-349
> 
> 
> Diffs
> -
> 
>   trunk/CHANGES.txt 1203120 
>   trunk/cli/src/main/java/org/apache/oodt/cas/cli/CmdLineUtility.java 1203120 
>   trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/CmdLineAction.java 
> 1203120 
>   
> trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/PrintMessageAction.java
>  1203120 
>   
> trunk/cli/src/main/java/org/apache/oodt/cas/cli/presenter/CmdLinePresenter.java
>  1203120 
>   
> trunk/cli/src/main/java/org/apache/oodt/cas/cli/presenter/StdCmdLinePresenter.java
>  1203120 
>   trunk/cli/src/main/java/org/apache/oodt/cas/cli/printer/CmdLinePrinter.java 
> 1203120 
>   
> trunk/cli/src/main/java/org/apache/oodt/cas/cli/printer/StdCmdLinePrinter.java
>  1203120 
>   
> trunk/cli/src/test/org/apache/oodt/cas/cli/action/store/spring/TestSpringCmdLineActionStore.java
>  1203120 
>   
> trunk/cli/src/test/org/apache/oodt/cas/cli/option/handler/TestApplyToActionHandler.java
>  1203120 
>   
> trunk/cli/src/test/org/apache/oodt/cas/cli/option/store/spring/TestSpringCmdLineOptionStore.java
>  1203120 
>   
> trunk/cli/src/test/org/apache/oodt/cas/cli/test/util/TestSetContextInjectTypeAction.java
>  1203120 
>   trunk/cli/src/test/org/apache/oodt/cas/cli/test/util/TestUtils.java 1203120 
>   trunk/cli/src/testdata/cmd-line-options.xml 1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddNodeCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddNodeToQueueCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddQueueCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetExecNodeCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetJobInfoCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodeByIdCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodeLoadCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodesCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodesInQueueCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetQueuesCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetQueuesWithNodeCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/KillCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveNodeCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveNodeFromQueueCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveQueueCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/SetNodeCapacityCliAction.java
>  1203120 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/SubmitJobCliAction.java
>  1203120 
>   
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/DynWorkflowCliAction.java
>  1203120 
>   
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetConditionByIdCliAction.java
>  1203120 
>   
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetFirstPageCliAction.java
>  1203120 
>   
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetLastPageCliAction.java
>  1203120 
>   
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetNextPageCliAction.java
>  1203120 
>   
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetPrevPageCliAction.java
>  1203120 
>   
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetRegisteredEventsCliAction.java
>  1203120 
>   
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetTaskByIdCliAction.java
>  1203120 
>   
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetTaskWallClockTimeCliAction.java
>  1203120 
> 

Re: Review Request: CAS-Resource using CAS-CLI

2011-11-17 Thread Paul Ramirez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2839/#review3299
---

Ship it!


Looks good. In this iteration I noticed the Actions: header didn't repeat as 
often as in the other ones. Was there a change?

- Paul


On 2011-11-16 00:58:22, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2839/
> ---
> 
> (Updated 2011-11-16 00:58:22)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Summary
> ---
> 
> example outputs:
> 
> $ ./resmgr-client -h
> -
> | Short | Long | Description
> -
> 
>  -u, --url Workflow Manager 
> URL
>   Handler: 
>Sets the 
> following Java Properties: 
>
> [org.apache.oodt.cas.workflow.url] 
> 
>  -op,--operationDeclare that you 
> wish to present an operation
>SubOptions:
>> Required:
>> Optional:
>   -nbyid, --getNodeById Triggers 
> GetNodeById Action
>   Requirement 
> Rules: 
>[GetNodeById : 
> REQUIRED] 
>   -nodes, --getNodesTriggers GetNodes 
> Action
>   Requirement 
> Rules: 
>[GetNodes : 
> REQUIRED] 
>   -queues,--getQueues   Triggers 
> GetQueues Action
>   Requirement 
> Rules: 
>[GetQueues : 
> REQUIRED] 
>   -an,--addNode Triggers AddNode 
> Action
>   Requirement 
> Rules: 
>[AddNode : 
> REQUIRED] 
>   -rn,--removeNode  Triggers 
> RemoveNode Action
>   Requirement 
> Rules: 
>[RemoveNode : 
> REQUIRED] 
>   -sncap, --setNodeCapacity Triggers 
> SetNodeCapacity Action
>   Requirement 
> Rules: 
>
> [SetNodeCapacity : REQUIRED] 
>   -exeNode,--getExecNode Triggers 
> GetExecNode Action
>   Requirement 
> Rules: 
>[GetExecNode : 
> REQUIRED] 
>   -aq,--addQueueTriggers AddQueue 
> Action
>   Requirement 
> Rules: 
>[AddQueue : 
> REQUIRED] 
>   -rq,--removeQueue Triggers 
> RemoveQueue Action
>   Requirement 
> Rules: 
>[RemoveQueue : 
> REQUIRED] 
>   -antq,  --addNodeToQueue  Triggers 
> AddNodeToQueue Action
>   Requirement 
> Rules: 
>
> [AddNodeToQueue : REQUIRED] 
>   -ninq,  --getNodesInQueue Triggers 
> GetNodesInQueue Action
>   Requirement 
> Rules: 
>
> [GetNodesInQueue : REQUIRED] 
>   -qwn,   --getQueuesWithNode   Triggers 
> GetQueuesWithNode Action
>   Requirement 
> Rules: 
>
> [GetQueuesWithNode : REQUIRED] 
>   -rnfq,  --removeNodeFromQueue

[ANNOUNCE] Release of Apache OODT 0.3

2011-06-29 Thread Paul Ramirez
The Apache OODT community is proud to announce our
0.3 release.

Please visit our project website to learn more about Apache
OODT, a data grid framework for transparent discovery of
disparate science resources.

*http://oodt.apache.org/*

Thanks,
Apache OODT PPMC


[ANNOUNCE] Release of Apache OODT 0.3

2011-06-29 Thread Paul Ramirez
The Apache OODT community is proud to announce our
0.3 release.

Please visit our project website to learn more about Apache
OODT, a data grid framework for transparent discovery of
disparate science resources.

*http://oodt.apache.org/*

Thanks,
Apache OODT PPMC


[VOTE] Apache OODT 0.3 Release

2011-06-23 Thread Paul Ramirez
Hi Folks,

Apache OODT 0.3 is almost upon us. Special thanks to Andrew Hart and Chris
Mattmann as they were heavily involved in release process. For a time there
Maven release plugin didn't seem to want to let this happen.

I have posted a 1st release candidate for the Apache OODT 0.3 release. The
source code is at:

http://people.apache.org/~pramirez/apache-oodt-0.3/rc1/

For more detailed information, see the included CHANGES.txt file for details
on
release contents and latest changes. The release was made using the OODT
release process, documented on the Wiki here:

https://cwiki.apache.org/confluence/display/OODT/Release+Process

The release was made from the OODT 0.3 tag (r1139067) at:

http://svn.apache.org/repos/asf/oodt/tags/0.3/

A staged Maven repository is available at:

https://repository.apache.org/content/repositories/orgapacheoodt-044/

Please vote on releasing these packages as Apache OODT 0.3. The vote is
open for the next 72 hours.

Only votes from OODT PMC are binding, but folks are welcome to check the
release candidate and voice their approval or disapproval. The vote passes
if at least three binding +1 votes are cast.

[ ] +1 Release the packages as Apache OODT 0.3

[ ] -1 Do not release the packages because...

Thanks!

Paul Ramirez

P.S. Here is my +1.