Re: Review Request: Allow for CAS-PGE PgeMetadata to be dumped to an xml file after initialization

2012-03-19 Thread Chris Mattmann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4397/#review6071
---

Ship it!


LGTM!


trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java
https://reviews.apache.org/r/4397/#comment13050

nice note on why the warning was caused.


- Chris


On 2012-03-18 19:39:40, brian Foster wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/4397/
 ---
 
 (Updated 2012-03-18 19:39:40)
 
 
 Review request for oodt.
 
 
 Summary
 ---
 
 Will write out PgeMetadata.asMetadata() to and xml file in the execution 
 directory
 
 
 This addresses bug OODT-422.
 https://issues.apache.org/jira/browse/OODT-422
 
 
 Diffs
 -
 
   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
 1302040 
   
 trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 
 1302040 
   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1302040 
 
 Diff: https://reviews.apache.org/r/4397/diff
 
 
 Testing
 ---
 
 Added unit-tests
 
 
 Thanks,
 
 brian
 




Review Request: Allow for CAS-PGE PgeMetadata to be dumped to an xml file after initialization

2012-03-19 Thread brian Foster

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4397/
---

Review request for oodt.


Summary
---

Will write out PgeMetadata.asMetadata() to and xml file in the execution 
directory


This addresses bug OODT-422.
https://issues.apache.org/jira/browse/OODT-422


Diffs
-

  trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1302040 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 
1302040 
  trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1302040 

Diff: https://reviews.apache.org/r/4397/diff


Testing
---

Added unit-tests


Thanks,

brian