Re: Review Request: OODT-627 Review
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11810/ --- (Updated June 13, 2013, 5:45 a.m.) Review request for oodt, Chris Mattmann and Cameron Goodale. Changes --- Mike LGTM. This was a bug -- your expectation was my intended functionality. Thanks! Description --- Please see [1] for a more thorough description. I decided to change the MappingFunc calls instead of the actual implementation of ReplaceFunc since I felt that this made the most sense. The ReplaceFunc implementation seems to imply the replace 'orig' with 'with' approach so I left that alone and changed the various calls. [1] https://issues.apache.org/jira/browse/OODT-627 This addresses bug OODT-627. https://issues.apache.org/jira/browse/OODT-627 Diffs - /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java 1490420 /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/profile/DBMSExecutor.java 1490420 /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1490420 Diff: https://reviews.apache.org/r/11810/diff/ Testing --- Tested locally with the setup from [1] and changes to the example-ps.xml file from [2]. All tests pass and functionality of product handler is as expected. [1] https://cwiki.apache.org/confluence/display/OODT/XMLPS+Quick+Start+Guide [2] https://issues.apache.org/jira/browse/OODT-627 Thanks, Michael Joyce
Re: Review Request: OODT-627 Review
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11810/#review21841 --- Ship it! Ship It! - Chris Mattmann On June 11, 2013, 8:38 p.m., Michael Joyce wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11810/ --- (Updated June 11, 2013, 8:38 p.m.) Review request for oodt, Chris Mattmann and Cameron Goodale. Description --- Please see [1] for a more thorough description. I decided to change the MappingFunc calls instead of the actual implementation of ReplaceFunc since I felt that this made the most sense. The ReplaceFunc implementation seems to imply the replace 'orig' with 'with' approach so I left that alone and changed the various calls. [1] https://issues.apache.org/jira/browse/OODT-627 Diffs - /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java 1490420 /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/profile/DBMSExecutor.java 1490420 /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1490420 Diff: https://reviews.apache.org/r/11810/diff/ Testing --- Tested locally with the setup from [1] and changes to the example-ps.xml file from [2]. All tests pass and functionality of product handler is as expected. [1] https://cwiki.apache.org/confluence/display/OODT/XMLPS+Quick+Start+Guide [2] https://issues.apache.org/jira/browse/OODT-627 Thanks, Michael Joyce
Review Request: OODT-627 Review
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11810/ --- Review request for oodt, Chris Mattmann and Cameron Goodale. Description --- Please see [1] for a more thorough description. I decided to change the MappingFunc calls instead of the actual implementation of ReplaceFunc since I felt that this made the most sense. The ReplaceFunc implementation seems to imply the replace 'orig' with 'with' approach so I left that alone and changed the various calls. [1] https://issues.apache.org/jira/browse/OODT-627 Diffs - /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java 1490420 /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/profile/DBMSExecutor.java 1490420 /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1490420 Diff: https://reviews.apache.org/r/11810/diff/ Testing --- Tested locally with the setup from [1] and changes to the example-ps.xml file from [2]. All tests pass and functionality of product handler is as expected. [1] https://cwiki.apache.org/confluence/display/OODT/XMLPS+Quick+Start+Guide [2] https://issues.apache.org/jira/browse/OODT-627 Thanks, Michael Joyce
