Re: Review Request 28916: Resource Manager To Mesos Cluster Manager Integration

[Chris Mattmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28916/#review65727
---

Ship it!


Ship It!

- Chris Mattmann


On Dec. 18, 2014, 3:43 p.m., Michael Starch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28916/
> ---
> 
> (Updated Dec. 18, 2014, 3:43 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Repository: oodt
> 
> 
> Description
> ---
> 
> This patch integrates the mesos cluster manager and OODT resource manager.  
> It allows resource manager jobs to run on a mesos-controlled cluster. Is a 
> solution to: https://issues.apache.org/jira/browse/OODT-699 and includes: 
> https://reviews.apache.org/r/27773/
> 
> 
> Diffs
> -
> 
>   trunk/resource/pom.xml 1646471 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManager.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManagerFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/ResourceExecutor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitorFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosScheduler.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosSchedulerFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/JobSpecSerializer.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/exceptions/MesosFrameworkException.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/util/MesosUtilities.java
>  PRE-CREATION 
>   
> trunk/resource/src/test/org/apache/oodt/cas/resource/util/TestMesosUtilities.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28916/diff/
> 
> 
> Testing
> ---
> 
> Basic unit testing.
> 
> Integration/prototye testing has also been done. It starts and runs.
> 
> 
> Thanks,
> 
> Michael Starch
> 
>

Re: Review Request 28916: Resource Manager To Mesos Cluster Manager Integration

[Michael Starch]

> On Dec. 11, 2014, 1:37 a.m., Chris Mattmann wrote:
> >
> 
> Michael Starch wrote:
> Same thing with Spark, I put the mesos stuff in its own package to keep 
> it seperate. I can easily sort the components into the other packages, if 
> needed.
> 
> Chris Mattmann wrote:
> yep please do so thanks Mike

It is done.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28916/#review64660
---


On Dec. 18, 2014, 3:43 p.m., Michael Starch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28916/
> ---
> 
> (Updated Dec. 18, 2014, 3:43 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Repository: oodt
> 
> 
> Description
> ---
> 
> This patch integrates the mesos cluster manager and OODT resource manager.  
> It allows resource manager jobs to run on a mesos-controlled cluster. Is a 
> solution to: https://issues.apache.org/jira/browse/OODT-699 and includes: 
> https://reviews.apache.org/r/27773/
> 
> 
> Diffs
> -
> 
>   trunk/resource/pom.xml 1646471 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManager.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManagerFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/ResourceExecutor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitorFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosScheduler.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosSchedulerFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/JobSpecSerializer.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/exceptions/MesosFrameworkException.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/util/MesosUtilities.java
>  PRE-CREATION 
>   
> trunk/resource/src/test/org/apache/oodt/cas/resource/util/TestMesosUtilities.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28916/diff/
> 
> 
> Testing
> ---
> 
> Basic unit testing.
> 
> Integration/prototye testing has also been done. It starts and runs.
> 
> 
> Thanks,
> 
> Michael Starch
> 
>

Re: Review Request 28916: Resource Manager To Mesos Cluster Manager Integration

[Chris Mattmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28916/#review65728
---


Great work Mike!

- Chris Mattmann


On Dec. 18, 2014, 3:43 p.m., Michael Starch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28916/
> ---
> 
> (Updated Dec. 18, 2014, 3:43 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Repository: oodt
> 
> 
> Description
> ---
> 
> This patch integrates the mesos cluster manager and OODT resource manager.  
> It allows resource manager jobs to run on a mesos-controlled cluster. Is a 
> solution to: https://issues.apache.org/jira/browse/OODT-699 and includes: 
> https://reviews.apache.org/r/27773/
> 
> 
> Diffs
> -
> 
>   trunk/resource/pom.xml 1646471 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManager.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManagerFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/ResourceExecutor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitorFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosScheduler.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosSchedulerFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/JobSpecSerializer.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/exceptions/MesosFrameworkException.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/util/MesosUtilities.java
>  PRE-CREATION 
>   
> trunk/resource/src/test/org/apache/oodt/cas/resource/util/TestMesosUtilities.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28916/diff/
> 
> 
> Testing
> ---
> 
> Basic unit testing.
> 
> Integration/prototye testing has also been done. It starts and runs.
> 
> 
> Thanks,
> 
> Michael Starch
> 
>

Re: Review Request 28916: Resource Manager To Mesos Cluster Manager Integration

[Chris Mattmann]

> On Dec. 11, 2014, 1:37 a.m., Chris Mattmann wrote:
> >
> 
> Michael Starch wrote:
> Same thing with Spark, I put the mesos stuff in its own package to keep 
> it seperate. I can easily sort the components into the other packages, if 
> needed.

yep please do so thanks Mike


- Chris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28916/#review64660
---


On Dec. 18, 2014, 3:43 p.m., Michael Starch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28916/
> ---
> 
> (Updated Dec. 18, 2014, 3:43 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Repository: oodt
> 
> 
> Description
> ---
> 
> This patch integrates the mesos cluster manager and OODT resource manager.  
> It allows resource manager jobs to run on a mesos-controlled cluster. Is a 
> solution to: https://issues.apache.org/jira/browse/OODT-699 and includes: 
> https://reviews.apache.org/r/27773/
> 
> 
> Diffs
> -
> 
>   trunk/resource/pom.xml 1646471 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManager.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManagerFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/ResourceExecutor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitorFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosScheduler.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosSchedulerFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/JobSpecSerializer.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/exceptions/MesosFrameworkException.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/util/MesosUtilities.java
>  PRE-CREATION 
>   
> trunk/resource/src/test/org/apache/oodt/cas/resource/util/TestMesosUtilities.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28916/diff/
> 
> 
> Testing
> ---
> 
> Basic unit testing.
> 
> Integration/prototye testing has also been done. It starts and runs.
> 
> 
> Thanks,
> 
> Michael Starch
> 
>

Re: Review Request 28916: Resource Manager To Mesos Cluster Manager Integration

[Michael Starch]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28916/
---

(Updated Dec. 18, 2014, 3:43 p.m.)


Review request for oodt and Chris Mattmann.


Changes
---

Updating the diff to sort components.


Repository: oodt


Description
---

This patch integrates the mesos cluster manager and OODT resource manager.  It 
allows resource manager jobs to run on a mesos-controlled cluster. Is a 
solution to: https://issues.apache.org/jira/browse/OODT-699 and includes: 
https://reviews.apache.org/r/27773/


Diffs (updated)
-

  trunk/resource/pom.xml 1646471 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManager.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManagerFactory.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/ResourceExecutor.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitor.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitorFactory.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosScheduler.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosSchedulerFactory.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/JobSpecSerializer.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/exceptions/MesosFrameworkException.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/util/MesosUtilities.java
 PRE-CREATION 
  
trunk/resource/src/test/org/apache/oodt/cas/resource/util/TestMesosUtilities.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/28916/diff/


Testing
---

Basic unit testing.

Integration/prototye testing has also been done. It starts and runs.


Thanks,

Michael Starch

Re: Review Request 28916: Resource Manager To Mesos Cluster Manager Integration

[Michael Starch]

> On Dec. 11, 2014, 1:37 a.m., Chris Mattmann wrote:
> >

Same thing with Spark, I put the mesos stuff in its own package to keep it 
seperate. I can easily sort the components into the other packages, if needed.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28916/#review64660
---


On Dec. 18, 2014, 3:43 p.m., Michael Starch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28916/
> ---
> 
> (Updated Dec. 18, 2014, 3:43 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Repository: oodt
> 
> 
> Description
> ---
> 
> This patch integrates the mesos cluster manager and OODT resource manager.  
> It allows resource manager jobs to run on a mesos-controlled cluster. Is a 
> solution to: https://issues.apache.org/jira/browse/OODT-699 and includes: 
> https://reviews.apache.org/r/27773/
> 
> 
> Diffs
> -
> 
>   trunk/resource/pom.xml 1646471 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManager.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/MesosBatchManagerFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/ResourceExecutor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/MesosMonitorFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosScheduler.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/scheduler/ResourceMesosSchedulerFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/JobSpecSerializer.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/structs/exceptions/MesosFrameworkException.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/util/MesosUtilities.java
>  PRE-CREATION 
>   
> trunk/resource/src/test/org/apache/oodt/cas/resource/util/TestMesosUtilities.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28916/diff/
> 
> 
> Testing
> ---
> 
> Basic unit testing.
> 
> Integration/prototye testing has also been done. It starts and runs.
> 
> 
> Thanks,
> 
> Michael Starch
> 
>

Re: Review Request 28916: Resource Manager To Mesos Cluster Manager Integration

[Chris Mattmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28916/#review64660
---



trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/JobSpecSerializer.java


this should be in the org.apache.oodt.cas.resource.structs package



trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosBatchManager.java


=>org.apache.oodt.cas.resource.batchmgr



trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosBatchManagerFactory.java


=>org.apache.oodt.cas.resource.batchmgr



trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosMonitorFactory.java


move to monitor package



trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosUtilities.java


move to o.a.oodt.cas.resource.util pkg



trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/ResourceExecutor.java


move to batchmgr pkg?



trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/ResourceMesosFrameworkFactory.java


move to o.a.oodt.cas.resource.system pkg?



trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/ResourceMesosScheduler.java


schedule package;
also comments here , but no license?



trunk/resource/src/test/org/apache/oodt/cas/resource/mesos/TestMesosUtilities.java


test.util..


- Chris Mattmann


On Dec. 10, 2014, 9:34 p.m., Michael Starch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28916/
> ---
> 
> (Updated Dec. 10, 2014, 9:34 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Repository: oodt
> 
> 
> Description
> ---
> 
> This patch integrates the mesos cluster manager and OODT resource manager.  
> It allows resource manager jobs to run on a mesos-controlled cluster. Is a 
> solution to: https://issues.apache.org/jira/browse/OODT-699 and includes: 
> https://reviews.apache.org/r/27773/
> 
> 
> Diffs
> -
> 
>   trunk/resource/pom.xml 1644494 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/JobSpecSerializer.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosBatchManager.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosBatchManagerFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosMonitor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosMonitorFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosUtilities.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/ResourceExecutor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/ResourceMesosFrameworkFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/ResourceMesosScheduler.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/exception/MesosFrameworkException.java
>  PRE-CREATION 
>   
> trunk/resource/src/test/org/apache/oodt/cas/resource/mesos/TestMesosUtilities.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28916/diff/
> 
> 
> Testing
> ---
> 
> Basic unit testing.
> 
> Integration/prototye testing has also been done. It starts and runs.
> 
> 
> Thanks,
> 
> Michael Starch
> 
>

Review Request 28916: Resource Manager To Mesos Cluster Manager Integration

[Michael Starch]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28916/
---

Review request for oodt and Chris Mattmann.


Repository: oodt


Description
---

This patch integrates the mesos cluster manager and OODT resource manager.  It 
allows resource manager jobs to run on a mesos-controlled cluster. Is a 
solution to: https://issues.apache.org/jira/browse/OODT-699 and includes: 
https://reviews.apache.org/r/27773/


Diffs
-

  trunk/resource/pom.xml 1644494 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/JobSpecSerializer.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosBatchManager.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosBatchManagerFactory.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosMonitor.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosMonitorFactory.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/MesosUtilities.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/ResourceExecutor.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/ResourceMesosFrameworkFactory.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/ResourceMesosScheduler.java
 PRE-CREATION 
  
trunk/resource/src/main/java/org/apache/oodt/cas/resource/mesos/exception/MesosFrameworkException.java
 PRE-CREATION 
  
trunk/resource/src/test/org/apache/oodt/cas/resource/mesos/TestMesosUtilities.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/28916/diff/


Testing
---

Basic unit testing.

Integration/prototye testing has also been done. It starts and runs.


Thanks,

Michael Starch