[jira] [Created] (OOZIE-1626) pig action pop-up is not working properly in UI
Ryota Egashira created OOZIE-1626: - Summary: pig action pop-up is not working properly in UI Key: OOZIE-1626 URL: https://issues.apache.org/jira/browse/OOZIE-1626 Project: Oozie Issue Type: Bug Affects Versions: 4.0.0, trunk Reporter: Ryota Egashira Assignee: Ryota Egashira pop-up doesn't show up when pig job failed and externalChildIDs is null (as string) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OOZIE-1623) JPAService doesn't need to do reads in a transaction
[
https://issues.apache.org/jira/browse/OOZIE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831659#comment-13831659
]
Rohini Palaniswamy commented on OOZIE-1623:
---
This was one of the reasons we separated out update and get calls. Thanks for
creating this one Robert. I thought Ryota already had a jira for this. This was
one of the TODO items which I had lost track of getting done.
JPAService doesn't need to do reads in a transaction
Key: OOZIE-1623
URL: https://issues.apache.org/jira/browse/OOZIE-1623
Project: Oozie
Issue Type: Bug
Affects Versions: trunk
Reporter: Robert Kanter
Assignee: Robert Kanter
{{JPAService#executeGet}} and {{JPAService#executeGetList}} are both doing
{{SELECT}} queries (so only reading), which means that they shouldn't need to
be in a transaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Re: Review Request 15660: [OOZIE-1615] shell action cannot find script file and fails in uber mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15660/ --- (Updated Nov. 25, 2013, 6:29 p.m.) Review request for oozie. Changes --- root cause is yarn.app.mapreduce.am.env does not include PATH=./$PATH. shellAction set mapred.child.env=PATH./$PATH, but in uber mode, it was not properly copied to yarn.app.mapreduce.am.env Bugs: OOZIE-1615 https://issues.apache.org/jira/browse/OOZIE-1615 Repository: oozie Description --- https://issues.apache.org/jira/browse/OOZIE-1615 reason is, PATH doesn't include current directory in Uberized launcher. currently shell action simply execute exec file name like script.sh, hitting 'No such file or directory' solution is to use absolute path of exec file Diffs (updated) - trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1545347 trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1545347 Diff: https://reviews.apache.org/r/15660/diff/ Testing --- tested sample workflows (including shell action) with uber on/off using Hadoop hadoop-2.2.1 cluster, made sure both work. Thanks, Ryota Egashira
Re: Review Request 15660: [OOZIE-1615] shell action cannot find script file and fails in uber mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15660/ --- (Updated Nov. 25, 2013, 6:32 p.m.) Review request for oozie. Bugs: OOZIE-1615 https://issues.apache.org/jira/browse/OOZIE-1615 Repository: oozie Description (updated) --- https://issues.apache.org/jira/browse/OOZIE-1615 reason is, PATH doesn't include current directory in Uberized launcher. root cause is yarn.app.mapreduce.am.env does not include PATH=.:$PATH shellAction set mapred.child.env PATH=.:$PATH, but in uber mode, it was not properly copied to yarn.app.mapreduce.am.env Diffs - trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1545347 trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1545347 Diff: https://reviews.apache.org/r/15660/diff/ Testing --- tested sample workflows (including shell action) with uber on/off using Hadoop hadoop-2.2.1 cluster, made sure both work. Thanks, Ryota Egashira
[jira] [Commented] (OOZIE-1612) When printing Dates to log messages, we should make sure they are in oozie.processing.timezone
[
https://issues.apache.org/jira/browse/OOZIE-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831767#comment-13831767
]
Robert Kanter commented on OOZIE-1612:
--
There are, unfortunately, some flaky tests; this doesn't look related, so I
don't think we need to worry about it for this JIRA.
I think this is the right way to fix the date messages; especially considering
there ended up only being 5 messages that had dates in them. We'll just have
to be on the look-out for new patches to make sure they print their dates in
the proper timezone.
Patch looks good: +1
When printing Dates to log messages, we should make sure they are in
oozie.processing.timezone
--
Key: OOZIE-1612
URL: https://issues.apache.org/jira/browse/OOZIE-1612
Project: Oozie
Issue Type: Improvement
Affects Versions: trunk
Reporter: Robert Kanter
Priority: Minor
Labels: newbie
Attachments: OOZIE-1612.1.patch, OOZIE-1612.3.patch,
OOZIE-1612.patch, oozie-1612.2.patch
We were recently looking into an issue and noticed that the same log message
had printed different date objects with different timezones, which makes it
hard to compare the two. Which leads to the bigger picture, which is that we
should be printing any Date objects in log messages with the
{{oozie.processing.timezone}} timezone (there's a method for that in
{{DateUtils}}).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Re: Review Request 15276: [OOZIE-1605] Add common custom filter applied to Wf/Coord/Bundle jobs on oozie UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15276/#review29382 --- Ship it! Ship It! - Mona Chitnis On Nov. 22, 2013, 11:27 p.m., Ryota Egashira wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15276/ --- (Updated Nov. 22, 2013, 11:27 p.m.) Review request for oozie. Bugs: OOZIE-1605 https://issues.apache.org/jira/browse/OOZIE-1605 Repository: oozie Description --- https://issues.apache.org/jira/browse/OOZIE-1605 Diffs - trunk/webapp/src/main/webapp/oozie-console.js 1538031 Diff: https://reviews.apache.org/r/15276/diff/ Testing --- locally tested Thanks, Ryota Egashira
Re: Review Request 15660: [OOZIE-1615] shell action cannot find script file and fails in uber mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15660/#review29383 --- Ship it! Ship It! - Rohini Palaniswamy On Nov. 25, 2013, 6:32 p.m., Ryota Egashira wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15660/ --- (Updated Nov. 25, 2013, 6:32 p.m.) Review request for oozie. Bugs: OOZIE-1615 https://issues.apache.org/jira/browse/OOZIE-1615 Repository: oozie Description --- https://issues.apache.org/jira/browse/OOZIE-1615 reason is, PATH doesn't include current directory in Uberized launcher. root cause is yarn.app.mapreduce.am.env does not include PATH=.:$PATH shellAction set mapred.child.env PATH=.:$PATH, but in uber mode, it was not properly copied to yarn.app.mapreduce.am.env Diffs - trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1545347 trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1545347 Diff: https://reviews.apache.org/r/15660/diff/ Testing --- tested sample workflows (including shell action) with uber on/off using Hadoop hadoop-2.2.1 cluster, made sure both work. Thanks, Ryota Egashira
[jira] [Updated] (OOZIE-1605) Add common custom filter applied to Wf/Coord/Bundle jobs on oozie UI
[ https://issues.apache.org/jira/browse/OOZIE-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryota Egashira updated OOZIE-1605: -- Attachment: OOZIE-1605-v3.patch Add common custom filter applied to Wf/Coord/Bundle jobs on oozie UI Key: OOZIE-1605 URL: https://issues.apache.org/jira/browse/OOZIE-1605 Project: Oozie Issue Type: Bug Affects Versions: trunk Reporter: Ryota Egashira Assignee: Ryota Egashira Fix For: trunk Attachments: OOZIE-1605-v3.patch 1. add common custom filter which applied to all types of jobs (wf/coord/bundle), especially user name, since customer only want to see his/her jobs but not others. store it into cookie not to lose it after browser refresh. 2. make current custom filter to be stored in cookie, as well. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OOZIE-1581) Workflow performance optimizations
[ https://issues.apache.org/jira/browse/OOZIE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mona Chitnis updated OOZIE-1581: Attachment: OOZIE-1581-final.patch final patch uploaded after +1 on RB Workflow performance optimizations -- Key: OOZIE-1581 URL: https://issues.apache.org/jira/browse/OOZIE-1581 Project: Oozie Issue Type: Improvement Components: workflow Affects Versions: trunk Reporter: Mona Chitnis Assignee: Mona Chitnis Fix For: trunk Attachments: OOZIE-1581-2.patch, OOZIE-1581-final.patch, OOZIE-1581.patch Creating a combo JIRA for small performance optimizations. 1. changing from asynchronous action start to a synchronous one, to overcome the undue delay in transitioning from ::start:: control node to the actual first node, owing to a loaded queue. This delay has been observed to be close to 30 min at times in stress conditions. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (OOZIE-1627) Rerun doesn't resolve workflow app name
purshotam shah created OOZIE-1627: - Summary: Rerun doesn't resolve workflow app name Key: OOZIE-1627 URL: https://issues.apache.org/jira/browse/OOZIE-1627 Project: Oozie Issue Type: Bug Reporter: purshotam shah -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OOZIE-1615) shell action cannot find script file and fails in uber mode
[
https://issues.apache.org/jira/browse/OOZIE-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryota Egashira updated OOZIE-1615:
--
Attachment: OOZIE-1615-v2.patch
shell action cannot find script file and fails in uber mode
---
Key: OOZIE-1615
URL: https://issues.apache.org/jira/browse/OOZIE-1615
Project: Oozie
Issue Type: Bug
Affects Versions: trunk
Reporter: Ryota Egashira
Assignee: Ryota Egashira
Attachments: OOZIE-1615-v2.patch, OOZIE-1615.patch
even when symlink to script file exists on current working directory, shell
action fails due to following error.
{noformat}
Cannot run program script.sh (in directory
/grid/0/tmp/yarn-local/usercache/hadoopqa/appcache/application_1383065695012_12853/container_1383065695012_12853_01_01):
error=2, No such file or directory
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Assigned] (OOZIE-1627) Rerun doesn't resolve workflow app name
[ https://issues.apache.org/jira/browse/OOZIE-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] purshotam shah reassigned OOZIE-1627: - Assignee: purshotam shah Rerun doesn't resolve workflow app name --- Key: OOZIE-1627 URL: https://issues.apache.org/jira/browse/OOZIE-1627 Project: Oozie Issue Type: Bug Reporter: purshotam shah Assignee: purshotam shah -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OOZIE-1605) Add common custom filter applied to Wf/Coord/Bundle jobs on oozie UI
[
https://issues.apache.org/jira/browse/OOZIE-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831942#comment-13831942
]
Hadoop QA commented on OOZIE-1605:
--
Testing JIRA OOZIE-1605
Cleaning local svn workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1368
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/905/
Add common custom filter applied to Wf/Coord/Bundle jobs on oozie UI
Key: OOZIE-1605
URL: https://issues.apache.org/jira/browse/OOZIE-1605
Project: Oozie
Issue Type: Bug
Affects Versions: trunk
Reporter: Ryota Egashira
Assignee: Ryota Egashira
Fix For: trunk
Attachments: OOZIE-1605-v3.patch
1. add common custom filter which applied to all types of jobs
(wf/coord/bundle), especially user name, since customer only want to see
his/her jobs but not others. store it into cookie not to lose it after
browser refresh.
2. make current custom filter to be stored in cookie, as well.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Review Request 15848: [OOZIE-1627]Rerun doesn't resolve workflow app name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15848/ --- Review request for oozie. Bugs: OOZIE-1627 https://issues.apache.org/jira/browse/OOZIE-1627 Repository: oozie Description --- Rerun doesn't resolve workflow app name Diffs - http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1545406 http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1545406 http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/rerun-el-wf.xml 1545406 Diff: https://reviews.apache.org/r/15848/diff/ Testing --- Thanks, Purshotam Shah
Re: Review Request 15848: [OOZIE-1627]Rerun doesn't resolve workflow app name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15848/#review29397 --- Ship it! Ship It! - Rohini Palaniswamy On Nov. 25, 2013, 9:51 p.m., Purshotam Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15848/ --- (Updated Nov. 25, 2013, 9:51 p.m.) Review request for oozie. Bugs: OOZIE-1627 https://issues.apache.org/jira/browse/OOZIE-1627 Repository: oozie Description --- Rerun doesn't resolve workflow app name Diffs - http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1545406 http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1545406 http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/rerun-el-wf.xml 1545406 Diff: https://reviews.apache.org/r/15848/diff/ Testing --- Thanks, Purshotam Shah
[jira] [Updated] (OOZIE-1627) Rerun doesn't resolve workflow app name
[ https://issues.apache.org/jira/browse/OOZIE-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] purshotam shah updated OOZIE-1627: -- Attachment: OOZIE-1627-v1.patch Patch Rerun doesn't resolve workflow app name --- Key: OOZIE-1627 URL: https://issues.apache.org/jira/browse/OOZIE-1627 Project: Oozie Issue Type: Bug Reporter: purshotam shah Assignee: purshotam shah Attachments: OOZIE-1627-v1.patch -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OOZIE-1605) Add common custom filter applied to Wf/Coord/Bundle jobs on oozie UI
[ https://issues.apache.org/jira/browse/OOZIE-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryota Egashira updated OOZIE-1605: -- Attachment: Global_Filter_ScreenShot.png OOZIE-1605-v4.patch changed wording Text -Filter Text this is UI (oozie-console.js) hence no test case. ready to commit. also attached the screen shot of global filter Add common custom filter applied to Wf/Coord/Bundle jobs on oozie UI Key: OOZIE-1605 URL: https://issues.apache.org/jira/browse/OOZIE-1605 Project: Oozie Issue Type: Bug Affects Versions: trunk Reporter: Ryota Egashira Assignee: Ryota Egashira Fix For: trunk Attachments: Global_Filter_ScreenShot.png, OOZIE-1605-v3.patch, OOZIE-1605-v4.patch 1. add common custom filter which applied to all types of jobs (wf/coord/bundle), especially user name, since customer only want to see his/her jobs but not others. store it into cookie not to lose it after browser refresh. 2. make current custom filter to be stored in cookie, as well. -- This message was sent by Atlassian JIRA (v6.1#6144)
Re: Review Request 15848: [OOZIE-1627]Rerun doesn't resolve workflow app name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15848/ --- (Updated Nov. 25, 2013, 10:06 p.m.) Review request for oozie. Changes --- review comment. Bugs: OOZIE-1627 https://issues.apache.org/jira/browse/OOZIE-1627 Repository: oozie Description --- Rerun doesn't resolve workflow app name Diffs (updated) - http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1545406 http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1545406 http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/rerun-el-wf.xml 1545406 Diff: https://reviews.apache.org/r/15848/diff/ Testing --- Thanks, Purshotam Shah
[jira] [Updated] (OOZIE-1626) pig action pop-up is not working properly in UI
[ https://issues.apache.org/jira/browse/OOZIE-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryota Egashira updated OOZIE-1626: -- Attachment: OOZIE-1626.patch pig action pop-up is not working properly in UI --- Key: OOZIE-1626 URL: https://issues.apache.org/jira/browse/OOZIE-1626 Project: Oozie Issue Type: Bug Affects Versions: trunk, 4.0.0 Reporter: Ryota Egashira Assignee: Ryota Egashira Attachments: OOZIE-1626.patch pop-up doesn't show up when pig job failed and externalChildIDs is null (as string) -- This message was sent by Atlassian JIRA (v6.1#6144)
Re: Review Request 15848: [OOZIE-1627]Rerun doesn't resolve workflow app name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15848/#review29399 --- Ship it! +1 - Virag Kothari On Nov. 25, 2013, 10:06 p.m., Purshotam Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15848/ --- (Updated Nov. 25, 2013, 10:06 p.m.) Review request for oozie. Bugs: OOZIE-1627 https://issues.apache.org/jira/browse/OOZIE-1627 Repository: oozie Description --- Rerun doesn't resolve workflow app name Diffs - http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1545406 http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1545406 http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/rerun-el-wf.xml 1545406 Diff: https://reviews.apache.org/r/15848/diff/ Testing --- Thanks, Purshotam Shah
Re: Review Request 14239: OOZIE-1504 parameterize coord EL functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14239/#review29376 --- http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56621 formatting http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56595 Can you rename this as parseOneStringArg http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56620 formatting http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56573 This condition and else block needs to be fixed. Check is wrong. formatting. http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56574 You are going to throw exception even if they are same http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56575 Move function to DateUtils and rename the function to validateDateOozieTZ http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56619 formatting http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java https://reviews.apache.org/r/14239/#comment56601 You need to handle timezone http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56605 Have one positive test in TestCoordActionInputCheckxcommand to test more e2e flow. Rename test methods and test files. These are tests for EL functions and not parameterizing. Please add some comments to the tests. It is difficult to understand what the test is doing without thorough reading of code. http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56622 Extract common test code to one method http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56602 Remove the try catch block in all test methods. Redundant. http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56618 Do in one assertEquals. Same for other methods http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java https://reviews.apache.org/r/14239/#comment56604 why is this changed? http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java https://reviews.apache.org/r/14239/#comment56608 formatting. This should throw an exception and not return http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java https://reviews.apache.org/r/14239/#comment56609 Too many new lines. Group expr and corresponding assertEquals without new lines in between them http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java https://reviews.apache.org/r/14239/#comment56607 Remove try catch block http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/cord-action-for-parameterization-2.xml https://reviews.apache.org/r/14239/#comment56623 Combine this all into previous test case with multiple data-in http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/cord-action-for-parameterization-3.xml https://reviews.apache.org/r/14239/#comment56611 Combine this all into one test case with multiple data-in http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/cord-action-for-parameterization.xml https://reviews.apache.org/r/14239/#comment56610 Why is this required as a test? http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki https://reviews.apache.org/r/14239/#comment56613 Not materialization time. It is a dataset instance. http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
[jira] [Updated] (OOZIE-1627) Rerun doesn't resolve workflow app name
[ https://issues.apache.org/jira/browse/OOZIE-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] purshotam shah updated OOZIE-1627: -- Attachment: OOZIE-1627-v2.patch Patch v2 Rerun doesn't resolve workflow app name --- Key: OOZIE-1627 URL: https://issues.apache.org/jira/browse/OOZIE-1627 Project: Oozie Issue Type: Bug Reporter: purshotam shah Assignee: purshotam shah Attachments: OOZIE-1627-v1.patch, OOZIE-1627-v2.patch -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OOZIE-1575) Add functionality to summit sqoop jobs through http on oozie server side
[ https://issues.apache.org/jira/browse/OOZIE-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alejandro Abdelnur updated OOZIE-1575: -- Summary: Add functionality to summit sqoop jobs through http on oozie server side (was: Add functionality to sumbit sqoop job through http on oozie server side) Add functionality to summit sqoop jobs through http on oozie server side Key: OOZIE-1575 URL: https://issues.apache.org/jira/browse/OOZIE-1575 Project: Oozie Issue Type: Sub-task Components: client Reporter: Bowen Zhang Assignee: Bowen Zhang Fix For: trunk Attachments: oozie-1575.patch, oozie-1575.patch, oozie-1575.patch -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OOZIE-1575) Add functionality to submit sqoop jobs through http on oozie server side
[ https://issues.apache.org/jira/browse/OOZIE-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alejandro Abdelnur updated OOZIE-1575: -- Summary: Add functionality to submit sqoop jobs through http on oozie server side (was: Add functionality to summit sqoop jobs through http on oozie server side) Add functionality to submit sqoop jobs through http on oozie server side Key: OOZIE-1575 URL: https://issues.apache.org/jira/browse/OOZIE-1575 Project: Oozie Issue Type: Sub-task Components: client Reporter: Bowen Zhang Assignee: Bowen Zhang Fix For: trunk Attachments: oozie-1575.patch, oozie-1575.patch, oozie-1575.patch -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OOZIE-1575) Add functionality to submit sqoop jobs through http on oozie server side
[
https://issues.apache.org/jira/browse/OOZIE-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832035#comment-13832035
]
Robert Kanter commented on OOZIE-1575:
--
[~bowenzhangusa], I talked to Alejandro, and he suggested that as long as the
Oozie CLI script is passing the args with {{$@}}, then we should be able to
just do something like:
{noformat}
oozie sqoop -config job.properties -command import --connect whatever --query
something with a space in it -m 1
{noformat}
OozieCLI Java code would receive the arguments in the double quotes as a single
String. And you shouldn't need any fancy custom parsing; just grab everything
after {{-command}} (so the order would matter slightly, but that's ok because
we do that with the other commands and the {{-X}} arg as I mentioned before).
Would this not work?
Add functionality to submit sqoop jobs through http on oozie server side
Key: OOZIE-1575
URL: https://issues.apache.org/jira/browse/OOZIE-1575
Project: Oozie
Issue Type: Sub-task
Components: client
Reporter: Bowen Zhang
Assignee: Bowen Zhang
Fix For: trunk
Attachments: oozie-1575.patch, oozie-1575.patch, oozie-1575.patch
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (OOZIE-1623) JPAService doesn't need to do reads in a transaction
[
https://issues.apache.org/jira/browse/OOZIE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Kanter updated OOZIE-1623:
-
Attachment: OOZIE-1623.patch
No new/modified tests, but I don't think we really need any for this.
JPAService doesn't need to do reads in a transaction
Key: OOZIE-1623
URL: https://issues.apache.org/jira/browse/OOZIE-1623
Project: Oozie
Issue Type: Bug
Affects Versions: trunk
Reporter: Robert Kanter
Assignee: Robert Kanter
Attachments: OOZIE-1623.patch
{{JPAService#executeGet}} and {{JPAService#executeGetList}} are both doing
{{SELECT}} queries (so only reading), which means that they shouldn't need to
be in a transaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OOZIE-1581) Workflow performance optimizations
[ https://issues.apache.org/jira/browse/OOZIE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832076#comment-13832076 ] Mona Chitnis commented on OOZIE-1581: - failing test is flaky - java.lang.NullPointerException at org.apache.oozie.event.TestEventGeneration.testCoordinatorActionEvent(TestEventGeneration.java:326) will fix while committing. Workflow performance optimizations -- Key: OOZIE-1581 URL: https://issues.apache.org/jira/browse/OOZIE-1581 Project: Oozie Issue Type: Improvement Components: workflow Affects Versions: trunk Reporter: Mona Chitnis Assignee: Mona Chitnis Fix For: trunk Attachments: OOZIE-1581-2.patch, OOZIE-1581-final.patch, OOZIE-1581.patch Creating a combo JIRA for small performance optimizations. 1. changing from asynchronous action start to a synchronous one, to overcome the undue delay in transitioning from ::start:: control node to the actual first node, owing to a loaded queue. This delay has been observed to be close to 30 min at times in stress conditions. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OOZIE-1623) JPAService doesn't need to do reads in a transaction
[
https://issues.apache.org/jira/browse/OOZIE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832077#comment-13832077
]
Rohini Palaniswamy commented on OOZIE-1623:
---
+1
JPAService doesn't need to do reads in a transaction
Key: OOZIE-1623
URL: https://issues.apache.org/jira/browse/OOZIE-1623
Project: Oozie
Issue Type: Bug
Affects Versions: trunk
Reporter: Robert Kanter
Assignee: Robert Kanter
Attachments: OOZIE-1623.patch
{{JPAService#executeGet}} and {{JPAService#executeGetList}} are both doing
{{SELECT}} queries (so only reading), which means that they shouldn't need to
be in a transaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OOZIE-1623) JPAService doesn't need to do reads in a transaction
[
https://issues.apache.org/jira/browse/OOZIE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832086#comment-13832086
]
Rohini Palaniswamy commented on OOZIE-1623:
---
The processFinally would still keep checking for
em.getTransaction().isActive(). Can we get rid of that as well for get calls ?
JPAService doesn't need to do reads in a transaction
Key: OOZIE-1623
URL: https://issues.apache.org/jira/browse/OOZIE-1623
Project: Oozie
Issue Type: Bug
Affects Versions: trunk
Reporter: Robert Kanter
Assignee: Robert Kanter
Attachments: OOZIE-1623.patch
{{JPAService#executeGet}} and {{JPAService#executeGetList}} are both doing
{{SELECT}} queries (so only reading), which means that they shouldn't need to
be in a transaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OOZIE-1626) pig action pop-up is not working properly in UI
[ https://issues.apache.org/jira/browse/OOZIE-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832092#comment-13832092 ] Rohini Palaniswamy commented on OOZIE-1626: --- +1. one line UI change. I think you can go ahead and commit instead of waiting for precommit build. pig action pop-up is not working properly in UI --- Key: OOZIE-1626 URL: https://issues.apache.org/jira/browse/OOZIE-1626 Project: Oozie Issue Type: Bug Affects Versions: trunk, 4.0.0 Reporter: Ryota Egashira Assignee: Ryota Egashira Attachments: OOZIE-1626.patch pop-up doesn't show up when pig job failed and externalChildIDs is null (as string) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OOZIE-1623) JPAService doesn't need to do reads in a transaction
[
https://issues.apache.org/jira/browse/OOZIE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Kanter updated OOZIE-1623:
-
Attachment: OOZIE-1623.patch
Sure; new patch only checks if the transaction isActive if necessary.
JPAService doesn't need to do reads in a transaction
Key: OOZIE-1623
URL: https://issues.apache.org/jira/browse/OOZIE-1623
Project: Oozie
Issue Type: Bug
Affects Versions: trunk
Reporter: Robert Kanter
Assignee: Robert Kanter
Attachments: OOZIE-1623.patch, OOZIE-1623.patch
{{JPAService#executeGet}} and {{JPAService#executeGetList}} are both doing
{{SELECT}} queries (so only reading), which means that they shouldn't need to
be in a transaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OOZIE-1468) Add created time column in WF_ACTIONS and SLA tables
[
https://issues.apache.org/jira/browse/OOZIE-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832136#comment-13832136
]
Robert Kanter commented on OOZIE-1468:
--
[~rohini], [~virag], [~shwethags]: for the added indexes, don't we need to have
some kind of upgrade with the upgrade script? I just tried using an DB
created without this patch and then applied the patch and it doesn't look like
the indexes are automatically added. I haven't hit any errors, but it could
just be I haven't done anything that required the new indexes.
For example, one of the new indexes was the parent_id of a workflow, but its
not listed in the database:
{code:java}
Index: core/src/main/java/org/apache/oozie/WorkflowJobBean.java
===
--- core/src/main/java/org/apache/oozie/WorkflowJobBean.java(revision
1525051)
+++ core/src/main/java/org/apache/oozie/WorkflowJobBean.java(working copy)
@@ -208,6 +208,7 @@
private int run = 1;
@Basic
+@Index
@Column(name = parent_id)
private String parentId;
{code}
{noformat}
mysql show index in WF_JOBS;
+-++--+--++---+-+--++--++-+
| Table | Non_unique | Key_name | Seq_in_index |
Column_name| Collation | Cardinality | Sub_part | Packed | Null |
Index_type | Comment |
+-++--+--++---+-+--++--++-+
| WF_JOBS | 0 | PRIMARY |1 | id
| A | 10 | NULL | NULL | | BTREE |
|
| WF_JOBS | 1 | I_WF_JOBS_END_TIME |1 | end_time
| A | 10 | NULL | NULL | YES | BTREE |
|
| WF_JOBS | 1 | I_WF_JOBS_EXTERNAL_ID|1 |
external_id| A | 2 | NULL | NULL | YES | BTREE
| |
| WF_JOBS | 1 | I_WF_JOBS_LAST_MODIFIED_TIME |1 |
last_modified_time | A | 10 | NULL | NULL | YES | BTREE
| |
| WF_JOBS | 1 | I_WF_JOBS_STATUS |1 | status
| A | 10 | NULL | NULL | YES | BTREE |
|
+-++--+--++---+-+--++--++-+
5 rows in set (0.00 sec)
{noformat}
Add created time column in WF_ACTIONS and SLA tables
Key: OOZIE-1468
URL: https://issues.apache.org/jira/browse/OOZIE-1468
Project: Oozie
Issue Type: Improvement
Affects Versions: 4.0.0
Reporter: Shwetha G S
Assignee: Rohini Palaniswamy
Fix For: trunk
Attachments: OOZIE-1468-1.patch, OOZIE-1468-2.patch
Its useful to have a created_time column in WF_ACTIONS table that is set at
insert time and not updated later. This can be used to know time of insert
and its required for table partitioning(for db purging).
Any thoughts?
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Re: Review Request 15159: OOZIE-1474 Fix logging issues - latency, accurate job ids, coord Job UI to show job logs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15159/ --- (Updated Nov. 26, 2013, 1:04 a.m.) Review request for oozie. Changes --- addressed review comments. removed 2 unit tests from patch as they are fixed as part of OOZIE-1581. Bugs: OOZIE-1474 https://issues.apache.org/jira/browse/OOZIE-1474 Repository: oozie Description --- Back end change to batch log streaming + front-end change for Coord 'Job' UI (web-console only displays coord action UI). Diffs (updated) - trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1545415 trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java 1545415 trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 1545415 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1545415 trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1545415 trunk/core/src/main/java/org/apache/oozie/service/XLogStreamingService.java 1545415 trunk/core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 1545415 trunk/core/src/main/java/org/apache/oozie/util/LogUtils.java 1545415 trunk/core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 1545415 trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1545415 trunk/core/src/main/resources/oozie-default.xml 1545415 trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1545415 trunk/webapp/src/main/webapp/oozie-console.js 1545415 Diff: https://reviews.apache.org/r/15159/diff/ Testing --- Thanks, Mona Chitnis
[jira] [Commented] (OOZIE-1575) Add functionality to submit sqoop jobs through http on oozie server side
[
https://issues.apache.org/jira/browse/OOZIE-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832157#comment-13832157
]
Alejandro Abdelnur commented on OOZIE-1575:
---
The {{oozie}} script does the following already:
{code}
${JAVA_BIN} ${OOZIE_CLIENT_OPTS} -cp ${OOZIECPPATH}
org.apache.oozie.cli.OozieCLI ${@}
{code}
This means that if you do {{oozie sqoop ... -query select * from T}},
{{select * from T}} will be pass to java as a single argument. So, nothing to
be done here other than document that the query must be between double quotes.
Aren't you seeing that behavior?
Add functionality to submit sqoop jobs through http on oozie server side
Key: OOZIE-1575
URL: https://issues.apache.org/jira/browse/OOZIE-1575
Project: Oozie
Issue Type: Sub-task
Components: client
Reporter: Bowen Zhang
Assignee: Bowen Zhang
Fix For: trunk
Attachments: oozie-1575.patch, oozie-1575.patch, oozie-1575.patch
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (OOZIE-1605) Add common custom filter applied to Wf/Coord/Bundle jobs on oozie UI
[ https://issues.apache.org/jira/browse/OOZIE-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryota Egashira updated OOZIE-1605: -- Description: 1. add common custom filter which applied to all types of jobs (wf/coord/bundle), especially user name, since customer only want to see his/her jobs but not others. store it into cookie not to lose it after browser refresh. 2. make current custom filter to be stored in cookie, as well. 3. make status filter (e.g., status=SUCCEEDED) case-insensitive, (previously upper-case was enforced, hence usability degraded) was: 1. add common custom filter which applied to all types of jobs (wf/coord/bundle), especially user name, since customer only want to see his/her jobs but not others. store it into cookie not to lose it after browser refresh. 2. make current custom filter to be stored in cookie, as well. Add common custom filter applied to Wf/Coord/Bundle jobs on oozie UI Key: OOZIE-1605 URL: https://issues.apache.org/jira/browse/OOZIE-1605 Project: Oozie Issue Type: Bug Affects Versions: trunk Reporter: Ryota Egashira Assignee: Ryota Egashira Fix For: trunk Attachments: Global_Filter_ScreenShot.png, OOZIE-1605-v3.patch, OOZIE-1605-v4.patch 1. add common custom filter which applied to all types of jobs (wf/coord/bundle), especially user name, since customer only want to see his/her jobs but not others. store it into cookie not to lose it after browser refresh. 2. make current custom filter to be stored in cookie, as well. 3. make status filter (e.g., status=SUCCEEDED) case-insensitive, (previously upper-case was enforced, hence usability degraded) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OOZIE-1575) Add functionality to submit sqoop jobs through http on oozie server side
[
https://issues.apache.org/jira/browse/OOZIE-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832234#comment-13832234
]
Bowen Zhang commented on OOZIE-1575:
Agreed. Also, any EL expression like ${wf:user} needs to be either single
quoted or properly escaped.
Add functionality to submit sqoop jobs through http on oozie server side
Key: OOZIE-1575
URL: https://issues.apache.org/jira/browse/OOZIE-1575
Project: Oozie
Issue Type: Sub-task
Components: client
Reporter: Bowen Zhang
Assignee: Bowen Zhang
Fix For: trunk
Attachments: oozie-1575.patch, oozie-1575.patch, oozie-1575.patch
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OOZIE-1627) Rerun doesn't resolve workflow app name
[
https://issues.apache.org/jira/browse/OOZIE-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832238#comment-13832238
]
Hadoop QA commented on OOZIE-1627:
--
Testing JIRA OOZIE-1627
Cleaning local svn workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1368
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/908/
Rerun doesn't resolve workflow app name
---
Key: OOZIE-1627
URL: https://issues.apache.org/jira/browse/OOZIE-1627
Project: Oozie
Issue Type: Bug
Reporter: purshotam shah
Assignee: purshotam shah
Attachments: OOZIE-1627-v1.patch, OOZIE-1627-v2.patch
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OOZIE-1605) Add common custom filter applied to Wf/Coord/Bundle jobs on oozie UI
[
https://issues.apache.org/jira/browse/OOZIE-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832262#comment-13832262
]
Hadoop QA commented on OOZIE-1605:
--
Testing JIRA OOZIE-1605
Cleaning local svn workspace
{color:red}-1{color} Patch failed to apply to head of branch
Add common custom filter applied to Wf/Coord/Bundle jobs on oozie UI
Key: OOZIE-1605
URL: https://issues.apache.org/jira/browse/OOZIE-1605
Project: Oozie
Issue Type: Bug
Affects Versions: trunk
Reporter: Ryota Egashira
Assignee: Ryota Egashira
Fix For: trunk
Attachments: Global_Filter_ScreenShot.png, OOZIE-1605-v3.patch,
OOZIE-1605-v4.patch
1. add common custom filter which applied to all types of jobs
(wf/coord/bundle), especially user name, since customer only want to see
his/her jobs but not others. store it into cookie not to lose it after
browser refresh.
2. make current custom filter to be stored in cookie, as well.
3. make status filter (e.g., status=SUCCEEDED) case-insensitive, (previously
upper-case was enforced, hence usability degraded)
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OOZIE-1623) JPAService doesn't need to do reads in a transaction
[
https://issues.apache.org/jira/browse/OOZIE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832370#comment-13832370
]
Hadoop QA commented on OOZIE-1623:
--
Testing JIRA OOZIE-1623
Cleaning local svn workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1368
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/910/
JPAService doesn't need to do reads in a transaction
Key: OOZIE-1623
URL: https://issues.apache.org/jira/browse/OOZIE-1623
Project: Oozie
Issue Type: Bug
Affects Versions: trunk
Reporter: Robert Kanter
Assignee: Robert Kanter
Attachments: OOZIE-1623.patch, OOZIE-1623.patch
{{JPAService#executeGet}} and {{JPAService#executeGetList}} are both doing
{{SELECT}} queries (so only reading), which means that they shouldn't need to
be in a transaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
