[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-01-13 Thread Azrael (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870457#comment-13870457
 ] 

Azrael commented on OOZIE-1638:
---

Failing test is unrelated patch.

> Action retry does not use default retry max count.
> --
>
> Key: OOZIE-1638
> URL: https://issues.apache.org/jira/browse/OOZIE-1638
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 4.0.0
>Reporter: Azrael
>Priority: Minor
> Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
> OOZIE-1638.4.patch, OOZIE-1638.patch
>
>
> the oozie-default
> {code:xml}
> 
> oozie.service.LiteWorkflowStoreService.user.retry.max
> 3
> 
> Automatic retry max count for workflow action is 3 in default.
> 
> 
> {code}
> but the action failed with error, is not retried. 
> It should retry $\{user.retry.max\} times.
> If the patch applied, some other tests in TestActionError failed because the 
> action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (OOZIE-1668) Coord log streaming start and end time should be of action list start and end time

2014-01-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870452#comment-13870452
 ] 

Hadoop QA commented on OOZIE-1668:
--

Testing JIRA OOZIE-1668

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1379
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1010/

> Coord log streaming start and end time should be of action list start and end 
> time
> --
>
> Key: OOZIE-1668
> URL: https://issues.apache.org/jira/browse/OOZIE-1668
> Project: Oozie
>  Issue Type: Bug
>Reporter: purshotam shah
>Assignee: purshotam shah
> Attachments: OOZIE-1668.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-01-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870403#comment-13870403
 ] 

Hadoop QA commented on OOZIE-1638:
--

Testing JIRA OOZIE-1638

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 5 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:red}-1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:red}-1{color} the patch seems to introduce 1 new javac warning(s)
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1383
.Tests failed: 0
.Tests errors: 1

.The patch failed the following testcases:

.  

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1009/

> Action retry does not use default retry max count.
> --
>
> Key: OOZIE-1638
> URL: https://issues.apache.org/jira/browse/OOZIE-1638
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 4.0.0
>Reporter: Azrael
>Priority: Minor
> Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
> OOZIE-1638.4.patch, OOZIE-1638.patch
>
>
> the oozie-default
> {code:xml}
> 
> oozie.service.LiteWorkflowStoreService.user.retry.max
> 3
> 
> Automatic retry max count for workflow action is 3 in default.
> 
> 
> {code}
> but the action failed with error, is not retried. 
> It should retry $\{user.retry.max\} times.
> If the patch applied, some other tests in TestActionError failed because the 
> action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Updated] (OOZIE-1638) Action retry does not use default retry max count.

2014-01-13 Thread Azrael (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Azrael updated OOZIE-1638:
--

Attachment: OOZIE-1638.4.patch

Thanks for review.

Address comments and update the patch.


> Action retry does not use default retry max count.
> --
>
> Key: OOZIE-1638
> URL: https://issues.apache.org/jira/browse/OOZIE-1638
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 4.0.0
>Reporter: Azrael
>Priority: Minor
> Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
> OOZIE-1638.4.patch, OOZIE-1638.patch
>
>
> the oozie-default
> {code:xml}
> 
> oozie.service.LiteWorkflowStoreService.user.retry.max
> 3
> 
> Automatic retry max count for workflow action is 3 in default.
> 
> 
> {code}
> but the action failed with error, is not retried. 
> It should retry $\{user.retry.max\} times.
> If the patch applied, some other tests in TestActionError failed because the 
> action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Updated] (OOZIE-1668) Coord log streaming start and end time should be of action list start and end time

2014-01-13 Thread purshotam shah (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

purshotam shah updated OOZIE-1668:
--

Attachment: OOZIE-1668.patch

> Coord log streaming start and end time should be of action list start and end 
> time
> --
>
> Key: OOZIE-1668
> URL: https://issues.apache.org/jira/browse/OOZIE-1668
> Project: Oozie
>  Issue Type: Bug
>Reporter: purshotam shah
>Assignee: purshotam shah
> Attachments: OOZIE-1668.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


Re: Review Request 16840: OOZIE-1668 Coord log streaming start and end time should be of action list start and end time

2014-01-13 Thread Purshotam Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16840/
---

(Updated Jan. 14, 2014, 2:02 a.m.)


Review request for oozie.


Bugs: OOZIE-1668
https://issues.apache.org/jira/browse/OOZIE-1668


Repository: oozie-git


Description
---

Coord log streaming start and end time should be of action list start and end 
time


Diffs
-

  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 
  core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java 
a29a07e 

Diff: https://reviews.apache.org/r/16840/diff/


Testing
---

Refactored test-cases.
Each test cases run a coord job which takes 5 min to complete.
Made changes so that coord job is executed only once and all test cases use 
that for validate.


Thanks,

Purshotam Shah



Review Request 16840: OOZIE-1668 Coord log streaming start and end time should be of action list start and end time

2014-01-13 Thread Purshotam Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16840/
---

Review request for oozie.


Bugs: OOZIE-1668
https://issues.apache.org/jira/browse/OOZIE-1668


Repository: oozie-git


Description
---

Coord log streaming start and end time should be of action list start and end 
time


Diffs
-

  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 
  core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java 
a29a07e 

Diff: https://reviews.apache.org/r/16840/diff/


Testing
---

Refactored test-cases.
Each test cases run a coord job which takes 5 min to complete.
Made changes so that coord job is executed only once and all test cases use 
that for validate.


Thanks,

Purshotam Shah



[jira] Subscription: Oozie Patch Available

2014-01-13 Thread jira
Issue Subscription
Filter: Oozie Patch Available (24 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-1666  Child job link not working in safari and chrome
https://issues.apache.org/jira/browse/OOZIE-1666
OOZIE-1663  Queuedump to display command type
https://issues.apache.org/jira/browse/OOZIE-1663
OOZIE-1654  Fix typo (inteval to interval)
https://issues.apache.org/jira/browse/OOZIE-1654
OOZIE-1653  Support ALL to allowed error code of the user retry
https://issues.apache.org/jira/browse/OOZIE-1653
OOZIE-1646  HBase Table Copy between two HBase servers doesn't work with 
Kerberos
https://issues.apache.org/jira/browse/OOZIE-1646
OOZIE-1645  Oozie upgrade DB command fails due to missing dependencies for mssql
https://issues.apache.org/jira/browse/OOZIE-1645
OOZIE-1638  Action retry does not use default retry max count.
https://issues.apache.org/jira/browse/OOZIE-1638
OOZIE-1636  OOZIE_SYS table engine should be innodb
https://issues.apache.org/jira/browse/OOZIE-1636
OOZIE-1624  Exclusion pattern for sharelib.
https://issues.apache.org/jira/browse/OOZIE-1624
OOZIE-1622  Multiple CoordSubmit for same bundle
https://issues.apache.org/jira/browse/OOZIE-1622
OOZIE-1618  dryrun should check variable substitution in workflow.xml
https://issues.apache.org/jira/browse/OOZIE-1618
OOZIE-1609  HA support for share lib.
https://issues.apache.org/jira/browse/OOZIE-1609
OOZIE-1602  pom.xml should take use of the profiles when building hadooplibs
https://issues.apache.org/jira/browse/OOZIE-1602
OOZIE-1581  Workflow performance optimizations
https://issues.apache.org/jira/browse/OOZIE-1581
OOZIE-1579  Add basic HTTP auth to Oozie CLI
https://issues.apache.org/jira/browse/OOZIE-1579
OOZIE-1552  Bring Windows shell script functionality and structure in line with 
trunk
https://issues.apache.org/jira/browse/OOZIE-1552
OOZIE-1388  Add a admin servlet to show thread stack trace and CPU usage per 
thread
https://issues.apache.org/jira/browse/OOZIE-1388
OOZIE-1376  Extending Oozie ACLs like admin groups and proxy users to support 
both groups and users
https://issues.apache.org/jira/browse/OOZIE-1376
OOZIE-1369  OozieDBCLI code should not hardcode the Oozie table filenames
https://issues.apache.org/jira/browse/OOZIE-1369
OOZIE-1319  "LAST_ONLY" in execution control for coordinator job still runs all 
the actions
https://issues.apache.org/jira/browse/OOZIE-1319
OOZIE-1232  GroupsService should be able to reference Hadoop configurations in 
Hadoop configuration folder (such as /etc/hadoop/conf)
https://issues.apache.org/jira/browse/OOZIE-1232
OOZIE-1074  workflowgenerator does not package a tar.gz file though it seems 
creating one is the intention
https://issues.apache.org/jira/browse/OOZIE-1074
OOZIE-891   Add pagination for all popup panels in Oozie Web UI
https://issues.apache.org/jira/browse/OOZIE-891
OOZIE-547   build workflow progress information in Oozie
https://issues.apache.org/jira/browse/OOZIE-547

You may edit this subscription at:
https://issues.apache.org/jira/secure/FilterSubscription!default.jspa?subId=14721&filterId=12325939


[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib.

2014-01-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870196#comment-13870196
 ] 

Hadoop QA commented on OOZIE-1624:
--

Testing JIRA OOZIE-1624

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132 
characters
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1383
.Tests failed: 1
.Tests errors: 0

.The patch failed the following testcases:

.  
testConcurrencyReachedAndChooseNextEligible(org.apache.oozie.service.TestCallableQueueService)

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1008/

> Exclusion pattern for sharelib.
> ---
>
> Key: OOZIE-1624
> URL: https://issues.apache.org/jira/browse/OOZIE-1624
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: purshotam shah
>Assignee: purshotam shah
> Attachments: OOZIE-1624-v1.patch
>
>
> Sharelib may bring some jar which might conflict with user jars.
> Ex. Sharelib hive has json-2..jar, where as some of the user use-case 
> need higher version of json jar.
> He should be able to exclude sharelib json jar and bring his own version.
> 
> oozie.action.sharelib.exclusion
> json-*.jar,abc-*.jar
>  



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Assigned] (OOZIE-1668) Coord log streaming start and end time should be of action list start and end time

2014-01-13 Thread purshotam shah (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

purshotam shah reassigned OOZIE-1668:
-

Assignee: purshotam shah

> Coord log streaming start and end time should be of action list start and end 
> time
> --
>
> Key: OOZIE-1668
> URL: https://issues.apache.org/jira/browse/OOZIE-1668
> Project: Oozie
>  Issue Type: Bug
>Reporter: purshotam shah
>Assignee: purshotam shah
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (OOZIE-1618) dryrun should check variable substitution in workflow.xml

2014-01-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870109#comment-13870109
 ] 

Hadoop QA commented on OOZIE-1618:
--

Testing JIRA OOZIE-1618

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 5 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:red}-1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:red}-1{color} the patch seems to introduce 2 new javac warning(s)
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1382
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1007/

> dryrun should check variable substitution in workflow.xml
> -
>
> Key: OOZIE-1618
> URL: https://issues.apache.org/jira/browse/OOZIE-1618
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Bowen Zhang
>Assignee: Bowen Zhang
> Attachments: oozie-1618.patch, oozie-1618.patch
>
>
> Currently, dryrun doesn't check variable substitution in workflow.xml, like 
> in the configuration section.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Created] (OOZIE-1668) Coord log streaming start and end time should be of action list start and end time

2014-01-13 Thread purshotam shah (JIRA)
purshotam shah created OOZIE-1668:
-

 Summary: Coord log streaming start and end time should be of 
action list start and end time
 Key: OOZIE-1668
 URL: https://issues.apache.org/jira/browse/OOZIE-1668
 Project: Oozie
  Issue Type: Bug
Reporter: purshotam shah






--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Assigned] (OOZIE-1624) Exclusion pattern for sharelib.

2014-01-13 Thread purshotam shah (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

purshotam shah reassigned OOZIE-1624:
-

Assignee: purshotam shah

> Exclusion pattern for sharelib.
> ---
>
> Key: OOZIE-1624
> URL: https://issues.apache.org/jira/browse/OOZIE-1624
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: purshotam shah
>Assignee: purshotam shah
> Attachments: OOZIE-1624-v1.patch
>
>
> Sharelib may bring some jar which might conflict with user jars.
> Ex. Sharelib hive has json-2..jar, where as some of the user use-case 
> need higher version of json jar.
> He should be able to exclude sharelib json jar and bring his own version.
> 
> oozie.action.sharelib.exclusion
> json-*.jar,abc-*.jar
>  



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Updated] (OOZIE-1624) Exclusion pattern for sharelib.

2014-01-13 Thread purshotam shah (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

purshotam shah updated OOZIE-1624:
--

Attachment: OOZIE-1624-v1.patch

> Exclusion pattern for sharelib.
> ---
>
> Key: OOZIE-1624
> URL: https://issues.apache.org/jira/browse/OOZIE-1624
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: purshotam shah
> Attachments: OOZIE-1624-v1.patch
>
>
> Sharelib may bring some jar which might conflict with user jars.
> Ex. Sharelib hive has json-2..jar, where as some of the user use-case 
> need higher version of json jar.
> He should be able to exclude sharelib json jar and bring his own version.
> 
> oozie.action.sharelib.exclusion
> json-*.jar,abc-*.jar
>  



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Updated] (OOZIE-1618) dryrun should check variable substitution in workflow.xml

2014-01-13 Thread Bowen Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bowen Zhang updated OOZIE-1618:
---

Attachment: oozie-1618.patch

> dryrun should check variable substitution in workflow.xml
> -
>
> Key: OOZIE-1618
> URL: https://issues.apache.org/jira/browse/OOZIE-1618
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Bowen Zhang
>Assignee: Bowen Zhang
> Attachments: oozie-1618.patch, oozie-1618.patch
>
>
> Currently, dryrun doesn't check variable substitution in workflow.xml, like 
> in the configuration section.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Updated] (OOZIE-1618) dryrun should check variable substitution in workflow.xml

2014-01-13 Thread Bowen Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bowen Zhang updated OOZIE-1618:
---

Attachment: (was: oozie-1618.patch)

> dryrun should check variable substitution in workflow.xml
> -
>
> Key: OOZIE-1618
> URL: https://issues.apache.org/jira/browse/OOZIE-1618
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Bowen Zhang
>Assignee: Bowen Zhang
> Attachments: oozie-1618.patch
>
>
> Currently, dryrun doesn't check variable substitution in workflow.xml, like 
> in the configuration section.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-01-13 Thread purshotam shah (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869741#comment-13869741
 ] 

purshotam shah commented on OOZIE-1638:
---

Comment on Patch.


+final WorkflowActionsGetForJobJPAExecutor actionsGetExecutor = new 
WorkflowActionsGetForJobJPAExecutor(jobId);
+waitFor(5000, new Predicate() {
+public boolean evaluate() throws Exception {
+List actions = 
jpaService.execute(actionsGetExecutor);
+WorkflowActionBean action = null;
+for (WorkflowActionBean bean : actions) {
+if (bean.getType().equals("test")) {
+action = bean;
+break;
+}
+}
+>>>return (action != null && action.getUserRetryCount() == 
max);
+}
+});


You should break when action is succeeded or failed and then check 
getUserRetryCount()


>>+
Why not to use latest version 0.5

> Action retry does not use default retry max count.
> --
>
> Key: OOZIE-1638
> URL: https://issues.apache.org/jira/browse/OOZIE-1638
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 4.0.0
>Reporter: Azrael
>Priority: Minor
> Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, OOZIE-1638.patch
>
>
> the oozie-default
> {code:xml}
> 
> oozie.service.LiteWorkflowStoreService.user.retry.max
> 3
> 
> Automatic retry max count for workflow action is 3 in default.
> 
> 
> {code}
> but the action failed with error, is not retried. 
> It should retry $\{user.retry.max\} times.
> If the patch applied, some other tests in TestActionError failed because the 
> action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)