Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

2017-10-13 Thread Robert Kanter via Review Board


> On Oct. 12, 2017, 11:36 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> > Lines 1197 (patched)
> > 
> >
> > This is fine to leave for a different JIRA, but we should consider 
> > dropping the "oozie:launcher:" part of the name.  The job type is now 
> > OOZIE, so it's probably redundent and we can shorten the names.
> 
> Peter Cseh wrote:
> OOZIE-2893

Oh I forgot about that Haha.  At least I'm being consistent with the name :)


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62936/#review187893
---


On Oct. 12, 2017, 3:33 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62936/
> ---
> 
> (Updated Oct. 12, 2017, 3:33 p.m.)
> 
> 
> Review request for oozie, Attila Sasvari, Peter Cseh, and Peter Bacsko.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2896 Ensure compatibility for existing LauncherMapper settings
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 76d0daa4f7528de6fb3c8993bae4dd28b6f7865b 
>   
> core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationFilter.java
>  PRE-CREATION 
>   core/src/main/resources/oozie-default.xml 
> 2389b993b7b1769521d6dd0c7386e99e7516210a 
>   
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 
> a7bd357f8938d148a150db43135a7a8fe7f0da4c 
>   
> core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherConfigurationFilter.java
>  PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java 
> ee1a32ac9b071009e1dbe78396520d778f58bddc 
> 
> 
> Diff: https://reviews.apache.org/r/62936/diff/1/
> 
> 
> Testing
> ---
> 
> JUnit tests:
> 
> * `TestJavaActionExecutor`
> * `TestLauncherConfigurationFilter`
> 
> Functional tests: submit and run `examples/apps/java-main/workflow.xml` in 
> three modes:
> 
> * only `oozie.launcher.` parameters are present: `oozie.launcher.` parameters 
> are passed through
> * `oozie.launcher.` and override (`yarn.`, `mapreduce.`, and `mapred.`) 
> parameters are also present: `oozie.launcher.` parameters are passed through
> * only override (`yarn.`, `mapreduce.`, and `mapred.`) parameters are 
> present: override parameters are passed through
> 
> 
> Thanks,
> 
> András Piros
> 
>



Re: Review Request 62459: OOZIE-2296: Add an Oozie diagnostic bundle tool

2017-10-13 Thread Peter Cseh via Review Board


> On Oct. 6, 2017, 12:26 a.m., Robert Kanter wrote:
> > tools/src/main/java/org/apache/oozie/tools/diag/AppInfoCollector.java
> > Lines 173-174 (patched)
> > 
> >
> > LogAggregationUtils is marked @Private so we shouldn't 
> > be using it.  Hadoop can change things incompatibly here.
> 
> Attila Sasvari wrote:
> What do you think about borrowing/inlining/copying those functions from 
> Hadoop 2.6 too? I was thinking about it and it is probably better than 
> bringing back the initial ``ExecutorService`` based approach. I am thinking 
> of a class like:
> 
> ```java
> // TODO: once OOZIE-2983 ("Stream the Launcher AM Logs") is done, remove 
> it.
> public class OozieLauncherLogFetcher {
> private static final String TMP_FILE_SUFFIX = ".tmp";
> final private Configuration hadoopConfig;
> 
> public OozieLauncherLogFetcher(final Configuration hadoopConfig) {
> this.hadoopConfig = hadoopConfig;
> }
> 
> // Borrowed code from 
> org.apache.hadoop.yarn.logaggregation.LogCLIHelpers
> private static void logDirNotExist(String remoteAppLogDir) {
> System.out.println(remoteAppLogDir + "does not exist.");
> System.out.println("Log aggregation has not completed or is not 
> enabled.");
> }
> // Borrowed code from 
> org.apache.hadoop.yarn.logaggregation.LogCLIHelpers
> private static void emptyLogDir(String remoteAppLogDir) {
> System.out.println(remoteAppLogDir + "does not have any log 
> files.");
> }
> // Borrowed code from 
> org.apache.hadoop.yarn.logaggregation.LogAggregationUtils
> public static String getRemoteNodeLogDirSuffix(Configuration conf) {
> return conf.get(YarnConfiguration.NM_REMOTE_APP_LOG_DIR_SUFFIX, 
> YarnConfiguration.DEFAULT_NM_REMOTE_APP_LOG_DIR_SUFFIX);
> }
> // Borrowed code from 
> org.apache.hadoop.yarn.logaggregation.LogAggregationUtils
> public static Path getRemoteLogSuffixedDir(Path remoteRootLogDir, 
> String user, String suffix) {
> return suffix != null && !suffix.isEmpty() ? new 
> Path(getRemoteLogUserDir(remoteRootLogDir, user), suffix) :
> getRemoteLogUserDir(remoteRootLogDir, user);
> }
> // Borrowed code from 
> org.apache.hadoop.yarn.logaggregation.LogAggregationUtils
> public static Path getRemoteLogUserDir(Path remoteRootLogDir, String 
> user) {
> return new Path(remoteRootLogDir, user);
> }
> 
> // Borrowed code from 
> org.apache.hadoop.yarn.logaggregation.LogAggregationUtils
> public static Path getRemoteAppLogDir(Path remoteRootLogDir, 
> ApplicationId appId, String user, String suffix) {
> return new Path(getRemoteLogSuffixedDir(remoteRootLogDir, user, 
> suffix), appId.toString());
> }
> 
> // Borrowed code from 
> org.apache.hadoop.yarn.logaggregation.LogCLIHelpers
> public int dumpAllContainersLogs(ApplicationId appId, String 
> appOwner, PrintStream out) throws IOException {
> Path remoteRootLogDir = new 
> Path(hadoopConfig.get(YarnConfiguration.NM_REMOTE_APP_LOG_DIR,
> YarnConfiguration.DEFAULT_NM_REMOTE_APP_LOG_DIR));
> String logDirSuffix = getRemoteNodeLogDirSuffix(hadoopConfig);
> Path remoteAppLogDir = getRemoteAppLogDir(remoteRootLogDir, 
> appId, appOwner, logDirSuffix);
> 
> RemoteIterator nodeFiles;
> try {
> Path qualifiedLogDir = 
> FileContext.getFileContext(hadoopConfig).makeQualified(remoteAppLogDir);
> nodeFiles = 
> FileContext.getFileContext(qualifiedLogDir.toUri(), 
> hadoopConfig).listStatus(remoteAppLogDir);
> } catch (FileNotFoundException fileNotFoundException) {
> logDirNotExist(remoteAppLogDir.toString());
> return -1;
> }
> 
> boolean foundAnyLogs = false;
> 
> while(true) {
> FileStatus thisNodeFile;
> do {
> if (!nodeFiles.hasNext()) {
> if (!foundAnyLogs) {
> emptyLogDir(remoteAppLogDir.toString());
> return -1;
> }
> 
> return 0;
> }
> 
> thisNodeFile = (FileStatus)nodeFiles.next();
> } 
> while(thisNodeFile.getPath().getName().endsWith(TMP_FILE_SUFFIX));
> 
> AggregatedLogFormat.LogReader reader = new 
> AggregatedLogFormat.LogReader(hadoopConfig, thisNodeFile.getPath());
> 
> try {
> AggregatedLogFormat.LogKey key = new 
> AggregatedLogFormat.LogKey();
> DataInputStream 

Re: Review Request 62459: OOZIE-2296: Add an Oozie diagnostic bundle tool

2017-10-13 Thread Attila Sasvari via Review Board


> On Oct. 6, 2017, 12:26 a.m., Robert Kanter wrote:
> > tools/src/main/java/org/apache/oozie/tools/diag/AppInfoCollector.java
> > Lines 173-174 (patched)
> > 
> >
> > LogAggregationUtils is marked @Private so we shouldn't 
> > be using it.  Hadoop can change things incompatibly here.

What do you think about borrowing/inlining/copying those functions from Hadoop 
2.6 too? I was thinking about it and it is probably better than bringing back 
the initial ``ExecutorService`` based approach. I am thinking of a class like:

```java
// TODO: once OOZIE-2983 ("Stream the Launcher AM Logs") is done, remove it.
public class OozieLauncherLogFetcher {
private static final String TMP_FILE_SUFFIX = ".tmp";
final private Configuration hadoopConfig;

public OozieLauncherLogFetcher(final Configuration hadoopConfig) {
this.hadoopConfig = hadoopConfig;
}

// Borrowed code from org.apache.hadoop.yarn.logaggregation.LogCLIHelpers
private static void logDirNotExist(String remoteAppLogDir) {
System.out.println(remoteAppLogDir + "does not exist.");
System.out.println("Log aggregation has not completed or is not 
enabled.");
}
// Borrowed code from org.apache.hadoop.yarn.logaggregation.LogCLIHelpers
private static void emptyLogDir(String remoteAppLogDir) {
System.out.println(remoteAppLogDir + "does not have any log files.");
}
// Borrowed code from 
org.apache.hadoop.yarn.logaggregation.LogAggregationUtils
public static String getRemoteNodeLogDirSuffix(Configuration conf) {
return conf.get(YarnConfiguration.NM_REMOTE_APP_LOG_DIR_SUFFIX, 
YarnConfiguration.DEFAULT_NM_REMOTE_APP_LOG_DIR_SUFFIX);
}
// Borrowed code from 
org.apache.hadoop.yarn.logaggregation.LogAggregationUtils
public static Path getRemoteLogSuffixedDir(Path remoteRootLogDir, String 
user, String suffix) {
return suffix != null && !suffix.isEmpty() ? new 
Path(getRemoteLogUserDir(remoteRootLogDir, user), suffix) :
getRemoteLogUserDir(remoteRootLogDir, user);
}
// Borrowed code from 
org.apache.hadoop.yarn.logaggregation.LogAggregationUtils
public static Path getRemoteLogUserDir(Path remoteRootLogDir, String user) {
return new Path(remoteRootLogDir, user);
}

// Borrowed code from 
org.apache.hadoop.yarn.logaggregation.LogAggregationUtils
public static Path getRemoteAppLogDir(Path remoteRootLogDir, ApplicationId 
appId, String user, String suffix) {
return new Path(getRemoteLogSuffixedDir(remoteRootLogDir, user, 
suffix), appId.toString());
}

// Borrowed code from org.apache.hadoop.yarn.logaggregation.LogCLIHelpers
public int dumpAllContainersLogs(ApplicationId appId, String appOwner, 
PrintStream out) throws IOException {
Path remoteRootLogDir = new 
Path(hadoopConfig.get(YarnConfiguration.NM_REMOTE_APP_LOG_DIR,
YarnConfiguration.DEFAULT_NM_REMOTE_APP_LOG_DIR));
String logDirSuffix = getRemoteNodeLogDirSuffix(hadoopConfig);
Path remoteAppLogDir = getRemoteAppLogDir(remoteRootLogDir, appId, 
appOwner, logDirSuffix);

RemoteIterator nodeFiles;
try {
Path qualifiedLogDir = 
FileContext.getFileContext(hadoopConfig).makeQualified(remoteAppLogDir);
nodeFiles = FileContext.getFileContext(qualifiedLogDir.toUri(), 
hadoopConfig).listStatus(remoteAppLogDir);
} catch (FileNotFoundException fileNotFoundException) {
logDirNotExist(remoteAppLogDir.toString());
return -1;
}

boolean foundAnyLogs = false;

while(true) {
FileStatus thisNodeFile;
do {
if (!nodeFiles.hasNext()) {
if (!foundAnyLogs) {
emptyLogDir(remoteAppLogDir.toString());
return -1;
}

return 0;
}

thisNodeFile = (FileStatus)nodeFiles.next();
} while(thisNodeFile.getPath().getName().endsWith(TMP_FILE_SUFFIX));

AggregatedLogFormat.LogReader reader = new 
AggregatedLogFormat.LogReader(hadoopConfig, thisNodeFile.getPath());

try {
AggregatedLogFormat.LogKey key = new 
AggregatedLogFormat.LogKey();
DataInputStream valueStream = reader.next(key);

while(valueStream != null) {
String containerString = "\n\nContainer: " + key + " on " + 
thisNodeFile.getPath().getName();
out.println(containerString);
out.println(StringUtils.repeat("=", 
containerString.length()));

while(true) {
try {

AggregatedLogFormat.LogReader.readAContainerLogsForALogType(valueStream, out,

[jira] [Commented] (OOZIE-2406) Completely rewrite GraphGenerator code

2017-10-13 Thread Robert Kanter (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203850#comment-16203850
 ] 

Robert Kanter commented on OOZIE-2406:
--

Yay!

> Completely rewrite GraphGenerator code
> --
>
> Key: OOZIE-2406
> URL: https://issues.apache.org/jira/browse/OOZIE-2406
> Project: Oozie
>  Issue Type: New Feature
>Affects Versions: 4.2.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: OOZIE-2406.004.patch, OOZIE-2406.004.patch, 
> OOZIE-2406.005.patch, OOZIE-2406.006.patch, OOZIE-2406.007.patch, 
> OOZIE-2406.008.patch, OOZIE-2406.009.patch, OOZIE-2406.010.patch, 
> OOZIE-2406.011.patch, OOZIE-2406.012.patch, OOZIE-2406.012.patch, 
> OOZIE-2406.012.patch, OOZIE-2406.012.patch, OOZIE-2406.012.patch, 
> OOZIE-2406.013.patch, Screen Shot 2017-10-02 at 1.55.58 PM.png, Screen Shot 
> 2017-10-02 at 1.56.33 PM.png, graphviz-10-action-nodes.png, 
> graphviz-25-action-nodes.png, graphviz-50-action-nodes.png, 
> graphviz-many-nodes.png, jung-many-nodes.png
>
>
> The Web UI currently generates a graph of the workflow DAG as a png image 
> that it can show to the user ({{GraphGenerator}} class).  Unfortunately, 
> there are a number of downsides to the current implementation:
> # The image is generated server-side, which doesn't scale well and eats up 
> lots of memory
> #- To help combat this issue, we only generate graphs for workflows with less 
> than 25 nodes and we disabled the refresh button in the UI
> # It's slow
> # It uses a library ({{net.sf.jung}} from http://jung.sourceforge.net), which 
> hasn't been updated since 2010.  
> #- This library also has a dependency on a fork of Commons-Collections 
> ({{net.sourceforge.collections}} from 
> http://sourceforge.net/projects/collections/), which similarly hasn't been 
> updated since 2010.  This is a problem because we can't update 
> Commons-Collections when there are security concerns such as COLLECTIONS-580 
> (though Oozie is *not* susceptible to this attack).
> It would be good to do a complete rewrite, using a different library and 
> remove Jung and the Commons-Collections fork.  Whatever we choose, it should 
> an svg which will draw the image on the browser.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OOZIE-3084) Add missing JVM properties to Jetty startup script

2017-10-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203748#comment-16203748
 ] 

Hadoop QA commented on OOZIE-3084:
--

Testing JIRA OOZIE-3084

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/111/

> Add missing JVM properties to Jetty startup script
> --
>
> Key: OOZIE-3084
> URL: https://issues.apache.org/jira/browse/OOZIE-3084
> Project: Oozie
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 5.0.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: OOZIE-3084.001.patch
>
>
> In OOZIE-2666, when Oozie has moved from Tomcat to Jetty, we also moved the 
> Tomcat related JVM options inside the startup script {{bin/oozied.sh}} to the 
> more specific {{bin/oozie-jetty-server.sh}}.
> It seems that not all the 
> [*{{catalina_opts}}*|https://github.com/apache/oozie/blob/branch-4.3/distro/src/main/bin/oozied.sh#L54-L74]
>  have been moved to 
> [*{{jetty_opts}}*|https://github.com/apache/oozie/blob/master/distro/src/main/bin/oozie-jetty-server.sh#L70-L86].
>  Such an example is {{oozie.instance.id}}, causing we don't have any server 
> name information within the Oozie server logs.
> So the task is to investigate startup scripts and put missing and needed 
> {{catalina_opts}} to {{jetty_opts}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Failed: OOZIE-3084 PreCommit Build #111

2017-10-13 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/OOZIE-3084
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/111/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1.53 MB...]
+1 the patch does not introduce any line longer than 132
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 77 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/pig].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS - patch does not compile, cannot run testcases
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/111/

  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 3706k  100 3706k0 0  2808k  0  0:00:01  0:00:01 --:--:-- 4081k
Adding comment to JIRA
Comment added.

test-patch exit code: 1

Build step 'Execute shell' marked build as failure
[description-setter] Description set: OOZIE-3084
Archiving artifacts
[Fast Archiver] Compressed 1.80 MB of artifacts by 55.6% relative to #108
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (OOZIE-2896) Ensure compatibility for existing LauncherMapper settings

2017-10-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203652#comment-16203652
 ] 

Hadoop QA commented on OOZIE-2896:
--

Testing JIRA OOZIE-2896

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/110/

> Ensure compatibility for existing LauncherMapper settings
> -
>
> Key: OOZIE-2896
> URL: https://issues.apache.org/jira/browse/OOZIE-2896
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: 5.0.0
>Reporter: Peter Bacsko
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2896.001.patch, OOZIE-2896.002.patch, 
> OOZIE-2896.002.patch, OOZIE-2896.003.patch
>
>
> There are a couple of LauncherMapper settings that we should support for 
> backward compatibility reasons.
> For example, {{oozie.launcher.mapreduce.map.memory.mb}}, 
> {{mapred.child.env}}, {{mapred.map.env}}, etc.
> We also have to discuss the list of properties we're going to support, since 
> there are many of them.
> List of hadoop properties under this task:
> mapreduce.job.queuename
> mapreduce.map.memory.mb
> mapreduce.map.java.opts
> mapreduce.map.env
> mapreduce.job.priority
> yarn.app.mapreduce.am.scheduler.heartbeat.interval-ms
> yarn.app.mapreduce.am.resource.mb
> yarn.app.mapreduce.am.command-opts
> yarn.app.mapreduce.am.env
> ACL related properties should go under OOZIE-2897:
> mapreduce.job.acl-view-job
> mapreduce.job.acl-modfy-job



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Failed: OOZIE-2896 PreCommit Build #110

2017-10-13 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/OOZIE-2896
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/110/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1.53 MB...]
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 2 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 77 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [client].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS - patch does not compile, cannot run testcases
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/110/

  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  0 
00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0
100 3706k  100 3706k0 0  3713k  0 --:--:-- --:--:-- --:--:-- 3713k
Adding comment to JIRA
Comment added.

test-patch exit code: 1

Build step 'Execute shell' marked build as failure
[description-setter] Description set: OOZIE-2896
Archiving artifacts
[Fast Archiver] Compressed 1.80 MB of artifacts by 59.1% relative to #108
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (OOZIE-2406) Completely rewrite GraphGenerator code

2017-10-13 Thread Peter Cseh (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203544#comment-16203544
 ] 

Peter Cseh commented on OOZIE-2406:
---

+1 Thanks for fixing this!

> Completely rewrite GraphGenerator code
> --
>
> Key: OOZIE-2406
> URL: https://issues.apache.org/jira/browse/OOZIE-2406
> Project: Oozie
>  Issue Type: New Feature
>Affects Versions: 4.2.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: OOZIE-2406.004.patch, OOZIE-2406.004.patch, 
> OOZIE-2406.005.patch, OOZIE-2406.006.patch, OOZIE-2406.007.patch, 
> OOZIE-2406.008.patch, OOZIE-2406.009.patch, OOZIE-2406.010.patch, 
> OOZIE-2406.011.patch, OOZIE-2406.012.patch, OOZIE-2406.012.patch, 
> OOZIE-2406.012.patch, OOZIE-2406.012.patch, OOZIE-2406.012.patch, 
> OOZIE-2406.013.patch, Screen Shot 2017-10-02 at 1.55.58 PM.png, Screen Shot 
> 2017-10-02 at 1.56.33 PM.png, graphviz-10-action-nodes.png, 
> graphviz-25-action-nodes.png, graphviz-50-action-nodes.png, 
> graphviz-many-nodes.png, jung-many-nodes.png
>
>
> The Web UI currently generates a graph of the workflow DAG as a png image 
> that it can show to the user ({{GraphGenerator}} class).  Unfortunately, 
> there are a number of downsides to the current implementation:
> # The image is generated server-side, which doesn't scale well and eats up 
> lots of memory
> #- To help combat this issue, we only generate graphs for workflows with less 
> than 25 nodes and we disabled the refresh button in the UI
> # It's slow
> # It uses a library ({{net.sf.jung}} from http://jung.sourceforge.net), which 
> hasn't been updated since 2010.  
> #- This library also has a dependency on a fork of Commons-Collections 
> ({{net.sourceforge.collections}} from 
> http://sourceforge.net/projects/collections/), which similarly hasn't been 
> updated since 2010.  This is a problem because we can't update 
> Commons-Collections when there are security concerns such as COLLECTIONS-580 
> (though Oozie is *not* susceptible to this attack).
> It would be good to do a complete rewrite, using a different library and 
> remove Jung and the Commons-Collections fork.  Whatever we choose, it should 
> an svg which will draw the image on the browser.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OOZIE-3084) Add missing JVM properties to Jetty startup script

2017-10-13 Thread Andras Piros (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203525#comment-16203525
 ] 

Andras Piros commented on OOZIE-3084:
-

No test cases modified or added, tested entirely manually, see my previous 
comment.

[~asasvari] can you please review?

> Add missing JVM properties to Jetty startup script
> --
>
> Key: OOZIE-3084
> URL: https://issues.apache.org/jira/browse/OOZIE-3084
> Project: Oozie
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 5.0.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: OOZIE-3084.001.patch
>
>
> In OOZIE-2666, when Oozie has moved from Tomcat to Jetty, we also moved the 
> Tomcat related JVM options inside the startup script {{bin/oozied.sh}} to the 
> more specific {{bin/oozie-jetty-server.sh}}.
> It seems that not all the 
> [*{{catalina_opts}}*|https://github.com/apache/oozie/blob/branch-4.3/distro/src/main/bin/oozied.sh#L54-L74]
>  have been moved to 
> [*{{jetty_opts}}*|https://github.com/apache/oozie/blob/master/distro/src/main/bin/oozie-jetty-server.sh#L70-L86].
>  Such an example is {{oozie.instance.id}}, causing we don't have any server 
> name information within the Oozie server logs.
> So the task is to investigate startup scripts and put missing and needed 
> {{catalina_opts}} to {{jetty_opts}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Failed: OOZIE-3084 PreCommit Build #109

2017-10-13 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/OOZIE-3084
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/109/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1.56 MB...]
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 77 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [server].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 1774
Tests rerun: 23
Tests failed at first run: 
org.apache.oozie.service.TestActionService,org.apache.oozie.service.TestRecoveryService,org.apache.oozie.dependency.TestFSURIHandler,org.apache.oozie.TestDagEngine,org.apache.oozie.service.TestPartitionDependencyManagerService,org.apache.oozie.dependency.TestHCatURIHandler,
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/109/

  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  0 
00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0
100 3706k  100 3706k0 0  4706k  0 --:--:-- --:--:-- --:--:-- 4706k
Adding comment to JIRA
Comment added.

test-patch exit code: 1

Build step 'Execute shell' marked build as failure
[description-setter] Description set: OOZIE-3084
Archiving artifacts
[Fast Archiver] Compressed 1.80 MB of artifacts by 64.4% relative to #108
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (OOZIE-3084) Add missing JVM properties to Jetty startup script

2017-10-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203519#comment-16203519
 ] 

Hadoop QA commented on OOZIE-3084:
--

Testing JIRA OOZIE-3084

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1774
.Tests rerun: 23
.Tests failed at first run: 
org.apache.oozie.service.TestActionService,org.apache.oozie.service.TestRecoveryService,org.apache.oozie.dependency.TestFSURIHandler,org.apache.oozie.TestDagEngine,org.apache.oozie.service.TestPartitionDependencyManagerService,org.apache.oozie.dependency.TestHCatURIHandler,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/109/

> Add missing JVM properties to Jetty startup script
> --
>
> Key: OOZIE-3084
> URL: https://issues.apache.org/jira/browse/OOZIE-3084
> Project: Oozie
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 5.0.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: OOZIE-3084.001.patch
>
>
> In OOZIE-2666, when Oozie has moved from Tomcat to Jetty, we also moved the 
> Tomcat related JVM options inside the startup script {{bin/oozied.sh}} to the 
> more specific {{bin/oozie-jetty-server.sh}}.
> It seems that not all the 
> [*{{catalina_opts}}*|https://github.com/apache/oozie/blob/branch-4.3/distro/src/main/bin/oozied.sh#L54-L74]
>  have been moved to 
> [*{{jetty_opts}}*|https://github.com/apache/oozie/blob/master/distro/src/main/bin/oozie-jetty-server.sh#L70-L86].
>  Such an example is {{oozie.instance.id}}, causing we don't have any server 
> name information within the Oozie server logs.
> So the task is to investigate startup scripts and put missing and needed 
> {{catalina_opts}} to {{jetty_opts}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OOZIE-2600) OYA: Update Documentation

2017-10-13 Thread Andras Piros (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2600:

Description: Based on the work done in OOZIE-2896, document also the way 
how {{oozie.launcher.override.\*}} and {{oozie.launcher.prepend.\*}} parameters 
function.  (was: Based on the work done in OOZIE-2896, document also the way 
how {{oozie.launcher.override.*}} and {{oozie.launcher.prepend.*}} parameters 
function.)

> OYA: Update Documentation
> -
>
> Key: OOZIE-2600
> URL: https://issues.apache.org/jira/browse/OOZIE-2600
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: oya, 5.0.0
>Reporter: Robert Kanter
>Priority: Blocker
> Fix For: oya
>
>
> Based on the work done in OOZIE-2896, document also the way how 
> {{oozie.launcher.override.\*}} and {{oozie.launcher.prepend.\*}} parameters 
> function.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OOZIE-2600) OYA: Update Documentation

2017-10-13 Thread Andras Piros (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2600:

Description: Based on the work done in OOZIE-2896, document also the way 
how {{oozie.launcher.override.*}} and {{oozie.launcher.prepend.*}} parameters 
function.

> OYA: Update Documentation
> -
>
> Key: OOZIE-2600
> URL: https://issues.apache.org/jira/browse/OOZIE-2600
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: oya, 5.0.0
>Reporter: Robert Kanter
>Priority: Blocker
> Fix For: oya
>
>
> Based on the work done in OOZIE-2896, document also the way how 
> {{oozie.launcher.override.*}} and {{oozie.launcher.prepend.*}} parameters 
> function.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OOZIE-3062) Set HADOOP_CONF_DIR for spark action

2017-10-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203429#comment-16203429
 ] 

Hadoop QA commented on OOZIE-3062:
--

Testing JIRA OOZIE-3062

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2039
.Tests rerun: 65
.Tests failed at first run: 
org.apache.oozie.command.coord.TestCoordPushDependencyCheckXCommand,org.apache.oozie.action.hadoop.TestJavaActionExecutor,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/108/

> Set HADOOP_CONF_DIR for spark action
> 
>
> Key: OOZIE-3062
> URL: https://issues.apache.org/jira/browse/OOZIE-3062
> Project: Oozie
>  Issue Type: Bug
>Reporter: Satish Subhashrao Saley
>Assignee: Satish Subhashrao Saley
> Attachments: OOZIE-3062-1.patch, OOZIE-3062-2.patch, 
> OOZIE-3062-3.patch, OOZIE-3062-4.patch, OOZIE-3062-5.patch, OOZIE-3062-6.patch
>
>
> OOZIE-2569 created core-site.xml, hdfs-site.xml, mapred-site.xml, 
> yarn-site.xml for spark action. But for spark to consider these files ([spark 
> code 
> ref|https://github.com/apache/spark/blob/83fe3b5e10f8dc62245ea37143abb96be0f39805/core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala#L284]),
>  we need to set HADOOP_CONF_DIR environmental variable, otherwise it will 
> point to default HADOOP_CONF_DIR configured on the node. Therefore, Oozie 
> should set HADOOP_CONF_DIR.
> Due to a bug YARN-4727, yarn was not considering user specified value for 
> whiltelisted environment variables including HADOOP_CONF_DIR. So, this will 
> work on specified hadoop fix versions in YARN-4727.
> This fix in Oozie will be no-op on Hadoop without YARN-4727 fix and Oozie 
> will behave as it is.
> To verify this on one node machine. 
> 1. In hadoop mapred-site.xml, set 
> {code}
> 
>mapreduce.fileoutputcommitter.marksuccessfuljobs
>false
> 
> {code}
> 2. Run any spark file copy example from Oozie. Check output directory, 
> _SUCCESS flag is missing. It should be there because we explicitly set 
> conf.set("mapreduce.fileoutputcommitter.marksuccessfuljobs", "true"); in 
> 

Success: OOZIE-3062 PreCommit Build #108

2017-10-13 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/OOZIE-3062
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/108/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1.59 MB...]
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 77 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [client].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 2039
Tests rerun: 65
Tests failed at first run: 
org.apache.oozie.command.coord.TestCoordPushDependencyCheckXCommand,org.apache.oozie.action.hadoop.TestJavaActionExecutor,
+1 DISTRO
+1 distro tarball builds with the patch 


+1 Overall result, good!, no -1s

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/108/

  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0
  0 3706k0  86880 0  14057  0  0:04:29 --:--:--  0:04:29 
14057100 3706k  100 3706k0 0  4112k  0 --:--:-- --:--:-- --:--:-- 
12.7M
Adding comment to JIRA
Comment added.

test-patch exit code: 0

[description-setter] Description set: OOZIE-3062
Archiving artifacts
[Fast Archiver] Compressed 1.80 MB of artifacts by 64.4% relative to #107
Recording test results
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Updated] (OOZIE-3084) Add missing JVM properties to Jetty startup script

2017-10-13 Thread Andras Piros (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3084:

Attachment: OOZIE-3084.001.patch

> Add missing JVM properties to Jetty startup script
> --
>
> Key: OOZIE-3084
> URL: https://issues.apache.org/jira/browse/OOZIE-3084
> Project: Oozie
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 5.0.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-3084.001.patch
>
>
> In OOZIE-2666, when Oozie has moved from Tomcat to Jetty, we also moved the 
> Tomcat related JVM options inside the startup script {{bin/oozied.sh}} to the 
> more specific {{bin/oozie-jetty-server.sh}}.
> It seems that not all the 
> [*{{catalina_opts}}*|https://github.com/apache/oozie/blob/branch-4.3/distro/src/main/bin/oozied.sh#L54-L74]
>  have been moved to 
> [*{{jetty_opts}}*|https://github.com/apache/oozie/blob/master/distro/src/main/bin/oozie-jetty-server.sh#L70-L86].
>  Such an example is {{oozie.instance.id}}, causing we don't have any server 
> name information within the Oozie server logs.
> So the task is to investigate startup scripts and put missing and needed 
> {{catalina_opts}} to {{jetty_opts}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OOZIE-3084) Add missing JVM properties to Jetty startup script

2017-10-13 Thread Andras Piros (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203363#comment-16203363
 ] 

Andras Piros commented on OOZIE-3084:
-

It turns out we only need to add {{-Doozie.instance.id}}, every other missing 
parameter is handled within {{oozie-default.xml}}.

JVM parameters w/ the patch:
{noformat}
bash-3.2$ ps ax | grep oozie.instance.id
27823 s003  S  0:20.49 
/Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk/Contents/Home/bin/java
-Doozie.home.dir=/Users/forsage/Workspace/oozie/distro/target/oozie-5.0.0-SNAPSHOT-distro/oozie-5.0.0-SNAPSHOT
 
-Doozie.config.dir=/Users/forsage/Workspace/oozie/distro/target/oozie-5.0.0-SNAPSHOT-distro/oozie-5.0.0-SNAPSHOT/conf
 
-Doozie.log.dir=/Users/forsage/Workspace/oozie/distro/target/oozie-5.0.0-SNAPSHOT-distro/oozie-5.0.0-SNAPSHOT/logs
 
-Doozie.data.dir=/Users/forsage/Workspace/oozie/distro/target/oozie-5.0.0-SNAPSHOT-distro/oozie-5.0.0-SNAPSHOT/data
 
-Doozie.instance.id=Budapests-MacBook-Pro.local 
-Doozie.config.file=oozie-site.xml 
-Doozie.log4j.file=oozie-log4j.properties 
-Doozie.log4j.reload=10 
-Djava.library.path= 
-cp 
/Users/forsage/Workspace/oozie/distro/target/oozie-5.0.0-SNAPSHOT-distro/oozie-5.0.0-SNAPSHOT/embedded-oozie-server/*:/Users/forsage/Workspace/oozie/distro/target/oozie-5.0.0-SNAPSHOT-distro/oozie-5.0.0-SNAPSHOT/embedded-oozie-server/dependency/*:/Users/forsage/Workspace/oozie/distro/target/oozie-5.0.0-SNAPSHOT-distro/oozie-5.0.0-SNAPSHOT/lib/*:/Users/forsage/Workspace/oozie/distro/target/oozie-5.0.0-SNAPSHOT-distro/oozie-5.0.0-SNAPSHOT/libtools/*:/Users/forsage/Workspace/oozie/distro/target/oozie-5.0.0-SNAPSHOT-distro/oozie-5.0.0-SNAPSHOT/embedded-oozie-server
 
org.apache.oozie.server.EmbeddedOozieServer
{noformat}

Excerpt from {{logs/oozie.log}}:
{noformat}
2017-10-13 12:34:55,302  INFO StatusTransitService$StatusTransitRunnable:520 - 
SERVER[Budapests-MacBook-Pro.local] USER[-] GROUP[-] TOKEN[-] APP[-] JOB[-] 
ACTION[-] Running bundle status service from last instance time =  
2017-10-13T10:33Z
2017-10-13 12:34:55,304  INFO StatusTransitService$StatusTransitRunnable:520 - 
SERVER[Budapests-MacBook-Pro.local] USER[-] GROUP[-] TOKEN[-] APP[-] JOB[-] 
ACTION[-] Released lock for [org.apache.oozie.service.StatusTransitService]
{noformat}

> Add missing JVM properties to Jetty startup script
> --
>
> Key: OOZIE-3084
> URL: https://issues.apache.org/jira/browse/OOZIE-3084
> Project: Oozie
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 5.0.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>
> In OOZIE-2666, when Oozie has moved from Tomcat to Jetty, we also moved the 
> Tomcat related JVM options inside the startup script {{bin/oozied.sh}} to the 
> more specific {{bin/oozie-jetty-server.sh}}.
> It seems that not all the 
> [*{{catalina_opts}}*|https://github.com/apache/oozie/blob/branch-4.3/distro/src/main/bin/oozied.sh#L54-L74]
>  have been moved to 
> [*{{jetty_opts}}*|https://github.com/apache/oozie/blob/master/distro/src/main/bin/oozie-jetty-server.sh#L70-L86].
>  Such an example is {{oozie.instance.id}}, causing we don't have any server 
> name information within the Oozie server logs.
> So the task is to investigate startup scripts and put missing and needed 
> {{catalina_opts}} to {{jetty_opts}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OOZIE-3084) Add missing JVM properties to Jetty startup script

2017-10-13 Thread Andras Piros (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros reassigned OOZIE-3084:
---

Assignee: Andras Piros

> Add missing JVM properties to Jetty startup script
> --
>
> Key: OOZIE-3084
> URL: https://issues.apache.org/jira/browse/OOZIE-3084
> Project: Oozie
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 5.0.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>
> In OOZIE-2666, when Oozie has moved from Tomcat to Jetty, we also moved the 
> Tomcat related JVM options inside the startup script {{bin/oozied.sh}} to the 
> more specific {{bin/oozie-jetty-server.sh}}.
> It seems that not all the 
> [*{{catalina_opts}}*|https://github.com/apache/oozie/blob/branch-4.3/distro/src/main/bin/oozied.sh#L54-L74]
>  have been moved to 
> [*{{jetty_opts}}*|https://github.com/apache/oozie/blob/master/distro/src/main/bin/oozie-jetty-server.sh#L70-L86].
>  Such an example is {{oozie.instance.id}}, causing we don't have any server 
> name information within the Oozie server logs.
> So the task is to investigate startup scripts and put missing and needed 
> {{catalina_opts}} to {{jetty_opts}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

2017-10-13 Thread Peter Cseh via Review Board


> On Oct. 12, 2017, 11:36 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> > Lines 1197 (patched)
> > 
> >
> > This is fine to leave for a different JIRA, but we should consider 
> > dropping the "oozie:launcher:" part of the name.  The job type is now 
> > OOZIE, so it's probably redundent and we can shorten the names.

OOZIE-2893


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62936/#review187893
---


On Oct. 12, 2017, 3:33 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62936/
> ---
> 
> (Updated Oct. 12, 2017, 3:33 p.m.)
> 
> 
> Review request for oozie, Attila Sasvari, Peter Cseh, and Peter Bacsko.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2896 Ensure compatibility for existing LauncherMapper settings
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 76d0daa4f7528de6fb3c8993bae4dd28b6f7865b 
>   
> core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationFilter.java
>  PRE-CREATION 
>   core/src/main/resources/oozie-default.xml 
> 2389b993b7b1769521d6dd0c7386e99e7516210a 
>   
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 
> a7bd357f8938d148a150db43135a7a8fe7f0da4c 
>   
> core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherConfigurationFilter.java
>  PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java 
> ee1a32ac9b071009e1dbe78396520d778f58bddc 
> 
> 
> Diff: https://reviews.apache.org/r/62936/diff/1/
> 
> 
> Testing
> ---
> 
> JUnit tests:
> 
> * `TestJavaActionExecutor`
> * `TestLauncherConfigurationFilter`
> 
> Functional tests: submit and run `examples/apps/java-main/workflow.xml` in 
> three modes:
> 
> * only `oozie.launcher.` parameters are present: `oozie.launcher.` parameters 
> are passed through
> * `oozie.launcher.` and override (`yarn.`, `mapreduce.`, and `mapred.`) 
> parameters are also present: `oozie.launcher.` parameters are passed through
> * only override (`yarn.`, `mapreduce.`, and `mapred.`) parameters are 
> present: override parameters are passed through
> 
> 
> Thanks,
> 
> András Piros
> 
>



[jira] [Commented] (OOZIE-2406) Completely rewrite GraphGenerator code

2017-10-13 Thread Andras Piros (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203209#comment-16203209
 ] 

Andras Piros commented on OOZIE-2406:
-

Thanks [~gezapeti] [~rkanter] [~pbacsko] for the reviews! Hopefully everything 
is addressed. Can you have a look?

> Completely rewrite GraphGenerator code
> --
>
> Key: OOZIE-2406
> URL: https://issues.apache.org/jira/browse/OOZIE-2406
> Project: Oozie
>  Issue Type: New Feature
>Affects Versions: 4.2.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: OOZIE-2406.004.patch, OOZIE-2406.004.patch, 
> OOZIE-2406.005.patch, OOZIE-2406.006.patch, OOZIE-2406.007.patch, 
> OOZIE-2406.008.patch, OOZIE-2406.009.patch, OOZIE-2406.010.patch, 
> OOZIE-2406.011.patch, OOZIE-2406.012.patch, OOZIE-2406.012.patch, 
> OOZIE-2406.012.patch, OOZIE-2406.012.patch, OOZIE-2406.012.patch, 
> OOZIE-2406.013.patch, Screen Shot 2017-10-02 at 1.55.58 PM.png, Screen Shot 
> 2017-10-02 at 1.56.33 PM.png, graphviz-10-action-nodes.png, 
> graphviz-25-action-nodes.png, graphviz-50-action-nodes.png, 
> graphviz-many-nodes.png, jung-many-nodes.png
>
>
> The Web UI currently generates a graph of the workflow DAG as a png image 
> that it can show to the user ({{GraphGenerator}} class).  Unfortunately, 
> there are a number of downsides to the current implementation:
> # The image is generated server-side, which doesn't scale well and eats up 
> lots of memory
> #- To help combat this issue, we only generate graphs for workflows with less 
> than 25 nodes and we disabled the refresh button in the UI
> # It's slow
> # It uses a library ({{net.sf.jung}} from http://jung.sourceforge.net), which 
> hasn't been updated since 2010.  
> #- This library also has a dependency on a fork of Commons-Collections 
> ({{net.sourceforge.collections}} from 
> http://sourceforge.net/projects/collections/), which similarly hasn't been 
> updated since 2010.  This is a problem because we can't update 
> Commons-Collections when there are security concerns such as COLLECTIONS-580 
> (though Oozie is *not* susceptible to this attack).
> It would be good to do a complete rewrite, using a different library and 
> remove Jung and the Commons-Collections fork.  Whatever we choose, it should 
> an svg which will draw the image on the browser.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] Subscription: Oozie Patch Available

2017-10-13 Thread jira
Issue Subscription
Filter: Oozie Patch Available (107 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-3083  Make improved version Info backward compatible
https://issues.apache.org/jira/browse/OOZIE-3083
OOZIE-3071  Oozie 4.3 Spark sharelib ueses a different version of commons-lang3 
than Spark 2.2.0
https://issues.apache.org/jira/browse/OOZIE-3071
OOZIE-3063  Sanitizing variables that are part of openjpa.ConnectionProperties
https://issues.apache.org/jira/browse/OOZIE-3063
OOZIE-3062  Set HADOOP_CONF_DIR for spark action
https://issues.apache.org/jira/browse/OOZIE-3062
OOZIE-3022  fix for warning has no file and won't be listed in dependency files 
details
https://issues.apache.org/jira/browse/OOZIE-3022
OOZIE-3002  address findbugs errors in client lib
https://issues.apache.org/jira/browse/OOZIE-3002
OOZIE-3001  core library has many instances of warnings with trailing spaces 
and lines longer than 132 chars
https://issues.apache.org/jira/browse/OOZIE-3001
OOZIE-2997  files contain trailing white spaces in client lib
https://issues.apache.org/jira/browse/OOZIE-2997
OOZIE-2996  add option for -UseGCOverheadLimit to maven opts as sometimes local 
testing fails
https://issues.apache.org/jira/browse/OOZIE-2996
OOZIE-2975  code clean up in pig sharelib, replace Exception with more 
explicit, add try with resources, StringBuilder instead of StringBuffer
https://issues.apache.org/jira/browse/OOZIE-2975
OOZIE-2969  Drop support for Java 1.7
https://issues.apache.org/jira/browse/OOZIE-2969
OOZIE-2964  Add -Xdoclint:none to javadoc opts to avoid warnings
https://issues.apache.org/jira/browse/OOZIE-2964
OOZIE-2962  bump maven-javadoc-plugin to 2.10.4
https://issues.apache.org/jira/browse/OOZIE-2962
OOZIE-2957  Documentation states that starting a coordinator is possible
https://issues.apache.org/jira/browse/OOZIE-2957
OOZIE-2956  Fix Findbugs warnings related to reliance on default encoding in 
oozie-core
https://issues.apache.org/jira/browse/OOZIE-2956
OOZIE-2955  Fix Findbugs warnings related to reliance on default encoding in 
oozie-client
https://issues.apache.org/jira/browse/OOZIE-2955
OOZIE-2954  Fix Checkstyle issues in oozie-client
https://issues.apache.org/jira/browse/OOZIE-2954
OOZIE-2953  Fix Checkstyle issues in oozie-tools
https://issues.apache.org/jira/browse/OOZIE-2953
OOZIE-2952  Fix Findbugs warnings in oozie-sharelib-oozie
https://issues.apache.org/jira/browse/OOZIE-2952
OOZIE-2949  Escape quotes whitespaces in Sqoop  field
https://issues.apache.org/jira/browse/OOZIE-2949
OOZIE-2942  Fix Findbugs warnings in oozie-examples
https://issues.apache.org/jira/browse/OOZIE-2942
OOZIE-2937  Remove redundant groupId from the child pom's
https://issues.apache.org/jira/browse/OOZIE-2937
OOZIE-2934  Fix "Exceptional return value of java.io.File.mkdirs() ignored" 
Findbugs error in oozie-sharelib-spark
https://issues.apache.org/jira/browse/OOZIE-2934
OOZIE-2927  Append new line character for Hive2 query using query tag
https://issues.apache.org/jira/browse/OOZIE-2927
OOZIE-2914  Consolidate Trim 
https://issues.apache.org/jira/browse/OOZIE-2914
OOZIE-2896  Ensure compatibility for existing LauncherMapper settings
https://issues.apache.org/jira/browse/OOZIE-2896
OOZIE-2883  OOZIE throw the error "Missing 
[oozie.service.ProxyUserService.proxyuser.oozie.service.ProxyUserService.proxyuser.mr.groups]
 property"
https://issues.apache.org/jira/browse/OOZIE-2883
OOZIE-2877  Oozie Git Action
https://issues.apache.org/jira/browse/OOZIE-2877
OOZIE-2867  Timezone handling for Coordinators: emphasize "Continent/City" 
format
https://issues.apache.org/jira/browse/OOZIE-2867
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.
https://issues.apache.org/jira/browse/OOZIE-2833
OOZIE-2829  Improve sharelib upload to accept multiple source folders
https://issues.apache.org/jira/browse/OOZIE-2829
OOZIE-2826  Falcon feed fails to aws s3; Oozie joda time version does not meet 
required jar version 2.2 or later
https://issues.apache.org/jira/browse/OOZIE-2826
OOZIE-2812  SparkConfigurationService should support loading configurations 
from multiple Spark versions
https://issues.apache.org/jira/browse/OOZIE-2812
OOZIE-2795  Create lib directory or symlink for Oozie CLI during packaging
https://issues.apache.org/jira/browse/OOZIE-2795
OOZIE-2791  ShareLib installation may fail on busy Hadoop clusters