[jira] Subscription: Oozie Patch Available

[jira]

Issue Subscription
Filter: Oozie Patch Available (93 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-3304  Parsing sharelib timestamps is not threadsafe
https://issues.apache.org/jira/browse/OOZIE-3304
OOZIE-3301  Update NOTICE file
https://issues.apache.org/jira/browse/OOZIE-3301
OOZIE-3298  OYA: external ID is not filled properly and failing MR job is 
treated as SUCCEEDED
https://issues.apache.org/jira/browse/OOZIE-3298
OOZIE-3274  Remove slf4j
https://issues.apache.org/jira/browse/OOZIE-3274
OOZIE-3266  Coord action rerun support RERUN_SKIP_NODES option
https://issues.apache.org/jira/browse/OOZIE-3266
OOZIE-3265  properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to 
appear together
https://issues.apache.org/jira/browse/OOZIE-3265
OOZIE-3256  refactor OozieCLI class
https://issues.apache.org/jira/browse/OOZIE-3256
OOZIE-3249  [tools] Instrumentation log parser
https://issues.apache.org/jira/browse/OOZIE-3249
OOZIE-3229  Improved filtering options in V2SLAServlet
https://issues.apache.org/jira/browse/OOZIE-3229
OOZIE-3218  Oozie Sqoop action with command splits the select clause into 
multiple parts due to delimiter being space
https://issues.apache.org/jira/browse/OOZIE-3218
OOZIE-3199  Let system property restriction configurable
https://issues.apache.org/jira/browse/OOZIE-3199
OOZIE-3196  Authorization: restrict world readability by user
https://issues.apache.org/jira/browse/OOZIE-3196
OOZIE-3194  Oozie should set proper permissions to sharelib after upload
https://issues.apache.org/jira/browse/OOZIE-3194
OOZIE-3193  Applications are not killed when submitted via subworkflow
https://issues.apache.org/jira/browse/OOZIE-3193
OOZIE-3186  Oozie is unable to use configuration linked using jceks://file/...
https://issues.apache.org/jira/browse/OOZIE-3186
OOZIE-3179  Adding a configurable config-default.xml location to a workflow
https://issues.apache.org/jira/browse/OOZIE-3179
OOZIE-3170  Oozie Diagnostic Bundle tool fails with NPE due to missing service 
class
https://issues.apache.org/jira/browse/OOZIE-3170
OOZIE-3160  PriorityDelayQueue put()/take() can cause significant CPU load due 
to busy waiting
https://issues.apache.org/jira/browse/OOZIE-3160
OOZIE-3135  Configure log4j2 in SqoopMain
https://issues.apache.org/jira/browse/OOZIE-3135
OOZIE-3091  Oozie Sqoop Avro Import fails with "java.lang.NoClassDefFoundError: 
org/apache/avro/mapred/AvroWrapper"
https://issues.apache.org/jira/browse/OOZIE-3091
OOZIE-3071  Oozie 4.3 Spark sharelib ueses a different version of commons-lang3 
than Spark 2.2.0
https://issues.apache.org/jira/browse/OOZIE-3071
OOZIE-3063  Sanitizing variables that are part of openjpa.ConnectionProperties
https://issues.apache.org/jira/browse/OOZIE-3063
OOZIE-3062  Set HADOOP_CONF_DIR for spark action
https://issues.apache.org/jira/browse/OOZIE-3062
OOZIE-3061  Kill only those child jobs which are not already killed
https://issues.apache.org/jira/browse/OOZIE-3061
OOZIE-2952  Fix Findbugs warnings in oozie-sharelib-oozie
https://issues.apache.org/jira/browse/OOZIE-2952
OOZIE-2949  Escape quotes whitespaces in Sqoop  field
https://issues.apache.org/jira/browse/OOZIE-2949
OOZIE-2927  Append new line character for Hive2 query using query tag
https://issues.apache.org/jira/browse/OOZIE-2927
OOZIE-2877  Oozie Git Action
https://issues.apache.org/jira/browse/OOZIE-2877
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.
https://issues.apache.org/jira/browse/OOZIE-2833
OOZIE-2812  SparkConfigurationService should support loading configurations 
from multiple Spark versions
https://issues.apache.org/jira/browse/OOZIE-2812
OOZIE-2795  Create lib directory or symlink for Oozie CLI during packaging
https://issues.apache.org/jira/browse/OOZIE-2795
OOZIE-2784  Include WEEK as a parameter in the Coordinator Expression Language 
Evaulator
https://issues.apache.org/jira/browse/OOZIE-2784
OOZIE-2779  Mask Hive2 action Beeline JDBC password
https://issues.apache.org/jira/browse/OOZIE-2779
OOZIE-2736  Reduce the number of threads during test execution
https://issues.apache.org/jira/browse/OOZIE-2736
OOZIE-2734  Switch docs from twiki to markdown
https://issues.apache.org/jira/browse/OOZIE-2734
OOZIE-2714  Detect conflicting resources during class loading
https://issues.apache.org/jira/browse/OOZIE-2714
OOZIE-2694  Add logging for FsActio

[jira] [Commented] (OOZIE-3273) FsAction should fail on retry if destination path exists

[Mate Juhasz (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564770#comment-16564770
 ] 

Mate Juhasz commented on OOZIE-3273:


[~gezapeti], I think the file is there, but [~shubham.chhabra] would like to 
see an error as the move did not occur, because a file with the same name 
already exists.

I tried to reproduce, but I am not familiar with the process when the 
'recovery' param changes to true, could you give a short intro about it? :)

> FsAction should fail on retry if destination path exists
> 
>
> Key: OOZIE-3273
> URL: https://issues.apache.org/jira/browse/OOZIE-3273
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 4.2.0
>Reporter: Shubham
>Priority: Major
>
> This FsAction fails with error code FS008 if the source files already exist 
> in target folder.
> The expected behavior should be that Oozie will try this action once again 
> after 1 minute, and marked the action as failed because the error is still 
> there.
> However, Oozie marks the action as success on retry. (we didn't clean up the 
> target folder)
> Logs:
> {code}
> 2018-05-15 00:08:05,187 INFO ActionStartXCommand:520 - SERVER[mn2.sf.priv] 
> USER[hive] GROUP[-] TOKEN[] APP[sample-wf] 
> JOB[061-180514024838863-oozie-oozi-W] 
> ACTION[061-180514024838863-oozie-oozi-W@loading] Start action 
> [061-180514024838863-oozie-oozi-W@loading] with user-retry state : 
> userRetryCount [0], userRetryMax [2], userRetryInterval [1]
> 2018-05-15 00:08:05,201 WARN ActionStartXCommand:523 - SERVER[mn2.sf.priv] 
> USER[hive] GROUP[-] TOKEN[] APP[sample-wf] 
> JOB[061-180514024838863-oozie-oozi-W] 
> ACTION[061-180514024838863-oozie-oozi-W@loading] Error starting action 
> [load-staging]. ErrorType [ERROR], ErrorCode [FS008], Message [FS008: move, 
> could not move 
> [hdfs://nn:8020/user/hive/audit/data/ingestion/USER_ACCOUNT_AF_A/1522284431816-2018-03-28_1747_11.816-PT2M10.096S-TEST.0-19462_24325-67401946-8fcf-4940-91ec-063016a5da48.avro]
>  to [hdfs://nn:8020/user/hive/audit/data/staging/USER_ACCOUNT_AF_A]]
> org.apache.oozie.action.ActionExecutorException: FS008: move, could not move 
> [hdfs://nn:8020/user/hive/audit/data/ingestion/SAMPLE_WF/1522284431816-2018-03-28_1747_11.816-PT2M10.096S-TEST.0-19462_24325-67401946-8fcf-4940-91ec-063016a5da48.avro]
>  to [hdfs://nn:8020/user/hive/audit/data/staging/USER_ACCOUNT_AF_A]
>  at 
> org.apache.oozie.action.hadoop.FsActionExecutor.move(FsActionExecutor.java:509)
>  at 
> org.apache.oozie.action.hadoop.FsActionExecutor.doOperations(FsActionExecutor.java:199)
>  at 
> org.apache.oozie.action.hadoop.FsActionExecutor.start(FsActionExecutor.java:609)
>  at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:234)
>  at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:65)
>  at org.apache.oozie.command.XCommand.call(XCommand.java:287)
>  at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:331)
>  at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:260)
>  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>  at 
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:178)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  at java.lang.Thread.run(Thread.java:745)
> 2018-05-15 00:08:05,202 WARN ActionStartXCommand:523 - SERVER[mn2.sf.priv] 
> USER[hive] GROUP[-] TOKEN[] APP[sample-wf] 
> JOB[061-180514024838863-oozie-oozi-W] 
> ACTION[061-180514024838863-oozie-oozi-W@loading] Setting Action Status to 
> [DONE]
> 2018-05-15 00:08:05,202 INFO ActionStartXCommand:520 - SERVER[mn2.sf.priv] 
> USER[hive] GROUP[-] TOKEN[] APP[sample-wf] 
> JOB[061-180514024838863-oozie-oozi-W] 
> ACTION[061-180514024838863-oozie-oozi-W@loading] Preparing retry this 
> action [061-180514024838863-oozie-oozi-W@loading], errorCode [FS008], 
> userRetryCount [0], userRetryMax [2], userRetryInterval [1]
> 2018-05-15 00:09:05,254 INFO ActionStartXCommand:520 - SERVER[mn2.sf.priv] 
> USER[hive] GROUP[-] TOKEN[] APP[sample-wf] 
> JOB[061-180514024838863-oozie-oozi-W] 
> ACTION[061-180514024838863-oozie-oozi-W@loading] Start action 
> [061-180514024838863-oozie-oozi-W@loading] with user-retry state : 
> userRetryCount [1], userRetryMax [2], userRetryInterval [1]
> 2018-05-15 00:09:05,276 INFO ActionStartXCommand:520 - SERVER[mn2.sf.priv] 
> USER[hive] GROUP[-] TOKEN[] APP[sample-wf] 
> JOB[061-180514024838863-oozie-oozi-W] 
> ACTION[061-180514024838863-oozie-oozi-W@loading] 
> [***0

Failed: OOZIE-2734 PreCommit Build #707

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-2734
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/707/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.83 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/hive].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/hcatalog].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/sqoop].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/oozie].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/distcp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/spark].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [client].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2458 bytes
[TRACE] Full summary file size is 1399 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-2734

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
-1 the patch contains 3 line(s) with tabs
+1 the patch does not introduce any trailing spaces
-1 the patch contains 282 line(s) longer than 132 characters
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 the patch does not seem to introduce new Javadoc error(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [fluent-job/fluent-job-api].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [client].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 2911
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/707/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0{"self":"https://issues.apache.org/jira/rest/api/2/issue/13019874/comment/16563853","id":"16563853","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=hadoopqa&avatarId=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium&owne

[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563853#comment-16563853
 ] 

Hadoop QA commented on OOZIE-2734:
--


Testing JIRA OOZIE-2734

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:red}-1{color} the patch contains 3 line(s) with tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 282 line(s) longer than 132 
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2911
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/707/



> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> oozie_generated_html_20180731.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563814#comment-16563814
 ] 

Hadoop QA commented on OOZIE-2734:
--


Testing JIRA OOZIE-2734

Cleaning local git workspace



{color:red}-1{color} Patch failed to apply to head of branch




> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> oozie_generated_html_20180731.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-2734 PreCommit Build #708

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-2734
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/708/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 763.27 KB...]
[INFO] 
[INFO] --- maven-resources-plugin:3.0.2:resources (default-resources) @ 
oozie-zookeeper-security-tests ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/zookeeper-security-tests/src/main/resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
oozie-zookeeper-security-tests ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-resources-plugin:3.0.2:resources (default-resources) @ 
oozie-zookeeper-security-tests ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/zookeeper-security-tests/src/main/resources
[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
oozie-zookeeper-security-tests ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:3.0.2:testResources (default-testResources) @ 
oozie-zookeeper-security-tests ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/zookeeper-security-tests/src/test/resources
[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
oozie-zookeeper-security-tests ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 2 source files to 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/zookeeper-security-tests/target/test-classes
[INFO] 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/zookeeper-security-tests/src/test/java/org/apache/oozie/util/TestZKUtilsWithSecurity.java:
 Some input files use or override a deprecated API.
[INFO] 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/zookeeper-security-tests/src/test/java/org/apache/oozie/util/TestZKUtilsWithSecurity.java:
 Recompile with -Xlint:deprecation for details.
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.5:check (default-cli) > :findbugs @ 
oozie-zookeeper-security-tests >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.5:findbugs (findbugs) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.5:check (default-cli) < :findbugs @ 
oozie-zookeeper-security-tests <<<
[INFO] 
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.5:check (default-cli) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Oozie Main 5.1.0-SNAPSHOT ... SUCCESS [  1.688 s]
[INFO] Apache Oozie Fluent Job  SUCCESS [  0.045 s]
[INFO] Apache Oozie Fluent Job API  SUCCESS [ 22.798 s]
[INFO] Apache Oozie Client  SUCCESS [ 14.297 s]
[INFO] Apache Oozie Share Lib Oozie ... SUCCESS [ 11.025 s]
[INFO] Apache Oozie Share Lib HCatalog  SUCCESS [  5.769 s]
[INFO] Apache Oozie Share Lib Distcp .. SUCCESS [  4.674 s]
[INFO] Apache Oozie Core .. SUCCESS [01:15 min]
[INFO] Apache Oozie Share Lib Streaming ... SUCCESS [  7.169 s]
[INFO] Apache Oozie Share Lib Pig . SUCCESS [  6.861 s]
[INFO] Apache Oozie Share Lib Hive  SUCCESS [  8.130 s]
[INFO] Apache Oozie Share Lib Hive 2 .. SUCCESS [  9.357 s]
[INFO] Apache Oozie Share Lib Sqoop ... SUCCESS [  5.633 s]
[INFO] Apache Oozie Examples .. SUCCESS [  8.598 s]
[INFO] Apache Oozie Share Lib Spark ... SUCCESS [ 10.023 s]
[INFO] Apache Oozie Share Lib . SUCCESS [  0.036 s]
[INFO] Apache Oozie Docs .. SUCCESS [  3.066 s]
[INFO] Apache Oozie WebApp  SUCCESS [  8.280 s]
[INFO] Apache Oozie Tools . SUCCESS [ 12.216 s]
[INFO] Apache Oozie MiniOozie . SUCCESS [  1.663 s]
[INFO] Apache Oozie Fluent Job Client . SUCCESS [  0.389 s]
[INFO] Apache Oozie Server  SUCCESS [ 10.308 s]
[INFO] Apache Oozie Distro  SUCCESS [  2.185 s]
[INFO] Apache Oozie ZooKeeper Security Tests 5.1.0-

[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

[Andras Salamon (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563810#comment-16563810
 ] 

Andras Salamon commented on OOZIE-2734:
---

I uploaded a zip which contains the HTML generated from the twiki and from the 
markdown documentation.

> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> oozie_generated_html_20180731.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563804#comment-16563804
 ] 

Hadoop QA commented on OOZIE-2734:
--

PreCommit-OOZIE-Build started


> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> oozie_generated_html_20180731.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-2734) Switch docs from twiki to markdown

[Andras Salamon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Salamon updated OOZIE-2734:
--
Attachment: oozie_generated_html_20180731.zip

> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> oozie_generated_html_20180731.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 67999: Parsing sharelib timestamps is not threadsafe

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67999/#review206660
---




core/src/test/java/org/apache/oozie/service/TestShareLibService.java
Lines 1052 (patched)


Nice catch!


- András Piros


On July 20, 2018, 11 a.m., Denes Bodo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67999/
> ---
> 
> (Updated July 20, 2018, 11 a.m.)
> 
> 
> Review request for oozie and András Piros.
> 
> 
> Bugs: OOZIE-3304
> https://issues.apache.org/jira/browse/OOZIE-3304
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> In rare cases the fNumberFormatException occurs while parsing latest sharelib 
> directory names
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/service/ShareLibService.java a901567 
>   core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 
> 5087505 
>   core/src/test/java/org/apache/oozie/service/TestShareLibService.java 
> d244166 
> 
> 
> Diff: https://reviews.apache.org/r/67999/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Denes Bodo
> 
>

Re: Review Request 67999: Parsing sharelib timestamps is not threadsafe

[Zsombor Gegesy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67999/#review206659
---




core/src/test/java/org/apache/oozie/service/TestShareLibService.java
Lines 1052 (patched)


Please collect the threads in a List, and later call 'join' on each of 
that, otherwise the test function returns earlier than the threads would do 
it's stuff


- Zsombor Gegesy


On July 20, 2018, 11 a.m., Denes Bodo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67999/
> ---
> 
> (Updated July 20, 2018, 11 a.m.)
> 
> 
> Review request for oozie and András Piros.
> 
> 
> Bugs: OOZIE-3304
> https://issues.apache.org/jira/browse/OOZIE-3304
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> In rare cases the fNumberFormatException occurs while parsing latest sharelib 
> directory names
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/service/ShareLibService.java a901567 
>   core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 
> 5087505 
>   core/src/test/java/org/apache/oozie/service/TestShareLibService.java 
> d244166 
> 
> 
> Diff: https://reviews.apache.org/r/67999/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Denes Bodo
> 
>

[jira] [Commented] (OOZIE-3304) Parsing sharelib timestamps is not threadsafe

[Zsombor Gegesy (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563785#comment-16563785
 ] 

Zsombor Gegesy commented on OOZIE-3304:
---

It seems to be a network issue in the tests:

{code}
java.util.concurrent.ExecutionException: java.net.ConnectException: Call From 
asf917.gq1.ygridcore.net/67.195.81.137 to localhost:40116 failed on connection 
exception: java.net.ConnectException: Connection refused; For more details see: 
 http://wiki.apache.org/hadoop/ConnectionRefused
at java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.util.concurrent.FutureTask.get(FutureTask.java:192)
at 
org.apache.oozie.tools.TestCopyTaskCallable.performAndCheckCallCopyTask(TestCopyTaskCallable.java:130)
at 
org.apache.oozie.tools.TestCopyTaskCallable.testCallCopyTaskMoreFilesThanThreads(TestCopyTaskCallable.java:100)
{code}

The thread local variable initialization only happens, when it first accessed, 
so just creating hundreds of threads, shouldn't create hundreds of new 
SimpleDateFormat, and shouldn't trigger timeouts.

> Parsing sharelib timestamps is not threadsafe
> -
>
> Key: OOZIE-3304
> URL: https://issues.apache.org/jira/browse/OOZIE-3304
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0b1, 4.3.1
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Critical
>  Labels: usability
> Attachments: OOZIE-3304-001.patch, OOZIE-3304-002.patch
>
>
> In rare cases the following Exception can be read in log files when an action 
> fails:
> {code:java}
> org.apache.oozie.action.ActionExecutorException: NumberFormatException: 
> multiple points
>   at 
> org.apache.oozie.action.ActionExecutor.convertException(ActionExecutor.java:446)
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:1271)
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.start(JavaActionExecutor.java:1472)
>   at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:234)
>   at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:65)
>   at org.apache.oozie.command.XCommand.call(XCommand.java:287)
>   at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:332)
>   at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:261)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:179)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.NumberFormatException: multiple points
>   at 
> sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1890)
>   at sun.misc.FloatingDecimal.parseDouble(FloatingDecimal.java:110)
>   at java.lang.Double.parseDouble(Double.java:538)
>   at java.text.DigitList.getDouble(DigitList.java:169)
>   at java.text.DecimalFormat.parse(DecimalFormat.java:2056)
>   at java.text.SimpleDateFormat.subParse(SimpleDateFormat.java:2160)
>   at java.text.SimpleDateFormat.parse(SimpleDateFormat.java:1514)
>   at java.text.DateFormat.parse(DateFormat.java:364)
>   at 
> org.apache.oozie.service.ShareLibService.getLatestLibPath(ShareLibService.java:727)
>   at 
> org.apache.oozie.service.ShareLibService.getShareLibRootPath(ShareLibService.java:595)
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.getSharelibRoot(JavaActionExecutor.java:1297)
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.initShareLibExcluder(JavaActionExecutor.java:858)
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.setLibFilesArchives(JavaActionExecutor.java:866)
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:1156)
>   ... 11 more
> {code}
> or
> {code:java}
> 2018-07-12 04:48:52,649  WARN ForkedActionStartXCommand:523 - 
> SERVER[ctr-e138-1518143905142-410551-01-03.hwx.site] USER[user] GROUP[-] 
> TOKEN[] APP[demo-wf] JOB[023-180712043119670-oozie-oozi-W] 
> ACTION[023-180712043119670-oozie-oozi-W@streaming-node] Error starting 
> action [streaming-node]. ErrorType [ERROR], ErrorCode 
> [NumberFormatException], Message [NumberFormatException: For input string: ""]
> org.apache.oozie.action.ActionExecutorException: NumberFormatException: For 
> input string: ""
>   at 
> org.apache.oozie.action.

[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

[Andras Salamon (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563727#comment-16563727
 ] 

Andras Salamon commented on OOZIE-2734:
---

A few comments about my patch:
 * I've updated quite a few maven plugins used during the site creation, so we 
also address OOZIE-3164
 * A customised version of the twiki pugin was used for HTML creation (because 
of special colors and table of contents), there is no need for a customised 
plugin for markdown
 * To avoid using a customised plugin I've changed a few header formatting 
levels. For instance twiki was using a header3 sometimes with a special flag to 
avoid the header to appear in the table of contents. I use a simple bold 
formatting instead.
 * HTML generation from Markdown is quite strict compared to the HTML 
generation from Twiki. If the input file is not syntactically correct sometimes 
it just gives an error message instead of creating a semi-correct HTML file.

> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563725#comment-16563725
 ] 

Hadoop QA commented on OOZIE-2734:
--

PreCommit-OOZIE-Build started


> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-2734) Switch docs from twiki to markdown

[Andras Salamon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Salamon updated OOZIE-2734:
--
Attachment: OOZIE-2734-2.patch

> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3160) PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563585#comment-16563585
 ] 

Hadoop QA commented on OOZIE-3160:
--


Testing JIRA OOZIE-3160

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:red}-1 RAT{color}
.{color:red}-1{color} the patch seems to introduce 2 new RAT warning(s)
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [3] new bugs found below threshold in total that 
must be fixed.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:red}-1{color} There are [3] new bugs found below threshold in [core] 
that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
. The most important FindBugs errors are:
. At AsyncXCommandExecutor.java:[line 177]: 
org.apache.oozie.service.AsyncXCommandExecutor$AccessibleRunnableScheduledFuture
 defines compareTo(Object) and uses Object.equals()
. At AsyncXCommandExecutor.java:[lines 177-233]: Should 
org.apache.oozie.service.AsyncXCommandExecutor$AccessibleRunnableScheduledFuture
 be a _static_ inner class?
. At AsyncXCommandExecutor.java:[lines 169-172]: 
org.apache.oozie.service.AsyncXCommandExecutor$PriorityComparator implements 
Comparator but not Serializable
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2920
.{color:orange}Tests failed at first run:{color}
TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/706/



> PriorityDelayQueue put()/take() can cause significant CPU load due to busy 
> waiting
> --
>
> Key: OOZIE-3160
> URL: https://issues.apache.org/jira/browse/OOZIE-3160
> Project: Oozie
>  Issue Type: Bug
>  Components: core
> Environment: all platforms
>Reporter: jj
>Assignee: Peter Bacsko
>Priority: Major
> Attachments: 11.png, 22.png, 
> OOZIE-3160-POC01.patch, OOZIE-3160-POC02.patch, OOZIE-3160-POC02.patch, 
> OOZIE-3160-POC03.patch, OOZIE-3160-POC04.patch, PriorityDelayQueue 
> improvement - OOZIE-3160.pdf
>
>
> oozie 

Failed: OOZIE-3160 PreCommit Build #706

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-3160
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/706/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.73 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/distcp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/spark].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [client].
[ERROR] There are [3] new bugs found below threshold in total that must be 
fixed.
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 3153 bytes
[TRACE] Full summary file size is 2104 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3160

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch adds/modifies 1 testcase(s)
-1 RAT
-1 the patch seems to introduce 2 new RAT warning(s)
+1 JAVADOC
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 the patch does not seem to introduce new Javadoc error(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
-1 There are [3] new bugs found below threshold in total that must be fixed.
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [webapp].
 -1 There are [3] new bugs found below threshold in [core] that must be fixed.
 You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
 The most important FindBugs errors are:
 At AsyncXCommandExecutor.java:[line 177]: 
org.apache.oozie.service.AsyncXCommandExecutor$AccessibleRunnableScheduledFuture
 defines compareTo(Object) and uses Object.equals()
 At AsyncXCommandExecutor.java:[lines 177-233]: Should 
org.apache.oozie.service.AsyncXCommandExecutor$AccessibleRunnableScheduledFuture
 be a _static_ inner class?
 At AsyncXCommandExecutor.java:[lines 169-172]: 
org.apache.oozie.service.AsyncXCommandExecutor$PriorityComparator implements 
Comparator but not Serializable
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [fluent-job/fluent-job-api].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [client].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 2920
Tests failed at first run:
TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/706/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0{"self":"https://issues.apache.org/jira/rest/api/2/issue/13130774/comment/16563585","id":"16563585","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.a

[jira] [Commented] (OOZIE-3310) SQL error during /v2/sla filtering

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563506#comment-16563506
 ] 

Andras Piros commented on OOZIE-3310:
-

Thanks for the contribution [~asalamon74]! +1

> SQL error during /v2/sla filtering
> --
>
> Key: OOZIE-3310
> URL: https://issues.apache.org/jira/browse/OOZIE-3310
> Project: Oozie
>  Issue Type: Bug
>  Components: client
>Affects Versions: 5.1.0
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Minor
> Attachments: OOZIE-3310-1.patch, OOZIE-3310-2.patch, 
> OOZIE-3310-3.patch
>
>
> Filtering for both the id and the bundle field using /v2/sla servlet gives an 
> SQL error:
> {noformat}
> // 20180726124649
> // 
> http://localhost:11000/oozie/v2/sla?timezone=GMT&filter=id=001-180726123600112-oozie-andr-C;bundle=000-180726123600112-oozie-andr-B
> {
> "errorMessage": "E0603: SQL error in operation, "Encountered 
> "." at character 63, but expected: ["*", "+", 
> "-", "/", "GROUP", "HAVING", 
> "ORDER", ]." while parsing JPQL "SELECT 
> OBJECT(s) FROM SLASummaryBean s WHERE s.jobId = :jobIds.parentId in 
> (:parentId0) ORDER BY s.nominalTimeTS". See nested stack trace for 
> original parse error.",
> "httpStatusCode": 500
> }{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3160) PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563469#comment-16563469
 ] 

Hadoop QA commented on OOZIE-3160:
--

PreCommit-OOZIE-Build started


> PriorityDelayQueue put()/take() can cause significant CPU load due to busy 
> waiting
> --
>
> Key: OOZIE-3160
> URL: https://issues.apache.org/jira/browse/OOZIE-3160
> Project: Oozie
>  Issue Type: Bug
>  Components: core
> Environment: all platforms
>Reporter: jj
>Assignee: Peter Bacsko
>Priority: Major
> Attachments: 11.png, 22.png, 
> OOZIE-3160-POC01.patch, OOZIE-3160-POC02.patch, OOZIE-3160-POC02.patch, 
> OOZIE-3160-POC03.patch, OOZIE-3160-POC04.patch, PriorityDelayQueue 
> improvement - OOZIE-3160.pdf
>
>
> oozie process always  consume  high cpu. in my mechine,around 10%. 
> I check the source code，find take() method in PriorityDelayQueue class。
> code:
> {code:java}
> public QueueElement take() throws InterruptedException {
> QueueElement e = poll();
> while (e == null) {
> Thread.sleep(10);
> e = poll();
> }
> return e;
> }
> {code}
> i think it's the reason of this problem. it's keep while, not await.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

[Peter Bacsko via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/
---

(Updated júl. 31, 2018, 11 de)


Review request for oozie, András Piros and Robert Kanter.


Changes
---

Added new tests to TestCallableQueueService


Repository: oozie-git


Description
---

Still just a POC.

Tests are almost completely missing.


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/CallableAccess.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java 
ef8d58da5 
  core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c 
  core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 
9c2a11d6f 


Diff: https://reviews.apache.org/r/67885/diff/4/

Changes: https://reviews.apache.org/r/67885/diff/3-4/


Testing
---

Executed TestCallableQueueService which passed completely.


Thanks,

Peter Bacsko

[jira] [Updated] (OOZIE-3160) PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

[Peter Bacsko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Bacsko updated OOZIE-3160:

Attachment: OOZIE-3160-POC04.patch

> PriorityDelayQueue put()/take() can cause significant CPU load due to busy 
> waiting
> --
>
> Key: OOZIE-3160
> URL: https://issues.apache.org/jira/browse/OOZIE-3160
> Project: Oozie
>  Issue Type: Bug
>  Components: core
> Environment: all platforms
>Reporter: jj
>Assignee: Peter Bacsko
>Priority: Major
> Attachments: 11.png, 22.png, 
> OOZIE-3160-POC01.patch, OOZIE-3160-POC02.patch, OOZIE-3160-POC02.patch, 
> OOZIE-3160-POC03.patch, OOZIE-3160-POC04.patch, PriorityDelayQueue 
> improvement - OOZIE-3160.pdf
>
>
> oozie process always  consume  high cpu. in my mechine,around 10%. 
> I check the source code，find take() method in PriorityDelayQueue class。
> code:
> {code:java}
> public QueueElement take() throws InterruptedException {
> QueueElement e = poll();
> while (e == null) {
> Thread.sleep(10);
> e = poll();
> }
> return e;
> }
> {code}
> i think it's the reason of this problem. it's keep while, not await.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3310) SQL error during /v2/sla filtering

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563463#comment-16563463
 ] 

Hadoop QA commented on OOZIE-3310:
--


Testing JIRA OOZIE-3310

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that 
must be fixed.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:red}-1{color} There are [1] new bugs found below threshold in [core] 
that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
. The most important FindBugs errors are:
. At SLASummaryGetForFilterJPAExecutor.java:[line 200]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
. At SLASummaryGetForFilterJPAExecutor.java:[line 177]: At 
SLASummaryGetForFilterJPAExecutor.java:[line 167]
. At SLASummaryGetForFilterJPAExecutor.java:[line 197]: At 
SLASummaryGetForFilterJPAExecutor.java:[line 192]
. At SLASummaryGetForFilterJPAExecutor.java:[line 200]
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2911
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/705/



> SQL error during /v2/sla filtering
> --
>
> Key: OOZIE-3310
> URL: https://issues.apache.org/jira/browse/OOZIE-3310
> Project: Oozie
>  Issue Type: Bug
>  Components: client
>Affects Versions: 5.1.0
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Minor
> Attachments: OOZIE-3310-1.patch, OOZIE-3310-2.patch, 
> OOZIE-3310-3.patch
>
>
> Filtering for both the id and the bundle field using /v2/sla servlet gives an 
> SQL error:
> {noformat}
> // 20180726124649
> // 
> http://localhost:11000/oozie/v2/sla?timezone=GMT&filter=id=001-180726123600112-oozie-andr-C;bundle=000-180726123600112-oozie-andr-B
> {
> "errorMessage": "E0603: SQL error in operation, "Encountered 
> "." at character 63, but expected: ["*", "+", 
> "-", "/", "GROUP", "HAVING", 
> "ORDER", ]." while parsing JPQL "SE

Failed: OOZIE-3310 PreCommit Build #705

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-3310
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/705/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.75 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/oozie].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/distcp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/spark].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [client].
[ERROR] There are [1] new bugs found below threshold in total that must be 
fixed.
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 3133 bytes
[TRACE] Full summary file size is 2076 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3310

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 the patch does not seem to introduce new Javadoc error(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
-1 There are [1] new bugs found below threshold in total that must be fixed.
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [webapp].
 -1 There are [1] new bugs found below threshold in [core] that must be fixed.
 You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
 The most important FindBugs errors are:
 At SLASummaryGetForFilterJPAExecutor.java:[line 200]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
 At SLASummaryGetForFilterJPAExecutor.java:[line 177]: At 
SLASummaryGetForFilterJPAExecutor.java:[line 167]
 At SLASummaryGetForFilterJPAExecutor.java:[line 197]: At 
SLASummaryGetForFilterJPAExecutor.java:[line 192]
 At SLASummaryGetForFilterJPAExecutor.java:[line 200]
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [fluent-job/fluent-job-api].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [client].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 2911
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/705/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0{"self":"https://issues.apache.org/jira/rest/api/2/issue/13174795/comment/16563463","id":"16563463","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&ava

[jira] [Assigned] (OOZIE-3178) ./bin/mkdistro.sh -Papache-release fails due to javadoc errors

[Peter Cseh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Cseh reassigned OOZIE-3178:
-

Assignee: Peter Cseh  (was: Artem Ervits)

> ./bin/mkdistro.sh -Papache-release fails due to javadoc errors
> --
>
> Key: OOZIE-3178
> URL: https://issues.apache.org/jira/browse/OOZIE-3178
> Project: Oozie
>  Issue Type: Bug
>  Components: build
>Affects Versions: 5.0.0
>Reporter: Peter Cseh
>Assignee: Peter Cseh
>Priority: Blocker
> Fix For: 5.1.0
>
> Attachments: JAVADOC-patch.txt, OOZIE-3178-00.patch, 
> OOZIE-3178-01.patch, OOZIE-3178-02.patch
>
>
> The distro creation script fails if it's called using the profile 
> apache-release.
> The first batch of errors are javadoc-related.
> We should fix them and also enhance our pre-commit hook to prevent this from 
> happening in the future.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3310) SQL error during /v2/sla filtering

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563353#comment-16563353
 ] 

Hadoop QA commented on OOZIE-3310:
--

PreCommit-OOZIE-Build started


> SQL error during /v2/sla filtering
> --
>
> Key: OOZIE-3310
> URL: https://issues.apache.org/jira/browse/OOZIE-3310
> Project: Oozie
>  Issue Type: Bug
>  Components: client
>Affects Versions: 5.1.0
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Minor
> Attachments: OOZIE-3310-1.patch, OOZIE-3310-2.patch, 
> OOZIE-3310-3.patch
>
>
> Filtering for both the id and the bundle field using /v2/sla servlet gives an 
> SQL error:
> {noformat}
> // 20180726124649
> // 
> http://localhost:11000/oozie/v2/sla?timezone=GMT&filter=id=001-180726123600112-oozie-andr-C;bundle=000-180726123600112-oozie-andr-B
> {
> "errorMessage": "E0603: SQL error in operation, "Encountered 
> "." at character 63, but expected: ["*", "+", 
> "-", "/", "GROUP", "HAVING", 
> "ORDER", ]." while parsing JPQL "SELECT 
> OBJECT(s) FROM SLASummaryBean s WHERE s.jobId = :jobIds.parentId in 
> (:parentId0) ORDER BY s.nominalTimeTS". See nested stack trace for 
> original parse error.",
> "httpStatusCode": 500
> }{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563348#comment-16563348
 ] 

Hadoop QA commented on OOZIE-1624:
--


Testing JIRA OOZIE-1624

Cleaning local git workspace



{color:red}-1{color} Patch failed to apply to head of branch




> Exclusion pattern for sharelib JARs
> ---
>
> Key: OOZIE-1624
> URL: https://issues.apache.org/jira/browse/OOZIE-1624
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: 4.3.1
>Reporter: Purshotam Shah
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, 
> OOZIE-1624-V4.patch, OOZIE-1624-v1.patch
>
>
> Sharelib may bring some jar which might conflict with user jars.
> Ex. Sharelib hive has json-2..jar, where as some of the user use-case 
> need higher version of json jar.
> He should be able to exclude sharelib json jar and bring his own version.
> 
> oozie.action.sharelib.for.hive.exclusion
> json-\*.jar|abc-*.jar
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-1624 PreCommit Build #704

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-1624
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/704/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 764.51 KB...]
[INFO] --- maven-resources-plugin:3.0.2:testResources (default-testResources) @ 
oozie-zookeeper-security-tests ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/zookeeper-security-tests/src/test/resources
[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
oozie-zookeeper-security-tests ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 2 source files to 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/zookeeper-security-tests/target/test-classes
[INFO] 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/zookeeper-security-tests/src/test/java/org/apache/oozie/util/TestZKUtilsWithSecurity.java:
 Some input files use or override a deprecated API.
[INFO] 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/zookeeper-security-tests/src/test/java/org/apache/oozie/util/TestZKUtilsWithSecurity.java:
 Recompile with -Xlint:deprecation for details.
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.5:check (default-cli) > :findbugs @ 
oozie-zookeeper-security-tests >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.5:findbugs (findbugs) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.5:check (default-cli) < :findbugs @ 
oozie-zookeeper-security-tests <<<
[INFO] 
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.5:check (default-cli) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Oozie Main 5.1.0-SNAPSHOT ... SUCCESS [  1.657 s]
[INFO] Apache Oozie Fluent Job  SUCCESS [  0.046 s]
[INFO] Apache Oozie Fluent Job API  SUCCESS [ 22.808 s]
[INFO] Apache Oozie Client  SUCCESS [ 14.052 s]
[INFO] Apache Oozie Share Lib Oozie ... SUCCESS [ 11.078 s]
[INFO] Apache Oozie Share Lib HCatalog  SUCCESS [  5.490 s]
[INFO] Apache Oozie Share Lib Distcp .. SUCCESS [  4.635 s]
[INFO] Apache Oozie Core .. SUCCESS [01:14 min]
[INFO] Apache Oozie Share Lib Streaming ... SUCCESS [  7.874 s]
[INFO] Apache Oozie Share Lib Pig . SUCCESS [  7.332 s]
[INFO] Apache Oozie Share Lib Hive  SUCCESS [  7.731 s]
[INFO] Apache Oozie Share Lib Hive 2 .. SUCCESS [  8.683 s]
[INFO] Apache Oozie Share Lib Sqoop ... SUCCESS [  5.478 s]
[INFO] Apache Oozie Examples .. SUCCESS [  8.542 s]
[INFO] Apache Oozie Share Lib Spark ... SUCCESS [  9.802 s]
[INFO] Apache Oozie Share Lib . SUCCESS [  0.057 s]
[INFO] Apache Oozie Docs .. SUCCESS [  3.128 s]
[INFO] Apache Oozie WebApp  SUCCESS [  8.189 s]
[INFO] Apache Oozie Tools . SUCCESS [ 12.170 s]
[INFO] Apache Oozie MiniOozie . SUCCESS [  1.773 s]
[INFO] Apache Oozie Fluent Job Client . SUCCESS [  0.512 s]
[INFO] Apache Oozie Server  SUCCESS [ 10.674 s]
[INFO] Apache Oozie Distro  SUCCESS [  2.433 s]
[INFO] Apache Oozie ZooKeeper Security Tests 5.1.0-SNAPSHOT SUCCESS [  3.391 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 03:53 min
[INFO] Finished at: 2018-07-31T09:16:24Z
[INFO] 
[TRACE] FindBugs output in HEAD verified and saved
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO

Applying patch

Checking patch 
a/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java => 
b/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java...
error: 
a/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java: No 
such file or directory
Checking patch 
a/core/src/test/java/org/apache/oozie/service/TestShareLibService.java => 
b/core/src/test/java/org/apache/oozie/service/TestShareLibService.java...
error: a/core/src/test/java/org/apache/oozie/service/TestShareLibService.java: 
No such file or directory
Checking patch 
core/

[jira] [Commented] (OOZIE-3310) SQL error during /v2/sla filtering

[Andras Salamon (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563347#comment-16563347
 ] 

Andras Salamon commented on OOZIE-3310:
---

I've uploaded a new patch to fix the long lines problem. I'll address the 
FindBugs issues in OOZIE-3229 .

> SQL error during /v2/sla filtering
> --
>
> Key: OOZIE-3310
> URL: https://issues.apache.org/jira/browse/OOZIE-3310
> Project: Oozie
>  Issue Type: Bug
>  Components: client
>Affects Versions: 5.1.0
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Minor
> Attachments: OOZIE-3310-1.patch, OOZIE-3310-2.patch, 
> OOZIE-3310-3.patch
>
>
> Filtering for both the id and the bundle field using /v2/sla servlet gives an 
> SQL error:
> {noformat}
> // 20180726124649
> // 
> http://localhost:11000/oozie/v2/sla?timezone=GMT&filter=id=001-180726123600112-oozie-andr-C;bundle=000-180726123600112-oozie-andr-B
> {
> "errorMessage": "E0603: SQL error in operation, "Encountered 
> "." at character 63, but expected: ["*", "+", 
> "-", "/", "GROUP", "HAVING", 
> "ORDER", ]." while parsing JPQL "SELECT 
> OBJECT(s) FROM SLASummaryBean s WHERE s.jobId = :jobIds.parentId in 
> (:parentId0) ORDER BY s.nominalTimeTS". See nested stack trace for 
> original parse error.",
> "httpStatusCode": 500
> }{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3310) SQL error during /v2/sla filtering

[Andras Salamon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Salamon updated OOZIE-3310:
--
Attachment: OOZIE-3310-3.patch

> SQL error during /v2/sla filtering
> --
>
> Key: OOZIE-3310
> URL: https://issues.apache.org/jira/browse/OOZIE-3310
> Project: Oozie
>  Issue Type: Bug
>  Components: client
>Affects Versions: 5.1.0
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Minor
> Attachments: OOZIE-3310-1.patch, OOZIE-3310-2.patch, 
> OOZIE-3310-3.patch
>
>
> Filtering for both the id and the bundle field using /v2/sla servlet gives an 
> SQL error:
> {noformat}
> // 20180726124649
> // 
> http://localhost:11000/oozie/v2/sla?timezone=GMT&filter=id=001-180726123600112-oozie-andr-C;bundle=000-180726123600112-oozie-andr-B
> {
> "errorMessage": "E0603: SQL error in operation, "Encountered 
> "." at character 63, but expected: ["*", "+", 
> "-", "/", "GROUP", "HAVING", 
> "ORDER", ]." while parsing JPQL "SELECT 
> OBJECT(s) FROM SLASummaryBean s WHERE s.jobId = :jobIds.parentId in 
> (:parentId0) ORDER BY s.nominalTimeTS". See nested stack trace for 
> original parse error.",
> "httpStatusCode": 500
> }{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563339#comment-16563339
 ] 

Hadoop QA commented on OOZIE-1624:
--

PreCommit-OOZIE-Build started


> Exclusion pattern for sharelib JARs
> ---
>
> Key: OOZIE-1624
> URL: https://issues.apache.org/jira/browse/OOZIE-1624
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: 4.3.1
>Reporter: Purshotam Shah
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, 
> OOZIE-1624-V4.patch, OOZIE-1624-v1.patch
>
>
> Sharelib may bring some jar which might conflict with user jars.
> Ex. Sharelib hive has json-2..jar, where as some of the user use-case 
> need higher version of json jar.
> He should be able to exclude sharelib json jar and bring his own version.
> 
> oozie.action.sharelib.for.hive.exclusion
> json-\*.jar|abc-*.jar
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3310) SQL error during /v2/sla filtering

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563323#comment-16563323
 ] 

Hadoop QA commented on OOZIE-3310:
--


Testing JIRA OOZIE-3310

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 2 line(s) longer than 132 
characters
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
error(s)
.{color:red}ERROR{color}: the current HEAD has 2 Javadoc error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that 
must be fixed.
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:red}-1{color} There are [1] new bugs found below threshold in [core] 
that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
. The most important FindBugs errors are:
. At SLASummaryGetForFilterJPAExecutor.java:[line 200]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
. At SLASummaryGetForFilterJPAExecutor.java:[line 177]: At 
SLASummaryGetForFilterJPAExecutor.java:[line 167]
. At SLASummaryGetForFilterJPAExecutor.java:[line 197]: At 
SLASummaryGetForFilterJPAExecutor.java:[line 192]
. At SLASummaryGetForFilterJPAExecutor.java:[line 200]
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2911
.{color:orange}Tests failed at first run:{color}
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/703/



> SQL error during /v2/sla filtering
> --
>
> Key: OOZIE-3310
> URL: https://issues.apache.org/jira/browse/OOZIE-3310
> Project: Oozie
>  Issue Type: Bug
>  Components: client
>Affects Versions: 5.1.0
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Minor
> Attachments: OOZIE-3310-1.patch, OOZIE-3310-2.patch
>
>
> Filtering for both the id and the bundle field using /v2/sla servlet gives an 
> SQL error:
> {noformat}
> // 20180726124649
> // 
> http://localhost:11000/oozie/v2/sla?timezone=GMT&filter=id=001-180726123600112-oozie-andr-C;bundle=000-180726123600112-oozie-andr-B
> {
> "errorMessage": "E0603: SQL error in operation, "Encountered 
> "." at character 63, but ex

Failed: OOZIE-3310 PreCommit Build #703

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-3310
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/703/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.75 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [examples].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [docs].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[ERROR] There are [1] new bugs found below threshold in total that must be 
fixed.
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 3125 bytes
[TRACE] Full summary file size is 2076 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3310

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
-1 the patch contains 2 line(s) longer than 132 characters
+1 the patch adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warning(s)
+1 the patch does not seem to introduce new Javadoc error(s)
ERROR: the current HEAD has 2 Javadoc error(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
-1 There are [1] new bugs found below threshold in total that must be fixed.
 +1 There are no new bugs found in [webapp].
 -1 There are [1] new bugs found below threshold in [core] that must be fixed.
 You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
 The most important FindBugs errors are:
 At SLASummaryGetForFilterJPAExecutor.java:[line 200]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
 At SLASummaryGetForFilterJPAExecutor.java:[line 177]: At 
SLASummaryGetForFilterJPAExecutor.java:[line 167]
 At SLASummaryGetForFilterJPAExecutor.java:[line 197]: At 
SLASummaryGetForFilterJPAExecutor.java:[line 192]
 At SLASummaryGetForFilterJPAExecutor.java:[line 200]
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [fluent-job/fluent-job-api].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [server].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 2911
Tests failed at first run:
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)


The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/703/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0{"self":"https://issues.apache.org/jira/rest/api/2/issue/13174795/comment/16563323","id":"16563323","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","1

[jira] [Commented] (OOZIE-3265) properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear together

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563321#comment-16563321
 ] 

Andras Piros commented on OOZIE-3265:
-

[~txsing] can you please have a look at the failing unit tests 
{{TestErrorCode#testEscapedSingleQuotes()}} and 
{{TestDagEngine#testValidateReRunConfiguration()}}? Thanks!

> properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear 
> together
> --
>
> Key: OOZIE-3265
> URL: https://issues.apache.org/jira/browse/OOZIE-3265
> Project: Oozie
>  Issue Type: Task
>Affects Versions: 5.0.0
>Reporter: TIAN XING
>Assignee: TIAN XING
>Priority: Minor
> Attachments: OOZIE-3265-v1.patch, OOZIE-3265-v2.patch, 
> OOZIE-3265-v3.patch, rerun.patch
>
>
> Currently when you re-run a workflow with property "oozie.wf.rerun.failnodes" 
>  set to true,
> you can no longer re-run it again with "oozie.wf.rerun.skip.nodes" property 
> specified, even if you set "oozie.wf.rerun.failnodes" to false.
> This kind of limitation is not reasonable. There is only one case where 
> "oozie.wf.rerun.failnodes" is true and "oozie.wf.rerun.skip.nodes" is not 
> null or empty, that should be disallowed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68008: OOZIE-2942 [examples] Fix Findbugs warnings

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68008/#review206650
---


Ship it!




Ship It!

- András Piros


On July 22, 2018, 1:16 p.m., Kinga Marton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68008/
> ---
> 
> (Updated July 22, 2018, 1:16 p.m.)
> 
> 
> Review request for oozie, András Piros and Peter Cseh.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Currently Findbugs complains about the following warnings in the 
> oozie-examples module:
> ```
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close 
> stream on exception [org.apache.oozie.example.DateList] At 
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in 
> org.apache.oozie.example.DateList.main(String[]) 
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At 
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method 
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called 
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource 
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues 
> at LocalOozieExample.java:[line 76]Path continues at 
> LocalOozieExample.java:[line 77]Path continues at 
> LocalOozieExample.java:[line 78]Path continues at 
> LocalOozieExample.java:[line 81]Path continues at 
> LocalOozieExample.java:[line 88]Path continues at 
> LocalOozieExample.java:[line 89]Path continues at 
> LocalOozieExample.java:[line 91]Path continues at 
> LocalOozieExample.java:[line 
 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to close stream [org.apache.oozie.example.LocalOozieExample] At 
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal 
> representation by returning Repeatable.baseline 
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose 
> internal representation by storing an externally mutable object into 
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At 
> Repeatable.java:[line 172]
> ```
> 
> They should be fixed to get the code more reliable.
> 
> 
> Diffs
> -
> 
>   examples/src/main/java/org/apache/oozie/example/DateList.java 7e574cbe 
>   examples/src/main/java/org/apache/oozie/example/LocalOozieExample.java 
> c9f5697c 
>   examples/src/main/java/org/apache/oozie/example/Repeatable.java ee863251 
> 
> 
> Diff: https://reviews.apache.org/r/68008/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>

[jira] [Updated] (OOZIE-3311) [fluent-job] Create an ActionMarshaller

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3311:

Affects Version/s: 5.1.0

> [fluent-job] Create an ActionMarshaller
> ---
>
> Key: OOZIE-3311
> URL: https://issues.apache.org/jira/browse/OOZIE-3311
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: 5.1.0
>Reporter: Mate Juhasz
>Assignee: Mate Juhasz
>Priority: Major
>
> It would be handy to create action xmls in unit tests via the Fluent-Job API, 
> thus an "action to xml" conversion could be implemented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3311) [fluent-job] Create an ActionMarshaller

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563308#comment-16563308
 ] 

Andras Piros commented on OOZIE-3311:
-

Good idea [~matijhs]! Those {{ActionMarshaller}} classes could reside in 
{{org.apache.fluentjob.api.serialization}} package, and could share some 
functionality of the existing {{WorkflowMarshaller}}.

Interesting question is the handling of the XML namespaces, see 
{{WorkflowMarshaller#filterPackages()}}. Another detail to bear in mind can be 
generalizing the method signature (instead of overriding the method any single 
time we need a new {{Action}} to support), like {{ActionMarshaller#marshal(Node 
node)}}.

> [fluent-job] Create an ActionMarshaller
> ---
>
> Key: OOZIE-3311
> URL: https://issues.apache.org/jira/browse/OOZIE-3311
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Mate Juhasz
>Assignee: Mate Juhasz
>Priority: Major
>
> It would be handy to create action xmls in unit tests via the Fluent-Job API, 
> thus an "action to xml" conversion could be implemented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Fluent API Builder Classes?

[Andras Piros]

Hello Clay,

glad that you want to use and extend Fluent Job API for the new Git action
:) Exactly the type of use case the API was born to serve.

Currently the Action, Converter, Builder, ... classes are all handwritten,
only the JAXB ones (everything in org.apache.oozie.fluentjob.api.generated
package) are generated.

There is a guide *how to extend manually
*,
which is tedious and error prone. I can help you work on the Fluent Job API
extension.

If anyone comes up with a better idea, like using JavaCC or other tools to
generate Action, Builder, and Converter classes, please feel free to
discuss.

Andras

On Tue, Jul 31, 2018 at 2:42 AM Clay B.  wrote:

> Hello,
>
> I realized I should write a few more tests for OOZIE-2877 (Oozie Git
> Action) and figured it would be useful to use the new fluent API
> (from OOZIE-2399) for the test. Then, I saw all the builders in
> fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/action
>
> and the examples in
> examples/src/main/java/org/apache/oozie/example/fluentjob/.
>
> I take it these are all hand-written or is there a generator one can point
> me to which can read the XSD to create the necessary action and builder?
> (I saw some generic *{Configuration,Launcher,Prepare}Converters in there
> which look like I can simply copy and modify the class names...
>
> (An aside, what's the thought for external folks who are using custom
> actions and who want to use the fluent API is there an extension point
> for a custom bundled action?)
>
> -Clay
>

[jira] [Commented] (OOZIE-3310) SQL error during /v2/sla filtering

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563236#comment-16563236
 ] 

Hadoop QA commented on OOZIE-3310:
--

PreCommit-OOZIE-Build started


> SQL error during /v2/sla filtering
> --
>
> Key: OOZIE-3310
> URL: https://issues.apache.org/jira/browse/OOZIE-3310
> Project: Oozie
>  Issue Type: Bug
>  Components: client
>Affects Versions: 5.1.0
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Minor
> Attachments: OOZIE-3310-1.patch, OOZIE-3310-2.patch
>
>
> Filtering for both the id and the bundle field using /v2/sla servlet gives an 
> SQL error:
> {noformat}
> // 20180726124649
> // 
> http://localhost:11000/oozie/v2/sla?timezone=GMT&filter=id=001-180726123600112-oozie-andr-C;bundle=000-180726123600112-oozie-andr-B
> {
> "errorMessage": "E0603: SQL error in operation, "Encountered 
> "." at character 63, but expected: ["*", "+", 
> "-", "/", "GROUP", "HAVING", 
> "ORDER", ]." while parsing JPQL "SELECT 
> OBJECT(s) FROM SLASummaryBean s WHERE s.jobId = :jobIds.parentId in 
> (:parentId0) ORDER BY s.nominalTimeTS". See nested stack trace for 
> original parse error.",
> "httpStatusCode": 500
> }{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3310) SQL error during /v2/sla filtering

[Andras Salamon (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563234#comment-16563234
 ] 

Andras Salamon commented on OOZIE-3310:
---

Thanks [~andras.piros] for checking, I've uploaded an updated patch.

> SQL error during /v2/sla filtering
> --
>
> Key: OOZIE-3310
> URL: https://issues.apache.org/jira/browse/OOZIE-3310
> Project: Oozie
>  Issue Type: Bug
>  Components: client
>Affects Versions: 5.1.0
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Minor
> Attachments: OOZIE-3310-1.patch, OOZIE-3310-2.patch
>
>
> Filtering for both the id and the bundle field using /v2/sla servlet gives an 
> SQL error:
> {noformat}
> // 20180726124649
> // 
> http://localhost:11000/oozie/v2/sla?timezone=GMT&filter=id=001-180726123600112-oozie-andr-C;bundle=000-180726123600112-oozie-andr-B
> {
> "errorMessage": "E0603: SQL error in operation, "Encountered 
> "." at character 63, but expected: ["*", "+", 
> "-", "/", "GROUP", "HAVING", 
> "ORDER", ]." while parsing JPQL "SELECT 
> OBJECT(s) FROM SLASummaryBean s WHERE s.jobId = :jobIds.parentId in 
> (:parentId0) ORDER BY s.nominalTimeTS". See nested stack trace for 
> original parse error.",
> "httpStatusCode": 500
> }{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3310) SQL error during /v2/sla filtering

[Andras Salamon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Salamon updated OOZIE-3310:
--
Attachment: OOZIE-3310-2.patch

> SQL error during /v2/sla filtering
> --
>
> Key: OOZIE-3310
> URL: https://issues.apache.org/jira/browse/OOZIE-3310
> Project: Oozie
>  Issue Type: Bug
>  Components: client
>Affects Versions: 5.1.0
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Minor
> Attachments: OOZIE-3310-1.patch, OOZIE-3310-2.patch
>
>
> Filtering for both the id and the bundle field using /v2/sla servlet gives an 
> SQL error:
> {noformat}
> // 20180726124649
> // 
> http://localhost:11000/oozie/v2/sla?timezone=GMT&filter=id=001-180726123600112-oozie-andr-C;bundle=000-180726123600112-oozie-andr-B
> {
> "errorMessage": "E0603: SQL error in operation, "Encountered 
> "." at character 63, but expected: ["*", "+", 
> "-", "/", "GROUP", "HAVING", 
> "ORDER", ]." while parsing JPQL "SELECT 
> OBJECT(s) FROM SLASummaryBean s WHERE s.jobId = :jobIds.parentId in 
> (:parentId0) ORDER BY s.nominalTimeTS". See nested stack trace for 
> original parse error.",
> "httpStatusCode": 500
> }{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)