[jira] [Commented] (OOZIE-3513) Migrate from Preconditions.checkNotNull and ParamChecker.notNull
[
https://issues.apache.org/jira/browse/OOZIE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857861#comment-16857861
]
Andras Salamon commented on OOZIE-3513:
---
I'll check the long lines and {{TestParameterVerifier}}.
> Migrate from Preconditions.checkNotNull and ParamChecker.notNull
>
>
> Key: OOZIE-3513
> URL: https://issues.apache.org/jira/browse/OOZIE-3513
> Project: Oozie
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-3513-01.patch
>
>
> We currently use both Guava's {{Preconditions.checkNotNull}} and our own
> {{ParamChecker.notNull}} to check for null arguments. Instead we should use
> the standard {{Objects.requireNonNull}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3513) Migrate from Preconditions.checkNotNull and ParamChecker.notNull
[
https://issues.apache.org/jira/browse/OOZIE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857845#comment-16857845
]
Hadoop QA commented on OOZIE-3513:
--
Testing JIRA OOZIE-3513
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:red}-1{color} the patch contains 2 line(s) longer than 132
characters
.{color:green}+1{color} the patch adds/modifies 5 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [21] new bugs found below threshold in total
that must be fixed.
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:red}-1{color} There are [15] new bugs found below threshold in
[tools] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones):
tools/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At OozieDBCLI.java:[line 584]: This use of
java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL
injection
.At OozieDBCLI.java:[line 574]: At OozieDBCLI.java:[line 573]
.At OozieDBCLI.java:[line 577]: At OozieDBCLI.java:[line 575]
.At OozieDBCLI.java:[line 579]: At OozieDBCLI.java:[line 578]
.At OozieDBCLI.java:[line 584]: At OozieDBCLI.java:[line 581]
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:red}-1{color} There are [6] new bugs found below threshold in
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 206]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
.At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
.This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 206]
.At BulkJPAExecutor.java:[line 111]: At BulkJPAExecutor.java:[line 127]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 3168
.Tests failed : 0
.Tests in error : 3
.Tests timed out : 0
{color:red}-1{color} [ERROR] There are [3] test errors in [core]. Listing only
the first [5] ones
testVerifyParametersNull:org.apache.oozie.util.TestParameterVerifier
Check console output for the full list of errors/failures
.{color:orange}Tests failed at first run:{color}
TestPurgeXCommand#testPurgeableBundleUnpurgeableCoordinatorUnpurgeableWorkflow
Failed: OOZIE-3513 PreCommit Build #1142
Jira: https://issues.apache.org/jira/browse/OOZIE-3513 Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/1142/ ### ## LAST 100 LINES OF THE CONSOLE ### [...truncated 2.09 MB...] Testing JIRA OOZIE-3513 Cleaning local git workspace +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS +1 the patch does not introduce any @author tags +1 the patch does not introduce any tabs +1 the patch does not introduce any trailing spaces +1 the patch does not introduce any star imports -1 the patch contains 2 line(s) longer than 132 characters +1 the patch adds/modifies 5 testcase(s) +1 RAT +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC +1 Javadoc generation succeeded with the patch +1 the patch does not seem to introduce new Javadoc warning(s) +1 COMPILE +1 HEAD compiles +1 patch compiles +1 the patch does not seem to introduce new javac warnings -1 There are [21] new bugs found below threshold in total that must be fixed. +1 There are no new bugs found in [sharelib/hive2]. +1 There are no new bugs found in [sharelib/spark]. +1 There are no new bugs found in [sharelib/oozie]. +1 There are no new bugs found in [sharelib/pig]. +1 There are no new bugs found in [sharelib/streaming]. +1 There are no new bugs found in [sharelib/hive]. +1 There are no new bugs found in [sharelib/distcp]. +1 There are no new bugs found in [sharelib/hcatalog]. +1 There are no new bugs found in [sharelib/sqoop]. +1 There are no new bugs found in [sharelib/git]. +1 There are no new bugs found in [client]. +1 There are no new bugs found in [docs]. -1 There are [15] new bugs found below threshold in [tools] that must be fixed, listing only the first [5] ones. You can find the SpotBugs diff here (look for the red and orange ones): tools/findbugs-new.html The top [5] most important SpotBugs errors are: At OozieDBCLI.java:[line 584]: This use of java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL injection At OozieDBCLI.java:[line 574]: At OozieDBCLI.java:[line 573] At OozieDBCLI.java:[line 577]: At OozieDBCLI.java:[line 575] At OozieDBCLI.java:[line 579]: At OozieDBCLI.java:[line 578] At OozieDBCLI.java:[line 584]: At OozieDBCLI.java:[line 581] +1 There are no new bugs found in [fluent-job/fluent-job-api]. +1 There are no new bugs found in [server]. +1 There are no new bugs found in [webapp]. +1 There are no new bugs found in [examples]. -1 There are [6] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones. You can find the SpotBugs diff here (look for the red and orange ones): core/findbugs-new.html The top [5] most important SpotBugs errors are: At BulkJPAExecutor.java:[line 206]: This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175] At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199] This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 206] At BulkJPAExecutor.java:[line 111]: At BulkJPAExecutor.java:[line 127] +1 BACKWARDS_COMPATIBILITY +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations +1 the patch does not modify JPA files -1 TESTS Tests run: 3168 Tests failed : 0 Tests in error : 3 Tests timed out : 0 -1 [ERROR] There are [3] test errors in [core]. Listing only the first [5] ones testVerifyParametersNull:org.apache.oozie.util.TestParameterVerifier Check console output for the full list of errors/failures Tests failed at first run: TestPurgeXCommand#testPurgeableBundleUnpurgeableCoordinatorUnpurgeableWorkflow TestPurgeXCommand#testPurgeableWorkflowPurgeableSubWorkflowPurgeableSubSubWorkflow For the complete list of flaky tests, see TEST-SUMMARY-FULL files. +1 DISTRO +1 distro tarball builds with the patch -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at https://builds.apache.org/job/PreCommit-OOZIE-Build/1142/ Adding comment to JIRA % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0100 52820 0 100 5282 0 4686 0:00:01 0:00:01 --:--:--
[jira] [Commented] (OOZIE-2879) Remove unused class SLAStore and related classes
[
https://issues.apache.org/jira/browse/OOZIE-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857792#comment-16857792
]
Hadoop QA commented on OOZIE-2879:
--
Testing JIRA OOZIE-2879
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [6] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:red}-1{color} There are [6] new bugs found below threshold in
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 207]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
.At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
.This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207]
.At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128]
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3168
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1141/
> Remove unused class SLAStore and related classes
>
>
> Key: OOZIE-2879
> URL: https://issues.apache.org/jira/browse/OOZIE-2879
> Project: Oozie
> Issue Type: Sub-task
>Reporter: Peter Bacsko
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2879-01.patch
>
>
> While working on OOZIE-2854, I was looking for classes which use
> {{EntityManager}}. There is a class called {{SLAStore}} which uses it, but
> retrieving the call hierarchy revealed that only a test class invokes the
> methods of {{SLAStore}}.
> This class has been unused for a long time - it was deprecated in OOZIE-914
> (see commit:
>
Failed: OOZIE-2879 PreCommit Build #1141
Jira: https://issues.apache.org/jira/browse/OOZIE-2879 Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/1141/ ### ## LAST 100 LINES OF THE CONSOLE ### [...truncated 2.03 MB...] [ERROR] There are [6] new bugs found below threshold in [core]. [DEBUG] You can find the SpotBugs diff here (look for the red and orange ones): core/findbugs-new.html [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [client]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [docs]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [webapp]. [ERROR] There are [6] new bugs found below threshold in total that must be fixed. [TRACE] SpotBugs diffs checked and reports created [TRACE] Summary file size is 3382 bytes [TRACE] Full summary file size is 3729 bytes [TRACE] File [/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar] removed [TRACE] File [/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5] removed Running test-patch task BACKWARDS_COMPATIBILITY Running test-patch task TESTS Running test-patch task DISTRO Testing JIRA OOZIE-2879 Cleaning local git workspace +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS +1 the patch does not introduce any @author tags +1 the patch does not introduce any tabs +1 the patch does not introduce any trailing spaces +1 the patch does not introduce any star imports +1 the patch does not introduce any line longer than 132 -1 the patch does not add/modify any testcase +1 RAT +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC +1 Javadoc generation succeeded with the patch +1 the patch does not seem to introduce new Javadoc warning(s) +1 COMPILE +1 HEAD compiles +1 patch compiles +1 the patch does not seem to introduce new javac warnings -1 There are [6] new bugs found below threshold in total that must be fixed. +1 There are no new bugs found in [fluent-job/fluent-job-api]. +1 There are no new bugs found in [tools]. +1 There are no new bugs found in [sharelib/oozie]. +1 There are no new bugs found in [sharelib/streaming]. +1 There are no new bugs found in [sharelib/spark]. +1 There are no new bugs found in [sharelib/pig]. +1 There are no new bugs found in [sharelib/sqoop]. +1 There are no new bugs found in [sharelib/git]. +1 There are no new bugs found in [sharelib/hive]. +1 There are no new bugs found in [sharelib/hcatalog]. +1 There are no new bugs found in [sharelib/distcp]. +1 There are no new bugs found in [sharelib/hive2]. +1 There are no new bugs found in [server]. +1 There are no new bugs found in [examples]. -1 There are [6] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones. You can find the SpotBugs diff here (look for the red and orange ones): core/findbugs-new.html The top [5] most important SpotBugs errors are: At BulkJPAExecutor.java:[line 207]: This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176] At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200] This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207] At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128] +1 There are no new bugs found in [client]. +1 There are no new bugs found in [docs]. +1 There are no new bugs found in [webapp]. +1 BACKWARDS_COMPATIBILITY +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations +1 the patch does not modify JPA files +1 TESTS Tests run: 3168 +1 DISTRO +1 distro tarball builds with the patch -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at https://builds.apache.org/job/PreCommit-OOZIE-Build/1141/ Adding comment to JIRA % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0100 40440 0 100 4044 0 3428 0:00:01 0:00:01 --:--:--
[jira] [Resolved] (OOZIE-3039) Add Sqoop2 action
[ https://issues.apache.org/jira/browse/OOZIE-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon resolved OOZIE-3039. --- Resolution: Won't Do > Add Sqoop2 action > - > > Key: OOZIE-3039 > URL: https://issues.apache.org/jira/browse/OOZIE-3039 > Project: Oozie > Issue Type: Improvement >Reporter: Hu Liu, >Assignee: Hu Liu, >Priority: Major > Attachments: OOZIE-3039-1.patch > > > Now Sqoop2 is released and we should add support for it. > I'm glad to work on it if anyone could assign it to me. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3513) Migrate from Preconditions.checkNotNull and ParamChecker.notNull
[
https://issues.apache.org/jira/browse/OOZIE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857751#comment-16857751
]
Hadoop QA commented on OOZIE-3513:
--
PreCommit-OOZIE-Build started
> Migrate from Preconditions.checkNotNull and ParamChecker.notNull
>
>
> Key: OOZIE-3513
> URL: https://issues.apache.org/jira/browse/OOZIE-3513
> Project: Oozie
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-3513-01.patch
>
>
> We currently use both Guava's {{Preconditions.checkNotNull}} and our own
> {{ParamChecker.notNull}} to check for null arguments. Instead we should use
> the standard {{Objects.requireNonNull}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2879) Remove unused class SLAStore and related classes
[
https://issues.apache.org/jira/browse/OOZIE-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857648#comment-16857648
]
Hadoop QA commented on OOZIE-2879:
--
PreCommit-OOZIE-Build started
> Remove unused class SLAStore and related classes
>
>
> Key: OOZIE-2879
> URL: https://issues.apache.org/jira/browse/OOZIE-2879
> Project: Oozie
> Issue Type: Sub-task
>Reporter: Peter Bacsko
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2879-01.patch
>
>
> While working on OOZIE-2854, I was looking for classes which use
> {{EntityManager}}. There is a class called {{SLAStore}} which uses it, but
> retrieving the call hierarchy revealed that only a test class invokes the
> methods of {{SLAStore}}.
> This class has been unused for a long time - it was deprecated in OOZIE-914
> (see commit:
> https://github.com/apache/oozie/commit/c95c809a55005b44b05f0c496e4a3fd75a26be91),
> so we should remove it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OOZIE-2879) Remove unused class SLAStore and related classes
[
https://issues.apache.org/jira/browse/OOZIE-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Salamon reassigned OOZIE-2879:
-
Assignee: Andras Salamon (was: Peter Bacsko)
> Remove unused class SLAStore and related classes
>
>
> Key: OOZIE-2879
> URL: https://issues.apache.org/jira/browse/OOZIE-2879
> Project: Oozie
> Issue Type: Sub-task
>Reporter: Peter Bacsko
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2879-01.patch
>
>
> While working on OOZIE-2854, I was looking for classes which use
> {{EntityManager}}. There is a class called {{SLAStore}} which uses it, but
> retrieving the call hierarchy revealed that only a test class invokes the
> methods of {{SLAStore}}.
> This class has been unused for a long time - it was deprecated in OOZIE-914
> (see commit:
> https://github.com/apache/oozie/commit/c95c809a55005b44b05f0c496e4a3fd75a26be91),
> so we should remove it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OOZIE-3513) Migrate from Preconditions.checkNotNull and ParamChecker.notNull
Andras Salamon created OOZIE-3513:
-
Summary: Migrate from Preconditions.checkNotNull and
ParamChecker.notNull
Key: OOZIE-3513
URL: https://issues.apache.org/jira/browse/OOZIE-3513
Project: Oozie
Issue Type: Bug
Affects Versions: trunk
Reporter: Andras Salamon
Assignee: Andras Salamon
We currently use both Guava's {{Preconditions.checkNotNull}} and our own
{{ParamChecker.notNull}} to check for null arguments. Instead we should use the
standard {{Objects.requireNonNull}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3492) [spark-action] Missing HADOOP_CONF_DIR property
[
https://issues.apache.org/jira/browse/OOZIE-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857490#comment-16857490
]
Hadoop QA commented on OOZIE-3492:
--
Testing JIRA OOZIE-3492
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [6] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:red}-1{color} There are [6] new bugs found below threshold in
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 207]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
.At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
.This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207]
.At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128]
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3169
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1140/
> [spark-action] Missing HADOOP_CONF_DIR property
> ---
>
> Key: OOZIE-3492
> URL: https://issues.apache.org/jira/browse/OOZIE-3492
> Project: Oozie
> Issue Type: Bug
> Components: action
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-3492-001.patch
>
>
> Spark action fails with the following error:
> {noformat}
> Failing Oozie Launcher, When running with master 'yarn-cluster' either
> HADOOP_CONF_DIR or YARN_CONF_DIR must be set in the environment.
> org.apache.spark.SparkException: When running with master 'yarn-cluster'
> either HADOOP_CONF_DIR or
Failed: OOZIE-3492 PreCommit Build #1140
Jira: https://issues.apache.org/jira/browse/OOZIE-3492 Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/1140/ ### ## LAST 100 LINES OF THE CONSOLE ### [...truncated 2.03 MB...] [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/git]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/hcatalog]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/sqoop]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/distcp]. [ERROR] There are [6] new bugs found below threshold in total that must be fixed. [TRACE] SpotBugs diffs checked and reports created [TRACE] Summary file size is 3382 bytes [TRACE] Full summary file size is 3729 bytes [TRACE] File [/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar] removed [TRACE] File [/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5] removed Running test-patch task BACKWARDS_COMPATIBILITY Running test-patch task TESTS Running test-patch task DISTRO Testing JIRA OOZIE-3492 Cleaning local git workspace +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS +1 the patch does not introduce any @author tags +1 the patch does not introduce any tabs +1 the patch does not introduce any trailing spaces +1 the patch does not introduce any star imports +1 the patch does not introduce any line longer than 132 -1 the patch does not add/modify any testcase +1 RAT +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC +1 Javadoc generation succeeded with the patch +1 the patch does not seem to introduce new Javadoc warning(s) +1 COMPILE +1 HEAD compiles +1 patch compiles +1 the patch does not seem to introduce new javac warnings -1 There are [6] new bugs found below threshold in total that must be fixed. +1 There are no new bugs found in [fluent-job/fluent-job-api]. +1 There are no new bugs found in [docs]. +1 There are no new bugs found in [examples]. +1 There are no new bugs found in [webapp]. +1 There are no new bugs found in [tools]. +1 There are no new bugs found in [client]. +1 There are no new bugs found in [server]. -1 There are [6] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones. You can find the SpotBugs diff here (look for the red and orange ones): core/findbugs-new.html The top [5] most important SpotBugs errors are: At BulkJPAExecutor.java:[line 207]: This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176] At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200] This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207] At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128] +1 There are no new bugs found in [sharelib/hive2]. +1 There are no new bugs found in [sharelib/streaming]. +1 There are no new bugs found in [sharelib/pig]. +1 There are no new bugs found in [sharelib/hive]. +1 There are no new bugs found in [sharelib/oozie]. +1 There are no new bugs found in [sharelib/spark]. +1 There are no new bugs found in [sharelib/git]. +1 There are no new bugs found in [sharelib/hcatalog]. +1 There are no new bugs found in [sharelib/sqoop]. +1 There are no new bugs found in [sharelib/distcp]. +1 BACKWARDS_COMPATIBILITY +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations +1 the patch does not modify JPA files +1 TESTS Tests run: 3169 +1 DISTRO +1 distro tarball builds with the patch -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at https://builds.apache.org/job/PreCommit-OOZIE-Build/1140/ Adding comment to JIRA % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0100 40440 0 100 4044 0 3798 0:00:01 0:00:01 --:--:--
[jira] [Updated] (OOZIE-2879) Remove unused class SLAStore and related classes
[
https://issues.apache.org/jira/browse/OOZIE-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Salamon updated OOZIE-2879:
--
Issue Type: Sub-task (was: Bug)
Parent: OOZIE-2096
> Remove unused class SLAStore and related classes
>
>
> Key: OOZIE-2879
> URL: https://issues.apache.org/jira/browse/OOZIE-2879
> Project: Oozie
> Issue Type: Sub-task
>Reporter: Peter Bacsko
>Assignee: Peter Bacsko
>Priority: Major
>
> While working on OOZIE-2854, I was looking for classes which use
> {{EntityManager}}. There is a class called {{SLAStore}} which uses it, but
> retrieving the call hierarchy revealed that only a test class invokes the
> methods of {{SLAStore}}.
> This class has been unused for a long time - it was deprecated in OOZIE-914
> (see commit:
> https://github.com/apache/oozie/commit/c95c809a55005b44b05f0c496e4a3fd75a26be91),
> so we should remove it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3492) [spark-action] Missing HADOOP_CONF_DIR property
[
https://issues.apache.org/jira/browse/OOZIE-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857405#comment-16857405
]
Hadoop QA commented on OOZIE-3492:
--
PreCommit-OOZIE-Build started
> [spark-action] Missing HADOOP_CONF_DIR property
> ---
>
> Key: OOZIE-3492
> URL: https://issues.apache.org/jira/browse/OOZIE-3492
> Project: Oozie
> Issue Type: Bug
> Components: action
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-3492-001.patch
>
>
> Spark action fails with the following error:
> {noformat}
> Failing Oozie Launcher, When running with master 'yarn-cluster' either
> HADOOP_CONF_DIR or YARN_CONF_DIR must be set in the environment.
> org.apache.spark.SparkException: When running with master 'yarn-cluster'
> either HADOOP_CONF_DIR or YARN_CONF_DIR must be set in the environment.
> at
> org.apache.spark.deploy.SparkSubmitArguments.error(SparkSubmitArguments.scala:657)
> at
> org.apache.spark.deploy.SparkSubmitArguments.validateSubmitArguments(SparkSubmitArguments.scala:290)
> at
> org.apache.spark.deploy.SparkSubmitArguments.validateArguments(SparkSubmitArguments.scala:251)
> at
> org.apache.spark.deploy.SparkSubmitArguments.(SparkSubmitArguments.scala:120)
> at
> org.apache.spark.deploy.SparkSubmit$$anon$2$$anon$1.(SparkSubmit.scala:926)
> at
> org.apache.spark.deploy.SparkSubmit$$anon$2.parseArguments(SparkSubmit.scala:926)
> at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:81)
> at
> org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:939)
> at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:948)
> at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
> at
> org.apache.oozie.action.hadoop.SparkMain.runSpark(SparkMain.java:186)
> at org.apache.oozie.action.hadoop.SparkMain.run(SparkMain.java:93)
> at
> org.apache.oozie.action.hadoop.LauncherMain.run(LauncherMain.java:104)
> at org.apache.oozie.action.hadoop.SparkMain.main(SparkMain.java:60)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.oozie.action.hadoop.LauncherAM.runActionMain(LauncherAM.java:410)
> at
> org.apache.oozie.action.hadoop.LauncherAM.access$300(LauncherAM.java:55)
> at
> org.apache.oozie.action.hadoop.LauncherAM$2.run(LauncherAM.java:223)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
> at org.apache.oozie.action.hadoop.LauncherAM.run(LauncherAM.java:217)
> at
> org.apache.oozie.action.hadoop.LauncherAM$1.run(LauncherAM.java:153)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
> at
> org.apache.oozie.action.hadoop.LauncherAM.main(LauncherAM.java:141){noformat}
> if the followings are true:
> * yarn.nodemanager.env-whitelist does not contain {{HADOOP_CONF_DIR}}
> * Hadoop version >= 3.1 (or YARN-7677 is backported)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2879) Remove unused class SLAStore and related classes
[
https://issues.apache.org/jira/browse/OOZIE-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857397#comment-16857397
]
Andras Salamon commented on OOZIE-2879:
---
[~pbacsko] Do you mind if I take this over?
> Remove unused class SLAStore and related classes
>
>
> Key: OOZIE-2879
> URL: https://issues.apache.org/jira/browse/OOZIE-2879
> Project: Oozie
> Issue Type: Bug
>Reporter: Peter Bacsko
>Assignee: Peter Bacsko
>Priority: Major
>
> While working on OOZIE-2854, I was looking for classes which use
> {{EntityManager}}. There is a class called {{SLAStore}} which uses it, but
> retrieving the call hierarchy revealed that only a test class invokes the
> methods of {{SLAStore}}.
> This class has been unused for a long time - it was deprecated in OOZIE-914
> (see commit:
> https://github.com/apache/oozie/commit/c95c809a55005b44b05f0c496e4a3fd75a26be91),
> so we should remove it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] Subscription: Oozie Patch Available
Issue Subscription Filter: Oozie Patch Available (97 issues) Subscriber: ooziedaily Key Summary OOZIE-3507 Upgrade to Dozer 6 https://issues.apache.org/jira/browse/OOZIE-3507 OOZIE-3506 Flaky test TestOozieRollingPolicy https://issues.apache.org/jira/browse/OOZIE-3506 OOZIE-3505 [Java 11] Fix TestDBLoadDump https://issues.apache.org/jira/browse/OOZIE-3505 OOZIE-3495 Upgrade hive version to 1.2.2 https://issues.apache.org/jira/browse/OOZIE-3495 OOZIE-3486 duplicate code in ControlNodeHandler https://issues.apache.org/jira/browse/OOZIE-3486 OOZIE-3482 Fix bug in CoordSubmitXCommand#validateCoordinatorJob https://issues.apache.org/jira/browse/OOZIE-3482 OOZIE-3480 Add windowactionstatus metrics in DBLiteWorkflowStoreService https://issues.apache.org/jira/browse/OOZIE-3480 OOZIE-3476 Migrate several classes to JUnit4 https://issues.apache.org/jira/browse/OOZIE-3476 OOZIE-3468 Use modernizer plugin https://issues.apache.org/jira/browse/OOZIE-3468 OOZIE-3461 CoordMaterializeTriggerService code cleanup https://issues.apache.org/jira/browse/OOZIE-3461 OOZIE-3449 Make spark-2 as the default profile https://issues.apache.org/jira/browse/OOZIE-3449 OOZIE-3447 Run test case in local : It shows oozie-hsqldb-orm.xml exception https://issues.apache.org/jira/browse/OOZIE-3447 OOZIE-3418 Upgrade to Guava 27 https://issues.apache.org/jira/browse/OOZIE-3418 OOZIE-3404 The env variable of SPARK_HOME needs to be set when running pySpark https://issues.apache.org/jira/browse/OOZIE-3404 OOZIE-3375 Can't use empty in coordinator https://issues.apache.org/jira/browse/OOZIE-3375 OOZIE-3367 Using && in EL expressions in oozie bundle.xml files generates parse errors https://issues.apache.org/jira/browse/OOZIE-3367 OOZIE-3366 Update workflow status and subworkflow status on suspend command https://issues.apache.org/jira/browse/OOZIE-3366 OOZIE-3364 Rerunning Oozie bundle jobs starts the coordinators in indeterminate order https://issues.apache.org/jira/browse/OOZIE-3364 OOZIE-3362 When killed, SSH action should kill the spawned processes on target host https://issues.apache.org/jira/browse/OOZIE-3362 OOZIE-3335 Cleanup parseFilter methods https://issues.apache.org/jira/browse/OOZIE-3335 OOZIE-3328 Create Hive compatibility action executor to run hive actions using beeline https://issues.apache.org/jira/browse/OOZIE-3328 OOZIE-3320 Oozie ShellAction should support absolute bash file path https://issues.apache.org/jira/browse/OOZIE-3320 OOZIE-3319 Log SSH action callback error output https://issues.apache.org/jira/browse/OOZIE-3319 OOZIE-3301 Update NOTICE file https://issues.apache.org/jira/browse/OOZIE-3301 OOZIE-3274 Remove slf4j https://issues.apache.org/jira/browse/OOZIE-3274 OOZIE-3266 Coord action rerun support RERUN_SKIP_NODES option https://issues.apache.org/jira/browse/OOZIE-3266 OOZIE-3265 properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear together https://issues.apache.org/jira/browse/OOZIE-3265 OOZIE-3256 refactor OozieCLI class https://issues.apache.org/jira/browse/OOZIE-3256 OOZIE-3199 Let system property restriction configurable https://issues.apache.org/jira/browse/OOZIE-3199 OOZIE-3196 Authorization: restrict world readability by user https://issues.apache.org/jira/browse/OOZIE-3196 OOZIE-3179 Adding a configurable config-default.xml location to a workflow https://issues.apache.org/jira/browse/OOZIE-3179 OOZIE-3170 Oozie Diagnostic Bundle tool fails with NPE due to missing service class https://issues.apache.org/jira/browse/OOZIE-3170 OOZIE-3137 Add support for log4j2 in HiveMain https://issues.apache.org/jira/browse/OOZIE-3137 OOZIE-3135 Configure log4j2 in SqoopMain https://issues.apache.org/jira/browse/OOZIE-3135 OOZIE-3091 Oozie Sqoop Avro Import fails with "java.lang.NoClassDefFoundError: org/apache/avro/mapred/AvroWrapper" https://issues.apache.org/jira/browse/OOZIE-3091 OOZIE-3071 Oozie 4.3 Spark sharelib ueses a different version of commons-lang3 than Spark 2.2.0 https://issues.apache.org/jira/browse/OOZIE-3071 OOZIE-3063 Sanitizing variables that are part of openjpa.ConnectionProperties https://issues.apache.org/jira/browse/OOZIE-3063 OOZIE-3062 Set HADOOP_CONF_DIR for spark action https://issues.apache.org/jira/browse/OOZIE-3062 OOZIE-2952 Fix Findbugs warnings in oozie-sharelib-oozie https://issues.apache.org/jira/browse/OOZIE-2952 OOZIE-2907 Delete PrepareActionsDriver from oozie-sharelib https://issues.apache.org/jira/browse/OOZIE-2907 OOZIE-2834
