[jira] Subscription: Oozie Patch Available
Issue Subscription Filter: Oozie Patch Available (104 issues) Subscriber: ooziedaily Key Summary OOZIE-3696 [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module https://issues.apache.org/jira/browse/OOZIE-3696 OOZIE-3690 [server] Fix current SpotBugs discovered issues in Oozie's server module https://issues.apache.org/jira/browse/OOZIE-3690 OOZIE-3687 Fix Oozie client always using the current system username instead the one specified by the user (e.g.: via kerberos or via explicit basic authentication) https://issues.apache.org/jira/browse/OOZIE-3687 OOZIE-3680 Add default value to custom configuration of all the supported file systems in Oozie https://issues.apache.org/jira/browse/OOZIE-3680 OOZIE-3663 Upgrade Apache Xerces Java to 2.12.2 https://issues.apache.org/jira/browse/OOZIE-3663 OOZIE-3654 update to httpclient 4.5.13 https://issues.apache.org/jira/browse/OOZIE-3654 OOZIE-3635 Reduce nest of code in RecoveryService https://issues.apache.org/jira/browse/OOZIE-3635 OOZIE-3623 Fix Typos in Distro Assembly https://issues.apache.org/jira/browse/OOZIE-3623 OOZIE-3621 Make TestECPolicyDisabler work with Hadoop 3 https://issues.apache.org/jira/browse/OOZIE-3621 OOZIE-3620 hadoopId is not sent to eventHandlerService (listener) for workflow action events https://issues.apache.org/jira/browse/OOZIE-3620 OOZIE-3609 Zookeeper SSL/TLS support https://issues.apache.org/jira/browse/OOZIE-3609 OOZIE-3596 When the SSH action is killed, it must be changed to the kill command that can terminate the related subprocess. https://issues.apache.org/jira/browse/OOZIE-3596 OOZIE-3568 Have large amount of log information “WARN messages [main] openjpa.MetaData” in jetty.log need to clean https://issues.apache.org/jira/browse/OOZIE-3568 OOZIE-3567 Oozie ShellAction should support absolute bash file path https://issues.apache.org/jira/browse/OOZIE-3567 OOZIE-3560 IDEA shows have some error in index.jsp https://issues.apache.org/jira/browse/OOZIE-3560 OOZIE-3554 Add asf.yaml to git repo https://issues.apache.org/jira/browse/OOZIE-3554 OOZIE-3545 Upgrade jQuery https://issues.apache.org/jira/browse/OOZIE-3545 OOZIE-3482 Fix bug in CoordSubmitXCommand#validateCoordinatorJob https://issues.apache.org/jira/browse/OOZIE-3482 OOZIE-3480 Add windowactionstatus metrics in DBLiteWorkflowStoreService https://issues.apache.org/jira/browse/OOZIE-3480 OOZIE-3461 CoordMaterializeTriggerService code cleanup https://issues.apache.org/jira/browse/OOZIE-3461 OOZIE-3449 Make spark-2 as the default profile https://issues.apache.org/jira/browse/OOZIE-3449 OOZIE-3447 Run test case in local : It shows oozie-hsqldb-orm.xml exception https://issues.apache.org/jira/browse/OOZIE-3447 OOZIE-3434 Filtering for invalid jobtype should give error message https://issues.apache.org/jira/browse/OOZIE-3434 OOZIE-3418 Upgrade to Guava 27 https://issues.apache.org/jira/browse/OOZIE-3418 OOZIE-3404 The env variable of SPARK_HOME needs to be set when running pySpark https://issues.apache.org/jira/browse/OOZIE-3404 OOZIE-3375 Can't use empty in coordinator https://issues.apache.org/jira/browse/OOZIE-3375 OOZIE-3367 Using && in EL expressions in oozie bundle.xml files generates parse errors https://issues.apache.org/jira/browse/OOZIE-3367 OOZIE-3366 Update workflow status and subworkflow status on suspend command https://issues.apache.org/jira/browse/OOZIE-3366 OOZIE-3364 Rerunning Oozie bundle jobs starts the coordinators in indeterminate order https://issues.apache.org/jira/browse/OOZIE-3364 OOZIE-3362 When killed, SSH action should kill the spawned processes on target host https://issues.apache.org/jira/browse/OOZIE-3362 OOZIE-3335 Cleanup parseFilter methods https://issues.apache.org/jira/browse/OOZIE-3335 OOZIE-3328 Create Hive compatibility action executor to run hive actions using beeline https://issues.apache.org/jira/browse/OOZIE-3328 OOZIE-3319 Log SSH action callback error output https://issues.apache.org/jira/browse/OOZIE-3319 OOZIE-3301 Update NOTICE file https://issues.apache.org/jira/browse/OOZIE-3301 OOZIE-3274 Remove slf4j https://issues.apache.org/jira/browse/OOZIE-3274 OOZIE-3266 Coord action rerun support RERUN_SKIP_NODES option https://issues.apache.org/jira/browse/OOZIE-3266 OOZIE-3256 refactor OozieCLI class https://issues.apache.org/jira/browse/OOZIE-3256 OOZIE-3196 Authorization: restrict world readability by user https://issues.apache.org/jira/browse/OOZIE-3196 OOZIE-3170 Oozie Diagnostic Bundle tool
[jira] [Commented] (OOZIE-3479) Build pre-commit pipeline for pull requests.
[ https://issues.apache.org/jira/browse/OOZIE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650982#comment-17650982 ] Dénes Bodó commented on OOZIE-3479: --- We also have to decide how the release-log.txt will be uodated after transitioning to Github PRs. Should we add lines manually? Will we implement an automation which copies the commit message or Jira title? If manual, will we introduce a constraint that the release log must be updated? I think the automated update would be the most sustainable because we wouldn't forget it. Any thoughts? > Build pre-commit pipeline for pull requests. > > > Key: OOZIE-3479 > URL: https://issues.apache.org/jira/browse/OOZIE-3479 > Project: Oozie > Issue Type: Task >Reporter: Gézapeti >Priority: Major > > I think it would be great to accept pull requests for Oozie as well. > We should build the pre-commit system out first to see how it works for us > before updating the site and changing the rules. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3690) [server] Fix current SpotBugs discovered issues in Oozie's server module
[
https://issues.apache.org/jira/browse/OOZIE-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650981#comment-17650981
]
Hadoop QA commented on OOZIE-3690:
--
Testing JIRA OOZIE-3690
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [examples].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 3237
.Tests failed : 0
.Tests in error : 1280
.Tests timed out : 1
{color:red}-1{color} [ERROR] There are [1278] test errors in [core]. Listing
only the first [5] ones
testCoordActionsGetByActionNumber:org.apache.oozie.executor.jpa.TestCoordJobGetActionByActionNumberJPAExecutor
{color:red}-1{color} [ERROR] There are [2] test errors in [server]. Listing
only the first [5] ones
scratchDir_Is_Created_When_Setup_Called_And_ScratchDir_Did_Not_Exist:org.apache.oozie.server.TestJspHandler
scratchDir_Is_Reused_When_Setup_Called_And_ScratchDir_Existed:org.apache.oozie.server.TestJspHandler
Check console output for the full list of errors/failures
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://ci-hadoop.apache.org/job/PreCommit-OOZIE-Build/176/
> [server] Fix current SpotBugs discovered issues in Oozie's server module
>
>
> Key: OOZIE-3690
> URL: https://issues.apache.org/jira/browse/OOZIE-3690
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Affects Versions: 5.2.1
>Reporter: Janos Makai
>Assignee: Janos Makai
>Priority: Major
> Attachments: OOZIE-3690-001.patch, Oozie-server-SpotBugs-issues.txt
>
>
> This ticket is created for fixing or filtering the SpotBugs related issues in
> Oozie's server module.
> The exact SpotBugs output is attached for this module.
> There are currently 10 SpotBugs discovered issues in this module.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OOZIE-3479) Build pre-commit pipeline for pull requests.
[ https://issues.apache.org/jira/browse/OOZIE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650916#comment-17650916 ] Dénes Bodó commented on OOZIE-3479: --- [~jmakai] Thanks for the investigation. I think you could continue with the the mentioned Github Actions and try if the currently used validation script can be executed. At this moment I don't see what we need to do to make the surefire report and test results available but we have to start somewhere. > Build pre-commit pipeline for pull requests. > > > Key: OOZIE-3479 > URL: https://issues.apache.org/jira/browse/OOZIE-3479 > Project: Oozie > Issue Type: Task >Reporter: Gézapeti >Priority: Major > > I think it would be great to accept pull requests for Oozie as well. > We should build the pre-commit system out first to see how it works for us > before updating the site and changing the rules. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[
https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650842#comment-17650842
]
Hadoop QA commented on OOZIE-3696:
--
Testing JIRA OOZIE-3696
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:red}-1{color} There are [1] new bugs found below threshold in
[sharelib/oozie] that must be fixed.
.You can find the SpotBugs diff here (look for the red and orange ones):
sharelib/oozie/findbugs-new.html
.The most important SpotBugs errors are:
.At ShellMain.java:[line 93]: This usage of
java/lang/ProcessBuilder.init(Ljava/util/List;)V can be vulnerable to
Command Injection
.At ShellMain.java:[line 91]: At ShellMain.java:[line 90]
.At ShellMain.java:[line 92]
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3259
.{color:orange}Tests failed at first run:{color}
TestLocalOozieClientCoord#testJobsOperations
TestBundleRerunXCommand#testBundleRerunInPausedWithError
TestCoordActionsKillXCommand#testActionKillCommandDate
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://ci-hadoop.apache.org/job/PreCommit-OOZIE-Build/175/
> [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git
> module
>
>
> Key: OOZIE-3696
> URL: https://issues.apache.org/jira/browse/OOZIE-3696
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Affects Versions: 5.2.1
>Reporter: Janos Makai
>Assignee: Dénes Bodó
>Priority: Major
> Attachments: OOZIE-3696-001.patch,
> Oozie-oozie-sharelib-git-SpotBugs-issues.txt
>
>
> This ticket is created for fixing or filtering the SpotBugs related issues in
> Oozie's sharelib-git module.
> The exact SpotBugs output is attached for this module.
> There are currently 2 SpotBugs discovered issues in this module.
--
This message was sent
[jira] [Commented] (OOZIE-3690) [server] Fix current SpotBugs discovered issues in Oozie's server module
[ https://issues.apache.org/jira/browse/OOZIE-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650813#comment-17650813 ] Hadoop QA commented on OOZIE-3690: -- PreCommit-OOZIE-Build started > [server] Fix current SpotBugs discovered issues in Oozie's server module > > > Key: OOZIE-3690 > URL: https://issues.apache.org/jira/browse/OOZIE-3690 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Janos Makai >Priority: Major > Attachments: OOZIE-3690-001.patch, Oozie-server-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's server module. > The exact SpotBugs output is attached for this module. > There are currently 10 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650720#comment-17650720 ] Hadoop QA commented on OOZIE-3696: -- PreCommit-OOZIE-Build started > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[
https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650717#comment-17650717
]
Dénes Bodó commented on OOZIE-3696:
---
Thanks [~jmakai] .
I think the {{.toLowerCase()}} is not mandatory as the change utilises
{{.equalsIgnoreCase()}}.
Regarding the test failures: I see tons of Connection Refused in HDFS
communication. Locally I couldn't reproduce. Maybe it is some infra issue. I am
restarting the check and will investigate if the rerun fails.
> [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git
> module
>
>
> Key: OOZIE-3696
> URL: https://issues.apache.org/jira/browse/OOZIE-3696
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Affects Versions: 5.2.1
>Reporter: Janos Makai
>Assignee: Dénes Bodó
>Priority: Major
> Attachments: OOZIE-3696-001.patch,
> Oozie-oozie-sharelib-git-SpotBugs-issues.txt
>
>
> This ticket is created for fixing or filtering the SpotBugs related issues in
> Oozie's sharelib-git module.
> The exact SpotBugs output is attached for this module.
> There are currently 2 SpotBugs discovered issues in this module.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (OOZIE-3690) [server] Fix current SpotBugs discovered issues in Oozie's server module
[ https://issues.apache.org/jira/browse/OOZIE-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janos Makai reassigned OOZIE-3690: -- Assignee: Janos Makai > [server] Fix current SpotBugs discovered issues in Oozie's server module > > > Key: OOZIE-3690 > URL: https://issues.apache.org/jira/browse/OOZIE-3690 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Janos Makai >Priority: Major > Attachments: Oozie-server-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's server module. > The exact SpotBugs output is attached for this module. > There are currently 10 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OOZIE-3672) Fix current SpotBugs warnings
[ https://issues.apache.org/jira/browse/OOZIE-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janos Makai reassigned OOZIE-3672: -- Assignee: (was: Janos Makai) > Fix current SpotBugs warnings > - > > Key: OOZIE-3672 > URL: https://issues.apache.org/jira/browse/OOZIE-3672 > Project: Oozie > Issue Type: Task >Affects Versions: 5.2.1 >Reporter: Janos Makai >Priority: Major > > Currently the SpotBugs tool indicates hundreds of warnings across almost all > of the Oozie modules. > This Jira serves as a similar initiative like it was tracked under OOZIE-1987 > but this is aimed for the current warnings and potential bugs. > Additional information: Due to there are ~800 issues discovered by SpotBugs > in Oozie's core module, we have decided to create separate tickets for each > type of issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OOZIE-3672) Fix current SpotBugs warnings
[ https://issues.apache.org/jira/browse/OOZIE-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janos Makai reassigned OOZIE-3672: -- Assignee: Janos Makai > Fix current SpotBugs warnings > - > > Key: OOZIE-3672 > URL: https://issues.apache.org/jira/browse/OOZIE-3672 > Project: Oozie > Issue Type: Task >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Janos Makai >Priority: Major > > Currently the SpotBugs tool indicates hundreds of warnings across almost all > of the Oozie modules. > This Jira serves as a similar initiative like it was tracked under OOZIE-1987 > but this is aimed for the current warnings and potential bugs. > Additional information: Due to there are ~800 issues discovered by SpotBugs > in Oozie's core module, we have decided to create separate tickets for each > type of issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650472#comment-17650472 ] Janos Makai commented on OOZIE-3696: Hi [~dionusos] , could you please check the unit test results? Also, please use .toLowerCase() in your patch set Thanks. > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3479) Build pre-commit pipeline for pull requests.
[ https://issues.apache.org/jira/browse/OOZIE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650436#comment-17650436 ] Gézapeti commented on OOZIE-3479: - Good idea [~jmakai], I'd say go for it. If it's easier to reimplement the current pipeline (or equivalent) in GitHub Actions for PRs, that's fine as well if it does not result in two completely separate code base for pre-commit we have to maintain. Anything that makes contributing easier is welcome :) > Build pre-commit pipeline for pull requests. > > > Key: OOZIE-3479 > URL: https://issues.apache.org/jira/browse/OOZIE-3479 > Project: Oozie > Issue Type: Task >Reporter: Gézapeti >Priority: Major > > I think it would be great to accept pull requests for Oozie as well. > We should build the pre-commit system out first to see how it works for us > before updating the site and changing the rules. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3479) Build pre-commit pipeline for pull requests.
[ https://issues.apache.org/jira/browse/OOZIE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650413#comment-17650413 ] Janos Makai commented on OOZIE-3479: Using GitHub actions seems to have great potential and I think that could help simplifying the PreCommit system for the Github PRs. With that we can easily execute the build process and running the unit tests as @Gézapeti mentioned. The main concern @Gézapeti raised is that there might be a problem acquiring the changes of the PR. One direction that looks promising is that we could gather all the changed files corresponding to a PR using a changed files gathering GitHub action, and then we could launch our scripts against those files in the container (e.g. SpotBugs, RAW patch analysis, backward compatibility checks, etc..) Examples of this can be found here: [LINK|https://github.com/marketplace/actions/changed-files] and here: [LINK|https://docs.github.com/en/actions/examples/using-scripts-to-test-your-code-on-a-runner] What do you think of this approach? > Build pre-commit pipeline for pull requests. > > > Key: OOZIE-3479 > URL: https://issues.apache.org/jira/browse/OOZIE-3479 > Project: Oozie > Issue Type: Task >Reporter: Gézapeti >Priority: Major > > I think it would be great to accept pull requests for Oozie as well. > We should build the pre-commit system out first to see how it works for us > before updating the site and changing the rules. -- This message was sent by Atlassian Jira (v8.20.10#820010)
