[jira] [Updated] (OOZIE-2827) More directly view of the coordinator’s history from perspective of workflow action.
[ https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alonzo Zhou updated OOZIE-2827: --- Issue Type: New Feature (was: Improvement) > More directly view of the coordinator’s history from perspective of workflow > action. > > > Key: OOZIE-2827 > URL: https://issues.apache.org/jira/browse/OOZIE-2827 > Project: Oozie > Issue Type: New Feature > Reporter: Alonzo Zhou > Attachments: OOZIE-2827-0001.patch, OOZIE-2827-0002.patch, > OOZIE-2827-0003.patch, OOZIE-2827-0004.patch, OOZIE-2827-0005.patch > > > Background: > When we monitor a coordinator job, statistics of historical workflow > instances such as running time can be directly visualized. > But, we lack the ability to monitor historical statistics of coordinator from > perspective of workflow action.For example, running time of a coordinator > action is longer than before, but we can't see the exact change tendency of a > sepcific workflow action in it。 > Functional optimization: > More detailed view of the coordinator’s history can be observed from > perspective of workflow action.Furthermore, the trend of a workflow action > can be shown directly on front-end graph. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OOZIE-2827) More directly view of the coordinator’s history from perspective of workflow action.
[ https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alonzo Zhou updated OOZIE-2827: --- Attachment: OOZIE-2827-0005.patch > More directly view of the coordinator’s history from perspective of workflow > action. > > > Key: OOZIE-2827 > URL: https://issues.apache.org/jira/browse/OOZIE-2827 > Project: Oozie > Issue Type: Improvement > Reporter: Alonzo Zhou > Attachments: OOZIE-2827-0001.patch, OOZIE-2827-0002.patch, > OOZIE-2827-0003.patch, OOZIE-2827-0004.patch, OOZIE-2827-0005.patch > > > Background: > When we monitor a coordinator job, statistics of historical workflow > instances such as running time can be directly visualized. > But, we lack the ability to monitor historical statistics of coordinator from > perspective of workflow action.For example, running time of a coordinator > action is longer than before, but we can't see the exact change tendency of a > sepcific workflow action in it。 > Functional optimization: > More detailed view of the coordinator’s history can be observed from > perspective of workflow action.Furthermore, the trend of a workflow action > can be shown directly on front-end graph. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Issue Comment Deleted] (OOZIE-2827) More directly view of the coordinator’s history from perspective of workflow action.
[
https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alonzo Zhou updated OOZIE-2827:
---
Comment: was deleted
(was: Experimental result in real environment：
Request:
GET
/oozie/v2/job/002-160122140107162-oozie-oozi-C?show=wf-actions=fs-a747=2=2
Response：
HTTP/1.1 200 OK
Content-Type: application/json;charset=UTF-8
{code:none}
{
"coordJobId": "002-160122140107162-oozie-oozi-C",
"actions": [
{
"errorMessage": null,
"status": "OK",
"stats": null,
"data": null,
"transition": "End",
"externalStatus": "OK",
"cred": "null",
"conf": "
",
"type": "fs",
"endTime": "Fri, 22 Jan 2016 06:25:24 GMT",
"externalId": "-",
"id": "005-160122140107162-oozie-oozi-W@fs-a747",
"startTime": "Fri, 22 Jan 2016 06:25:24 GMT",
"externalChildIDs": null,
"name": "fs-a747",
"errorCode": null,
"trackerUri": "-",
"retries": 0,
"toString": "Action name[fs-a747] status[OK]",
"consoleUrl": "-"
},
{
"errorMessage": null,
"status": "OK",
"stats": null,
"data": null,
"transition": "End",
"externalStatus": "OK",
"cred": "null",
"conf": "
",
"type": "fs",
"endTime": "Fri, 22 Jan 2016 06:25:25 GMT",
"externalId": "-",
"id": "006-160122140107162-oozie-oozi-W@fs-a747",
"startTime": "Fri, 22 Jan 2016 06:25:25 GMT",
"externalChildIDs": null,
"name": "fs-a747",
"errorCode": null,
"trackerUri": "-",
"retries": 0,
"toString": "Action name[fs-a747] status[OK]",
"consoleUrl": "-"
}
]
}
{code})
> More directly view of the coordinator’s history from perspective of workflow
> action.
>
>
> Key: OOZIE-2827
> URL: https://issues.apache.org/jira/browse/OOZIE-2827
> Project: Oozie
> Issue Type: Improvement
>Reporter: Alonzo Zhou
> Attachments: OOZIE-2827-0001.patch, OOZIE-2827-0002.patch,
> OOZIE-2827-0003.patch, OOZIE-2827-0004.patch
>
>
> Background:
> When we monitor a coordinator job, statistics of historical workflow
> instances such as running time can be directly visualized.
> But, we lack the ability to monitor historical statistics of coordinator from
> perspective of workflow action.For example, running time of a coordinator
> action is longer than before, but we can't see the exact change tendency of a
> sepcific workflow action in it。
> Functional optimization:
> More detailed view of the coordinator’s history can be observed from
> perspective of workflow action.Furthermore, the trend of a workflow action
> can be shown directly on front-end graph.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.
> On 四月 3, 2017, 10:23 a.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java > > Lines 81 (patched) > > <https://reviews.apache.org/r/57870/diff/4/?file=1682907#file1682907line81> > > > > Are we sure that the default, uninitialized instance is good enough? > > > > So let's say we store the empty bean as a placeholder. How will that be > > returned to the user? > > > > As I can see, status will be PREP, wfId is null, id is null, everything > > else is pretty much null. > > > > Is this sufficient for us? Won't that be misleading? hi, i added a class CoordinatorWfActionBean as an element in the returned list, which includes a WorkflowActionBean, an int that corresponds to the coordinatorAction serial number, and a string to explain why the WorkflowActionBean is null. The packaging looks a bit more robustness and friendly. could you review it for me ? thanks. - Alonzo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/#review170838 ------- On 四月 6, 2017, 2:34 p.m., Alonzo Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57870/ > --- > > (Updated 四月 6, 2017, 2:34 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > --- > > More detailed view of the coordinator’s history can be observed from > perspective of workflow action. > > > Diffs > - > > client/src/main/java/org/apache/oozie/client/CoordinatorWfAction.java > PRE-CREATION > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java ca168e0 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 8ddb1f8 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 > core/src/main/java/org/apache/oozie/CoordinatorWfActionBean.java > PRE-CREATION > core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 > > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java > 0b7f50d > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a > > core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 4fc8653 > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 > > > Diff: https://reviews.apache.org/r/57870/diff/5/ > > > Testing > --- > > > Thanks, > > Alonzo Zhou > >
Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/ --- (Updated 四月 6, 2017, 2:34 p.m.) Review request for oozie. Changes --- 1 refactor the test so that they run as a single testcase (TestCoordWfActionInfoXCommand, TestV2JobServlet) 2 Added a class CoordinatorWfActionBean as an element in the returned list Repository: oozie-git Description --- More detailed view of the coordinator’s history can be observed from perspective of workflow action. Diffs (updated) - client/src/main/java/org/apache/oozie/client/CoordinatorWfAction.java PRE-CREATION client/src/main/java/org/apache/oozie/client/rest/JsonTags.java ca168e0 client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 8ddb1f8 core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 core/src/main/java/org/apache/oozie/CoordinatorWfActionBean.java PRE-CREATION core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java PRE-CREATION core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java 0b7f50d core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java PRE-CREATION core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 4fc8653 core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 Diff: https://reviews.apache.org/r/57870/diff/5/ Changes: https://reviews.apache.org/r/57870/diff/4-5/ Testing --- Thanks, Alonzo Zhou
Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/ --- (Updated 四月 1, 2017, 11:31 a.m.) Review request for oozie. Changes --- 1 add comment to the ambiguous method with empty body 2 Use empty WorkflowActionBean instead of null as placeholder element 3 Make WorkflowActionGetJPAExecutor be able to handle both "acceptable null" and "null exception" Repository: oozie-git Description --- More detailed view of the coordinator’s history can be observed from perspective of workflow action. Diffs (updated) - client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 8ddb1f8 core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java PRE-CREATION core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java 0b7f50d core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java PRE-CREATION core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 4fc8653 core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 Diff: https://reviews.apache.org/r/57870/diff/4/ Changes: https://reviews.apache.org/r/57870/diff/3-4/ Testing --- Thanks, Alonzo Zhou
[jira] [Commented] (OOZIE-2827) More directly view of the coordinator’s history from perspective of workflow action.
[ https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952180#comment-15952180 ] Alonzo Zhou commented on OOZIE-2827: Thank you for your thorough review! [~pbacsko] The 1st point your mentioned, namely, method with empty body, I have fixed it。 As for the 2nd and 3rd point, I'm going to explain in detail below: *There exist THREE cases where WorkflowActionBean couldn't be obtained:* 1. workflow id is null, which, in my opinion, means workflow instance is not created and this is expected situation. 2. action name has changed and WorkflowActionGetJPAExecutor couldn't retrieve node info. As far as I know, WARNING is decent enough to take care of this. In real situation, coordinator rarely update WorkflowAction name. 3. If there is an underlying database issue that caused JPAExecutorException, and we should throw Exception consequencely. *How we handle cases when workflowAction can't be retrieved:* 1. Should element be added into list? You know, there is actually no seq number info in workflowActionBean, which means placeholder element is needed. 2. And yes indeed I agree that using null as placeholder is not that reasonable. I think it is a better idea to use a empty WorkflowActionBean for that. we can determine whether it is empty by determining whether action id is empty. I have just updated patch according to what're mentioned above. I'd be much appreciated if you could continue to review my updated patch when you have time. Thanks! > More directly view of the coordinator’s history from perspective of workflow > action. > > > Key: OOZIE-2827 > URL: https://issues.apache.org/jira/browse/OOZIE-2827 > Project: Oozie > Issue Type: Improvement > Reporter: Alonzo Zhou > Attachments: OOZIE-2827-0001.patch, OOZIE-2827-0002.patch, > OOZIE-2827-0003.patch, OOZIE-2827-0004.patch > > > Background: > When we monitor a coordinator job, statistics of historical workflow > instances such as running time can be directly visualized. > But, we lack the ability to monitor historical statistics of coordinator from > perspective of workflow action.For example, running time of a coordinator > action is longer than before, but we can't see the exact change tendency of a > sepcific workflow action in it。 > Functional optimization: > More detailed view of the coordinator’s history can be observed from > perspective of workflow action.Furthermore, the trend of a workflow action > can be shown directly on front-end graph. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OOZIE-2827) More directly view of the coordinator’s history from perspective of workflow action.
[ https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alonzo Zhou updated OOZIE-2827: --- Attachment: OOZIE-2827-0004.patch > More directly view of the coordinator’s history from perspective of workflow > action. > > > Key: OOZIE-2827 > URL: https://issues.apache.org/jira/browse/OOZIE-2827 > Project: Oozie > Issue Type: Improvement > Reporter: Alonzo Zhou > Attachments: OOZIE-2827-0001.patch, OOZIE-2827-0002.patch, > OOZIE-2827-0003.patch, OOZIE-2827-0004.patch > > > Background: > When we monitor a coordinator job, statistics of historical workflow > instances such as running time can be directly visualized. > But, we lack the ability to monitor historical statistics of coordinator from > perspective of workflow action.For example, running time of a coordinator > action is longer than before, but we can't see the exact change tendency of a > sepcific workflow action in it。 > Functional optimization: > More detailed view of the coordinator’s history can be observed from > perspective of workflow action.Furthermore, the trend of a workflow action > can be shown directly on front-end graph. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OOZIE-2827) More directly view of the coordinator’s history from perspective of workflow action.
[ https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alonzo Zhou updated OOZIE-2827: --- Attachment: OOZIE-2827-0003.patch > More directly view of the coordinator’s history from perspective of workflow > action. > > > Key: OOZIE-2827 > URL: https://issues.apache.org/jira/browse/OOZIE-2827 > Project: Oozie > Issue Type: Improvement > Reporter: Alonzo Zhou > Attachments: OOZIE-2827-0001.patch, OOZIE-2827-0002.patch, > OOZIE-2827-0003.patch > > > Background: > When we monitor a coordinator job, statistics of historical workflow > instances such as running time can be directly visualized. > But, we lack the ability to monitor historical statistics of coordinator from > perspective of workflow action.For example, running time of a coordinator > action is longer than before, but we can't see the exact change tendency of a > sepcific workflow action in it。 > Functional optimization: > More detailed view of the coordinator’s history can be observed from > perspective of workflow action.Furthermore, the trend of a workflow action > can be shown directly on front-end graph. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OOZIE-2827) More directly view of the coordinator’s history from perspective of workflow action.
[ https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950623#comment-15950623 ] Alonzo Zhou commented on OOZIE-2827: [~andras.piros] hi,I have amended the patch following your advices. By any chance, could you please review it for me ? thanks. > More directly view of the coordinator’s history from perspective of workflow > action. > > > Key: OOZIE-2827 > URL: https://issues.apache.org/jira/browse/OOZIE-2827 > Project: Oozie > Issue Type: Improvement > Reporter: Alonzo Zhou > Attachments: OOZIE-2827-0001.patch, OOZIE-2827-0002.patch > > > Background: > When we monitor a coordinator job, statistics of historical workflow > instances such as running time can be directly visualized. > But, we lack the ability to monitor historical statistics of coordinator from > perspective of workflow action.For example, running time of a coordinator > action is longer than before, but we can't see the exact change tendency of a > sepcific workflow action in it。 > Functional optimization: > More detailed view of the coordinator’s history can be observed from > perspective of workflow action.Furthermore, the trend of a workflow action > can be shown directly on front-end graph. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/ --- (Updated 三月 28, 2017, 5:41 p.m.) Review request for oozie. Changes --- 1 Update CoordWfActionInfoXCommand : move some SQLs and JPA calls from execute() to loadState(). 2 Change the method getWfActionByJobIdAndName in BaseJobServlet from abstract to protected. could you please take a look? thanks! Repository: oozie-git Description --- More detailed view of the coordinator’s history can be observed from perspective of workflow action. Diffs (updated) - client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 8ddb1f8 core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java PRE-CREATION core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 9356768 core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java PRE-CREATION core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 4fc8653 core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 Diff: https://reviews.apache.org/r/57870/diff/3/ Changes: https://reviews.apache.org/r/57870/diff/2-3/ Testing --- Thanks, Alonzo Zhou
Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.
> On 三月 23, 2017, 11:35 a.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java > > Lines 280-285 (patched) > > <https://reviews.apache.org/r/57870/diff/1/?file=1672529#file1672529line280> > > > > Why not have this default implementation in `BaseJobServlet` instead? > > Alonzo Zhou wrote: > hi, i noticed that the methods in BaseJobServlet was defined as an > abstract method in addition to doGet and doPut. in order to maintain > consistency, then i defined getWfActionsInCoord as an abstract. > > András Piros wrote: > There are already non-abstract methods like `checkAuthorizationForApp()` > present in `BaseJobServlet`, so I wouldn't mind putting there a `protected` > method those implementation is the same for all children. Having duplicate > code is never OK - [DRY > principle](https://en.wikipedia.org/wiki/Don't_repeat_yourself). Thanks for your advice, i'll fix it right away. and I will remember that "Having duplicate code is never OK". - Alonzo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/#review169856 --- On 三月 28, 2017, 9:36 a.m., Alonzo Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57870/ > --- > > (Updated 三月 28, 2017, 9:36 a.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > --- > > More detailed view of the coordinator’s history can be observed from > perspective of workflow action. > > > Diffs > - > > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 8ddb1f8 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 > core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 > > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java > PRE-CREATION > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java d3b4689 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 9356768 > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a > > core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 4fc8653 > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 > > > Diff: https://reviews.apache.org/r/57870/diff/2/ > > > Testing > --- > > > Thanks, > > Alonzo Zhou > >
Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/ --- (Updated 三月 28, 2017, 9:36 a.m.) Review request for oozie. Repository: oozie-git Description --- More detailed view of the coordinator’s history can be observed from perspective of workflow action. Diffs (updated) - client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 8ddb1f8 core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java PRE-CREATION core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java d3b4689 core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 9356768 core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java PRE-CREATION core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 4fc8653 core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 Diff: https://reviews.apache.org/r/57870/diff/2/ Changes: https://reviews.apache.org/r/57870/diff/1-2/ Testing --- Thanks, Alonzo Zhou
Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.
ndrás Piros wrote: > > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java > > Lines 261 (patched) > > <https://reviews.apache.org/r/57870/diff/1/?file=1672534#file1672534line261> > > > > Great idea to add functional tests as well :) > > > > However, I'd focus more on the edge cases that can happen when calling > > `V2JobServlet` and weren't covered in other unit tests: unparseable query > > string for `offset` / `len`, querying a `jobId` that doesn't exist, calling > > `V0JobServlet` or `V1JobServlet` instead, etc. :) thx for your advice. i add some tests: 1) unparseable query string for offset/len. 2) offset/len out of range. 3) calling V0JobServlet or V1JobServlet instead. but i think the case that jobId doesnt exist shouldnt test here, because it is CoordWfActionInfoXCommand, rather than v2JobServlet, that handles it. - Alonzo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/#review169856 --- On 三月 23, 2017, 9:07 a.m., Alonzo Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57870/ > --- > > (Updated 三月 23, 2017, 9:07 a.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > --- > > More detailed view of the coordinator’s history can be observed from > perspective of workflow action. > > > Diffs > - > > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 4e38b4a > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 > > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java > PRE-CREATION > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java d3b4689 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 9356768 > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d > > core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 4fc8653 > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 > > > Diff: https://reviews.apache.org/r/57870/diff/1/ > > > Testing > --- > > > Thanks, > > Alonzo Zhou > >
[jira] [Commented] (OOZIE-2827) More directly view of the coordinator’s history from perspective of workflow action.
[ https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937987#comment-15937987 ] Alonzo Zhou commented on OOZIE-2827: [~andras.piros] thx for reviewing it ! here is the ReviewBoard patch of this issue: https://reviews.apache.org/r/57870/ could you please take a look? thanks > More directly view of the coordinator’s history from perspective of workflow > action. > > > Key: OOZIE-2827 > URL: https://issues.apache.org/jira/browse/OOZIE-2827 > Project: Oozie > Issue Type: Improvement > Reporter: Alonzo Zhou > Attachments: OOZIE-2827-0001.patch, OOZIE-2827-0002.patch > > > Background: > When we monitor a coordinator job, statistics of historical workflow > instances such as running time can be directly visualized. > But, we lack the ability to monitor historical statistics of coordinator from > perspective of workflow action.For example, running time of a coordinator > action is longer than before, but we can't see the exact change tendency of a > sepcific workflow action in it。 > Functional optimization: > More detailed view of the coordinator’s history can be observed from > perspective of workflow action.Furthermore, the trend of a workflow action > can be shown directly on front-end graph. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/ --- (Updated 三月 23, 2017, 9:07 a.m.) Review request for oozie. Repository: oozie-git Description (updated) --- More detailed view of the coordinator’s history can be observed from perspective of workflow action. Diffs - client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4e38b4a core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java PRE-CREATION core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java d3b4689 core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 9356768 core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java PRE-CREATION core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 4fc8653 core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 Diff: https://reviews.apache.org/r/57870/diff/1/ Testing --- Thanks, Alonzo Zhou
Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/ --- Review request for oozie. Repository: oozie-git Description --- More directly view of the coordinator’s history from perspective of workflow action. Diffs - client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4e38b4a core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java PRE-CREATION core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java d3b4689 core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 9356768 core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java PRE-CREATION core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 4fc8653 core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 Diff: https://reviews.apache.org/r/57870/diff/1/ Testing --- Thanks, Alonzo Zhou
[jira] [Commented] (OOZIE-2827) More directly view of the coordinator’s history from perspective of workflow action.
[ https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935685#comment-15935685 ] Alonzo Zhou commented on OOZIE-2827: i checked this test case : testConnectionDrop(org.apache.oozie.jms.TestJMSJobEventListener). and it passed. would anybody review this issue? thanks. > More directly view of the coordinator’s history from perspective of workflow > action. > > > Key: OOZIE-2827 > URL: https://issues.apache.org/jira/browse/OOZIE-2827 > Project: Oozie > Issue Type: Improvement > Reporter: Alonzo Zhou > Attachments: OOZIE-2827-0001.patch, OOZIE-2827-0002.patch > > > Background: > When we monitor a coordinator job, statistics of historical workflow > instances such as running time can be directly visualized. > But, we lack the ability to monitor historical statistics of coordinator from > perspective of workflow action.For example, running time of a coordinator > action is longer than before, but we can't see the exact change tendency of a > sepcific workflow action in it。 > Functional optimization: > More detailed view of the coordinator’s history can be observed from > perspective of workflow action.Furthermore, the trend of a workflow action > can be shown directly on front-end graph. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OOZIE-2827) More directly view of the coordinator’s history from perspective of workflow action.
[ https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alonzo Zhou updated OOZIE-2827: --- Attachment: OOZIE-2827-0002.patch > More directly view of the coordinator’s history from perspective of workflow > action. > > > Key: OOZIE-2827 > URL: https://issues.apache.org/jira/browse/OOZIE-2827 > Project: Oozie > Issue Type: Improvement > Reporter: Alonzo Zhou > Attachments: OOZIE-2827-0001.patch, OOZIE-2827-0002.patch > > > Background: > When we monitor a coordinator job, statistics of historical workflow > instances such as running time can be directly visualized. > But, we lack the ability to monitor historical statistics of coordinator from > perspective of workflow action.For example, running time of a coordinator > action is longer than before, but we can't see the exact change tendency of a > sepcific workflow action in it。 > Functional optimization: > More detailed view of the coordinator’s history can be observed from > perspective of workflow action.Furthermore, the trend of a workflow action > can be shown directly on front-end graph. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OOZIE-2827) More directly view of the coordinator’s history from perspective of workflow action.
[ https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alonzo Zhou updated OOZIE-2827: --- Summary: More directly view of the coordinator’s history from perspective of workflow action. (was: More directly view of the coordinator’s history from the workflow action dimension.) > More directly view of the coordinator’s history from perspective of workflow > action. > > > Key: OOZIE-2827 > URL: https://issues.apache.org/jira/browse/OOZIE-2827 > Project: Oozie > Issue Type: Improvement > Reporter: Alonzo Zhou > > Background: > When we monitor a coordinator job, statistics of historical workflow > instances such as running time can be directly visualized. > But, we lack the ability to monitor historical statistics of coordinator from > perspective of workflow action.For example, running time of a coordinator > action is longer than before, but we can't see the exact change tendency of a > sepcific workflow action in it。 > Functional optimization: > More detailed view of the coordinator’s history can be observed from > perspective of workflow action.Furthermore, the trend of a workflow action > can be shown directly on front-end graph. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OOZIE-2827) More directly view of the coordinator’s history from the workflow action dimension.
[
https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929533#comment-15929533
]
Alonzo Zhou commented on OOZIE-2827:
Experimental result in real environment：
Request:
GET
/oozie/v2/job/002-160122140107162-oozie-oozi-C?show=wf-actions=fs-a747=2=2
Response：
HTTP/1.1 200 OK
Content-Type: application/json;charset=UTF-8
{code:none}
{
"coordJobId": "002-160122140107162-oozie-oozi-C",
"actions": [
{
"errorMessage": null,
"status": "OK",
"stats": null,
"data": null,
"transition": "End",
"externalStatus": "OK",
"cred": "null",
"conf": "
",
"type": "fs",
"endTime": "Fri, 22 Jan 2016 06:25:24 GMT",
"externalId": "-",
"id": "005-160122140107162-oozie-oozi-W@fs-a747",
"startTime": "Fri, 22 Jan 2016 06:25:24 GMT",
"externalChildIDs": null,
"name": "fs-a747",
"errorCode": null,
"trackerUri": "-",
"retries": 0,
"toString": "Action name[fs-a747] status[OK]",
"consoleUrl": "-"
},
{
"errorMessage": null,
"status": "OK",
"stats": null,
"data": null,
"transition": "End",
"externalStatus": "OK",
"cred": "null",
"conf": "
",
"type": "fs",
"endTime": "Fri, 22 Jan 2016 06:25:25 GMT",
"externalId": "-",
"id": "006-160122140107162-oozie-oozi-W@fs-a747",
"startTime": "Fri, 22 Jan 2016 06:25:25 GMT",
"externalChildIDs": null,
"name": "fs-a747",
"errorCode": null,
"trackerUri": "-",
"retries": 0,
"toString": "Action name[fs-a747] status[OK]",
"consoleUrl": "-"
}
]
}
{code}
> More directly view of the coordinator’s history from the workflow action
> dimension.
> ---
>
> Key: OOZIE-2827
> URL: https://issues.apache.org/jira/browse/OOZIE-2827
> Project: Oozie
> Issue Type: Improvement
>Reporter: Alonzo Zhou
>
> Background:
> When we monitor a coordinator job, statistics of historical workflow
> instances such as running time can be directly visualized.
> But, we lack the ability to monitor historical statistics of coordinator from
> perspective of workflow action.For example, running time of a coordinator
> action is longer than before, but we can't see the exact change tendency of a
> sepcific workflow action in it。
> Functional optimization:
> More detailed view of the coordinator’s history can be observed from
> perspective of workflow action.Furthermore, the trend of a workflow action
> can be shown directly on front-end graph.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2827) More directly view of the coordinator’s history from the workflow action dimension.
[
https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929527#comment-15929527
]
Alonzo Zhou commented on OOZIE-2827:
web service API:
GET /oozie/v2/job/\{JOB-ID\}
parameter :
show=wf-actions
action-name=\{WF-ACTION-NAME\}
offset=\{OFFSET\}
len=\{LEN\}
> More directly view of the coordinator’s history from the workflow action
> dimension.
> ---
>
> Key: OOZIE-2827
> URL: https://issues.apache.org/jira/browse/OOZIE-2827
> Project: Oozie
> Issue Type: Improvement
> Reporter: Alonzo Zhou
>
> Background:
> When we monitor a coordinator job, statistics of historical workflow
> instances such as running time can be directly visualized.
> But, we lack the ability to monitor historical statistics of coordinator from
> perspective of workflow action.For example, running time of a coordinator
> action is longer than before, but we can't see the exact change tendency of a
> sepcific workflow action in it。
> Functional optimization:
> More detailed view of the coordinator’s history can be observed from
> perspective of workflow action.Furthermore, the trend of a workflow action
> can be shown directly on front-end graph.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (OOZIE-2827) More directly view of the coordinator’s history from the workflow action dimension.
Alonzo Zhou created OOZIE-2827: -- Summary: More directly view of the coordinator’s history from the workflow action dimension. Key: OOZIE-2827 URL: https://issues.apache.org/jira/browse/OOZIE-2827 Project: Oozie Issue Type: Improvement Reporter: Alonzo Zhou Background: When we monitor a coordinator job, statistics of historical workflow instances such as running time can be directly visualized. But, we lack the ability to monitor historical statistics of coordinator from perspective of workflow action.For example, running time of a coordinator action is longer than before, but we can't see the exact change tendency of a sepcific workflow action in it。 Functional optimization: More detailed view of the coordinator’s history can be observed from perspective of workflow action.Furthermore, the trend of a workflow action can be shown directly on front-end graph. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
