[jira] [Assigned] (OOZIE-1967) Fix checkstyle issues

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned OOZIE-1967:


Assignee: (was: Jan Hentschel)

> Fix checkstyle issues
> -
>
> Key: OOZIE-1967
> URL: https://issues.apache.org/jira/browse/OOZIE-1967
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Shwetha G S
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OOZIE-2976) Add extended attributes support to filesystem action

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned OOZIE-2976:


Assignee: (was: Jan Hentschel)

> Add extended attributes support to filesystem action
> 
>
> Key: OOZIE-2976
> URL: https://issues.apache.org/jira/browse/OOZIE-2976
> Project: Oozie
>  Issue Type: Improvement
>  Components: action
>Reporter: Jan Hentschel
>Priority: Major
>
> It would be nice to be able to set HDFS extended attributes on files via the 
> FS action, similar to the following one
> {code:xml}
> 
> ...
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OOZIE-1987) Fix existing findbugs warnings

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned OOZIE-1987:


Assignee: (was: Jan Hentschel)

> Fix existing findbugs warnings
> --
>
> Key: OOZIE-1987
> URL: https://issues.apache.org/jira/browse/OOZIE-1987
> Project: Oozie
>  Issue Type: Bug
>Reporter: Robert Kanter
>Priority: Major
> Fix For: 5.2.0
>
>
> Now that we have OOZIE-1793, we should actually fix the warnings that 
> findbugs finds in the existing codebase.  It may be a good idea to split this 
> into subtasks or multiple patches as there are a lot of warnings: over 500 in 
> oozie-core alone!
> If we think something is ok, but findbugs complains, we should exclude it.  
> There's a way to create a file that lists exclusions (Hadoop does this).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529706#comment-16529706
 ] 

Jan Hentschel commented on OOZIE-2942:
--

[~kmarton] Sure, go ahead.

> [examples] Fix Findbugs warnings
> 
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the 
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close 
> stream on exception [org.apache.oozie.example.DateList] At 
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in 
> org.apache.oozie.example.DateList.main(String[]) 
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At 
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method 
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called 
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource 
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues 
> at LocalOozieExample.java:[line 76]Path continues at 
> LocalOozieExample.java:[line 77]Path continues at 
> LocalOozieExample.java:[line 78]Path continues at 
> LocalOozieExample.java:[line 81]Path continues at 
> LocalOozieExample.java:[line 88]Path continues at 
> LocalOozieExample.java:[line 89]Path continues at 
> LocalOozieExample.java:[line 91]Path continues at 
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to close stream [org.apache.oozie.example.LocalOozieExample] At 
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal 
> representation by returning Repeatable.baseline 
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose 
> internal representation by storing an externally mutable object into 
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At 
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525104#comment-16525104
 ] 

Jan Hentschel commented on OOZIE-2956:
--

[~kmarton] Yes, sure. Go ahead.

> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Attachments: OOZIE-2956-1.patch, OOZIE-2956-2.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): 
> java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
> 69]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): 
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At 
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 684]Another occurrence at 
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 502]Another occurrence at 
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At 
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
> String): java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At 
> CoordUpdateXCommand.java:[line 203]
> [INFO] Found reliance on default encoding in 
> 

[jira] [Commented] (OOZIE-2955) Fix Findbugs warnings related to reliance on default encoding in oozie-client

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525105#comment-16525105
 ] 

Jan Hentschel commented on OOZIE-2955:
--

[~kmarton] Yes, sure. Go ahead.

> Fix Findbugs warnings related to reliance on default encoding in oozie-client
> -
>
> Key: OOZIE-2955
> URL: https://issues.apache.org/jira/browse/OOZIE-2955
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Attachments: OOZIE-2955-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-client* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new 
> java.io.PrintWriter(OutputStream) [org.apache.oozie.cli.CLIParser] At 
> CLIParser.java:[line 169]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 845]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 2171]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.readAuthToken(): new 
> java.io.FileReader(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 218]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token):
>  new java.io.FileWriter(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 248]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient.getSupportedProtocolVersions(): new 
> java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient] 
> At OozieClient.java:[line 412]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BulkResponseStatus.call(HttpURLConnection):
>  new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BulkResponseStatus] At 
> OozieClient.java:[line 1693]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobInfo] At OozieClient.java:[line 
> 1502]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobsStatus] At 
> OozieClient.java:[line 1667]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionInfo] At 
> OozieClient.java:[line 1522]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionsKill.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionsKill] At 
> OozieClient.java:[line 1720]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordIgnore.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordIgnore] At OozieClient.java:[line 
> 1743]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobInfo.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobInfo] At OozieClient.java:[line 
> 1455]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobsStatus] At 
> OozieClient.java:[line 1640]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordRerun.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordRerun] At OozieClient.java:[line 
> 1773]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$GetBuildVersion.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$GetBuildVersion] At 
> OozieClient.java:[line 2168]
> [INFO] Found reliance on default encoding in 
> 

[jira] [Updated] (OOZIE-2097) Get rid of non-Javadoc comments

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2097:
-
Attachment: OOZIE-2097-2.patch

> Get rid of non-Javadoc comments
> ---
>
> Key: OOZIE-2097
> URL: https://issues.apache.org/jira/browse/OOZIE-2097
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Rohini Palaniswamy
>Assignee: Jan Hentschel
>Priority: Major
>  Labels: newbie
> Attachments: OOZIE-2097-1.patch, OOZIE-2097-2.patch
>
>
> There are lot of (non-Javadoc) comments on @Override methods which don't add 
> any additional information and is just noise.
> For eg:
> {code}
> /*
>  * (non-Javadoc)
>  *
>  * @see org.apache.oozie.command.XCommand#getEntityKey()
>  */
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2937) Remove redundant groupId from the child pom's

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421284#comment-16421284
 ] 

Jan Hentschel commented on OOZIE-2937:
--

The failing tests are unrelated to the actual change. Only POMs are changed, no 
code.

> Remove redundant groupId from the child pom's
> -
>
> Key: OOZIE-2937
> URL: https://issues.apache.org/jira/browse/OOZIE-2937
> Project: Oozie
>  Issue Type: Task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: OOZIE-2937-1.patch, OOZIE-2937-2.patch
>
>
> Currently all child pom's define the *groupId* again. That's not necessary, 
> because it is already defined in the parent pom. Remove the redundant 
> declarations of the *groupId*.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-2937) Remove redundant groupId from the child pom's

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2937:
-
Attachment: OOZIE-2937-2.patch

> Remove redundant groupId from the child pom's
> -
>
> Key: OOZIE-2937
> URL: https://issues.apache.org/jira/browse/OOZIE-2937
> Project: Oozie
>  Issue Type: Task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: OOZIE-2937-1.patch, OOZIE-2937-2.patch
>
>
> Currently all child pom's define the *groupId* again. That's not necessary, 
> because it is already defined in the parent pom. Remove the redundant 
> declarations of the *groupId*.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OOZIE-3123) Make SMTP options configurable in email action

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-3123:


 Summary: Make SMTP options configurable in email action
 Key: OOZIE-3123
 URL: https://issues.apache.org/jira/browse/OOZIE-3123
 Project: Oozie
  Issue Type: Improvement
  Components: action
Affects Versions: trunk
Reporter: Jan Hentschel
Priority: Minor


Currently it is not possible to set SMTP-specific settings directly in the 
email action in a workflow. In some use cases it can be helpful to set them in 
the workflow instead of having to configure it in oozie-site. Setting some 
configurations directly in the workflow would have the advantage to use, f.e. a 
different FROM address for different workflows instead of one central address. 
I would like to be able to set the following configurations from oozie-site 
directly in the workflow:

* oozie.email.smtp.host
* oozie.email.smtp.port
* oozie.email.from.address

If these configurations are set in oozie-site the configuration in the workflow 
should take precedence.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2976) Add extended attributes support to filesystem action

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234554#comment-16234554
 ] 

Jan Hentschel commented on OOZIE-2976:
--

[~rreti] Sorry for the late reply. If you're faster than me, just go for it. If 
you have the rights, you can also assign this one to you.

> Add extended attributes support to filesystem action
> 
>
> Key: OOZIE-2976
> URL: https://issues.apache.org/jira/browse/OOZIE-2976
> Project: Oozie
>  Issue Type: Improvement
>  Components: action
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
>
> It would be nice to be able to set HDFS extended attributes on files via the 
> FS action, similar to the following one
> {code:xml}
> 
> ...
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072375#comment-16072375
 ] 

Jan Hentschel commented on OOZIE-2956:
--

Failing test passes locally. Maybe we can run the build again.

> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2956-1.patch, OOZIE-2956-2.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): 
> java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
> 69]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): 
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At 
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 684]Another occurrence at 
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 502]Another occurrence at 
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At 
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
> String): java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At 
> CoordUpdateXCommand.java:[line 203]
> [INFO] Found reliance on default encoding in 
> 

[jira] [Updated] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2956:
-
Attachment: OOZIE-2956-2.patch

Updated the patch to fix the test failures.

> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2956-1.patch, OOZIE-2956-2.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): 
> java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
> 69]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): 
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At 
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 684]Another occurrence at 
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 502]Another occurrence at 
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At 
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
> String): java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At 
> CoordUpdateXCommand.java:[line 203]
> [INFO] Found reliance on default encoding in 
> 

[jira] [Commented] (OOZIE-2780) Upgrade minimum Hadoop version to 2.6.0

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070234#comment-16070234
 ] 

Jan Hentschel commented on OOZIE-2780:
--

[~dbist13] I opened OOZIE-2976 for adding support for setting extended 
attributes.

> Upgrade minimum Hadoop version to 2.6.0
> ---
>
> Key: OOZIE-2780
> URL: https://issues.apache.org/jira/browse/OOZIE-2780
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 4.3.0
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
>  Labels: newbie
> Fix For: 5.0.0
>
> Attachments: OOZIE-2780-0.patch, OOZIE-2780-1.patch, 
> OOZIE-2780-2.patch
>
>
> I'd like to contribute an fs action enhancement to modify extended attributes 
> to core but methods to change extended attributes is not available in 
> hadoop-common < 2.6.0. Currently hadoop-common is at 2.4. I am contributing a 
> patch to bump to 2.6 but so far I haven't been able to generate a clean test 
> as tests in core module fail randomly. On the first run, I had a failure on 
> {code} Failed tests:   
> testCheckAfterActionDelete(org.apache.oozie.service.TestHAPartitionDependencyManagerService):
>  Expected:  but was: [000-170123095541655-oozie-aerv-C@1]{code}
> and on second run
> {code}Failed tests:   testWaitFor(org.apache.oozie.test.TestXTestCase): 
> expected:<1000.0> but was:<2036.0>{code}
> I can't tell whether it is due to my patch?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OOZIE-2976) Add extended attributes support to filesystem action

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2976:


 Summary: Add extended attributes support to filesystem action
 Key: OOZIE-2976
 URL: https://issues.apache.org/jira/browse/OOZIE-2976
 Project: Oozie
  Issue Type: Improvement
  Components: action
Reporter: Jan Hentschel
Assignee: Jan Hentschel


It would be nice to be able to set HDFS extended attributes on files via the FS 
action, similar to the following one

{code:xml}

...
  

{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2946) Include find-sec-bugs plugin

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070213#comment-16070213
 ] 

Jan Hentschel commented on OOZIE-2946:
--

I would also go with dropping support of 1.7. The public support ended in April 
2015, so it should be time to drop it with the next major release. I don't know 
if there is another minor release planned for Oozie. If there's a plan we 
probably need to address this one. HBASE-18293 solved this one by using the JDK 
1.8 specific profile. As far as I know Oozie doesn't have different profiles 
for the different Java versions.

> Include find-sec-bugs plugin
> 
>
> Key: OOZIE-2946
> URL: https://issues.apache.org/jira/browse/OOZIE-2946
> Project: Oozie
>  Issue Type: Task
>  Components: build, security
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 5.0.0
>
> Attachments: OOZIE-2946-1.patch, OOZIE-2946-2.patch
>
>
> The [Find Security Bugs|http://find-sec-bugs.github.io/] plugin looks for 
> security bugs in Java web apps, such as Oozie. This plugin should be included 
> in the build process.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066068#comment-16066068
 ] 

Jan Hentschel commented on OOZIE-2956:
--

I will have a look at it. I'm pretty sure it's related to my changes.

> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2956-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): 
> java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
> 69]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): 
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At 
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 684]Another occurrence at 
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 502]Another occurrence at 
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At 
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
> String): java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At 
> CoordUpdateXCommand.java:[line 203]
> [INFO] Found reliance on default encoding in 
> 

[jira] [Updated] (OOZIE-2957) Documentation states that starting a coordinator is possible

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2957:
-
Attachment: OOZIE-2957-1.patch

> Documentation states that starting a coordinator is possible
> 
>
> Key: OOZIE-2957
> URL: https://issues.apache.org/jira/browse/OOZIE-2957
> Project: Oozie
>  Issue Type: Bug
>  Components: coordinator, docs
>Affects Versions: 5.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2957-1.patch
>
>
> The documentation of the command line tools states that starting a 
> coordinator is possible
> {quote}---+++ Starting a Workflow, Coordinator or Bundle Job
> Example:
> 
> $ oozie job -oozie http://localhost:11000/oozie -start 
> 14-20090525161321-oozie-joe
> 
> The =start= option starts a previously submitted workflow job, coordinator 
> job or bundle job that is in =PREP= status.
> After the command is executed the workflow job will be in =RUNNING= status, 
> coordinator job will be in =RUNNING= status and
> bundle job will be in =RUNNING=status.{quote}
> As of OOZIE-923 this should not be possible. The documentation should be 
> changed to not include coordinators in this section or mention that starting 
> a coordinator from the CLI is not possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OOZIE-2957) Documentation states that starting a coordinator is possible

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2957:


 Summary: Documentation states that starting a coordinator is 
possible
 Key: OOZIE-2957
 URL: https://issues.apache.org/jira/browse/OOZIE-2957
 Project: Oozie
  Issue Type: Bug
  Components: coordinator, docs
Affects Versions: 5.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel


The documentation of the command line tools states that starting a coordinator 
is possible

{quote}---+++ Starting a Workflow, Coordinator or Bundle Job

Example:


$ oozie job -oozie http://localhost:11000/oozie -start 
14-20090525161321-oozie-joe


The =start= option starts a previously submitted workflow job, coordinator job 
or bundle job that is in =PREP= status.

After the command is executed the workflow job will be in =RUNNING= status, 
coordinator job will be in =RUNNING= status and
bundle job will be in =RUNNING=status.{quote}

As of OOZIE-923 this should not be possible. The documentation should be 
changed to not include coordinators in this section or mention that starting a 
coordinator from the CLI is not possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2955) Fix Findbugs warnings related to reliance on default encoding in oozie-client

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053278#comment-16053278
 ] 

Jan Hentschel commented on OOZIE-2955:
--

Not sure, if the test failures are related.

> Fix Findbugs warnings related to reliance on default encoding in oozie-client
> -
>
> Key: OOZIE-2955
> URL: https://issues.apache.org/jira/browse/OOZIE-2955
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2955-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-client* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new 
> java.io.PrintWriter(OutputStream) [org.apache.oozie.cli.CLIParser] At 
> CLIParser.java:[line 169]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 845]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 2171]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.readAuthToken(): new 
> java.io.FileReader(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 218]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token):
>  new java.io.FileWriter(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 248]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient.getSupportedProtocolVersions(): new 
> java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient] 
> At OozieClient.java:[line 412]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BulkResponseStatus.call(HttpURLConnection):
>  new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BulkResponseStatus] At 
> OozieClient.java:[line 1693]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobInfo] At OozieClient.java:[line 
> 1502]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobsStatus] At 
> OozieClient.java:[line 1667]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionInfo] At 
> OozieClient.java:[line 1522]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionsKill.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionsKill] At 
> OozieClient.java:[line 1720]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordIgnore.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordIgnore] At OozieClient.java:[line 
> 1743]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobInfo.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobInfo] At OozieClient.java:[line 
> 1455]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobsStatus] At 
> OozieClient.java:[line 1640]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordRerun.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordRerun] At OozieClient.java:[line 
> 1773]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$GetBuildVersion.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$GetBuildVersion] At 
> OozieClient.java:[line 2168]
> [INFO] Found reliance on default encoding in 
> 

[jira] [Updated] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2956:
-
Attachment: OOZIE-2956-1.patch

I also fixed some styling issues.

> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2956-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): 
> java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
> 69]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): 
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At 
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 684]Another occurrence at 
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 502]Another occurrence at 
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At 
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
> String): java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At 
> CoordUpdateXCommand.java:[line 203]
> [INFO] Found reliance on default encoding in 
> 

[jira] [Created] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2956:


 Summary: Fix Findbugs warnings related to reliance on default 
encoding in oozie-core
 Key: OOZIE-2956
 URL: https://issues.apache.org/jira/browse/OOZIE-2956
 Project: Oozie
  Issue Type: Sub-task
  Components: build, core
Reporter: Jan Hentschel
Assignee: Jan Hentschel


Currently Findbugs complains about the following warnings related to the 
reliance on the default encoding in the *oozie-core* module:

{code}
[INFO] Found reliance on default encoding in 
org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
[org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.ActionExecutor.registerError(String, 
ActionExecutorException$ErrorType, String): 
java.io.ByteArrayOutputStream.toString() 
[org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.ActionExecutor.registerError(String, 
ActionExecutorException$ErrorType, String): new 
java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
ActionExecutor.java:[line 353]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
Path, String): new java.io.InputStreamReader(InputStream) 
[org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 69]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): String.getBytes() 
[org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
160]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
java.io.InputStreamReader(InputStream) 
[org.apache.oozie.action.hadoop.LauncherHelper$1, 
org.apache.oozie.action.hadoop.LauncherHelper$1, 
org.apache.oozie.action.hadoop.LauncherHelper$1, 
org.apache.oozie.action.hadoop.LauncherHelper$1, 
org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
293]Another occurrence at LauncherHelper.java:[line 299]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
 WorkflowAction): String.getBytes() 
[org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
MapReduceActionExecutor.java:[line 250]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context, 
WorkflowAction): String.getBytes() 
[org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
SqoopActionExecutor.java:[line 186]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
[org.apache.oozie.action.ssh.SshActionExecutor, 
org.apache.oozie.action.ssh.SshActionExecutor] At SshActionExecutor.java:[line 
684]Another occurrence at SshActionExecutor.java:[line 685]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
org.apache.oozie.action.ssh.SshActionExecutor] At SshActionExecutor.java:[line 
502]Another occurrence at SshActionExecutor.java:[line 504]
[INFO] Found reliance on default encoding in 
org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
new java.io.InputStreamReader(InputStream) 
[org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
BundleSubmitXCommand.java:[line 322]
[INFO] Found reliance on default encoding in 
org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): new 
java.io.InputStreamReader(InputStream) 
[org.apache.oozie.command.coord.CoordSubmitXCommand] At 
CoordSubmitXCommand.java:[line 1193]
[INFO] Found reliance on default encoding in 
org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
String): java.io.ByteArrayOutputStream.toString() 
[org.apache.oozie.command.coord.CoordUpdateXCommand] At 
CoordUpdateXCommand.java:[line 203]
[INFO] Found reliance on default encoding in 
org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
String): String.getBytes() [org.apache.oozie.command.coord.CoordUpdateXCommand, 
org.apache.oozie.command.coord.CoordUpdateXCommand] At 
CoordUpdateXCommand.java:[line 198]Another occurrence at 
CoordUpdateXCommand.java:[line 199]
[INFO] Found reliance on default encoding in 
org.apache.oozie.service.AuthorizationService.loadAdminUsers(): new 
java.io.InputStreamReader(InputStream) 
[org.apache.oozie.service.AuthorizationService] At 

[jira] [Updated] (OOZIE-2955) Fix Findbugs warnings related to reliance on default encoding in oozie-client

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2955:
-
Attachment: OOZIE-2955-1.patch

I also fixed some styling issues.

> Fix Findbugs warnings related to reliance on default encoding in oozie-client
> -
>
> Key: OOZIE-2955
> URL: https://issues.apache.org/jira/browse/OOZIE-2955
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2955-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-client* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new 
> java.io.PrintWriter(OutputStream) [org.apache.oozie.cli.CLIParser] At 
> CLIParser.java:[line 169]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 845]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 2171]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.readAuthToken(): new 
> java.io.FileReader(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 218]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token):
>  new java.io.FileWriter(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 248]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient.getSupportedProtocolVersions(): new 
> java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient] 
> At OozieClient.java:[line 412]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BulkResponseStatus.call(HttpURLConnection):
>  new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BulkResponseStatus] At 
> OozieClient.java:[line 1693]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobInfo] At OozieClient.java:[line 
> 1502]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobsStatus] At 
> OozieClient.java:[line 1667]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionInfo] At 
> OozieClient.java:[line 1522]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionsKill.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionsKill] At 
> OozieClient.java:[line 1720]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordIgnore.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordIgnore] At OozieClient.java:[line 
> 1743]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobInfo.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobInfo] At OozieClient.java:[line 
> 1455]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobsStatus] At 
> OozieClient.java:[line 1640]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordRerun.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordRerun] At OozieClient.java:[line 
> 1773]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$GetBuildVersion.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$GetBuildVersion] At 
> OozieClient.java:[line 2168]
> [INFO] Found reliance on default encoding in 
> 

[jira] [Created] (OOZIE-2955) Fix Findbugs warnings related to reliance on default encoding in oozie-client

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2955:


 Summary: Fix Findbugs warnings related to reliance on default 
encoding in oozie-client
 Key: OOZIE-2955
 URL: https://issues.apache.org/jira/browse/OOZIE-2955
 Project: Oozie
  Issue Type: Sub-task
  Components: build, client
Reporter: Jan Hentschel
Assignee: Jan Hentschel


Currently Findbugs complains about the following warnings related to the 
reliance on the default encoding in the *oozie-client* module:

{code}
[INFO] Found reliance on default encoding in 
org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new 
java.io.PrintWriter(OutputStream) [org.apache.oozie.cli.CLIParser] At 
CLIParser.java:[line 169]
[INFO] Found reliance on default encoding in 
org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new 
java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At OozieCLI.java:[line 
845]
[INFO] Found reliance on default encoding in 
org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new 
java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At OozieCLI.java:[line 
2171]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.AuthOozieClient.readAuthToken(): new 
java.io.FileReader(File) [org.apache.oozie.client.AuthOozieClient] At 
AuthOozieClient.java:[line 218]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token): 
new java.io.FileWriter(File) [org.apache.oozie.client.AuthOozieClient] At 
AuthOozieClient.java:[line 248]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient.getSupportedProtocolVersions(): new 
java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient] At 
OozieClient.java:[line 412]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$BulkResponseStatus.call(HttpURLConnection): 
new java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$BulkResponseStatus] At 
OozieClient.java:[line 1693]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$BundleJobInfo.call(HttpURLConnection): new 
java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$BundleJobInfo] At OozieClient.java:[line 
1502]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$BundleJobsStatus.call(HttpURLConnection): 
new java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$BundleJobsStatus] At 
OozieClient.java:[line 1667]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$CoordActionInfo.call(HttpURLConnection): 
new java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$CoordActionInfo] At OozieClient.java:[line 
1522]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$CoordActionsKill.call(HttpURLConnection): 
new java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$CoordActionsKill] At 
OozieClient.java:[line 1720]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$CoordIgnore.call(HttpURLConnection): new 
java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$CoordIgnore] At OozieClient.java:[line 
1743]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$CoordJobInfo.call(HttpURLConnection): new 
java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$CoordJobInfo] At OozieClient.java:[line 
1455]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$CoordJobsStatus.call(HttpURLConnection): 
new java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$CoordJobsStatus] At OozieClient.java:[line 
1640]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$CoordRerun.call(HttpURLConnection): new 
java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$CoordRerun] At OozieClient.java:[line 1773]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$GetBuildVersion.call(HttpURLConnection): 
new java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$GetBuildVersion] At OozieClient.java:[line 
2168]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$GetInstrumentation.call(HttpURLConnection): 
new java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$GetInstrumentation] At 
OozieClient.java:[line 2907]
[INFO] Found reliance on default encoding in 
org.apache.oozie.client.OozieClient$GetMetrics.call(HttpURLConnection): new 
java.io.InputStreamReader(InputStream) 
[org.apache.oozie.client.OozieClient$GetMetrics] At OozieClient.java:[line 2674]
[INFO] Found reliance on default encoding in 

[jira] [Updated] (OOZIE-2954) Fix Checkstyle issues in oozie-client

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2954:
-
Attachment: OOZIE-2954-1.patch

> Fix Checkstyle issues in oozie-client
> -
>
> Key: OOZIE-2954
> URL: https://issues.apache.org/jira/browse/OOZIE-2954
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2954-1.patch
>
>
> Fix the Checkstyle issues in the *oozie-client* module:
> {code}
> oozie/client/src/main/java/org/apache/oozie/cli/CLIParser.java:165: warning: 
> Line has trailing spaces.
> oozie/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java:291: 
> warning: Line is longer than 132 characters.
> oozie/client/src/main/java/org/apache/oozie/client/BundleJob.java:56: 
> warning: Line has trailing spaces.
> oozie/client/src/main/java/org/apache/oozie/client/rest/JsonUtils.java:59: 
> warning: Line has trailing spaces.
> oozie/client/src/main/java/org/apache/oozie/client/WorkflowAction.java:65: 
> warning: Line has trailing spaces.
> oozie/client/src/main/java/org/apache/oozie/client/WorkflowAction.java:94: 
> warning: Line has trailing spaces.
> oozie/client/src/main/java/org/apache/oozie/client/WorkflowAction.java:101: 
> warning: Line has trailing spaces.
> oozie/client/src/main/java/org/apache/oozie/client/WorkflowAction.java:108: 
> warning: Line has trailing spaces.
> oozie/client/src/main/java/org/apache/oozie/client/WorkflowJob.java:138: 
> warning: Line has trailing spaces.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OOZIE-2954) Fix Checkstyle issues in oozie-client

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2954:


 Summary: Fix Checkstyle issues in oozie-client
 Key: OOZIE-2954
 URL: https://issues.apache.org/jira/browse/OOZIE-2954
 Project: Oozie
  Issue Type: Sub-task
  Components: build, client
Reporter: Jan Hentschel
Assignee: Jan Hentschel


Fix the Checkstyle issues in the *oozie-client* module:

{code}
oozie/client/src/main/java/org/apache/oozie/cli/CLIParser.java:165: warning: 
Line has trailing spaces.
oozie/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java:291: 
warning: Line is longer than 132 characters.
oozie/client/src/main/java/org/apache/oozie/client/BundleJob.java:56: warning: 
Line has trailing spaces.
oozie/client/src/main/java/org/apache/oozie/client/rest/JsonUtils.java:59: 
warning: Line has trailing spaces.
oozie/client/src/main/java/org/apache/oozie/client/WorkflowAction.java:65: 
warning: Line has trailing spaces.
oozie/client/src/main/java/org/apache/oozie/client/WorkflowAction.java:94: 
warning: Line has trailing spaces.
oozie/client/src/main/java/org/apache/oozie/client/WorkflowAction.java:101: 
warning: Line has trailing spaces.
oozie/client/src/main/java/org/apache/oozie/client/WorkflowAction.java:108: 
warning: Line has trailing spaces.
oozie/client/src/main/java/org/apache/oozie/client/WorkflowJob.java:138: 
warning: Line has trailing spaces.
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2953) Fix Checkstyle issues in oozie-tools

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2953:
-
Attachment: OOZIE-2953-1.patch

> Fix Checkstyle issues in oozie-tools
> 
>
> Key: OOZIE-2953
> URL: https://issues.apache.org/jira/browse/OOZIE-2953
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, tools
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2953-1.patch
>
>
> Fix the following Checkstyle issues in the *oozie-tools* module:
> {code}
> oozie/tools/src/main/java/org/apache/oozie/tools/OozieDBImportCLI.java:148: 
> warning: Line is longer than 132 characters.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OOZIE-2953) Fix Checkstyle issues in oozie-tools

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2953:


 Summary: Fix Checkstyle issues in oozie-tools
 Key: OOZIE-2953
 URL: https://issues.apache.org/jira/browse/OOZIE-2953
 Project: Oozie
  Issue Type: Sub-task
  Components: build, tools
Reporter: Jan Hentschel
Assignee: Jan Hentschel


Fix the following Checkstyle issues in the *oozie-tools* module:

{code}
oozie/tools/src/main/java/org/apache/oozie/tools/OozieDBImportCLI.java:148: 
warning: Line is longer than 132 characters.
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2252) Add HDFS extended ACL support in FS action

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052838#comment-16052838
 ] 

Jan Hentschel commented on OOZIE-2252:
--

[~jrkinley] Can you describe your use case a little bit? To me setting ACLs 
seem to be more a one time thing.

> Add HDFS extended ACL support in FS action
> --
>
> Key: OOZIE-2252
> URL: https://issues.apache.org/jira/browse/OOZIE-2252
> Project: Oozie
>  Issue Type: Improvement
>  Components: action
>Reporter: James Kinley
>Assignee: Satish Subhashrao Saley
>Priority: Minor
>
> Add support for the 'setfacl' command in the FS action.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2780) Upgrade minimum Hadoop version to 2.6.0

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052821#comment-16052821
 ] 

Jan Hentschel commented on OOZIE-2780:
--

[~dbist13] Did you already create a ticket for the extended attributes? I 
probably have a patch to include that.

> Upgrade minimum Hadoop version to 2.6.0
> ---
>
> Key: OOZIE-2780
> URL: https://issues.apache.org/jira/browse/OOZIE-2780
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 4.3.0
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
>  Labels: newbie
> Fix For: 5.0.0
>
> Attachments: OOZIE-2780-0.patch, OOZIE-2780-1.patch, 
> OOZIE-2780-2.patch
>
>
> I'd like to contribute an fs action enhancement to modify extended attributes 
> to core but methods to change extended attributes is not available in 
> hadoop-common < 2.6.0. Currently hadoop-common is at 2.4. I am contributing a 
> patch to bump to 2.6 but so far I haven't been able to generate a clean test 
> as tests in core module fail randomly. On the first run, I had a failure on 
> {code} Failed tests:   
> testCheckAfterActionDelete(org.apache.oozie.service.TestHAPartitionDependencyManagerService):
>  Expected:  but was: [000-170123095541655-oozie-aerv-C@1]{code}
> and on second run
> {code}Failed tests:   testWaitFor(org.apache.oozie.test.TestXTestCase): 
> expected:<1000.0> but was:<2036.0>{code}
> I can't tell whether it is due to my patch?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2914) Consolidate Trim

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2914:
-
Attachment: OOZIE-2914-1.patch

> Consolidate Trim 
> -
>
> Key: OOZIE-2914
> URL: https://issues.apache.org/jira/browse/OOZIE-2914
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Jan Hentschel
>  Labels: newbie
> Attachments: OOZIE-2914-1.patch
>
>
> There are some [tTrim] functions across our codebase:
> {code}
> 171- * @return the formatted time string.
> >> [350] 14:20 : oozie (cdh6.x) :: ack -C8 --type=java "[tT]rim\(String"
> core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java
> 89-}
> 90-
> 91-/**
> 92- * To trim string
> 93- *
> 94- * @param str
> 95- * @return trim string
> 96- */
> 97:public String trim(String str) {
> 98-if (str != null) {
> 99-str = str.replaceAll("\\n", "");
> 100-str = str.replaceAll("\\t", "");
> 101-str = str.trim();
> 102-}
> 103-return str;
> 104-}
> 105-}
> core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java
> 81-}
> 82-
> 83-/**
> 84- * To trim string
> 85- *
> 86- * @param str
> 87- * @return trim string
> 88- */
> 89:public static String Trim(String str) {
> 90-if (str != null) {
> 91-str = str.replaceAll("\\n", "");
> 92-str = str.replaceAll("\\t", "");
> 93-str = str.trim();
> 94-}
> 95-return str;
> 96-}
> 97-
> {code}
> The purpose of these functions is to clean up input from xml files.
> They should be consolidated to one place. 
> There might be a similar method in Hadoop, we should use that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (OOZIE-2914) Consolidate Trim

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned OOZIE-2914:


Assignee: Jan Hentschel

> Consolidate Trim 
> -
>
> Key: OOZIE-2914
> URL: https://issues.apache.org/jira/browse/OOZIE-2914
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Jan Hentschel
>  Labels: newbie
>
> There are some [tTrim] functions across our codebase:
> {code}
> 171- * @return the formatted time string.
> >> [350] 14:20 : oozie (cdh6.x) :: ack -C8 --type=java "[tT]rim\(String"
> core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java
> 89-}
> 90-
> 91-/**
> 92- * To trim string
> 93- *
> 94- * @param str
> 95- * @return trim string
> 96- */
> 97:public String trim(String str) {
> 98-if (str != null) {
> 99-str = str.replaceAll("\\n", "");
> 100-str = str.replaceAll("\\t", "");
> 101-str = str.trim();
> 102-}
> 103-return str;
> 104-}
> 105-}
> core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java
> 81-}
> 82-
> 83-/**
> 84- * To trim string
> 85- *
> 86- * @param str
> 87- * @return trim string
> 88- */
> 89:public static String Trim(String str) {
> 90-if (str != null) {
> 91-str = str.replaceAll("\\n", "");
> 92-str = str.replaceAll("\\t", "");
> 93-str = str.trim();
> 94-}
> 95-return str;
> 96-}
> 97-
> {code}
> The purpose of these functions is to clean up input from xml files.
> They should be consolidated to one place. 
> There might be a similar method in Hadoop, we should use that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2952) Fix Findbugs warnings in oozie-sharelib-oozie

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2952:
-
Attachment: OOZIE-2952-1.patch

> Fix Findbugs warnings in oozie-sharelib-oozie
> -
>
> Key: OOZIE-2952
> URL: https://issues.apache.org/jira/browse/OOZIE-2952
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2952-1.patch
>
>
> Currently Findbugs complains about the following warnings in the 
> *oozie-sharelib-oozie* module:
> {code}
> [INFO] The class org.apache.oozie.action.hadoop.HdfsOperations$2 could be 
> refactored into a named _static_ inner class 
> [org.apache.oozie.action.hadoop.HdfsOperations] At HdfsOperations.java:[line 
> 80]
> [INFO] The class org.apache.oozie.action.hadoop.HdfsOperations$3 could be 
> refactored into a named _static_ inner class 
> [org.apache.oozie.action.hadoop.HdfsOperations] At HdfsOperations.java:[line 
> 91]
> [INFO] The class org.apache.oozie.action.hadoop.HdfsOperations$4 could be 
> refactored into a named _static_ inner class 
> [org.apache.oozie.action.hadoop.HdfsOperations] At HdfsOperations.java:[line 
> 105]
> [INFO] Use of non-localized String.toUpperCase() or String.toLowerCase() in 
> org.apache.oozie.action.hadoop.LauncherMain.printArgs(String, String[]) 
> [org.apache.oozie.action.hadoop.LauncherMain] At LauncherMain.java:[line 416]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherMain.getHadoopJobIds(String, 
> Pattern[]): new java.io.FileReader(String) 
> [org.apache.oozie.action.hadoop.LauncherMain] At LauncherMain.java:[line 139]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherMain.writeExternalChildIDs(String, 
> Pattern[], String): String.getBytes() 
> [org.apache.oozie.action.hadoop.LauncherMain] At LauncherMain.java:[line 175]
> [INFO] org.apache.oozie.action.hadoop.LauncherMain.HADOOP_SITE_FILES should 
> be both final and package protected 
> [org.apache.oozie.action.hadoop.LauncherMain] At LauncherMain.java:[line 76]
> [INFO] Exceptional return value of java.io.File.mkdirs() ignored in 
> org.apache.oozie.action.hadoop.LauncherMain.writeHadoopConfig(String, File) 
> [org.apache.oozie.action.hadoop.LauncherMain] At LauncherMain.java:[line 394]
> [INFO] Use of non-localized String.toUpperCase() or String.toLowerCase() in 
> org.apache.oozie.action.hadoop.LauncherMapper.printArgs(String, String[]) 
> [org.apache.oozie.action.hadoop.LauncherMapper] At LauncherMapper.java:[line 
> 660]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File, 
> String, int): new java.io.FileReader(File) 
> [org.apache.oozie.action.hadoop.LauncherMapper] At LauncherMapper.java:[line 
> 407]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.hadoop.LauncherMapper] At 
> LauncherMapper.java:[line 355]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf(): new 
> java.io.OutputStreamWriter(OutputStream) 
> [org.apache.oozie.action.hadoop.LauncherMapper] At LauncherMapper.java:[line 
> 356]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherMapper.setRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherMapper] At LauncherMapper.java:[line 
> 107]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherMapper.setRecoveryId(Configuration, 
> Path, String): new java.io.OutputStreamWriter(OutputStream) 
> [org.apache.oozie.action.hadoop.LauncherMapper] At LauncherMapper.java:[line 
> 97]
> [INFO] 
> org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File, 
> String, int) may fail to clean up java.io.Reader on checked exception 
> [org.apache.oozie.action.hadoop.LauncherMapper, 
> org.apache.oozie.action.hadoop.LauncherMapper, 
> org.apache.oozie.action.hadoop.LauncherMapper, 
> org.apache.oozie.action.hadoop.LauncherMapper] Obligation to clean up 
> resource created at LauncherMapper.java:[line 407] is not dischargedPath 
> continues at LauncherMapper.java:[line 408]Path continues at 
> LauncherMapper.java:[line 410]Path continues at LauncherMapper.java:[line 411]
> [INFO] org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf() 
> may fail to clean up java.io.Writer on checked exception 
> [org.apache.oozie.action.hadoop.LauncherMapper] Obligation to clean up 
> resource created at LauncherMapper.java:[line 355] is not discharged
> [INFO] 
> 

[jira] [Created] (OOZIE-2952) Fix Findbugs warnings in oozie-sharelib-oozie

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2952:


 Summary: Fix Findbugs warnings in oozie-sharelib-oozie
 Key: OOZIE-2952
 URL: https://issues.apache.org/jira/browse/OOZIE-2952
 Project: Oozie
  Issue Type: Sub-task
  Components: build
Reporter: Jan Hentschel
Assignee: Jan Hentschel


Currently Findbugs complains about the following warnings in the 
*oozie-sharelib-oozie* module:

{code}
[INFO] The class org.apache.oozie.action.hadoop.HdfsOperations$2 could be 
refactored into a named _static_ inner class 
[org.apache.oozie.action.hadoop.HdfsOperations] At HdfsOperations.java:[line 80]
[INFO] The class org.apache.oozie.action.hadoop.HdfsOperations$3 could be 
refactored into a named _static_ inner class 
[org.apache.oozie.action.hadoop.HdfsOperations] At HdfsOperations.java:[line 91]
[INFO] The class org.apache.oozie.action.hadoop.HdfsOperations$4 could be 
refactored into a named _static_ inner class 
[org.apache.oozie.action.hadoop.HdfsOperations] At HdfsOperations.java:[line 
105]
[INFO] Use of non-localized String.toUpperCase() or String.toLowerCase() in 
org.apache.oozie.action.hadoop.LauncherMain.printArgs(String, String[]) 
[org.apache.oozie.action.hadoop.LauncherMain] At LauncherMain.java:[line 416]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.LauncherMain.getHadoopJobIds(String, Pattern[]): 
new java.io.FileReader(String) [org.apache.oozie.action.hadoop.LauncherMain] At 
LauncherMain.java:[line 139]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.LauncherMain.writeExternalChildIDs(String, 
Pattern[], String): String.getBytes() 
[org.apache.oozie.action.hadoop.LauncherMain] At LauncherMain.java:[line 175]
[INFO] org.apache.oozie.action.hadoop.LauncherMain.HADOOP_SITE_FILES should be 
both final and package protected [org.apache.oozie.action.hadoop.LauncherMain] 
At LauncherMain.java:[line 76]
[INFO] Exceptional return value of java.io.File.mkdirs() ignored in 
org.apache.oozie.action.hadoop.LauncherMain.writeHadoopConfig(String, File) 
[org.apache.oozie.action.hadoop.LauncherMain] At LauncherMain.java:[line 394]
[INFO] Use of non-localized String.toUpperCase() or String.toLowerCase() in 
org.apache.oozie.action.hadoop.LauncherMapper.printArgs(String, String[]) 
[org.apache.oozie.action.hadoop.LauncherMapper] At LauncherMapper.java:[line 
660]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File, 
String, int): new java.io.FileReader(File) 
[org.apache.oozie.action.hadoop.LauncherMapper] At LauncherMapper.java:[line 
407]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf(): new 
java.io.FileWriter(String) [org.apache.oozie.action.hadoop.LauncherMapper] At 
LauncherMapper.java:[line 355]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf(): new 
java.io.OutputStreamWriter(OutputStream) 
[org.apache.oozie.action.hadoop.LauncherMapper] At LauncherMapper.java:[line 
356]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.LauncherMapper.setRecoveryId(Configuration, 
Path, String): new java.io.InputStreamReader(InputStream) 
[org.apache.oozie.action.hadoop.LauncherMapper] At LauncherMapper.java:[line 
107]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.LauncherMapper.setRecoveryId(Configuration, 
Path, String): new java.io.OutputStreamWriter(OutputStream) 
[org.apache.oozie.action.hadoop.LauncherMapper] At LauncherMapper.java:[line 97]
[INFO] 
org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File, 
String, int) may fail to clean up java.io.Reader on checked exception 
[org.apache.oozie.action.hadoop.LauncherMapper, 
org.apache.oozie.action.hadoop.LauncherMapper, 
org.apache.oozie.action.hadoop.LauncherMapper, 
org.apache.oozie.action.hadoop.LauncherMapper] Obligation to clean up resource 
created at LauncherMapper.java:[line 407] is not dischargedPath continues at 
LauncherMapper.java:[line 408]Path continues at LauncherMapper.java:[line 
410]Path continues at LauncherMapper.java:[line 411]
[INFO] org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf() 
may fail to clean up java.io.Writer on checked exception 
[org.apache.oozie.action.hadoop.LauncherMapper] Obligation to clean up resource 
created at LauncherMapper.java:[line 355] is not discharged
[INFO] 
org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File, 
String, int) may fail to close stream on exception 
[org.apache.oozie.action.hadoop.LauncherMapper] At LauncherMapper.java:[line 
407]
[INFO] 
org.apache.oozie.action.hadoop.LauncherMapper.setRecoveryId(Configuration, 
Path, String) may fail to close stream on exception 
[org.apache.oozie.action.hadoop.LauncherMapper] At 

[jira] [Commented] (OOZIE-2946) Include find-sec-bugs plugin

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051662#comment-16051662
 ] 

Jan Hentschel commented on OOZIE-2946:
--

I'm not sure if the build compares the differences to the master or to previous 
runs. If I start a Maven build locally via mvn clean install I see the new 
problems, such as the one found in DistcpMain.

> Include find-sec-bugs plugin
> 
>
> Key: OOZIE-2946
> URL: https://issues.apache.org/jira/browse/OOZIE-2946
> Project: Oozie
>  Issue Type: Task
>  Components: build, security
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2946-1.patch, OOZIE-2946-2.patch
>
>
> The [Find Security Bugs|http://find-sec-bugs.github.io/] plugin looks for 
> security bugs in Java web apps, such as Oozie. This plugin should be included 
> in the build process.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2943) Fix Findbugs warnings in oozie-sharelib-pig

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050150#comment-16050150
 ] 

Jan Hentschel commented on OOZIE-2943:
--

Not sure, if the failing tests are flaky. Locally they are running fine.

> Fix Findbugs warnings in oozie-sharelib-pig
> ---
>
> Key: OOZIE-2943
> URL: https://issues.apache.org/jira/browse/OOZIE-2943
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2943-1.patch, OOZIE-2943-2.patch
>
>
> Currently Findbugs complains about the following warnings in the 
> *oozie-sharelib-pig* module:
> {code}
> [INFO] 
> org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map)
>  makes inefficient use of keySet iterator instead of entrySet iterator 
> [org.apache.oozie.action.hadoop.OoziePigStats] At OoziePigStats.java:[line 
> 130]
> [INFO] Dead store to klass in 
> org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean, 
> boolean) [org.apache.oozie.action.hadoop.PigMain] At PigMain.java:[line 335]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMain.handleError(String): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 307]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMain.writeExternalData(String, File): new 
> java.io.FileWriter(File) [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 408]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to clean 
> up java.io.OutputStream on checked exception 
> [org.apache.oozie.action.hadoop.PigMain, 
> org.apache.oozie.action.hadoop.PigMain] Obligation to clean up resource 
> created at PigMain.java:[line 130] is not dischargedPath continues at 
> PigMain.java:[line 131]
> [INFO] org.apache.oozie.action.hadoop.PigMain.handleError(String) may fail to 
> close stream on exception [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 307]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to close 
> stream on exception [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 130]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI] 
> At PigMainWithOldAPI.java:[line 265]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 126]Another occurrence at 
> PigMainWithOldAPI.java:[line 219]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to clean up java.io.OutputStream on checked exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] Obligation to clean up 
> resource created at PigMainWithOldAPI.java:[line 101] is not dischargedPath 
> continues at PigMainWithOldAPI.java:[line 102]
> [INFO] 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 265]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 101]Another occurrence at 
> PigMainWithOldAPI.java:[line 242]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 126]Another occurrence at 
> PigMainWithOldAPI.java:[line 219]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2946) Include find-sec-bugs plugin

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050140#comment-16050140
 ] 

Jan Hentschel commented on OOZIE-2946:
--

[~rkanter] I moved the version of findbugs-maven-plugin to the 
pluginManagement, but I was not able to move findsecbugs to it. It seems that 
Maven doesn't pick up the version for a dependency of a plugin (had the same 
problem with the findbugs dependency of the xml-maven-plugin) if you define it 
in the dependencyManagement or pluginManagement.

> Include find-sec-bugs plugin
> 
>
> Key: OOZIE-2946
> URL: https://issues.apache.org/jira/browse/OOZIE-2946
> Project: Oozie
>  Issue Type: Task
>  Components: build, security
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2946-1.patch, OOZIE-2946-2.patch
>
>
> The [Find Security Bugs|http://find-sec-bugs.github.io/] plugin looks for 
> security bugs in Java web apps, such as Oozie. This plugin should be included 
> in the build process.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2946) Include find-sec-bugs plugin

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2946:
-
Attachment: OOZIE-2946-2.patch

> Include find-sec-bugs plugin
> 
>
> Key: OOZIE-2946
> URL: https://issues.apache.org/jira/browse/OOZIE-2946
> Project: Oozie
>  Issue Type: Task
>  Components: build, security
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2946-1.patch, OOZIE-2946-2.patch
>
>
> The [Find Security Bugs|http://find-sec-bugs.github.io/] plugin looks for 
> security bugs in Java web apps, such as Oozie. This plugin should be included 
> in the build process.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-1967) Fix checkstyle issues

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050101#comment-16050101
 ] 

Jan Hentschel commented on OOZIE-1967:
--

Currently there are a lot of checkstyle issues in a lot of different files, 
especially in *oozie-core*. I would like to close this one and open sub-tasks 
in OOZIE-1965 to make it more granular.

> Fix checkstyle issues
> -
>
> Key: OOZIE-1967
> URL: https://issues.apache.org/jira/browse/OOZIE-1967
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Shwetha G S
>Assignee: Jan Hentschel
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2943) Fix Findbugs warnings in oozie-sharelib-pig

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049072#comment-16049072
 ] 

Jan Hentschel commented on OOZIE-2943:
--

[~gezapeti] You're absolutely right. I updated the patch accordingly.

> Fix Findbugs warnings in oozie-sharelib-pig
> ---
>
> Key: OOZIE-2943
> URL: https://issues.apache.org/jira/browse/OOZIE-2943
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2943-1.patch, OOZIE-2943-2.patch
>
>
> Currently Findbugs complains about the following warnings in the 
> *oozie-sharelib-pig* module:
> {code}
> [INFO] 
> org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map)
>  makes inefficient use of keySet iterator instead of entrySet iterator 
> [org.apache.oozie.action.hadoop.OoziePigStats] At OoziePigStats.java:[line 
> 130]
> [INFO] Dead store to klass in 
> org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean, 
> boolean) [org.apache.oozie.action.hadoop.PigMain] At PigMain.java:[line 335]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMain.handleError(String): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 307]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMain.writeExternalData(String, File): new 
> java.io.FileWriter(File) [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 408]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to clean 
> up java.io.OutputStream on checked exception 
> [org.apache.oozie.action.hadoop.PigMain, 
> org.apache.oozie.action.hadoop.PigMain] Obligation to clean up resource 
> created at PigMain.java:[line 130] is not dischargedPath continues at 
> PigMain.java:[line 131]
> [INFO] org.apache.oozie.action.hadoop.PigMain.handleError(String) may fail to 
> close stream on exception [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 307]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to close 
> stream on exception [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 130]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI] 
> At PigMainWithOldAPI.java:[line 265]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 126]Another occurrence at 
> PigMainWithOldAPI.java:[line 219]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to clean up java.io.OutputStream on checked exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] Obligation to clean up 
> resource created at PigMainWithOldAPI.java:[line 101] is not dischargedPath 
> continues at PigMainWithOldAPI.java:[line 102]
> [INFO] 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 265]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 101]Another occurrence at 
> PigMainWithOldAPI.java:[line 242]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 126]Another occurrence at 
> PigMainWithOldAPI.java:[line 219]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2943) Fix Findbugs warnings in oozie-sharelib-pig

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2943:
-
Attachment: OOZIE-2943-2.patch

> Fix Findbugs warnings in oozie-sharelib-pig
> ---
>
> Key: OOZIE-2943
> URL: https://issues.apache.org/jira/browse/OOZIE-2943
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2943-1.patch, OOZIE-2943-2.patch
>
>
> Currently Findbugs complains about the following warnings in the 
> *oozie-sharelib-pig* module:
> {code}
> [INFO] 
> org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map)
>  makes inefficient use of keySet iterator instead of entrySet iterator 
> [org.apache.oozie.action.hadoop.OoziePigStats] At OoziePigStats.java:[line 
> 130]
> [INFO] Dead store to klass in 
> org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean, 
> boolean) [org.apache.oozie.action.hadoop.PigMain] At PigMain.java:[line 335]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMain.handleError(String): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 307]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMain.writeExternalData(String, File): new 
> java.io.FileWriter(File) [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 408]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to clean 
> up java.io.OutputStream on checked exception 
> [org.apache.oozie.action.hadoop.PigMain, 
> org.apache.oozie.action.hadoop.PigMain] Obligation to clean up resource 
> created at PigMain.java:[line 130] is not dischargedPath continues at 
> PigMain.java:[line 131]
> [INFO] org.apache.oozie.action.hadoop.PigMain.handleError(String) may fail to 
> close stream on exception [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 307]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to close 
> stream on exception [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 130]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI] 
> At PigMainWithOldAPI.java:[line 265]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 126]Another occurrence at 
> PigMainWithOldAPI.java:[line 219]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to clean up java.io.OutputStream on checked exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] Obligation to clean up 
> resource created at PigMainWithOldAPI.java:[line 101] is not dischargedPath 
> continues at PigMainWithOldAPI.java:[line 102]
> [INFO] 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 265]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 101]Another occurrence at 
> PigMainWithOldAPI.java:[line 242]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 126]Another occurrence at 
> PigMainWithOldAPI.java:[line 219]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2946) Include find-sec-bugs plugin

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049032#comment-16049032
 ] 

Jan Hentschel commented on OOZIE-2946:
--

The Findbugs problems are expected due to the nature of the patch. Solving the 
new warnings should be part of another ticket. The failed tests seem to be 
flaky.

> Include find-sec-bugs plugin
> 
>
> Key: OOZIE-2946
> URL: https://issues.apache.org/jira/browse/OOZIE-2946
> Project: Oozie
>  Issue Type: Task
>  Components: build, security
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2946-1.patch
>
>
> The [Find Security Bugs|http://find-sec-bugs.github.io/] plugin looks for 
> security bugs in Java web apps, such as Oozie. This plugin should be included 
> in the build process.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (OOZIE-1967) Fix checkstyle issues

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned OOZIE-1967:


Assignee: Jan Hentschel

> Fix checkstyle issues
> -
>
> Key: OOZIE-1967
> URL: https://issues.apache.org/jira/browse/OOZIE-1967
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Shwetha G S
>Assignee: Jan Hentschel
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2946) Include find-sec-bugs plugin

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2946:
-
Attachment: OOZIE-2946-1.patch

> Include find-sec-bugs plugin
> 
>
> Key: OOZIE-2946
> URL: https://issues.apache.org/jira/browse/OOZIE-2946
> Project: Oozie
>  Issue Type: Task
>  Components: build, security
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2946-1.patch
>
>
> The [Find Security Bugs|http://find-sec-bugs.github.io/] plugin looks for 
> security bugs in Java web apps, such as Oozie. This plugin should be included 
> in the build process.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (OOZIE-2946) Include find-sec-bugs plugin

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned OOZIE-2946:


Assignee: Jan Hentschel

> Include find-sec-bugs plugin
> 
>
> Key: OOZIE-2946
> URL: https://issues.apache.org/jira/browse/OOZIE-2946
> Project: Oozie
>  Issue Type: Task
>  Components: build, security
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> The [Find Security Bugs|http://find-sec-bugs.github.io/] plugin looks for 
> security bugs in Java web apps, such as Oozie. This plugin should be included 
> in the build process.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2933) Switch from Findbugs to Spotbugs

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048801#comment-16048801
 ] 

Jan Hentschel commented on OOZIE-2933:
--

[~rkanter] Thanks for your comments. I updated the patch to the latest RC 
version and filed OOZIE-2945 for moving to the GA version as soon as it is 
available. For the "find-sec-bugs" I opened OOZIE-2946. I didn't include it in 
this patch to have a better separation.

Regarding ReviewBoard: Thanks for the hint. I will keep it in mind.

> Switch from Findbugs to Spotbugs
> 
>
> Key: OOZIE-2933
> URL: https://issues.apache.org/jira/browse/OOZIE-2933
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2933-1.patch, OOZIE-2933-2.patch, 
> oozie-findbugs-pre-commit.txt
>
>
> Because Findbugs hadn't a new release in some time other projects such as 
> Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch 
> the current Findbugs implementation to Spotbugs, similar to the changes made 
> to Hadoop and HBase.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OOZIE-2946) Include find-sec-bugs plugin

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2946:


 Summary: Include find-sec-bugs plugin
 Key: OOZIE-2946
 URL: https://issues.apache.org/jira/browse/OOZIE-2946
 Project: Oozie
  Issue Type: Task
  Components: build, security
Reporter: Jan Hentschel
Priority: Minor


The [Find Security Bugs|http://find-sec-bugs.github.io/] plugin looks for 
security bugs in Java web apps, such as Oozie. This plugin should be included 
in the build process.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OOZIE-2945) Update SpotBugs to stable version after GA

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2945:


 Summary: Update SpotBugs to stable version after GA
 Key: OOZIE-2945
 URL: https://issues.apache.org/jira/browse/OOZIE-2945
 Project: Oozie
  Issue Type: Task
  Components: build
Reporter: Jan Hentschel
Priority: Minor


Currently Oozie uses an RC version of SpotBugs. As soon as SpotBugs has a GA 
version the current version should be raised to the GA version.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2933) Switch from Findbugs to Spotbugs

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2933:
-
Attachment: OOZIE-2933-2.patch

> Switch from Findbugs to Spotbugs
> 
>
> Key: OOZIE-2933
> URL: https://issues.apache.org/jira/browse/OOZIE-2933
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2933-1.patch, OOZIE-2933-2.patch, 
> oozie-findbugs-pre-commit.txt
>
>
> Because Findbugs hadn't a new release in some time other projects such as 
> Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch 
> the current Findbugs implementation to Spotbugs, similar to the changes made 
> to Hadoop and HBase.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (OOZIE-2942) Fix Findbugs warnings in oozie-examples

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047970#comment-16047970
 ] 

Jan Hentschel edited comment on OOZIE-2942 at 6/13/17 2:35 PM:
---

The test failures seem to be unrelated to the actual changes.


was (Author: jan hentschel):
The test failures seem to be unrelated to the actual change.

> Fix Findbugs warnings in oozie-examples
> ---
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the 
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close 
> stream on exception [org.apache.oozie.example.DateList] At 
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in 
> org.apache.oozie.example.DateList.main(String[]) 
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At 
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method 
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called 
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource 
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues 
> at LocalOozieExample.java:[line 76]Path continues at 
> LocalOozieExample.java:[line 77]Path continues at 
> LocalOozieExample.java:[line 78]Path continues at 
> LocalOozieExample.java:[line 81]Path continues at 
> LocalOozieExample.java:[line 88]Path continues at 
> LocalOozieExample.java:[line 89]Path continues at 
> LocalOozieExample.java:[line 91]Path continues at 
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to close stream [org.apache.oozie.example.LocalOozieExample] At 
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal 
> representation by returning Repeatable.baseline 
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose 
> internal representation by storing an externally mutable object into 
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At 
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2942) Fix Findbugs warnings in oozie-examples

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047970#comment-16047970
 ] 

Jan Hentschel commented on OOZIE-2942:
--

The test failures seem to be unrelated to the actual change.

> Fix Findbugs warnings in oozie-examples
> ---
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the 
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close 
> stream on exception [org.apache.oozie.example.DateList] At 
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in 
> org.apache.oozie.example.DateList.main(String[]) 
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At 
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method 
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called 
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource 
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues 
> at LocalOozieExample.java:[line 76]Path continues at 
> LocalOozieExample.java:[line 77]Path continues at 
> LocalOozieExample.java:[line 78]Path continues at 
> LocalOozieExample.java:[line 81]Path continues at 
> LocalOozieExample.java:[line 88]Path continues at 
> LocalOozieExample.java:[line 89]Path continues at 
> LocalOozieExample.java:[line 91]Path continues at 
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to close stream [org.apache.oozie.example.LocalOozieExample] At 
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal 
> representation by returning Repeatable.baseline 
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose 
> internal representation by storing an externally mutable object into 
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At 
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2942) Fix Findbugs warnings in oozie-examples

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2942:
-
Attachment: OOZIE-2942-2.patch

Trying to fix build warnings.

> Fix Findbugs warnings in oozie-examples
> ---
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the 
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close 
> stream on exception [org.apache.oozie.example.DateList] At 
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in 
> org.apache.oozie.example.DateList.main(String[]) 
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At 
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method 
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called 
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource 
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues 
> at LocalOozieExample.java:[line 76]Path continues at 
> LocalOozieExample.java:[line 77]Path continues at 
> LocalOozieExample.java:[line 78]Path continues at 
> LocalOozieExample.java:[line 81]Path continues at 
> LocalOozieExample.java:[line 88]Path continues at 
> LocalOozieExample.java:[line 89]Path continues at 
> LocalOozieExample.java:[line 91]Path continues at 
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to close stream [org.apache.oozie.example.LocalOozieExample] At 
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal 
> representation by returning Repeatable.baseline 
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose 
> internal representation by storing an externally mutable object into 
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At 
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2943) Fix Findbugs warnings in oozie-sharelib-pig

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2943:
-
Attachment: OOZIE-2943-1.patch

> Fix Findbugs warnings in oozie-sharelib-pig
> ---
>
> Key: OOZIE-2943
> URL: https://issues.apache.org/jira/browse/OOZIE-2943
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2943-1.patch
>
>
> Currently Findbugs complains about the following warnings in the 
> *oozie-sharelib-pig* module:
> {code}
> [INFO] 
> org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map)
>  makes inefficient use of keySet iterator instead of entrySet iterator 
> [org.apache.oozie.action.hadoop.OoziePigStats] At OoziePigStats.java:[line 
> 130]
> [INFO] Dead store to klass in 
> org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean, 
> boolean) [org.apache.oozie.action.hadoop.PigMain] At PigMain.java:[line 335]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMain.handleError(String): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 307]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMain.writeExternalData(String, File): new 
> java.io.FileWriter(File) [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 408]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to clean 
> up java.io.OutputStream on checked exception 
> [org.apache.oozie.action.hadoop.PigMain, 
> org.apache.oozie.action.hadoop.PigMain] Obligation to clean up resource 
> created at PigMain.java:[line 130] is not dischargedPath continues at 
> PigMain.java:[line 131]
> [INFO] org.apache.oozie.action.hadoop.PigMain.handleError(String) may fail to 
> close stream on exception [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 307]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to close 
> stream on exception [org.apache.oozie.action.hadoop.PigMain] At 
> PigMain.java:[line 130]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI] 
> At PigMainWithOldAPI.java:[line 265]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 126]Another occurrence at 
> PigMainWithOldAPI.java:[line 219]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to clean up java.io.OutputStream on checked exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] Obligation to clean up 
> resource created at PigMainWithOldAPI.java:[line 101] is not dischargedPath 
> continues at PigMainWithOldAPI.java:[line 102]
> [INFO] 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 265]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 101]Another occurrence at 
> PigMainWithOldAPI.java:[line 242]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may 
> fail to close stream on exception 
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
> PigMainWithOldAPI.java:[line 126]Another occurrence at 
> PigMainWithOldAPI.java:[line 219]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OOZIE-2943) Fix Findbugs warnings in oozie-sharelib-pig

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2943:


 Summary: Fix Findbugs warnings in oozie-sharelib-pig
 Key: OOZIE-2943
 URL: https://issues.apache.org/jira/browse/OOZIE-2943
 Project: Oozie
  Issue Type: Sub-task
  Components: build
Reporter: Jan Hentschel
Assignee: Jan Hentschel


Currently Findbugs complains about the following warnings in the 
*oozie-sharelib-pig* module:

{code}
[INFO] 
org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map) 
makes inefficient use of keySet iterator instead of entrySet iterator 
[org.apache.oozie.action.hadoop.OoziePigStats] At OoziePigStats.java:[line 130]
[INFO] Dead store to klass in 
org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean, 
boolean) [org.apache.oozie.action.hadoop.PigMain] At PigMain.java:[line 335]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.PigMain.handleError(String): new 
java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMain] At 
PigMain.java:[line 307]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.PigMain.writeExternalData(String, File): new 
java.io.FileWriter(File) [org.apache.oozie.action.hadoop.PigMain] At 
PigMain.java:[line 408]
[INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to clean 
up java.io.OutputStream on checked exception 
[org.apache.oozie.action.hadoop.PigMain, 
org.apache.oozie.action.hadoop.PigMain] Obligation to clean up resource created 
at PigMain.java:[line 130] is not dischargedPath continues at 
PigMain.java:[line 131]
[INFO] org.apache.oozie.action.hadoop.PigMain.handleError(String) may fail to 
close stream on exception [org.apache.oozie.action.hadoop.PigMain] At 
PigMain.java:[line 307]
[INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to close 
stream on exception [org.apache.oozie.action.hadoop.PigMain] At 
PigMain.java:[line 130]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String): new 
java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI] 
At PigMainWithOldAPI.java:[line 265]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]): new 
java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
PigMainWithOldAPI.java:[line 126]Another occurrence at 
PigMainWithOldAPI.java:[line 219]
[INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may fail 
to clean up java.io.OutputStream on checked exception 
[org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
org.apache.oozie.action.hadoop.PigMainWithOldAPI] Obligation to clean up 
resource created at PigMainWithOldAPI.java:[line 101] is not dischargedPath 
continues at PigMainWithOldAPI.java:[line 102]
[INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String) 
may fail to close stream on exception 
[org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
PigMainWithOldAPI.java:[line 265]
[INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may fail 
to close stream on exception [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
PigMainWithOldAPI.java:[line 101]Another occurrence at 
PigMainWithOldAPI.java:[line 242]
[INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may fail 
to close stream on exception [org.apache.oozie.action.hadoop.PigMainWithOldAPI, 
org.apache.oozie.action.hadoop.PigMainWithOldAPI] At 
PigMainWithOldAPI.java:[line 126]Another occurrence at 
PigMainWithOldAPI.java:[line 219]
{code}

They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2942) Fix Findbugs warnings in oozie-examples

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2942:
-
Attachment: OOZIE-2942-1.patch

> Fix Findbugs warnings in oozie-examples
> ---
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2942-1.patch
>
>
> Currently Findbugs complains about the following warnings in the 
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close 
> stream on exception [org.apache.oozie.example.DateList] At 
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in 
> org.apache.oozie.example.DateList.main(String[]) 
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At 
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method 
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called 
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample, 
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource 
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues 
> at LocalOozieExample.java:[line 76]Path continues at 
> LocalOozieExample.java:[line 77]Path continues at 
> LocalOozieExample.java:[line 78]Path continues at 
> LocalOozieExample.java:[line 81]Path continues at 
> LocalOozieExample.java:[line 88]Path continues at 
> LocalOozieExample.java:[line 89]Path continues at 
> LocalOozieExample.java:[line 91]Path continues at 
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail 
> to close stream [org.apache.oozie.example.LocalOozieExample] At 
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal 
> representation by returning Repeatable.baseline 
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose 
> internal representation by storing an externally mutable object into 
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At 
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OOZIE-2942) Fix Findbugs warnings in oozie-examples

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2942:


 Summary: Fix Findbugs warnings in oozie-examples
 Key: OOZIE-2942
 URL: https://issues.apache.org/jira/browse/OOZIE-2942
 Project: Oozie
  Issue Type: Sub-task
  Components: build
Reporter: Jan Hentschel
Assignee: Jan Hentschel


Currently Findbugs complains about the following warnings in the 
*oozie-examples* module:

{code}
[INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close 
stream on exception [org.apache.oozie.example.DateList] At DateList.java:[line 
69]
[INFO] Nullcheck of date at line 55 of value previously dereferenced in 
org.apache.oozie.example.DateList.main(String[]) 
[org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At 
DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
[INFO] Private method org.apache.oozie.example.DateList.formatDateUTC(Calendar) 
is never called [org.apache.oozie.example.DateList] At DateList.java:[line 97]
[INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to 
clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample, 
org.apache.oozie.example.LocalOozieExample, 
org.apache.oozie.example.LocalOozieExample, 
org.apache.oozie.example.LocalOozieExample, 
org.apache.oozie.example.LocalOozieExample, 
org.apache.oozie.example.LocalOozieExample, 
org.apache.oozie.example.LocalOozieExample, 
org.apache.oozie.example.LocalOozieExample, 
org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource 
created at LocalOozieExample.java:[line 72] is not dischargedPath continues at 
LocalOozieExample.java:[line 76]Path continues at LocalOozieExample.java:[line 
77]Path continues at LocalOozieExample.java:[line 78]Path continues at 
LocalOozieExample.java:[line 81]Path continues at LocalOozieExample.java:[line 
88]Path continues at LocalOozieExample.java:[line 89]Path continues at 
LocalOozieExample.java:[line 91]Path continues at LocalOozieExample.java:[line 
100]
[INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to 
close stream [org.apache.oozie.example.LocalOozieExample] At 
LocalOozieExample.java:[line 72]
[INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal 
representation by returning Repeatable.baseline 
[org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
[INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose 
internal representation by storing an externally mutable object into 
Repeatable.baseline [org.apache.oozie.example.Repeatable] At 
Repeatable.java:[line 172]
{code}

They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2939) Fix Findbugs warnings related to reliance on default encoding in oozie-sharelib-hive2 module

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2939:
-
Attachment: OOZIE-2939-1.patch

There's also a warning related to the System.exit call in *Hive2Main*. Not sure 
about how to handle this one and if this is the intended behavior.

> Fix Findbugs warnings related to reliance on default encoding in 
> oozie-sharelib-hive2 module
> 
>
> Key: OOZIE-2939
> URL: https://issues.apache.org/jira/browse/OOZIE-2939
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2939-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-sharelib-hive2* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.Hive2Main.readStringFromFile(String): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.Hive2Main] At 
> Hive2Main.java:[line 278]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.Hive2Main.runBeeline(String[], String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.hadoop.Hive2Main] 
> At Hive2Main.java:[line 266]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2939) Fix Findbugs warnings related to reliance on default encoding in oozie-sharelib-hive2 module

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2939:
-
Issue Type: Sub-task  (was: Bug)
Parent: OOZIE-1987

> Fix Findbugs warnings related to reliance on default encoding in 
> oozie-sharelib-hive2 module
> 
>
> Key: OOZIE-2939
> URL: https://issues.apache.org/jira/browse/OOZIE-2939
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-sharelib-hive2* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.Hive2Main.readStringFromFile(String): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.Hive2Main] At 
> Hive2Main.java:[line 278]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.Hive2Main.runBeeline(String[], String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.hadoop.Hive2Main] 
> At Hive2Main.java:[line 266]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OOZIE-2939) Fix Findbugs warnings related to reliance on default encoding in oozie-sharelib-hive2 module

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2939:


 Summary: Fix Findbugs warnings related to reliance on default 
encoding in oozie-sharelib-hive2 module
 Key: OOZIE-2939
 URL: https://issues.apache.org/jira/browse/OOZIE-2939
 Project: Oozie
  Issue Type: Bug
  Components: build
Reporter: Jan Hentschel
Assignee: Jan Hentschel


Currently Findbugs complains about the following warnings related to the 
reliance on the default encoding in the *oozie-sharelib-hive2* module:

{code}
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.Hive2Main.readStringFromFile(String): new 
java.io.FileReader(String) [org.apache.oozie.action.hadoop.Hive2Main] At 
Hive2Main.java:[line 278]
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.Hive2Main.runBeeline(String[], String): new 
java.io.PrintStream(OutputStream) [org.apache.oozie.action.hadoop.Hive2Main] At 
Hive2Main.java:[line 266]
{code}

They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OOZIE-2933) Switch from Findbugs to Spotbugs

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2933:
-
Attachment: oozie-findbugs-pre-commit.txt

I attached the output against the current master. The last lines look like the 
following

{code}


+1 PATCH_APPLIES
0 There are [40] new bugs found in total that would be nice to have fixed.
 +1 There are no new bugs found in [client].
 0 There are [34] new bugs found in [core] that would be nice to have fixed.
 You can find the FindBugs diff here: core/findbugs-new.html
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/hive2].
 0 There are [5] new bugs found in [sharelib/oozie] that would be nice to have 
fixed.
 You can find the FindBugs diff here: sharelib/oozie/findbugs-new.html
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/streaming].
 0 There are [1] new bugs found in [tools] that would be nice to have fixed.
 You can find the FindBugs diff here: tools/findbugs-new.html


+1 Overall result, good!, no -1s
{code}

> Switch from Findbugs to Spotbugs
> 
>
> Key: OOZIE-2933
> URL: https://issues.apache.org/jira/browse/OOZIE-2933
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2933-1.patch, oozie-findbugs-pre-commit.txt
>
>
> Because Findbugs hadn't a new release in some time other projects such as 
> Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch 
> the current Findbugs implementation to Spotbugs, similar to the changes made 
> to Hadoop and HBase.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OOZIE-2936) Fix Javadoc warnings from build

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046111#comment-16046111
 ] 

Jan Hentschel commented on OOZIE-2936:
--

The failing tests are unrelated to the actual change and seem to be flaky.

> Fix Javadoc warnings from build
> ---
>
> Key: OOZIE-2936
> URL: https://issues.apache.org/jira/browse/OOZIE-2936
> Project: Oozie
>  Issue Type: Task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2936-1.patch
>
>
> Currently the build complains about the following Javadoc warnings
> {code}
> 5 warnings
> [WARNING] Javadoc Warnings
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/OozieLauncherOutputCommitter.java:57:
>  warning - @param argument "context" is not a parameter name.
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
>  warning - Tag @see cannot be used in inline documentation.  It can only be 
> used in the following types of documentation: overview, package, 
> class/interface, constructor, field, method.
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
>  warning - Tag @see cannot be used in inline documentation.  It can only be 
> used in the following types of documentation: overview, package, 
> class/interface, constructor, field, method.
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
>  warning - Tag @see cannot be used in inline documentation.  It can only be 
> used in the following types of documentation: overview, package, 
> class/interface, constructor, field, method.
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
>  warning - Tag @see cannot be used in inline documentation.  It can only be 
> used in the following types of documentation: overview, package, 
> class/interface, constructor, field, method.
> {code}
> These should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2938) Fix Findbugs warnings in oozie-sharelib-hive module

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2938:
-
Attachment: OOZIE-2938-1.patch

> Fix Findbugs warnings in oozie-sharelib-hive module
> ---
>
> Key: OOZIE-2938
> URL: https://issues.apache.org/jira/browse/OOZIE-2938
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2938-1.patch
>
>
> Currently Findbugs complains about the following warnings in the 
> *oozie-sharelib-hive* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.HiveMain.readStringFromFile(String): new 
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.HiveMain] At 
> HiveMain.java:[line 336]
> [INFO] org.apache.oozie.action.hadoop.HiveMain.setUpHiveSite() may fail to 
> clean up java.io.OutputStream on checked exception 
> [org.apache.oozie.action.hadoop.HiveMain, 
> org.apache.oozie.action.hadoop.HiveMain] Obligation to clean up resource 
> created at HiveMain.java:[line 184] is not dischargedPath continues at 
> HiveMain.java:[line 185]
> [INFO] org.apache.oozie.action.hadoop.HiveMain.setUpHiveSite() may fail to 
> close stream on exception [org.apache.oozie.action.hadoop.HiveMain] At 
> HiveMain.java:[line 184]
> {code}
> They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OOZIE-2938) Fix Findbugs warnings in oozie-sharelib-hive module

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2938:


 Summary: Fix Findbugs warnings in oozie-sharelib-hive module
 Key: OOZIE-2938
 URL: https://issues.apache.org/jira/browse/OOZIE-2938
 Project: Oozie
  Issue Type: Sub-task
  Components: build
Reporter: Jan Hentschel
Assignee: Jan Hentschel


Currently Findbugs complains about the following warnings in the 
*oozie-sharelib-hive* module:

{code}
[INFO] Found reliance on default encoding in 
org.apache.oozie.action.hadoop.HiveMain.readStringFromFile(String): new 
java.io.FileReader(String) [org.apache.oozie.action.hadoop.HiveMain] At 
HiveMain.java:[line 336]
[INFO] org.apache.oozie.action.hadoop.HiveMain.setUpHiveSite() may fail to 
clean up java.io.OutputStream on checked exception 
[org.apache.oozie.action.hadoop.HiveMain, 
org.apache.oozie.action.hadoop.HiveMain] Obligation to clean up resource 
created at HiveMain.java:[line 184] is not dischargedPath continues at 
HiveMain.java:[line 185]
[INFO] org.apache.oozie.action.hadoop.HiveMain.setUpHiveSite() may fail to 
close stream on exception [org.apache.oozie.action.hadoop.HiveMain] At 
HiveMain.java:[line 184]
{code}

They should be fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2937) Remove redundant groupId from the child pom's

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2937:
-
Attachment: OOZIE-2937-1.patch

> Remove redundant groupId from the child pom's
> -
>
> Key: OOZIE-2937
> URL: https://issues.apache.org/jira/browse/OOZIE-2937
> Project: Oozie
>  Issue Type: Task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: OOZIE-2937-1.patch
>
>
> Currently all child pom's define the *groupId* again. That's not necessary, 
> because it is already defined in the parent pom. Remove the redundant 
> declarations of the *groupId*.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OOZIE-2937) Remove redundant groupId from the child pom's

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2937:


 Summary: Remove redundant groupId from the child pom's
 Key: OOZIE-2937
 URL: https://issues.apache.org/jira/browse/OOZIE-2937
 Project: Oozie
  Issue Type: Task
  Components: build
Reporter: Jan Hentschel
Assignee: Jan Hentschel
Priority: Trivial


Currently all child pom's define the *groupId* again. That's not necessary, 
because it is already defined in the parent pom. Remove the redundant 
declarations of the *groupId*.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2936) Fix Javadoc warnings from build

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2936:
-
Attachment: OOZIE-2936-1.patch

> Fix Javadoc warnings from build
> ---
>
> Key: OOZIE-2936
> URL: https://issues.apache.org/jira/browse/OOZIE-2936
> Project: Oozie
>  Issue Type: Task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2936-1.patch
>
>
> Currently the build complains about the following Javadoc warnings
> {code}
> 5 warnings
> [WARNING] Javadoc Warnings
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/OozieLauncherOutputCommitter.java:57:
>  warning - @param argument "context" is not a parameter name.
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
>  warning - Tag @see cannot be used in inline documentation.  It can only be 
> used in the following types of documentation: overview, package, 
> class/interface, constructor, field, method.
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
>  warning - Tag @see cannot be used in inline documentation.  It can only be 
> used in the following types of documentation: overview, package, 
> class/interface, constructor, field, method.
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
>  warning - Tag @see cannot be used in inline documentation.  It can only be 
> used in the following types of documentation: overview, package, 
> class/interface, constructor, field, method.
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
>  warning - Tag @see cannot be used in inline documentation.  It can only be 
> used in the following types of documentation: overview, package, 
> class/interface, constructor, field, method.
> {code}
> These should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OOZIE-2936) Fix Javadoc warnings from build

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2936:


 Summary: Fix Javadoc warnings from build
 Key: OOZIE-2936
 URL: https://issues.apache.org/jira/browse/OOZIE-2936
 Project: Oozie
  Issue Type: Task
  Components: build
Reporter: Jan Hentschel
Assignee: Jan Hentschel
Priority: Minor


Currently the build complains about the following Javadoc warnings

{code}
5 warnings
[WARNING] Javadoc Warnings
[WARNING] 
/home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/OozieLauncherOutputCommitter.java:57:
 warning - @param argument "context" is not a parameter name.
[WARNING] 
/home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
 warning - Tag @see cannot be used in inline documentation.  It can only be 
used in the following types of documentation: overview, package, 
class/interface, constructor, field, method.
[WARNING] 
/home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
 warning - Tag @see cannot be used in inline documentation.  It can only be 
used in the following types of documentation: overview, package, 
class/interface, constructor, field, method.
[WARNING] 
/home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
 warning - Tag @see cannot be used in inline documentation.  It can only be 
used in the following types of documentation: overview, package, 
class/interface, constructor, field, method.
[WARNING] 
/home/jenkins/jenkins-slave/workspace/oozie-trunk-precommit-build/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java:35:
 warning - Tag @see cannot be used in inline documentation.  It can only be 
used in the following types of documentation: overview, package, 
class/interface, constructor, field, method.
{code}

These should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2934) Fix "Exceptional return value of java.io.File.mkdirs() ignored" Findbugs error in oozie-sharelib-spark

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046032#comment-16046032
 ] 

Jan Hentschel commented on OOZIE-2934:
--

The test failures and Javadoc warnings are unrelated to the actual change and 
should be addressed in an additional ticket.

> Fix "Exceptional return value of java.io.File.mkdirs() ignored" Findbugs 
> error in oozie-sharelib-spark
> --
>
> Key: OOZIE-2934
> URL: https://issues.apache.org/jira/browse/OOZIE-2934
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2934-1.patch
>
>
> Currently Findbugs complaints about "Exceptional return value of 
> java.io.File.mkdirs() ignored" in the *sharelib-spark* module. This should be 
> fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2825) Custom Authentication doc page is not well formatted

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2825:
-
Attachment: OOZIE-2825-4.patch

Trying to address the build comments.

> Custom Authentication doc page is not well formatted
> 
>
> Key: OOZIE-2825
> URL: https://issues.apache.org/jira/browse/OOZIE-2825
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Laszlo Zeke
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2825-1.patch, OOZIE-2825-2.patch, 
> OOZIE-2825-3.patch, OOZIE-2825-4.patch
>
>
> At line 30 there's a verbatim tag staring but don't end.
> Also at line 45 a paragraph is staring but it does not make a lot of sense 
> with a code sample seems to be cut in half.
> All in ENG_Custom_Authentication.twiki



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2935) Fix "concatenates strings using + in a loop" Findbugs error in oozie-sharelib-streaming

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2935:
-
Attachment: OOZIE-2935-1.patch

> Fix "concatenates strings using + in a loop" Findbugs error in 
> oozie-sharelib-streaming
> ---
>
> Key: OOZIE-2935
> URL: https://issues.apache.org/jira/browse/OOZIE-2935
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2935-1.patch
>
>
> Currently Findbugs complaints about "concatenates strings using + in a loop" 
> in the *sharelib-streaming* module. This should be fixed to get the code more 
> reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OOZIE-2935) Fix "concatenates strings using + in a loop" Findbugs error in oozie-sharelib-streaming

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2935:


 Summary: Fix "concatenates strings using + in a loop" Findbugs 
error in oozie-sharelib-streaming
 Key: OOZIE-2935
 URL: https://issues.apache.org/jira/browse/OOZIE-2935
 Project: Oozie
  Issue Type: Sub-task
  Components: build
Reporter: Jan Hentschel
Assignee: Jan Hentschel


Currently Findbugs complaints about "concatenates strings using + in a loop" in 
the *sharelib-streaming* module. This should be fixed to get the code more 
reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2934) Fix "Exceptional return value of java.io.File.mkdirs() ignored" Findbugs error in oozie-sharelib-spark

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2934:
-
Attachment: OOZIE-2934-1.patch

> Fix "Exceptional return value of java.io.File.mkdirs() ignored" Findbugs 
> error in oozie-sharelib-spark
> --
>
> Key: OOZIE-2934
> URL: https://issues.apache.org/jira/browse/OOZIE-2934
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2934-1.patch
>
>
> Currently Findbugs complaints about "Exceptional return value of 
> java.io.File.mkdirs() ignored" in the *sharelib-spark* module. This should be 
> fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2934) Fix "Exceptional return value of java.io.File.mkdirs() ignored" Findbugs error in oozie-sharelib-spark

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2934:
-
Issue Type: Sub-task  (was: Bug)
Parent: OOZIE-1987

> Fix "Exceptional return value of java.io.File.mkdirs() ignored" Findbugs 
> error in oozie-sharelib-spark
> --
>
> Key: OOZIE-2934
> URL: https://issues.apache.org/jira/browse/OOZIE-2934
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>
> Currently Findbugs complaints about "Exceptional return value of 
> java.io.File.mkdirs() ignored" in the *sharelib-spark* module. This should be 
> fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OOZIE-2934) Fix "Exceptional return value of java.io.File.mkdirs() ignored" Findbugs error in oozie-sharelib-spark

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2934:


 Summary: Fix "Exceptional return value of java.io.File.mkdirs() 
ignored" Findbugs error in oozie-sharelib-spark
 Key: OOZIE-2934
 URL: https://issues.apache.org/jira/browse/OOZIE-2934
 Project: Oozie
  Issue Type: Bug
  Components: build
Reporter: Jan Hentschel
Assignee: Jan Hentschel


Currently Findbugs complaints about "Exceptional return value of 
java.io.File.mkdirs() ignored" in the *sharelib-spark* module. This should be 
fixed to get the code more reliable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2825) Custom Authentication doc page is not well formatted

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045948#comment-16045948
 ] 

Jan Hentschel commented on OOZIE-2825:
--

[~rkanter] Thanks for your feedback. I tried to incorporate your feedback and 
updated the patch accordingly.

> Custom Authentication doc page is not well formatted
> 
>
> Key: OOZIE-2825
> URL: https://issues.apache.org/jira/browse/OOZIE-2825
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Laszlo Zeke
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2825-1.patch, OOZIE-2825-2.patch, 
> OOZIE-2825-3.patch
>
>
> At line 30 there's a verbatim tag staring but don't end.
> Also at line 45 a paragraph is staring but it does not make a lot of sense 
> with a code sample seems to be cut in half.
> All in ENG_Custom_Authentication.twiki



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2825) Custom Authentication doc page is not well formatted

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2825:
-
Attachment: OOZIE-2825-3.patch

> Custom Authentication doc page is not well formatted
> 
>
> Key: OOZIE-2825
> URL: https://issues.apache.org/jira/browse/OOZIE-2825
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Laszlo Zeke
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2825-1.patch, OOZIE-2825-2.patch, 
> OOZIE-2825-3.patch
>
>
> At line 30 there's a verbatim tag staring but don't end.
> Also at line 45 a paragraph is staring but it does not make a lot of sense 
> with a code sample seems to be cut in half.
> All in ENG_Custom_Authentication.twiki



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2933) Switch from Findbugs to Spotbugs

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2933:
-
Attachment: OOZIE-2933-1.patch

> Switch from Findbugs to Spotbugs
> 
>
> Key: OOZIE-2933
> URL: https://issues.apache.org/jira/browse/OOZIE-2933
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2933-1.patch
>
>
> Because Findbugs hadn't a new release in some time other projects such as 
> Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch 
> the current Findbugs implementation to Spotbugs, similar to the changes made 
> to Hadoop and HBase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OOZIE-2933) Switch from Findbugs to Spotbugs

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2933:


 Summary: Switch from Findbugs to Spotbugs
 Key: OOZIE-2933
 URL: https://issues.apache.org/jira/browse/OOZIE-2933
 Project: Oozie
  Issue Type: Improvement
  Components: build
Reporter: Jan Hentschel
Assignee: Jan Hentschel
Priority: Minor


Because Findbugs hadn't a new release in some time other projects such as 
Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch 
the current Findbugs implementation to Spotbugs, similar to the changes made to 
Hadoop and HBase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OOZIE-2932) DistCp action should be able to preserve extended attributes

[Jan Hentschel (JIRA)]

Jan Hentschel created OOZIE-2932:


 Summary: DistCp action should be able to preserve extended 
attributes
 Key: OOZIE-2932
 URL: https://issues.apache.org/jira/browse/OOZIE-2932
 Project: Oozie
  Issue Type: Improvement
  Components: action
Reporter: Jan Hentschel
Priority: Minor


DistCp offers the ability to preserve extended attributes. With the latest move 
to Hadoop 2.6 the flag should also be added to the DistCp action.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2747) README.txt is out of date

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2747:
-
Attachment: OOZIE-2747-1.patch

> README.txt is out of date
> -
>
> Key: OOZIE-2747
> URL: https://issues.apache.org/jira/browse/OOZIE-2747
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 4.0.0
>Reporter: Robert Kanter
>Assignee: Jan Hentschel
> Fix For: 5.0.0
>
> Attachments: OOZIE-2747-1.patch
>
>
> The README.txt file is out of date.  The main text may require some updating 
> as it hasn't been touched in a while, but the really obvious problems here 
> are that it refers to 
> "http://oozie.apache.org/docs/3.2.0-incubating/DG_QuickStart.html; 
> (3.2.0-incubating version) and says "This version of Oozie was primarily 
> tested against Hadoop 0.20.205.x. This will not work on earlier versions of 
> Hadoop such as 0.20.x. and 0.21." which way off.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (OOZIE-2747) README.txt is out of date

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned OOZIE-2747:


Assignee: Jan Hentschel

> README.txt is out of date
> -
>
> Key: OOZIE-2747
> URL: https://issues.apache.org/jira/browse/OOZIE-2747
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 4.0.0
>Reporter: Robert Kanter
>Assignee: Jan Hentschel
> Fix For: 5.0.0
>
>
> The README.txt file is out of date.  The main text may require some updating 
> as it hasn't been touched in a while, but the really obvious problems here 
> are that it refers to 
> "http://oozie.apache.org/docs/3.2.0-incubating/DG_QuickStart.html; 
> (3.2.0-incubating version) and says "This version of Oozie was primarily 
> tested against Hadoop 0.20.205.x. This will not work on earlier versions of 
> Hadoop such as 0.20.x. and 0.21." which way off.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2920) Extend FS action to do HDFS copy

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027522#comment-16027522
 ] 

Jan Hentschel commented on OOZIE-2920:
--

[~rkanter] Should we close this one then? Is there any documentation available 
explaining an alternative way for users if they want to copy files in HDFS?

> Extend FS action to do HDFS copy
> 
>
> Key: OOZIE-2920
> URL: https://issues.apache.org/jira/browse/OOZIE-2920
> Project: Oozie
>  Issue Type: New Feature
>Affects Versions: 4.3.0
>Reporter: Artem Ervits
>Assignee: Jan Hentschel
>
> Today FS action has a limited number of actions, it would benefit community 
> if FS copy would be available.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (OOZIE-2920) Extend FS action to do HDFS copy

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned OOZIE-2920:


Assignee: Jan Hentschel

> Extend FS action to do HDFS copy
> 
>
> Key: OOZIE-2920
> URL: https://issues.apache.org/jira/browse/OOZIE-2920
> Project: Oozie
>  Issue Type: New Feature
>Affects Versions: 4.3.0
>Reporter: Artem Ervits
>Assignee: Jan Hentschel
>
> Today FS action has a limited number of actions, it would benefit community 
> if FS copy would be available.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-1283) Remove the old ssh documentation

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955092#comment-15955092
 ] 

Jan Hentschel commented on OOZIE-1283:
--

The failing test seems to be unrelated to the actual change. Only content of 
the documentation was changed in this patch.

> Remove the old ssh documentation
> 
>
> Key: OOZIE-1283
> URL: https://issues.apache.org/jira/browse/OOZIE-1283
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Reporter: Robert Kanter
>Assignee: Jan Hentschel
>Priority: Minor
>  Labels: newbie
> Attachments: OOZIE-1283-1.patch
>
>
> The documentation currently has info on the ssh action extension: 
> http://oozie.apache.org/docs/3.3.1/DG_SshActionExtension.html
> as well as the old one: 
> http://oozie.apache.org/docs/3.3.1/WorkflowFunctionalSpec.html#a3.2.5_Ssh_Action
> We should remove the old one or at least put a WARNING and a link to the new 
> one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2825) Custom Authentication doc page is not well formatted

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2825:
-
Attachment: OOZIE-2825-2.patch

Fixed problems with tabs from QA build.

> Custom Authentication doc page is not well formatted
> 
>
> Key: OOZIE-2825
> URL: https://issues.apache.org/jira/browse/OOZIE-2825
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Laszlo Zeke
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2825-1.patch, OOZIE-2825-2.patch
>
>
> At line 30 there's a verbatim tag staring but don't end.
> Also at line 45 a paragraph is staring but it does not make a lot of sense 
> with a code sample seems to be cut in half.
> All in ENG_Custom_Authentication.twiki



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-1283) Remove the old ssh documentation

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-1283:
-
Attachment: OOZIE-1283-1.patch

> Remove the old ssh documentation
> 
>
> Key: OOZIE-1283
> URL: https://issues.apache.org/jira/browse/OOZIE-1283
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Reporter: Robert Kanter
>Assignee: Jan Hentschel
>Priority: Minor
>  Labels: newbie
> Attachments: OOZIE-1283-1.patch
>
>
> The documentation currently has info on the ssh action extension: 
> http://oozie.apache.org/docs/3.3.1/DG_SshActionExtension.html
> as well as the old one: 
> http://oozie.apache.org/docs/3.3.1/WorkflowFunctionalSpec.html#a3.2.5_Ssh_Action
> We should remove the old one or at least put a WARNING and a link to the new 
> one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (OOZIE-1283) Remove the old ssh documentation

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned OOZIE-1283:


Assignee: Jan Hentschel  (was: Udai Kiran Potluri)

> Remove the old ssh documentation
> 
>
> Key: OOZIE-1283
> URL: https://issues.apache.org/jira/browse/OOZIE-1283
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Reporter: Robert Kanter
>Assignee: Jan Hentschel
>Priority: Minor
>  Labels: newbie
> Attachments: OOZIE-1283-1.patch
>
>
> The documentation currently has info on the ssh action extension: 
> http://oozie.apache.org/docs/3.3.1/DG_SshActionExtension.html
> as well as the old one: 
> http://oozie.apache.org/docs/3.3.1/WorkflowFunctionalSpec.html#a3.2.5_Ssh_Action
> We should remove the old one or at least put a WARNING and a link to the new 
> one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2825) Custom Authentication doc page is not well formatted

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2825:
-
Attachment: OOZIE-2825-1.patch

> Custom Authentication doc page is not well formatted
> 
>
> Key: OOZIE-2825
> URL: https://issues.apache.org/jira/browse/OOZIE-2825
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Laszlo Zeke
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2825-1.patch
>
>
> At line 30 there's a verbatim tag staring but don't end.
> Also at line 45 a paragraph is staring but it does not make a lot of sense 
> with a code sample seems to be cut in half.
> All in ENG_Custom_Authentication.twiki



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (OOZIE-2825) Custom Authentication doc page is not well formatted

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned OOZIE-2825:


Assignee: Jan Hentschel

> Custom Authentication doc page is not well formatted
> 
>
> Key: OOZIE-2825
> URL: https://issues.apache.org/jira/browse/OOZIE-2825
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Laszlo Zeke
>Assignee: Jan Hentschel
>Priority: Minor
>
> At line 30 there's a verbatim tag staring but don't end.
> Also at line 45 a paragraph is staring but it does not make a lot of sense 
> with a code sample seems to be cut in half.
> All in ENG_Custom_Authentication.twiki



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2773) property not working with hive2 action

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822426#comment-15822426
 ] 

Jan Hentschel commented on OOZIE-2773:
--

What do you try to accomplish by using the *file* tag? You normally use it to 
[pass a password 
file|https://community.hortonworks.com/articles/3251/running-hive-in-oozie-with-hive2action-and-passwor.html]
 to Beeline. Your Hive query file is linked via the *script* tag. There is no 
need to reference the Hive file again via the *file* tag. Most of the paths in 
Oozie are relative to the application path of the workflow. If the file is in 
another location in HDFS you have to use the full path.

>  property not working with hive2 action
> -
>
> Key: OOZIE-2773
> URL: https://issues.apache.org/jira/browse/OOZIE-2773
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 4.2.0, 4.3.0
> Environment: HDP 2.4, Beeline version 1.2.1000.2.4.0.0-169
>Reporter: Christoph Körner
>
> The beeline client does not consider files linked with the  property in 
> Hive 2 actions. The file gets successfully linked to the local appcache 
> directory, however Oozie tries to access the file from the workflow path.
> A simple job
> {code:borderStyle=solid}
> 
>   
> ${jdbcURL}
> query.hive
> hive/query.hive#query.hive
>   
>   
>   
> 
> {code}
> fails with the error message:
> {code:borderStyle=solid}
> JA008: File does not exist: 
> /user/koernerc/apps/simple-hive-query-wf/query.hive#query.hive
> {code}
> The complete workflow is also available on Github 
> https://github.com/chaosmail/oozie-bugs/tree/master/simple-hive-query/simple-hive-query-wf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2097) Get rid of non-Javadoc comments

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647403#comment-15647403
 ] 

Jan Hentschel commented on OOZIE-2097:
--

The failing test seems to be unrelated to the changes of the patch.

> Get rid of non-Javadoc comments
> ---
>
> Key: OOZIE-2097
> URL: https://issues.apache.org/jira/browse/OOZIE-2097
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Rohini Palaniswamy
>Assignee: Jan Hentschel
>  Labels: newbie
> Attachments: OOZIE-2097-1.patch
>
>
> There are lot of (non-Javadoc) comments on @Override methods which don't add 
> any additional information and is just noise.
> For eg:
> {code}
> /*
>  * (non-Javadoc)
>  *
>  * @see org.apache.oozie.command.XCommand#getEntityKey()
>  */
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2097) Get rid of non-Javadoc comments

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15639592#comment-15639592
 ] 

Jan Hentschel commented on OOZIE-2097:
--

Added a patch where I removed the non-Javadoc comments throughout the codebase.

> Get rid of non-Javadoc comments
> ---
>
> Key: OOZIE-2097
> URL: https://issues.apache.org/jira/browse/OOZIE-2097
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Rohini Palaniswamy
>Assignee: Jan Hentschel
>  Labels: newbie
> Attachments: OOZIE-2097-1.patch
>
>
> There are lot of (non-Javadoc) comments on @Override methods which don't add 
> any additional information and is just noise.
> For eg:
> {code}
> /*
>  * (non-Javadoc)
>  *
>  * @see org.apache.oozie.command.XCommand#getEntityKey()
>  */
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OOZIE-2097) Get rid of non-Javadoc comments

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-2097:
-
Attachment: OOZIE-2097-1.patch

> Get rid of non-Javadoc comments
> ---
>
> Key: OOZIE-2097
> URL: https://issues.apache.org/jira/browse/OOZIE-2097
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Rohini Palaniswamy
>Assignee: Jan Hentschel
>  Labels: newbie
> Attachments: OOZIE-2097-1.patch
>
>
> There are lot of (non-Javadoc) comments on @Override methods which don't add 
> any additional information and is just noise.
> For eg:
> {code}
> /*
>  * (non-Javadoc)
>  *
>  * @see org.apache.oozie.command.XCommand#getEntityKey()
>  */
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OOZIE-2097) Get rid of non-Javadoc comments

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel reassigned OOZIE-2097:


Assignee: Jan Hentschel

> Get rid of non-Javadoc comments
> ---
>
> Key: OOZIE-2097
> URL: https://issues.apache.org/jira/browse/OOZIE-2097
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Rohini Palaniswamy
>Assignee: Jan Hentschel
>  Labels: newbie
>
> There are lot of (non-Javadoc) comments on @Override methods which don't add 
> any additional information and is just noise.
> For eg:
> {code}
> /*
>  * (non-Javadoc)
>  *
>  * @see org.apache.oozie.command.XCommand#getEntityKey()
>  */
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-1459) We should remove the version in the child poms for maven-antrun-plugin

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632241#comment-15632241
 ] 

Jan Hentschel commented on OOZIE-1459:
--

The test failures seem to be unrelated to the changes of the patch. Can anyone 
confirm this?

> We should remove the version in the child poms for maven-antrun-plugin
> --
>
> Key: OOZIE-1459
> URL: https://issues.apache.org/jira/browse/OOZIE-1459
> Project: Oozie
>  Issue Type: Bug
>Reporter: Robert Kanter
>Assignee: Jan Hentschel
>Priority: Critical
>  Labels: newbie
> Attachments: OOZIE-1459-1.patch
>
>
> Many of the poms use the {{maven-antrun-plugin}} and define the version again 
> as {{1.6}}.  We should remove the {{}} elements from these poms and 
> it should get picked up from the root pom. 
> For example, the hive sharelib pom has:
> {code:xml}
> 
>  org.apache.maven.plugins
>  maven-antrun-plugin
>  1.6
>  
>   
>   ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-1459) We should remove the version in the child poms for maven-antrun-plugin

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622895#comment-15622895
 ] 

Jan Hentschel commented on OOZIE-1459:
--

[~rkanter] Thanks for your help. I was now able to attach the patch.

> We should remove the version in the child poms for maven-antrun-plugin
> --
>
> Key: OOZIE-1459
> URL: https://issues.apache.org/jira/browse/OOZIE-1459
> Project: Oozie
>  Issue Type: Bug
>Reporter: Robert Kanter
>Assignee: Jan Hentschel
>Priority: Critical
>  Labels: newbie
> Attachments: OOZIE-1459-1.patch
>
>
> Many of the poms use the {{maven-antrun-plugin}} and define the version again 
> as {{1.6}}.  We should remove the {{}} elements from these poms and 
> it should get picked up from the root pom. 
> For example, the hive sharelib pom has:
> {code:xml}
> 
>  org.apache.maven.plugins
>  maven-antrun-plugin
>  1.6
>  
>   
>   ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OOZIE-1459) We should remove the version in the child poms for maven-antrun-plugin

[Jan Hentschel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated OOZIE-1459:
-
Attachment: OOZIE-1459-1.patch

> We should remove the version in the child poms for maven-antrun-plugin
> --
>
> Key: OOZIE-1459
> URL: https://issues.apache.org/jira/browse/OOZIE-1459
> Project: Oozie
>  Issue Type: Bug
>Reporter: Robert Kanter
>Assignee: Jan Hentschel
>Priority: Critical
>  Labels: newbie
> Attachments: OOZIE-1459-1.patch
>
>
> Many of the poms use the {{maven-antrun-plugin}} and define the version again 
> as {{1.6}}.  We should remove the {{}} elements from these poms and 
> it should get picked up from the root pom. 
> For example, the hive sharelib pom has:
> {code:xml}
> 
>  org.apache.maven.plugins
>  maven-antrun-plugin
>  1.6
>  
>   
>   ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-1459) We should remove the version in the child poms for maven-antrun-plugin

[Jan Hentschel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621728#comment-15621728
 ] 

Jan Hentschel commented on OOZIE-1459:
--

I have a patch for this one ready, but it seems that I'm not allowed to attach 
the patch to this JIRA. Could some please help me?

> We should remove the version in the child poms for maven-antrun-plugin
> --
>
> Key: OOZIE-1459
> URL: https://issues.apache.org/jira/browse/OOZIE-1459
> Project: Oozie
>  Issue Type: Bug
>Reporter: Robert Kanter
>Assignee: Udai Kiran Potluri
>Priority: Critical
>  Labels: newbie
>
> Many of the poms use the {{maven-antrun-plugin}} and define the version again 
> as {{1.6}}.  We should remove the {{}} elements from these poms and 
> it should get picked up from the root pom. 
> For example, the hive sharelib pom has:
> {code:xml}
> 
>  org.apache.maven.plugins
>  maven-antrun-plugin
>  1.6
>  
>   
>   ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)