[jira] [Commented] (OOZIE-1623) JPAService doesn't need to do reads in a transaction
[
https://issues.apache.org/jira/browse/OOZIE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832785#comment-13832785
]
Rohini Palaniswamy commented on OOZIE-1623:
---
+1
> JPAService doesn't need to do reads in a transaction
>
>
> Key: OOZIE-1623
> URL: https://issues.apache.org/jira/browse/OOZIE-1623
> Project: Oozie
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: OOZIE-1623.patch, OOZIE-1623.patch
>
>
> {{JPAService#executeGet}} and {{JPAService#executeGetList}} are both doing
> {{SELECT}} queries (so only reading), which means that they shouldn't need to
> be in a transaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OOZIE-1623) JPAService doesn't need to do reads in a transaction
[
https://issues.apache.org/jira/browse/OOZIE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832370#comment-13832370
]
Hadoop QA commented on OOZIE-1623:
--
Testing JIRA OOZIE-1623
Cleaning local svn workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1368
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/910/
> JPAService doesn't need to do reads in a transaction
>
>
> Key: OOZIE-1623
> URL: https://issues.apache.org/jira/browse/OOZIE-1623
> Project: Oozie
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: OOZIE-1623.patch, OOZIE-1623.patch
>
>
> {{JPAService#executeGet}} and {{JPAService#executeGetList}} are both doing
> {{SELECT}} queries (so only reading), which means that they shouldn't need to
> be in a transaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OOZIE-1623) JPAService doesn't need to do reads in a transaction
[
https://issues.apache.org/jira/browse/OOZIE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832086#comment-13832086
]
Rohini Palaniswamy commented on OOZIE-1623:
---
The processFinally would still keep checking for
em.getTransaction().isActive(). Can we get rid of that as well for get calls ?
> JPAService doesn't need to do reads in a transaction
>
>
> Key: OOZIE-1623
> URL: https://issues.apache.org/jira/browse/OOZIE-1623
> Project: Oozie
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: OOZIE-1623.patch
>
>
> {{JPAService#executeGet}} and {{JPAService#executeGetList}} are both doing
> {{SELECT}} queries (so only reading), which means that they shouldn't need to
> be in a transaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OOZIE-1623) JPAService doesn't need to do reads in a transaction
[
https://issues.apache.org/jira/browse/OOZIE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832077#comment-13832077
]
Rohini Palaniswamy commented on OOZIE-1623:
---
+1
> JPAService doesn't need to do reads in a transaction
>
>
> Key: OOZIE-1623
> URL: https://issues.apache.org/jira/browse/OOZIE-1623
> Project: Oozie
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: OOZIE-1623.patch
>
>
> {{JPAService#executeGet}} and {{JPAService#executeGetList}} are both doing
> {{SELECT}} queries (so only reading), which means that they shouldn't need to
> be in a transaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OOZIE-1623) JPAService doesn't need to do reads in a transaction
[
https://issues.apache.org/jira/browse/OOZIE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831659#comment-13831659
]
Rohini Palaniswamy commented on OOZIE-1623:
---
This was one of the reasons we separated out update and get calls. Thanks for
creating this one Robert. I thought Ryota already had a jira for this. This was
one of the TODO items which I had lost track of getting done.
> JPAService doesn't need to do reads in a transaction
>
>
> Key: OOZIE-1623
> URL: https://issues.apache.org/jira/browse/OOZIE-1623
> Project: Oozie
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Robert Kanter
>
> {{JPAService#executeGet}} and {{JPAService#executeGetList}} are both doing
> {{SELECT}} queries (so only reading), which means that they shouldn't need to
> be in a transaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
