[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787927#comment-16787927 ] Andras Salamon commented on OOZIE-1624: --- Thanks for the contribution [~matijhs], +1, committed to master. Thanks for everybody who helped in the last 5 years to finish this jira. > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V10.patch, OOZIE-1624-V2.patch, > OOZIE-1624-V3.patch, OOZIE-1624-V4.patch, OOZIE-1624-V5.patch, > OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786973#comment-16786973
]
Hadoop QA commented on OOZIE-1624:
--
Testing JIRA OOZIE-1624
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch adds/modifies 4 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [5] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:red}-1{color} There are [5] new bugs found below threshold in
[core] that must be fixed.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 207]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
.At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
.This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207]
.At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128]
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3166
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1038/
> Exclusion pattern for sharelib JARs
> ---
>
> Key: OOZIE-1624
> URL: https://issues.apache.org/jira/browse/OOZIE-1624
> Project: Oozie
> Issue Type: Sub-task
>Affects Versions: 4.3.1
>Reporter: Purshotam Shah
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-1624-V10.patch, OOZIE-1624-V2.patch,
> OOZIE-1624-V3.patch, OOZIE-1624-V4.patch, OOZIE-1624-V5.patch,
> OOZIE-1624-v1.patch
>
>
> Sharelib may bring some jar which might conflict with user jars.
> Ex. Sharelib hive has json-2..jar, where as some of the user use-case
> need higher version of json jar.
> He should be able to exclude sharelib json jar and bring his own version.
>
> oozie.actio
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786850#comment-16786850 ] Hadoop QA commented on OOZIE-1624: -- PreCommit-OOZIE-Build started > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V10.patch, OOZIE-1624-V2.patch, > OOZIE-1624-V3.patch, OOZIE-1624-V4.patch, OOZIE-1624-V5.patch, > OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786844#comment-16786844 ] Mate Juhasz commented on OOZIE-1624: Fixed the typos and line breaks and also added the warning message for using exclusions :) > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-V5.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786826#comment-16786826 ] Andras Salamon commented on OOZIE-1624: --- Thanks for the docs update [~matijhs] I think the chapter is very clear. I've sent a few comments about the documentation, mostly typos and formatting things. Can you please also upload the next version of the patch here. PreCommit script is much better catching problems like long lines, javadoc problems than me. I've also tested your patch on a pseudo-distrubuted cluster, it was working great. ( One should be very careful it is quite easy to exclude very basic oozie jars :) ) > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-V5.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786802#comment-16786802 ] Mate Juhasz commented on OOZIE-1624: Thanks [~asalamon74], I forgot to add it. Attached to the review, hope it's clear and understandable. > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-V5.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786660#comment-16786660 ] Andras Salamon commented on OOZIE-1624: --- [~matijhs] I've just realized that the patch contains no documentation change. I think this feature should be documented, adding a simple example to the documentation would also be useful. Probably you could add a new section 17.2 to [here|https://oozie.apache.org/docs/5.1.0/WorkflowFunctionalSpec.html#ShareLib]. > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-V5.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783271#comment-16783271 ] Andras Salamon commented on OOZIE-1624: --- [~matijhs] I left a few comments on the review board. > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-V5.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781810#comment-16781810
]
Hadoop QA commented on OOZIE-1624:
--
Testing JIRA OOZIE-1624
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch adds/modifies 4 testcase(s)
{color:red}-1 RAT{color}
.{color:red}-1{color} the patch seems to introduce 1 new RAT warning(s)
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [6] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:red}-1{color} There are [1] new bugs found below threshold in
[sharelib/oozie] that must be fixed.
.You can find the SpotBugs diff here (look for the red and orange ones):
sharelib/oozie/findbugs-new.html
.The most important SpotBugs errors are:
.At ShellMain.java:[line 92]: This usage of
java/lang/ProcessBuilder.(Ljava/util/List;)V can be vulnerable to
Command Injection
.At ShellMain.java:[line 90]: At ShellMain.java:[line 89]
.At ShellMain.java:[line 91]
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:red}-1{color} There are [5] new bugs found below threshold in
[core] that must be fixed.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 207]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
.At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
.This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207]
.At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3164
.{color:orange}Tests failed at first run:{color}
TestPurgeXCommand#testPurgeableWorkflowPurgeableSubWorkflowPurgeableSubSubWorkflow
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1025/
> Exclusion pattern for sharelib JARs
>
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781760#comment-16781760 ] Mate Juhasz commented on OOZIE-1624: Thanks [~asalamon74], uploaded to the review board as well. I agree with you, the ActionMarshaller could go in separately. Waiting for your feedback, thanks! > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-V5.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781725#comment-16781725 ] Andras Salamon commented on OOZIE-1624: --- Thanks for continuing the development of this patch [~matijhs]. Although using an ActionMarshaller would make this patch nicer, personally I don't think that this issue is blocked by OOZIE-3311. Could you please also upload the patch to the review board? > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-V5.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781694#comment-16781694 ] Hadoop QA commented on OOZIE-1624: -- PreCommit-OOZIE-Build started > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-V5.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781688#comment-16781688 ] Mate Juhasz commented on OOZIE-1624: Uploaded new patch based on the current master > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-V5.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563348#comment-16563348
]
Hadoop QA commented on OOZIE-1624:
--
Testing JIRA OOZIE-1624
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> Exclusion pattern for sharelib JARs
> ---
>
> Key: OOZIE-1624
> URL: https://issues.apache.org/jira/browse/OOZIE-1624
> Project: Oozie
> Issue Type: Sub-task
>Affects Versions: 4.3.1
>Reporter: Purshotam Shah
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch,
> OOZIE-1624-V4.patch, OOZIE-1624-v1.patch
>
>
> Sharelib may bring some jar which might conflict with user jars.
> Ex. Sharelib hive has json-2..jar, where as some of the user use-case
> need higher version of json jar.
> He should be able to exclude sharelib json jar and bring his own version.
>
> oozie.action.sharelib.for.hive.exclusion
> json-\*.jar|abc-*.jar
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563339#comment-16563339 ] Hadoop QA commented on OOZIE-1624: -- PreCommit-OOZIE-Build started > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547602#comment-16547602 ] Andras Piros commented on OOZIE-1624: - :) [~matijhs] looking forward to the new patch, thanks so much! > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547578#comment-16547578 ] Mate Juhasz commented on OOZIE-1624: Ignore my previous comment, I just realized how wonderful is the JavaActionBuilder class... :) I create a new patch for the review board, thanks! > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547557#comment-16547557 ] Mate Juhasz commented on OOZIE-1624: Thanks [~andras.piros], I left the xml builder related issues open only, because I think that could be resolved in a separate Jira. What do you think? > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536725#comment-16536725 ] Andras Piros commented on OOZIE-1624: - [~matijhs] the overall direction is good, only a couple of review comments to go :) I like the documentation section as well. > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525019#comment-16525019 ] Andras Piros commented on OOZIE-1624: - [~matijhs] did another review round. > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479400#comment-16479400 ] Andras Piros commented on OOZIE-1624: - [~matijhs] while I'm more than happy to do another review round, can you please close ReviewBoard review comments as fixed / won't fix / answered as I don't have a clue at the moment what got addressed? Thanks so much! > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475974#comment-16475974 ] Mate Juhasz commented on OOZIE-1624: By sharelib root do you mean the "lib_" directory? For example instead of filtering against the below full paths: * /user/oozie/share/lib/lib123456789/oozie/jackson*.jar * /user/oozie/share/lib/lib123456789/pig/lib/jackson*.jar We could only let jars excluded inside lib123456789: * oozie/jackson*.jar * pig/lib/jackson*.jar > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475724#comment-16475724
]
Hadoop QA commented on OOZIE-1624:
--
Testing JIRA OOZIE-1624
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> Exclusion pattern for sharelib JARs
> ---
>
> Key: OOZIE-1624
> URL: https://issues.apache.org/jira/browse/OOZIE-1624
> Project: Oozie
> Issue Type: Sub-task
>Affects Versions: 4.3.1
>Reporter: Purshotam Shah
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch,
> OOZIE-1624-V4.patch, OOZIE-1624-v1.patch
>
>
> Sharelib may bring some jar which might conflict with user jars.
> Ex. Sharelib hive has json-2..jar, where as some of the user use-case
> need higher version of json jar.
> He should be able to exclude sharelib json jar and bring his own version.
>
> oozie.action.sharelib.for.hive.exclusion
> json-\*.jar|abc-*.jar
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475716#comment-16475716 ] Hadoop QA commented on OOZIE-1624: -- PreCommit-OOZIE-Build started > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Mate Juhasz >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[ https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467456#comment-16467456 ] Peter Cseh commented on OOZIE-1624: --- I don't really see the value of a preconfigured blacklisted JAR pattern as there are almost an infinite way to define the equivalent of "oozie*jar" using regex. :) We should definitely log out every single jar we're removing though to avoid confusion about missing jars. I'd prefer Rohini's take and filter against the full path - excluding the sharelib root - as it's easy to just add a "*/" to the start of the pattern to exclude it from everywhere and it is more flexible than filtering just for filenames. > Exclusion pattern for sharelib JARs > --- > > Key: OOZIE-1624 > URL: https://issues.apache.org/jira/browse/OOZIE-1624 > Project: Oozie > Issue Type: Sub-task >Affects Versions: 4.3.1 >Reporter: Purshotam Shah >Assignee: Purshotam Shah >Priority: Major > Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, > OOZIE-1624-V4.patch, OOZIE-1624-v1.patch > > > Sharelib may bring some jar which might conflict with user jars. > Ex. Sharelib hive has json-2..jar, where as some of the user use-case > need higher version of json jar. > He should be able to exclude sharelib json jar and bring his own version. > > oozie.action.sharelib.for.hive.exclusion > json-\*.jar|abc-*.jar > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs
[
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445954#comment-16445954
]
Andras Piros commented on OOZIE-1624:
-
Thanks [~matijhs]! Now I see the value of this JIRA in its entirety.
Commented on the review request a few items.
[~gezapeti] [~kmarton] what is your opinion about:
* whether we should look at the whole sharelib path (Rohini's take) instead of
parent directory name and / or file name only (Puru's take)
* whether we should have a preconfigured blacklist which JAR patterns we should
never allow to exclude, e.g. {{oozie*.jar}}
Imagine following sharelib contents:
* {{pig/lib/jackson*.jar}}
* {{hbase/lib/jackson*.jar}}
* {{oozie/jackson*.jar}}
* user provided {{jackson*.jar}}
As a user I want following distinct use cases:
* exclude {{pig/lib/jackson*.jar}} only
* exclude {{pig/lib/jackson*.jar}} and {{hbase/lib/jackson*.jar}}
* exclude {{pig/lib/jackson*.jar}}, {{hbase/lib/jackson*.jar}}, and
{{oozie/jackson*.jar}}
* exclude everything which is {{jackson*.jar}}, independent of location
> Exclusion pattern for sharelib JARs
> ---
>
> Key: OOZIE-1624
> URL: https://issues.apache.org/jira/browse/OOZIE-1624
> Project: Oozie
> Issue Type: Sub-task
>Affects Versions: 4.3.1
>Reporter: Purshotam Shah
>Assignee: Purshotam Shah
>Priority: Major
> Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch,
> OOZIE-1624-V4.patch, OOZIE-1624-v1.patch
>
>
> Sharelib may bring some jar which might conflict with user jars.
> Ex. Sharelib hive has json-2..jar, where as some of the user use-case
> need higher version of json jar.
> He should be able to exclude sharelib json jar and bring his own version.
>
> oozie.action.sharelib.for.hive.exclusion
> json-\*.jar|abc-*.jar
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
