[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-09-02 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119309#comment-14119309
 ] 

Hadoop QA commented on OOZIE-1638:
--

Testing JIRA OOZIE-1638

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1512
.Tests failed: 7
.Tests errors: 2

.The patch failed the following testcases:

.  testMain(org.apache.oozie.action.hadoop.TestHiveMain)
.  testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
.  testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
.  testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
.  testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
.  
testConcurrencyReachedAndChooseNextEligible(org.apache.oozie.service.TestCallableQueueService)
.  
testMemoryUsageAndSpeed(org.apache.oozie.service.TestPartitionDependencyManagerService)

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1854/

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.5.patch, OOZIE-1638.6.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-08-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14107535#comment-14107535
 ] 

Hadoop QA commented on OOZIE-1638:
--

Testing JIRA OOZIE-1638

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1509
.Tests failed: 5
.Tests errors: 2

.The patch failed the following testcases:

.  testMain(org.apache.oozie.action.hadoop.TestHiveMain)
.  testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
.  testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
.  testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
.  testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1599/

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.5.patch, OOZIE-1638.6.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-08-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14107579#comment-14107579
 ] 

Hadoop QA commented on OOZIE-1638:
--

Testing JIRA OOZIE-1638

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:red}-1 COMPILE{color}
.{color:red}-1{color} HEAD does not compile
.{color:red}-1{color} patch does not compile
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:red}-1 DISTRO{color}
.{color:red}-1{color} distro tarball fails with the patch


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1659/

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.5.patch, OOZIE-1638.6.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-08-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084168#comment-14084168
 ] 

Hadoop QA commented on OOZIE-1638:
--

Testing JIRA OOZIE-1638

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1506
.Tests failed: 2
.Tests errors: 0

.The patch failed the following testcases:

.  
testConcurrencyReachedAndChooseNextEligible(org.apache.oozie.service.TestCallableQueueService)
.  
testRequeueOnException(org.apache.oozie.command.coord.TestCoordPushDependencyCheckXCommand)

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1458/

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.5.patch, OOZIE-1638.6.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-04-09 Thread Mona Chitnis (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964719#comment-13964719
 ] 

Mona Chitnis commented on OOZIE-1638:
-

I'm also divided on whats the correct default retry count. Most users have no 
idea about the retry error codes and in some cases where users would benefit 
from auto retry, are not adequately captured in our error codes. I do agree 
that this requires urgent attention for documentation to understand which error 
codes are useful, which are not, and which new ones can we introduce.

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.5.patch, OOZIE-1638.6.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-04-09 Thread Azrael (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964870#comment-13964870
 ] 

Azrael commented on OOZIE-1638:
---

ALL keyword for the retry error code is convenient to users. I created issue 
[OOZIE-1653|https://issues.apache.org/jira/browse/OOZIE-1653]

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.5.patch, OOZIE-1638.6.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-03-18 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939502#comment-13939502
 ] 

Hadoop QA commented on OOZIE-1638:
--

Testing JIRA OOZIE-1638

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1397
.Tests failed: 0
.Tests errors: 2

.The patch failed the following testcases:

.  

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1105/

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.5.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-03-18 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940128#comment-13940128
 ] 

Hadoop QA commented on OOZIE-1638:
--

Testing JIRA OOZIE-1638

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1397
.Tests failed: 0
.Tests errors: 1

.The patch failed the following testcases:

.  

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1106/

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.5.patch, OOZIE-1638.6.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-03-17 Thread Rohini Palaniswamy (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13938496#comment-13938496
 ] 

Rohini Palaniswamy commented on OOZIE-1638:
---

Few minor comments:
- Can you remove assertTrue(true); ?
- In oozie-default.xml can you change the default value for 
oozie.service.LiteWorkflowStoreService.user.retry.max to 0 since that is the 
current behavior. Else suddenly there will be user retries with this release 
when it was not happening before. If default retries are needed, admins can set 
that in oozie-site.xml. 

[~rkanter],
 What is your thought on second comment? Should we leave the default at 3 
or change it to 0. The documentation also does not talk about a default retry. 

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-03-17 Thread Robert Kanter (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13938528#comment-13938528
 ] 

Robert Kanter commented on OOZIE-1638:
--

I'm thinking maybe we should change the default to 0 because:
a) That's the current effective behavior
b) There's no documentation on this; also, we don't mention what the possible 
Error Codes are that users could put into 
{{oozie.service.LiteWorkflowStoreService.user.retry.error.code}} or 
{{oozie.service.LiteWorkflowStoreService.user.retry.error.code.ext}}
c) The desired behavior of retrying on those error codes can be achieved in the 
workflow.xml; this is just the default when unspecified
I could see it the other way too though; 3 is supposed to be the correct 
behavior.  If you want to keep it at 3, I'm fine with that too.

Perhaps as part of this JIRA (or a followup/subtask) we should add 
documentation on this property and on the possible Error Codes that can be 
specified.  

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-01-13 Thread purshotam shah (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869741#comment-13869741
 ] 

purshotam shah commented on OOZIE-1638:
---

Comment on Patch.


+final WorkflowActionsGetForJobJPAExecutor actionsGetExecutor = new 
WorkflowActionsGetForJobJPAExecutor(jobId);
+waitFor(5000, new Predicate() {
+public boolean evaluate() throws Exception {
+ListWorkflowActionBean actions = 
jpaService.execute(actionsGetExecutor);
+WorkflowActionBean action = null;
+for (WorkflowActionBean bean : actions) {
+if (bean.getType().equals(test)) {
+action = bean;
+break;
+}
+}
+return (action != null  action.getUserRetryCount() == 
max);
+}
+});


You should break when action is succeeded or failed and then check 
getUserRetryCount()


+workflow-app xmlns=uri:oozie:workflow:0.3 name=test-wf
Why not to use latest version 0.5

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-01-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870403#comment-13870403
 ] 

Hadoop QA commented on OOZIE-1638:
--

Testing JIRA OOZIE-1638

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 5 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:red}-1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:red}-1{color} the patch seems to introduce 1 new javac warning(s)
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1383
.Tests failed: 0
.Tests errors: 1

.The patch failed the following testcases:

.  

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1009/

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2014-01-13 Thread Azrael (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870457#comment-13870457
 ] 

Azrael commented on OOZIE-1638:
---

Failing test is unrelated patch.

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, 
 OOZIE-1638.4.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2013-12-26 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857357#comment-13857357
 ] 

Hadoop QA commented on OOZIE-1638:
--

Testing JIRA OOZIE-1638

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 5 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1376
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/978/

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2013-12-11 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845324#comment-13845324
 ] 

Hadoop QA commented on OOZIE-1638:
--

Testing JIRA OOZIE-1638

Cleaning local svn workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132 
characters
.{color:green}+1{color} the patch does adds/modifies 4 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1375
.Tests failed: 3
.Tests errors: 0

.The patch failed the following testcases:

.  testRerunFromFailNodes(org.apache.oozie.command.wf.TestReRunXCommand)
.  testRerun(org.apache.oozie.command.wf.TestReRunXCommand)
.  
testTimeOutWithUnresolvedMissingDependencies(org.apache.oozie.command.coord.TestCoordPushDependencyCheckXCommand)

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/944/

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

2013-12-11 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846021#comment-13846021
 ] 

Hadoop QA commented on OOZIE-1638:
--

Testing JIRA OOZIE-1638

Cleaning local svn workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 5 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1375
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/945/

 Action retry does not use default retry max count.
 --

 Key: OOZIE-1638
 URL: https://issues.apache.org/jira/browse/OOZIE-1638
 Project: Oozie
  Issue Type: Bug
  Components: action
Affects Versions: 4.0.0
Reporter: Azrael
Priority: Minor
 Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, OOZIE-1638.patch


 the oozie-default
 {code:xml}
 property
 nameoozie.service.LiteWorkflowStoreService.user.retry.max/name
 value3/value
 description
 Automatic retry max count for workflow action is 3 in default.
 /description
 /property
 {code}
 but the action failed with error, is not retried. 
 It should retry $\{user.retry.max\} times.
 If the patch applied, some other tests in TestActionError failed because the 
 action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)