[jira] [Commented] (OOZIE-1702) [build] Fix Javadoc warnings
[ https://issues.apache.org/jira/browse/OOZIE-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783371#comment-16783371 ] Julia Kinga Marton commented on OOZIE-1702: --- Thank you [~dionusos] for the contribution! Committed to master. The spotbugs issues are unrelated. > [build] Fix Javadoc warnings > > > Key: OOZIE-1702 > URL: https://issues.apache.org/jira/browse/OOZIE-1702 > Project: Oozie > Issue Type: Wish > Components: build >Affects Versions: trunk >Reporter: Mona Chitnis >Assignee: Denes Bodo >Priority: Minor > Labels: documentation, newbie > Fix For: 5.2.0 > > Attachments: OOZIE-1702-001.patch, OOZIE-1702-002.patch > > > A lot of warnings are thrown during Oozie compilation, complaining about > javadoc mistakes, missing links etc among probably other severe ones. This > clutters the output. This JIRA is to fix these warnings -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1702) [build] Fix Javadoc warnings
[
https://issues.apache.org/jira/browse/OOZIE-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781814#comment-16781814
]
Hadoop QA commented on OOZIE-1702:
--
Testing JIRA OOZIE-1702
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [6] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:red}-1{color} There are [6] new bugs found below threshold in
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 207]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
.At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
.This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207]
.At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128]
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3145
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1026/
> [build] Fix Javadoc warnings
>
>
> Key: OOZIE-1702
> URL: https://issues.apache.org/jira/browse/OOZIE-1702
> Project: Oozie
> Issue Type: Wish
> Components: build
>Affects Versions: trunk
>Reporter: Mona Chitnis
>Assignee: Denes Bodo
>Priority: Minor
> Labels: documentation, newbie
> Attachments: OOZIE-1702-001.patch, OOZIE-1702-002.patch
>
>
> A lot of warnings are thrown during Oozie compilation, complaining about
> javadoc mistakes, missing links etc among probably other severe
[jira] [Commented] (OOZIE-1702) [build] Fix Javadoc warnings
[ https://issues.apache.org/jira/browse/OOZIE-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781780#comment-16781780 ] Julia Kinga Marton commented on OOZIE-1702: --- Thank you [~dionusos] for fixing this huge amount of warnings. +1 (pending Jenkins) > [build] Fix Javadoc warnings > > > Key: OOZIE-1702 > URL: https://issues.apache.org/jira/browse/OOZIE-1702 > Project: Oozie > Issue Type: Wish > Components: build >Affects Versions: trunk >Reporter: Mona Chitnis >Assignee: Denes Bodo >Priority: Minor > Labels: documentation, newbie > Attachments: OOZIE-1702-001.patch, OOZIE-1702-002.patch > > > A lot of warnings are thrown during Oozie compilation, complaining about > javadoc mistakes, missing links etc among probably other severe ones. This > clutters the output. This JIRA is to fix these warnings -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1702) [build] Fix Javadoc warnings
[ https://issues.apache.org/jira/browse/OOZIE-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781695#comment-16781695 ] Hadoop QA commented on OOZIE-1702: -- PreCommit-OOZIE-Build started > [build] Fix Javadoc warnings > > > Key: OOZIE-1702 > URL: https://issues.apache.org/jira/browse/OOZIE-1702 > Project: Oozie > Issue Type: Wish > Components: build >Affects Versions: trunk >Reporter: Mona Chitnis >Assignee: Denes Bodo >Priority: Minor > Labels: documentation, newbie > Attachments: OOZIE-1702-001.patch, OOZIE-1702-002.patch > > > A lot of warnings are thrown during Oozie compilation, complaining about > javadoc mistakes, missing links etc among probably other severe ones. This > clutters the output. This JIRA is to fix these warnings -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1702) [build] Fix Javadoc warnings
[ https://issues.apache.org/jira/browse/OOZIE-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780685#comment-16780685 ] Andras Salamon commented on OOZIE-1702: --- Nice catch [~kmarton]. That warning is quite misleading. > [build] Fix Javadoc warnings > > > Key: OOZIE-1702 > URL: https://issues.apache.org/jira/browse/OOZIE-1702 > Project: Oozie > Issue Type: Wish > Components: build >Affects Versions: trunk >Reporter: Mona Chitnis >Assignee: Denes Bodo >Priority: Minor > Labels: documentation, newbie > Attachments: OOZIE-1702-001.patch > > > A lot of warnings are thrown during Oozie compilation, complaining about > javadoc mistakes, missing links etc among probably other severe ones. This > clutters the output. This JIRA is to fix these warnings -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1702) [build] Fix Javadoc warnings
[ https://issues.apache.org/jira/browse/OOZIE-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780655#comment-16780655 ] Julia Kinga Marton commented on OOZIE-1702: --- WARNING: the current HEAD has 100 Javadoc warning(s) - this line refers to the pre-patched state: https://github.com/apache/oozie/blob/master/bin/test-patch-09-javadoc#L89-L91 > [build] Fix Javadoc warnings > > > Key: OOZIE-1702 > URL: https://issues.apache.org/jira/browse/OOZIE-1702 > Project: Oozie > Issue Type: Wish > Components: build >Affects Versions: trunk >Reporter: Mona Chitnis >Assignee: Denes Bodo >Priority: Minor > Labels: documentation, newbie > Attachments: OOZIE-1702-001.patch > > > A lot of warnings are thrown during Oozie compilation, complaining about > javadoc mistakes, missing links etc among probably other severe ones. This > clutters the output. This JIRA is to fix these warnings -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1702) [build] Fix Javadoc warnings
[ https://issues.apache.org/jira/browse/OOZIE-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780646#comment-16780646 ] Denes Bodo commented on OOZIE-1702: --- Purpose of my patch is to eliminate the 100+ javadoc warnings. The interesting thing that I managed to eliminate them by checking *mvn javadoc:javadoc* and all gone. I'll check it later. > [build] Fix Javadoc warnings > > > Key: OOZIE-1702 > URL: https://issues.apache.org/jira/browse/OOZIE-1702 > Project: Oozie > Issue Type: Wish > Components: build >Affects Versions: trunk >Reporter: Mona Chitnis >Assignee: Denes Bodo >Priority: Minor > Labels: documentation, newbie > Attachments: OOZIE-1702-001.patch > > > A lot of warnings are thrown during Oozie compilation, complaining about > javadoc mistakes, missing links etc among probably other severe ones. This > clutters the output. This JIRA is to fix these warnings -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-1702) [build] Fix Javadoc warnings
[
https://issues.apache.org/jira/browse/OOZIE-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780627#comment-16780627
]
Hadoop QA commented on OOZIE-1702:
--
Testing JIRA OOZIE-1702
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:red}-1{color} the patch contains 5 line(s) with tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [core].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3145
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1024/
> [build] Fix Javadoc warnings
>
>
> Key: OOZIE-1702
> URL: https://issues.apache.org/jira/browse/OOZIE-1702
> Project: Oozie
> Issue Type: Wish
> Components: build
>Affects Versions: trunk
>Reporter: Mona Chitnis
>Assignee: Denes Bodo
>Priority: Minor
> Labels: documentation, newbie
> Attachments: OOZIE-1702-001.patch
>
>
> A lot of warnings are thrown during Oozie compilation, complaining about
> javadoc mistakes, missing links etc among probably other severe ones. This
> clutters the output. This JIRA is to fix these warnings
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
