[jira] [Commented] (OOZIE-1703) User should be able to set coord end-time before start time
[
https://issues.apache.org/jira/browse/OOZIE-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025990#comment-14025990
]
Hadoop QA commented on OOZIE-1703:
--
Testing JIRA OOZIE-1703
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1462
.Tests failed: 4
.Tests errors: 1
.The patch failed the following testcases:
.
testActionInputCheckLatestActionCreationTime(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC)
.
testBundleEngineChange(org.apache.oozie.servlet.TestV1JobServletBundleEngine)
.
testBundleEngineSuspend(org.apache.oozie.servlet.TestV1JobServletBundleEngine)
.
testActionInputCheckLatestActionCreationTime(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommand)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/1294/
User should be able to set coord end-time before start time
---
Key: OOZIE-1703
URL: https://issues.apache.org/jira/browse/OOZIE-1703
Project: Oozie
Issue Type: Bug
Reporter: Purshotam Shah
Assignee: Purshotam Shah
Fix For: trunk
Attachments: OOZIE-1703-V5.patch, OOZIE-1703-V6.patch,
OOZIE-1703-V7.patch, OOZIE-1703-V7.patch, OOZIE-1703.patch
This is one of the important use-case in case of versioning.
User can set end date of old coord before start date( if coord is supposed to
run in future), so that it doesn't run and user can safely upload new version.
We should also lookahead at created actions that become invalid because of
the new end time.
These actions should be deleted from DB.
We should also update the status of bundle. If it's in PREP and new end-date
is before kick off time, then job status will be set to SUCCEEDED. User can
again change the end date to future date, the status will be changed to
RUNNING.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (OOZIE-1703) User should be able to set coord end-time before start time
[ https://issues.apache.org/jira/browse/OOZIE-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013931#comment-14013931 ] Purshotam Shah commented on OOZIE-1703: --- We noticed some issue while testing internally. If we set endtime multiple times, coord remains in running state. Attaching amendment patch. User should be able to set coord end-time before start time --- Key: OOZIE-1703 URL: https://issues.apache.org/jira/browse/OOZIE-1703 Project: Oozie Issue Type: Bug Reporter: Purshotam Shah Assignee: Purshotam Shah Fix For: trunk Attachments: OOZIE-1703-V5.patch, OOZIE-1703-V6.patch, OOZIE-1703-V7.patch, OOZIE-1703.patch This is one of the important use-case in case of versioning. User can set end date of old coord before start date( if coord is supposed to run in future), so that it doesn't run and user can safely upload new version. We should also lookahead at created actions that become invalid because of the new end time. These actions should be deleted from DB. We should also update the status of bundle. If it's in PREP and new end-date is before kick off time, then job status will be set to SUCCEEDED. User can again change the end date to future date, the status will be changed to RUNNING. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OOZIE-1703) User should be able to set coord end-time before start time
[
https://issues.apache.org/jira/browse/OOZIE-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969122#comment-13969122
]
Hadoop QA commented on OOZIE-1703:
--
Testing JIRA OOZIE-1703
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 4 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:red}-1 RAT{color}
.{color:red}-1{color} the patch seems to introduce 1 new RAT warning(s)
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1412
.Tests failed: 0
.Tests errors: 1
.The patch failed the following testcases:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/1170/
User should be able to set coord end-time before start time
---
Key: OOZIE-1703
URL: https://issues.apache.org/jira/browse/OOZIE-1703
Project: Oozie
Issue Type: Bug
Reporter: Purshotam Shah
Assignee: Purshotam Shah
Attachments: OOZIE-1703-V5.patch, OOZIE-1703-V6.patch,
OOZIE-1703.patch
This is one of the important use-case in case of versioning.
User can set end date of old coord before start date( if coord is supposed to
run in future), so that it doesn't run and user can safely upload new version.
We should also lookahead at created actions that become invalid because of
the new end time.
These actions should be deleted from DB.
We should also update the status of bundle. If it's in PREP and new end-date
is before kick off time, then job status will be set to SUCCEEDED. User can
again change the end date to future date, the status will be changed to
RUNNING.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (OOZIE-1703) User should be able to set coord end-time before start time
[ https://issues.apache.org/jira/browse/OOZIE-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969126#comment-13969126 ] Purshotam Shah commented on OOZIE-1703: --- . -1 the patch contains 4 line(s) longer than 132 characters Those are lines from twiki. User should be able to set coord end-time before start time --- Key: OOZIE-1703 URL: https://issues.apache.org/jira/browse/OOZIE-1703 Project: Oozie Issue Type: Bug Reporter: Purshotam Shah Assignee: Purshotam Shah Attachments: OOZIE-1703-V5.patch, OOZIE-1703-V6.patch, OOZIE-1703.patch This is one of the important use-case in case of versioning. User can set end date of old coord before start date( if coord is supposed to run in future), so that it doesn't run and user can safely upload new version. We should also lookahead at created actions that become invalid because of the new end time. These actions should be deleted from DB. We should also update the status of bundle. If it's in PREP and new end-date is before kick off time, then job status will be set to SUCCEEDED. User can again change the end date to future date, the status will be changed to RUNNING. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OOZIE-1703) User should be able to set coord end-time before start time
[ https://issues.apache.org/jira/browse/OOZIE-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965650#comment-13965650 ] Bowen Zhang commented on OOZIE-1703: My biggest concern is the assumption that coord frequency is always an integer(which is not true) displayed in the patch. User should be able to set coord end-time before start time --- Key: OOZIE-1703 URL: https://issues.apache.org/jira/browse/OOZIE-1703 Project: Oozie Issue Type: Bug Reporter: Purshotam Shah Assignee: Purshotam Shah Attachments: OOZIE-1703.patch This is one of the important use-case in case of versioning. User can set end date of old coord before start date( if coord is supposed to run in future), so that it doesn't run and user can safely upload new version. We should also lookahead at created actions that become invalid because of the new end time. These actions should be deleted from DB. We should also update the status of bundle. If it's in PREP and new end-date is before kick off time, then job status will be set to SUCCEEDED. User can again change the end date to future date, the status will be changed to RUNNING. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OOZIE-1703) User should be able to set coord end-time before start time
[ https://issues.apache.org/jira/browse/OOZIE-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965767#comment-13965767 ] Purshotam Shah commented on OOZIE-1703: --- Thanks [~bowenzhangusa]. [~rohini] also pointed out the same issue. I have changed logic to calculate last action time. User should be able to set coord end-time before start time --- Key: OOZIE-1703 URL: https://issues.apache.org/jira/browse/OOZIE-1703 Project: Oozie Issue Type: Bug Reporter: Purshotam Shah Assignee: Purshotam Shah Attachments: OOZIE-1703.patch This is one of the important use-case in case of versioning. User can set end date of old coord before start date( if coord is supposed to run in future), so that it doesn't run and user can safely upload new version. We should also lookahead at created actions that become invalid because of the new end time. These actions should be deleted from DB. We should also update the status of bundle. If it's in PREP and new end-date is before kick off time, then job status will be set to SUCCEEDED. User can again change the end date to future date, the status will be changed to RUNNING. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OOZIE-1703) User should be able to set coord end-time before start time
[
https://issues.apache.org/jira/browse/OOZIE-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965986#comment-13965986
]
Hadoop QA commented on OOZIE-1703:
--
Testing JIRA OOZIE-1703
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 3 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:red}-1 RAT{color}
.{color:red}-1{color} the patch seems to introduce 1 new RAT warning(s)
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/1163/
User should be able to set coord end-time before start time
---
Key: OOZIE-1703
URL: https://issues.apache.org/jira/browse/OOZIE-1703
Project: Oozie
Issue Type: Bug
Reporter: Purshotam Shah
Assignee: Purshotam Shah
Attachments: OOZIE-1703-V5.patch, OOZIE-1703.patch
This is one of the important use-case in case of versioning.
User can set end date of old coord before start date( if coord is supposed to
run in future), so that it doesn't run and user can safely upload new version.
We should also lookahead at created actions that become invalid because of
the new end time.
These actions should be deleted from DB.
We should also update the status of bundle. If it's in PREP and new end-date
is before kick off time, then job status will be set to SUCCEEDED. User can
again change the end date to future date, the status will be changed to
RUNNING.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
