[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse
[
https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396975#comment-15396975
]
Hadoop QA commented on OOZIE-1918:
--
Testing JIRA OOZIE-1918
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> ActionXCommand refactoring for code reuse
> -
>
> Key: OOZIE-1918
> URL: https://issues.apache.org/jira/browse/OOZIE-1918
> Project: Oozie
> Issue Type: Improvement
> Components: action
>Affects Versions: trunk
>Reporter: Azrael Seoeun
>Assignee: Azrael Seoeun
>Priority: Trivial
> Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch,
> OOZIE-1918.3.noprefix.patch
>
>
> Subclasses of ActionXCommand have some duplicated code. Refactoring make it
> more neat.
> This patch contain:
> * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending
> ActionXCommand
> * Moving some variables and methods to ActionXCommand and making it protected
> * More meaningful log message : actionId is duplicated so removed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse
[
https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057419#comment-15057419
]
Hadoop QA commented on OOZIE-1918:
--
Testing JIRA OOZIE-1918
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> ActionXCommand refactoring for code reuse
> -
>
> Key: OOZIE-1918
> URL: https://issues.apache.org/jira/browse/OOZIE-1918
> Project: Oozie
> Issue Type: Improvement
> Components: action
>Affects Versions: trunk
>Reporter: Azrael Seoeun
>Assignee: Azrael Seoeun
>Priority: Trivial
> Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch,
> OOZIE-1918.3.noprefix.patch
>
>
> Subclasses of ActionXCommand have some duplicated code. Refactoring make it
> more neat.
> This patch contain:
> * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending
> ActionXCommand
> * Moving some variables and methods to ActionXCommand and making it protected
> * More meaningful log message : actionId is duplicated so removed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse
[ https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611711#comment-14611711 ] Jaydeep Vishwakarma commented on OOZIE-1918: [~seoeun25] , please check review in review board, have small issue otherwise it is fine. > ActionXCommand refactoring for code reuse > - > > Key: OOZIE-1918 > URL: https://issues.apache.org/jira/browse/OOZIE-1918 > Project: Oozie > Issue Type: Improvement > Components: action >Affects Versions: trunk >Reporter: Azrael Seoeun >Assignee: Azrael Seoeun >Priority: Trivial > Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch > > > Subclasses of ActionXCommand have some duplicated code. Refactoring make it > more neat. > This patch contain: > * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending > ActionXCommand > * Moving some variables and methods to ActionXCommand and making it protected > * More meaningful log message : actionId is duplicated so removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse
[ https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337869#comment-14337869 ] Azrael commented on OOZIE-1918: --- Thanks [~jaydeepmail]. I uploaded the rebased patch(without --no-prefix) on reviewboard. Please, review it. > ActionXCommand refactoring for code reuse > - > > Key: OOZIE-1918 > URL: https://issues.apache.org/jira/browse/OOZIE-1918 > Project: Oozie > Issue Type: Improvement > Components: action >Affects Versions: trunk >Reporter: Azrael >Assignee: Azrael >Priority: Trivial > Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch > > > Subclasses of ActionXCommand have some duplicated code. Refactoring make it > more neat. > This patch contain: > * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending > ActionXCommand > * Moving some variables and methods to ActionXCommand and making it protected > * More meaningful log message : actionId is duplicated so removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse
[ https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327173#comment-14327173 ] Jaydeep Vishwakarma commented on OOZIE-1918: These classes have so many changes from when you uploaded the patch. Can you please rebase your code and upload the patch again , I would like to review the patch. > ActionXCommand refactoring for code reuse > - > > Key: OOZIE-1918 > URL: https://issues.apache.org/jira/browse/OOZIE-1918 > Project: Oozie > Issue Type: Improvement > Components: action >Affects Versions: trunk >Reporter: Azrael >Assignee: Azrael >Priority: Trivial > Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch > > > Subclasses of ActionXCommand have some duplicated code. Refactoring make it > more neat. > This patch contain: > * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending > ActionXCommand > * Moving some variables and methods to ActionXCommand and making it protected > * More meaningful log message : actionId is duplicated so removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse
[
https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119246#comment-14119246
]
Hadoop QA commented on OOZIE-1918:
--
Testing JIRA OOZIE-1918
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> ActionXCommand refactoring for code reuse
> -
>
> Key: OOZIE-1918
> URL: https://issues.apache.org/jira/browse/OOZIE-1918
> Project: Oozie
> Issue Type: Improvement
> Components: action
>Affects Versions: trunk
>Reporter: Azrael
>Assignee: Azrael
>Priority: Trivial
> Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch
>
>
> Subclasses of ActionXCommand have some duplicated code. Refactoring make it
> more neat.
> This patch contain:
> * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending
> ActionXCommand
> * Moving some variables and methods to ActionXCommand and making it protected
> * More meaningful log message : actionId is duplicated so removed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse
[
https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110141#comment-14110141
]
Hadoop QA commented on OOZIE-1918:
--
Testing JIRA OOZIE-1918
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> ActionXCommand refactoring for code reuse
> -
>
> Key: OOZIE-1918
> URL: https://issues.apache.org/jira/browse/OOZIE-1918
> Project: Oozie
> Issue Type: Improvement
> Components: action
>Affects Versions: trunk
>Reporter: Azrael
>Assignee: Azrael
>Priority: Trivial
> Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch
>
>
> Subclasses of ActionXCommand have some duplicated code. Refactoring make it
> more neat.
> This patch contain:
> * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending
> ActionXCommand
> * Moving some variables and methods to ActionXCommand and making it protected
> * More meaningful log message : actionId is duplicated so removed
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse
[
https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107506#comment-14107506
]
Hadoop QA commented on OOZIE-1918:
--
Testing JIRA OOZIE-1918
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> ActionXCommand refactoring for code reuse
> -
>
> Key: OOZIE-1918
> URL: https://issues.apache.org/jira/browse/OOZIE-1918
> Project: Oozie
> Issue Type: Improvement
> Components: action
>Affects Versions: trunk
>Reporter: Azrael
>Assignee: Azrael
>Priority: Trivial
> Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch
>
>
> Subclasses of ActionXCommand have some duplicated code. Refactoring make it
> more neat.
> This patch contain:
> * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending
> ActionXCommand
> * Moving some variables and methods to ActionXCommand and making it protected
> * More meaningful log message : actionId is duplicated so removed
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse
[
https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107433#comment-14107433
]
Hadoop QA commented on OOZIE-1918:
--
Testing JIRA OOZIE-1918
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> ActionXCommand refactoring for code reuse
> -
>
> Key: OOZIE-1918
> URL: https://issues.apache.org/jira/browse/OOZIE-1918
> Project: Oozie
> Issue Type: Improvement
> Components: action
>Affects Versions: trunk
>Reporter: Azrael
>Assignee: Azrael
>Priority: Trivial
> Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch
>
>
> Subclasses of ActionXCommand have some duplicated code. Refactoring make it
> more neat.
> This patch contain:
> * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending
> ActionXCommand
> * Moving some variables and methods to ActionXCommand and making it protected
> * More meaningful log message : actionId is duplicated so removed
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse
[
https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083767#comment-14083767
]
Hadoop QA commented on OOZIE-1918:
--
Testing JIRA OOZIE-1918
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:red}-1{color} the patch contains 1 line(s) with tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1505
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
. testForNoDuplicates(org.apache.oozie.event.TestEventGeneration)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/1433/
> ActionXCommand refactoring for code reuse
> -
>
> Key: OOZIE-1918
> URL: https://issues.apache.org/jira/browse/OOZIE-1918
> Project: Oozie
> Issue Type: Improvement
> Components: action
>Affects Versions: trunk
>Reporter: Azrael
>Assignee: Azrael
>Priority: Trivial
> Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch
>
>
> Subclasses of ActionXCommand have some duplicated code. Refactoring make it
> more neat.
> This patch contain:
> * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending
> ActionXCommand
> * Moving some variables and methods to ActionXCommand and making it protected
> * More meaningful log message : actionId is duplicated so removed
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse
[ https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074970#comment-14074970 ] Rohini Palaniswamy commented on OOZIE-1918: --- I always like having lesser lines of code :). Thanks for doing some cleanup. > ActionXCommand refactoring for code reuse > - > > Key: OOZIE-1918 > URL: https://issues.apache.org/jira/browse/OOZIE-1918 > Project: Oozie > Issue Type: Improvement > Components: action >Affects Versions: trunk >Reporter: Azrael >Assignee: Azrael >Priority: Trivial > Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch > > > Subclasses of ActionXCommand have some duplicated code. Refactoring make it > more neat. > This patch contain: > * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending > ActionXCommand > * Moving some variables and methods to ActionXCommand and making it protected > * More meaningful log message : actionId is duplicated so removed -- This message was sent by Atlassian JIRA (v6.2#6252)
