[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439233#comment-15439233
]
Abhishek Bafna commented on OOZIE-2657:
---
[~rkanter], [~jaydeepvishwakarma] Can you guys please take? Thanks.
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Attachments: OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439428#comment-15439428
]
Hadoop QA commented on OOZIE-2657:
--
Testing JIRA OOZIE-2657
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1798
.Tests failed: 5
.Tests errors: 2
.The patch failed the following testcases:
. testMain(org.apache.oozie.action.hadoop.TestHiveMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
. testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
. testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3246/
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Attachments: OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439654#comment-15439654
]
Abhishek Bafna commented on OOZIE-2657:
---
Testcase failure is not related. Test passes locally.
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Attachments: OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439801#comment-15439801
]
Jaydeep Vishwakarma commented on OOZIE-2657:
+1.
Big cleanup. Thanks for the patch, Committed to master
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Attachments: OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440589#comment-15440589
]
Abhishek Bafna commented on OOZIE-2657:
---
Thanks [~jaydeepvishwakarma] for the review and committing it.
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Fix For: 4.3.0
>
> Attachments: OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501040#comment-15501040
]
Hadoop QA commented on OOZIE-2657:
--
Testing JIRA OOZIE-2657
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1804
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
.
testCoordActionInputCheckXCommandUniqueness(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommand)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3292/
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Fix For: 4.3.0
>
> Attachments: OOZIE-2657-00-amend.patch, OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501154#comment-15501154
]
Abhishek Bafna commented on OOZIE-2657:
---
Testcase failure is not relevant to the patch and passes locally. Thanks.
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Fix For: 4.3.0
>
> Attachments: OOZIE-2657-00-amend.patch, OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501289#comment-15501289
]
Jaydeep Vishwakarma commented on OOZIE-2657:
+1
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Fix For: 4.3.0
>
> Attachments: OOZIE-2657-00-amend.patch, OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502253#comment-15502253
]
Abhishek Bafna commented on OOZIE-2657:
---
Thanks [~jaydeepvishwakarma].
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Fix For: 4.3.0
>
> Attachments: OOZIE-2657-00-amend.patch, OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502531#comment-15502531
]
Robert Kanter commented on OOZIE-2657:
--
[~jaydeepvishwakarma], [~abhishekbafna]
I'm not sure this is a good idea. It's going to make backporting patches (e.g.
Cloudera, Yahoo!, Hortonworks, etc) harder because it makes a lot of changes to
a lot of files (the same reason we don't do a mass cleanup of imports). IMO,
that would be better left to fixing when we make other changes to those files.
I'm also not sure there's any real benefit to removing the redundant modifiers?
In fact, isn't it more clear with them?
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Fix For: 4.3.0
>
> Attachments: OOZIE-2657-00-amend.patch, OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502892#comment-15502892
]
Jaydeep Vishwakarma commented on OOZIE-2657:
[~rkanter],
The changes are in {{interface}} and it does not change so frequently, except
the {{interface}} with contains only {{constants}}.
Also I believe removing redundant access modifier will make any backward
compatibility issue, perhaps you meant something else?
It is common knowledge in case of interface that everything is public (there is
no point in putting a private member, because you are actually establishing an
interface) and and all assignments are final, because no instance it is also at
class level. Java's native supplied JDK interfaces don't put these modifiers.
So if you want to follow best practices, that is what you would follow.
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Fix For: 4.3.0
>
> Attachments: OOZIE-2657-00-amend.patch, OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2657) Clean up redundant access modifiers from oozie interfaces
[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504052#comment-15504052
]
Robert Kanter commented on OOZIE-2657:
--
Ya, it wouldn't be a backwards compatibility issue. I just meant, at least to
me, it's less clear because instead of just seeing that it's {{public static}}
or whatever in the code directly, I have to go and think about "Ok, this is an
interface, so that means that...".
But if that's the best practices, I suppose that's fine then.
> Clean up redundant access modifiers from oozie interfaces
> -
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
>Priority: Minor
> Labels: code-cleanup
> Fix For: 4.3.0
>
> Attachments: OOZIE-2657-00-amend.patch, OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
