[jira] [Commented] (OOZIE-2732) Remove login server example
[
https://issues.apache.org/jira/browse/OOZIE-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817374#comment-15817374
]
Abhishek Bafna commented on OOZIE-2732:
---
+1. Committed to master.
Thanks [~rkanter] for the patch and [~andras.piros] for the review.
> Remove login server example
> ---
>
> Key: OOZIE-2732
> URL: https://issues.apache.org/jira/browse/OOZIE-2732
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 5.0.0
>
> Attachments: OOZIE-2732.001.patch, OOZIE-2732.002.patch
>
>
> 4 years ago, OOZIE-1103 added a "login" module which provided two
> (non-secure) examples of hadoop-auth's {{AltKerberosAuthenticationHandler}}.
> This module is built only when the "login" profile is activated. I think
> it's time to remove this because:
> - it's super old and not maintained
> - it's not widely used AFAIK (if at all)
> - it doesn't really belong in Oozie; it's an example for a hadoop-auth feature
> - it's not secure, so it's not a great example anyway
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2732) Remove login server example
[
https://issues.apache.org/jira/browse/OOZIE-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15737510#comment-15737510
]
Andras Piros commented on OOZIE-2732:
-
+1 (non-binding)
> Remove login server example
> ---
>
> Key: OOZIE-2732
> URL: https://issues.apache.org/jira/browse/OOZIE-2732
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 5.0.0
>
> Attachments: OOZIE-2732.001.patch, OOZIE-2732.002.patch
>
>
> 4 years ago, OOZIE-1103 added a "login" module which provided two
> (non-secure) examples of hadoop-auth's {{AltKerberosAuthenticationHandler}}.
> This module is built only when the "login" profile is activated. I think
> it's time to remove this because:
> - it's super old and not maintained
> - it's not widely used AFAIK (if at all)
> - it doesn't really belong in Oozie; it's an example for a hadoop-auth feature
> - it's not secure, so it's not a great example anyway
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2732) Remove login server example
[
https://issues.apache.org/jira/browse/OOZIE-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734689#comment-15734689
]
Abhishek Bafna commented on OOZIE-2732:
---
This patch require small re-base. Thanks.
> Remove login server example
> ---
>
> Key: OOZIE-2732
> URL: https://issues.apache.org/jira/browse/OOZIE-2732
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 5.0.0
>
> Attachments: OOZIE-2732.001.patch
>
>
> 4 years ago, OOZIE-1103 added a "login" module which provided two
> (non-secure) examples of hadoop-auth's {{AltKerberosAuthenticationHandler}}.
> This module is built only when the "login" profile is activated. I think
> it's time to remove this because:
> - it's super old and not maintained
> - it's not widely used AFAIK (if at all)
> - it doesn't really belong in Oozie; it's an example for a hadoop-auth feature
> - it's not secure, so it's not a great example anyway
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2732) Remove login server example
[
https://issues.apache.org/jira/browse/OOZIE-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654676#comment-15654676
]
Hadoop QA commented on OOZIE-2732:
--
Testing JIRA OOZIE-2732
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} FindBugs diff JAR has a weird MD5 sum, rejecting.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1818
.Tests failed: 5
.Tests errors: 3
.The patch failed the following testcases:
. testMain(org.apache.oozie.action.hadoop.TestHiveMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
. testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
. testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3430/
> Remove login server example
> ---
>
> Key: OOZIE-2732
> URL: https://issues.apache.org/jira/browse/OOZIE-2732
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: trunk
>
> Attachments: OOZIE-2732.001.patch
>
>
> 4 years ago, OOZIE-1103 added a "login" module which provided two
> (non-secure) examples of hadoop-auth's {{AltKerberosAuthenticationHandler}}.
> This module is built only when the "login" profile is activated. I think
> it's time to remove this because:
> - it's super old and not maintained
> - it's not widely used AFAIK (if at all)
> - it doesn't really belong in Oozie; it's an example for a hadoop-auth feature
> - it's not secure, so it's not a great example anyway
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
