[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[ https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055265#comment-16055265 ] Peter Cseh commented on OOZIE-2769: --- +1 > Extend FS action to allow setrep on a file > -- > > Key: OOZIE-2769 > URL: https://issues.apache.org/jira/browse/OOZIE-2769 > Project: Oozie > Issue Type: Improvement > Components: action, core >Affects Versions: 4.2.0 >Reporter: Artem Ervits >Assignee: Artem Ervits >Priority: Minor > Labels: easyfix, features, patch > Fix For: trunk, 5.0.0 > > Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch, > OOZIE-2769-2.patch, OOZIE-2769-3.patch, OOZIE-2769-4.patch, > OOZIE-2769-5.patch, OOZIE-2769-6.patch > > > Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature > extends FS action to allow for setrep on an HDFS file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[ https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055081#comment-16055081 ] Artem Ervits commented on OOZIE-2769: - tests pass locally. Rebased the patch, please review. > Extend FS action to allow setrep on a file > -- > > Key: OOZIE-2769 > URL: https://issues.apache.org/jira/browse/OOZIE-2769 > Project: Oozie > Issue Type: Improvement > Components: action, core >Affects Versions: 4.2.0 >Reporter: Artem Ervits >Assignee: Artem Ervits >Priority: Minor > Labels: easyfix, features, patch > Fix For: trunk, 5.0.0 > > Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch, > OOZIE-2769-2.patch, OOZIE-2769-3.patch, OOZIE-2769-4.patch, > OOZIE-2769-5.patch, OOZIE-2769-6.patch > > > Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature > extends FS action to allow for setrep on an HDFS file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055047#comment-16055047
]
Hadoop QA commented on OOZIE-2769:
--
Testing JIRA OOZIE-2769
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:red}-1{color} the patch contains 1 line(s) with tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 6 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1968
.Tests rerun: 79
.Tests failed at first run:
org.apache.oozie.action.hadoop.TestJavaActionExecutor,org.apache.oozie.jms.TestJMSJobEventListener,org.apache.oozie.action.hadoop.TestLauncherAM,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3912/
> Extend FS action to allow setrep on a file
> --
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
>Affects Versions: 4.2.0
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk, 5.0.0
>
> Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch,
> OOZIE-2769-2.patch, OOZIE-2769-3.patch, OOZIE-2769-4.patch,
> OOZIE-2769-5.patch, OOZIE-2769-6.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[ https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053996#comment-16053996 ] Peter Cseh commented on OOZIE-2769: --- Oh, this totally slipped my mind. I'm sorry. Can you rebase the patch? It does not apply to master anymore. > Extend FS action to allow setrep on a file > -- > > Key: OOZIE-2769 > URL: https://issues.apache.org/jira/browse/OOZIE-2769 > Project: Oozie > Issue Type: Improvement > Components: action, core >Affects Versions: 4.2.0 >Reporter: Artem Ervits >Assignee: Artem Ervits >Priority: Minor > Labels: easyfix, features, patch > Fix For: trunk, 5.0.0 > > Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch, > OOZIE-2769-2.patch, OOZIE-2769-3.patch, OOZIE-2769-4.patch, OOZIE-2769-5.patch > > > Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature > extends FS action to allow for setrep on an HDFS file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[ https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029854#comment-16029854 ] Artem Ervits commented on OOZIE-2769: - [~gezapeti] you're a committer now ;) > Extend FS action to allow setrep on a file > -- > > Key: OOZIE-2769 > URL: https://issues.apache.org/jira/browse/OOZIE-2769 > Project: Oozie > Issue Type: Improvement > Components: action, core >Affects Versions: 4.2.0 >Reporter: Artem Ervits >Priority: Minor > Labels: easyfix, features, patch > Fix For: trunk > > Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch, > OOZIE-2769-2.patch, OOZIE-2769-3.patch, OOZIE-2769-4.patch, OOZIE-2769-5.patch > > > Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature > extends FS action to allow for setrep on an HDFS file. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[ https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817733#comment-15817733 ] Peter Cseh commented on OOZIE-2769: --- You have to get a +1 from one of the committers. Let's ping [~abhishekbafna] and [~satishsaley] and ask for a review. > Extend FS action to allow setrep on a file > -- > > Key: OOZIE-2769 > URL: https://issues.apache.org/jira/browse/OOZIE-2769 > Project: Oozie > Issue Type: Improvement > Components: action, core >Affects Versions: 4.2.0 >Reporter: Artem Ervits >Priority: Minor > Labels: easyfix, features, patch > Fix For: trunk > > Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch, > OOZIE-2769-2.patch, OOZIE-2769-3.patch, OOZIE-2769-4.patch, OOZIE-2769-5.patch > > > Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature > extends FS action to allow for setrep on an HDFS file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[ https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816384#comment-15816384 ] Artem Ervits commented on OOZIE-2769: - [~gezapeti] thank you for your +1, just for my own knowledge, what happens next, how many +1 do I need to have my patch committed to trunk? Btw, I saw in the build notes, lines > 132 characters is coming from other sources than mine. There are many different classes with that issue. > Extend FS action to allow setrep on a file > -- > > Key: OOZIE-2769 > URL: https://issues.apache.org/jira/browse/OOZIE-2769 > Project: Oozie > Issue Type: Improvement > Components: action, core >Affects Versions: 4.2.0 >Reporter: Artem Ervits >Priority: Minor > Labels: easyfix, features, patch > Fix For: trunk > > Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch, > OOZIE-2769-2.patch, OOZIE-2769-3.patch, OOZIE-2769-4.patch, OOZIE-2769-5.patch > > > Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature > extends FS action to allow for setrep on an HDFS file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816022#comment-15816022
]
Peter Cseh commented on OOZIE-2769:
---
Thanks for the improvements [~dbist13]!
The xsd files are used to validate the workflow.xml files before processing
them by Oozie. By defining the {{replication-factor}} as {{xs:short}} we'll
reject workflows containing letters and too big numbers there. It won't affect
the way the xml itself has to be processed.
+1 (non-binding) for the patch.
> Extend FS action to allow setrep on a file
> --
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
>Affects Versions: 4.2.0
>Reporter: Artem Ervits
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk
>
> Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch,
> OOZIE-2769-2.patch, OOZIE-2769-3.patch, OOZIE-2769-4.patch, OOZIE-2769-5.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815880#comment-15815880
]
Hadoop QA commented on OOZIE-2769:
--
Testing JIRA OOZIE-2769
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1839
.Tests failed: 0
.Tests errors: 1
.The patch failed the following testcases:
.
.Tests failing with errors:
. testJMXInstrumentation(org.apache.oozie.util.TestMetricsInstrumentation)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3540/
> Extend FS action to allow setrep on a file
> --
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
>Affects Versions: 4.2.0
>Reporter: Artem Ervits
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk
>
> Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch,
> OOZIE-2769-2.patch, OOZIE-2769-3.patch, OOZIE-2769-4.patch, OOZIE-2769-5.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814420#comment-15814420
]
Peter Cseh commented on OOZIE-2769:
---
Yes, that would be a great place for the test. Also, adding other commands like
thouchz is a good idea.
Some tests are still failing.
The code seem fine now, the problem is in the xsd / xml files.
# the schema version in {{/core/src/test/resources/wf-schema-valid.xml}} have
to be changed from 0.1 to 0.5
# the {{}} element in {{/core/src/test/resources/wf-schema-valid.xml}}
needs the {{replication-factor}} attribute.
# in {{oozie-workflow-0.5.xsd}} the SETREP type need a path attribute to work,
preferably before the {{replication-factor}}. You may copy it over from the
TOUCHZ type.
# I would change the type of the {{replication-factor}} from {{xs:string}} to
{{"xs:unsignedShort"}} or {{xs:short}}
# the documentation of the setrep command is not correct in
WorkflowFunctionalSpec, it does not have the number after the
{{replication-factor}} attribute
> Extend FS action to allow setrep on a file
> --
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
>Affects Versions: 4.2.0
>Reporter: Artem Ervits
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk
>
> Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch,
> OOZIE-2769-2.patch, OOZIE-2769-3.patch, OOZIE-2769-4.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813565#comment-15813565
]
Hadoop QA commented on OOZIE-2769:
--
Testing JIRA OOZIE-2769
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:red}-1{color} patch does not compile
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [core].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1837
.Tests failed: 1
.Tests errors: 2
.The patch failed the following testcases:
.
testCoordActionInputCheckXCommandUniqueness(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommand)
.Tests failing with errors:
. testSchema(org.apache.oozie.service.TestLiteWorkflowAppService)
. testParsing(org.apache.oozie.service.TestLiteWorkflowAppService)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3538/
> Extend FS action to allow setrep on a file
> --
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
>Affects Versions: 4.2.0
>Reporter: Artem Ervits
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk
>
> Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch,
> OOZIE-2769-2.patch, OOZIE-2769-3.patch, OOZIE-2769-4.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811159#comment-15811159
]
Peter Cseh commented on OOZIE-2769:
---
Thanks for the update!
Th long line was probably for the method {{setrep(Context context,
XConfiguration fsConf, Path nameNodePath, Path path, short
replicationFactor)}}. I think it still has two unnecessary parameters, which
are always null and should be removed.
I don't know what's wrong with the test, but the test in patch-0 works if I
change the {{path}} to {{outputFile}} in the asserts.
I haven't tried it out, but based on the code the documentation and the example
should say
{noformat}
{noformat}
or something like that.
Also, I've just noticed that the {{oozie-workflow-0.5.xsd}} have to be updated
to accept the new command.
Can you add a test with a workflow.xml file that uses this parameter?
> Extend FS action to allow setrep on a file
> --
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
>Affects Versions: 4.2.0
>Reporter: Artem Ervits
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk
>
> Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch,
> OOZIE-2769-2.patch, OOZIE-2769-3.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810628#comment-15810628
]
Hadoop QA commented on OOZIE-2769:
--
Testing JIRA OOZIE-2769
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1837
.Tests failed: 2
.Tests errors: 0
.The patch failed the following testcases:
. testSetRep(org.apache.oozie.action.hadoop.TestFsActionExecutor)
. testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)
.Tests failing with errors:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3536/
> Extend FS action to allow setrep on a file
> --
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
>Affects Versions: 4.2.0
>Reporter: Artem Ervits
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk
>
> Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch,
> OOZIE-2769-2.patch, OOZIE-2769-3.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810146#comment-15810146
]
Hadoop QA commented on OOZIE-2769:
--
Testing JIRA OOZIE-2769
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1837
.Tests failed: 0
.Tests errors: 1
.The patch failed the following testcases:
.
.Tests failing with errors:
. testSetRep(org.apache.oozie.action.hadoop.TestFsActionExecutor)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3535/
> Extend FS action to allow setrep on a file
> --
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
>Affects Versions: 4.2.0
>Reporter: Artem Ervits
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk
>
> Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch,
> OOZIE-2769-2.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807553#comment-15807553
]
Peter Cseh commented on OOZIE-2769:
---
Thanks for the contribution [~dbist13]!
We have some flaky tests around unfortunately,
{{testMemoryUsageAndSpeedOverflowToDisk}} is one of them. It can be ignored.
Some thoughts on your patch:
# Please check the patch for trailing whitespaces and remove them
# I would add the test back. It was failing because it's checking for the
replication factor of the {{path}} instead of the {{outputFile}}:
{code}
ae.setrep(context, *outputFile*, (short) 3);
assertEquals(fs.getFileStatus(*path*).getReplication(), 3);
{code}
Please switch the arguments for {{assertEquals}}, the expected value should be
the first one.
# I don't think there's a need for {{setrep(Context context, XConfiguration
fsConf, Path nameNodePath, Path path, short replicationFactor)}}. I would
simply inline it and use {{null}} where it's needed.
# Please add documentation for this feature in {{WorkflowFunctionalSpec.twiki}}
> Extend FS action to allow setrep on a file
> --
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
>Affects Versions: 4.2.0
>Reporter: Artem Ervits
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk
>
> Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15806909#comment-15806909
]
Hadoop QA commented on OOZIE-2769:
--
Testing JIRA OOZIE-2769
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 7 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1836
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3533/
> Extend FS action to allow setrep on a file
> --
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
>Affects Versions: 4.2.0
>Reporter: Artem Ervits
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk
>
> Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2769) Extend FS action to allow setrep on a file
[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805137#comment-15805137
]
Hadoop QA commented on OOZIE-2769:
--
Testing JIRA OOZIE-2769
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 13 line(s) with trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:orange}0{color} There are [1] new bugs found in total that would be nice
to have fixed.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:orange}0{color} There are [1] new bugs found in [core] that would
be nice to have fixed.
.You can find the FindBugs diff here: core/findbugs-new.html
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1832
.Tests failed: 1
.Tests errors: 1
.The patch failed the following testcases:
.
testMemoryUsageAndSpeedOverflowToDisk(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)
.Tests failing with errors:
. testSetRep(org.apache.oozie.action.hadoop.TestFsActionExecutor)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3531/
> Extend FS action to allow setrep on a file
> --
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
>Affects Versions: 4.2.0
>Reporter: Artem Ervits
>Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk
>
> Attachments: OOZIE-2769-0.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
