[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging
[
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935529#comment-15935529
]
Robert Kanter commented on OOZIE-2820:
--
+1
> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Grant Sohn
>Assignee: Laszlo Zeke
>Priority: Trivial
> Attachments: OOZIE-2820-1.patch, OOZIE-2820-2.patch
>
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:
> sb.append("Deamon
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging
[
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928259#comment-15928259
]
Hadoop QA commented on OOZIE-2820:
--
Testing JIRA OOZIE-2820
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [core].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1892
.Tests failed: 3
.Tests errors: 0
.The patch failed the following testcases:
.
testBundleStatusTransitWithLock(org.apache.oozie.service.TestStatusTransitService)
.
testActionKillCommandDate(org.apache.oozie.command.coord.TestCoordActionsKillXCommand)
.
testCoordMaterializeTriggerService3(org.apache.oozie.service.TestCoordMaterializeTriggerService)
.Tests failing with errors:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3697/
> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Grant Sohn
>Assignee: Laszlo Zeke
>Priority: Trivial
> Attachments: OOZIE-2820-1.patch, OOZIE-2820-2.patch
>
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:
> sb.append("Deamon
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging
[
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927300#comment-15927300
]
Robert Kanter commented on OOZIE-2820:
--
Thanks [~lzeke]. Seems good, but one minor thing:
- For the {{LOG.debug("blacklist loading thrown exception");}} line, I think
that it should be "threw" instead of "thrown", and it would be good to pass the
exception to the logger so it will be logged too.
> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Grant Sohn
>Assignee: Laszlo Zeke
>Priority: Trivial
> Attachments: OOZIE-2820-1.patch
>
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:
> sb.append("Deamon
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging
[
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923845#comment-15923845
]
Laszlo Zeke commented on OOZIE-2820:
Thanks [~grant.sohn] and [~rkanter], it seems it did the trick.
> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Grant Sohn
>Priority: Trivial
> Attachments: OOZIE-2820-1.patch
>
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:
> sb.append("Deamon
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging
[
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922835#comment-15922835
]
Robert Kanter commented on OOZIE-2820:
--
[~lzeke], I think you should be able to attach a file and do most things other
than assign a JIRA to yourself without being a contributor. In any case I've
just made you one, so you should be able to do that now.
> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Grant Sohn
>Priority: Trivial
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:
> sb.append("Deamon
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging
[
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922712#comment-15922712
]
Grant Sohn commented on OOZIE-2820:
---
[~rkanter], can you add Laszlo to the contributors list?
Thanks,
Grant
> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Grant Sohn
>Priority: Trivial
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:
> sb.append("Deamon
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging
[
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907318#comment-15907318
]
Laszlo Zeke commented on OOZIE-2820:
Hi [~grant.sohn],
I understand your approach. I'm willing to limit my changes to the things you
listed. I'm wondering if backporting this particular change beforehand and deal
with the conflicts sooner rather then when a dependent change is backported
would make this issue easier.
Anyway, I still can't post patches which makes me wonder if I have to wait 24
hours after registration to do that or something is not right with my
permissions.
Thanks,
Laszlo
> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Grant Sohn
>Priority: Trivial
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:
> sb.append("Deamon
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging
[
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906994#comment-15906994
]
Grant Sohn commented on OOZIE-2820:
---
Lazlo,
Thanks for contributing your changes! However, there is a slight problem with
fixing all spelling typos in one patch which is this will be difficult to
backport since all the changes to all these files will be tied together. For
that reason, I've limited my changes and JIRAs to user-facing typos (CLI usage,
logging, exception messages: like OOZIE-2740 for example). That said, you
could definitely use this approach for the docs since non-code changes wouldn't
suffer from this backporting-to-release-branches issue.
You can refer to
https://cwiki.apache.org/confluence/display/OOZIE/How+To+Contribute on how to
create and submit patches.
Thanks,
Grant
> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Grant Sohn
>Priority: Trivial
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:
> sb.append("Deamon
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging
[
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906687#comment-15906687
]
Peter Cseh commented on OOZIE-2820:
---
hey [~lzeke],
Thanks for the contribution!
Please attach a patch file to the Jira. You should be able to do so under More
> Attach file.
This will trigger the pre-commit job. [~rkanter] or [~rohini] can make you a
contributor so you can be assigned to an issue.
gp
> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Grant Sohn
>Priority: Trivial
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:
> sb.append("Deamon
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging
[
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906604#comment-15906604
]
Laszlo Zeke commented on OOZIE-2820:
Hi [~grant.sohn],
I'd like to submit a patch for this. I'm not sure how to proceed (don't see
where I can assign myself to this issue or submit the patch). As a matter of
fact this would be my first contribution to Oozie. Anyway, I uploaded the patch
in reviewboard, the link is here: [https://reviews.apache.org/r/57546/]
As for the issue itself I went through a little more than you listed. I mostly
fixed comments, log messages or local variable names and only those I was sure
that they are actual typos - there were a few debatable ones.
Still you should review it with care. Also I'm not sure if the log messages are
something that is being used/parsed by some other system out there.
The typos were found by Intellij Idea's Typo feature, I just went through most
source files I found. I did not touch test, examples, docs, which could be
interesting as well in the future.
Thanks,
Laszlo
> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
> Issue Type: Bug
> Components: core
>Reporter: Grant Sohn
>Priority: Trivial
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:
> sb.append("Deamon
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
