[jira] [Commented] (OOZIE-2825) Custom Authentication doc page is not well formatted
[ https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048554#comment-16048554 ] Robert Kanter commented on OOZIE-2825: -- +1 > Custom Authentication doc page is not well formatted > > > Key: OOZIE-2825 > URL: https://issues.apache.org/jira/browse/OOZIE-2825 > Project: Oozie > Issue Type: Sub-task >Reporter: Laszlo Zeke >Assignee: Jan Hentschel >Priority: Minor > Attachments: OOZIE-2825-1.patch, OOZIE-2825-2.patch, > OOZIE-2825-3.patch, OOZIE-2825-4.patch > > > At line 30 there's a verbatim tag staring but don't end. > Also at line 45 a paragraph is staring but it does not make a lot of sense > with a code sample seems to be cut in half. > All in ENG_Custom_Authentication.twiki -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OOZIE-2825) Custom Authentication doc page is not well formatted
[ https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046064#comment-16046064 ] Hadoop QA commented on OOZIE-2825: -- Testing JIRA OOZIE-2825 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any line longer than 132 .{color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings .{color:red}WARNING{color}: the current HEAD has 6 Javadoc warning(s) {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [tools]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} .Tests run: 1963 .Tests rerun: 3 .Tests failed at first run: org.apache.oozie.action.hadoop.TestHdfsOperations, {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3876/ > Custom Authentication doc page is not well formatted > > > Key: OOZIE-2825 > URL: https://issues.apache.org/jira/browse/OOZIE-2825 > Project: Oozie > Issue Type: Sub-task >Reporter: Laszlo Zeke >Assignee: Jan Hentschel >Priority: Minor > Attachments: OOZIE-2825-1.patch, OOZIE-2825-2.patch, > OOZIE-2825-3.patch, OOZIE-2825-4.patch > > > At line 30 there's a verbatim tag staring but don't end. > Also at line 45 a paragraph is staring but it does not make a lot of sense > with a code sample seems to be cut in half. > All in ENG_Custom_Authentication.twiki -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OOZIE-2825) Custom Authentication doc page is not well formatted
[ https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045995#comment-16045995 ] Hadoop QA commented on OOZIE-2825: -- Testing JIRA OOZIE-2825 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:red}-1{color} the patch contains 2 line(s) longer than 132 characters .{color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings .{color:red}WARNING{color}: the current HEAD has 6 Javadoc warning(s) {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} .Tests run: 1963 .Tests rerun: 79 .Tests failed at first run: org.apache.oozie.action.hadoop.TestJavaActionExecutor,org.apache.oozie.jms.TestJMSJobEventListener,org.apache.oozie.action.hadoop.TestLauncherAM, {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3873/ > Custom Authentication doc page is not well formatted > > > Key: OOZIE-2825 > URL: https://issues.apache.org/jira/browse/OOZIE-2825 > Project: Oozie > Issue Type: Sub-task >Reporter: Laszlo Zeke >Assignee: Jan Hentschel >Priority: Minor > Attachments: OOZIE-2825-1.patch, OOZIE-2825-2.patch, > OOZIE-2825-3.patch > > > At line 30 there's a verbatim tag staring but don't end. > Also at line 45 a paragraph is staring but it does not make a lot of sense > with a code sample seems to be cut in half. > All in ENG_Custom_Authentication.twiki -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OOZIE-2825) Custom Authentication doc page is not well formatted
[ https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045948#comment-16045948 ] Jan Hentschel commented on OOZIE-2825: -- [~rkanter] Thanks for your feedback. I tried to incorporate your feedback and updated the patch accordingly. > Custom Authentication doc page is not well formatted > > > Key: OOZIE-2825 > URL: https://issues.apache.org/jira/browse/OOZIE-2825 > Project: Oozie > Issue Type: Sub-task >Reporter: Laszlo Zeke >Assignee: Jan Hentschel >Priority: Minor > Attachments: OOZIE-2825-1.patch, OOZIE-2825-2.patch, > OOZIE-2825-3.patch > > > At line 30 there's a verbatim tag staring but don't end. > Also at line 45 a paragraph is staring but it does not make a lot of sense > with a code sample seems to be cut in half. > All in ENG_Custom_Authentication.twiki -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OOZIE-2825) Custom Authentication doc page is not well formatted
[ https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955960#comment-15955960 ] Robert Kanter commented on OOZIE-2825: -- Thanks for taking a look at this. I left some specific comments on RB, but I think this page needs a much larger refactoring than simply tweaking the examples. Given the general unclarity with this information, and the fact that a lot of what it's talking about is actually part of Hadoop (specifically, the hadoop-auth module), I think we'd be better off removing a bunch of this and pointing to the Hadoop documentation (https://hadoop.apache.org/docs/r2.7.2/hadoop-auth/index.html). More specifically, I'd remove the code samples on this page. They're really unhelpful. Just point to the relevant Hadoop code instead. We can keep the mention and descriptions of the various Hadoop classes, and the stuff under the "Provide Custom Authentication to Oozie Client" because that's Oozie-specific. > Custom Authentication doc page is not well formatted > > > Key: OOZIE-2825 > URL: https://issues.apache.org/jira/browse/OOZIE-2825 > Project: Oozie > Issue Type: Sub-task >Reporter: Laszlo Zeke >Assignee: Jan Hentschel >Priority: Minor > Attachments: OOZIE-2825-1.patch, OOZIE-2825-2.patch > > > At line 30 there's a verbatim tag staring but don't end. > Also at line 45 a paragraph is staring but it does not make a lot of sense > with a code sample seems to be cut in half. > All in ENG_Custom_Authentication.twiki -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OOZIE-2825) Custom Authentication doc page is not well formatted
[ https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955094#comment-15955094 ] Hadoop QA commented on OOZIE-2825: -- Testing JIRA OOZIE-2825 Cleaning local git workspace > Custom Authentication doc page is not well formatted > > > Key: OOZIE-2825 > URL: https://issues.apache.org/jira/browse/OOZIE-2825 > Project: Oozie > Issue Type: Sub-task >Reporter: Laszlo Zeke >Assignee: Jan Hentschel >Priority: Minor > Attachments: OOZIE-2825-1.patch, OOZIE-2825-2.patch > > > At line 30 there's a verbatim tag staring but don't end. > Also at line 45 a paragraph is staring but it does not make a lot of sense > with a code sample seems to be cut in half. > All in ENG_Custom_Authentication.twiki -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OOZIE-2825) Custom Authentication doc page is not well formatted
[ https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948714#comment-15948714 ] Hadoop QA commented on OOZIE-2825: -- Testing JIRA OOZIE-2825 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:red}-1{color} the patch contains 2 line(s) with tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any line longer than 132 .{color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [hadooplibs/hadoop-utils-2]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [tools]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} - patch does not compile, cannot run testcases {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3751/ > Custom Authentication doc page is not well formatted > > > Key: OOZIE-2825 > URL: https://issues.apache.org/jira/browse/OOZIE-2825 > Project: Oozie > Issue Type: Sub-task >Reporter: Laszlo Zeke >Assignee: Jan Hentschel >Priority: Minor > Attachments: OOZIE-2825-1.patch > > > At line 30 there's a verbatim tag staring but don't end. > Also at line 45 a paragraph is staring but it does not make a lot of sense > with a code sample seems to be cut in half. > All in ENG_Custom_Authentication.twiki -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OOZIE-2825) Custom Authentication doc page is not well formatted
[ https://issues.apache.org/jira/browse/OOZIE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932047#comment-15932047 ] Hadoop QA commented on OOZIE-2825: -- Testing JIRA OOZIE-2825 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:red}-1{color} the patch contains 2 line(s) with tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any line longer than 132 .{color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. .{color:green}+1{color} There are no new bugs found in [client]. .{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. .{color:green}+1{color} There are no new bugs found in [sharelib/distcp]. .{color:green}+1{color} There are no new bugs found in [sharelib/oozie]. .{color:green}+1{color} There are no new bugs found in [hadooplibs/hadoop-utils-2]. .{color:green}+1{color} There are no new bugs found in [core]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} - patch does not compile, cannot run testcases {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3706/ > Custom Authentication doc page is not well formatted > > > Key: OOZIE-2825 > URL: https://issues.apache.org/jira/browse/OOZIE-2825 > Project: Oozie > Issue Type: Sub-task >Reporter: Laszlo Zeke >Assignee: Jan Hentschel >Priority: Minor > Attachments: OOZIE-2825-1.patch > > > At line 30 there's a verbatim tag staring but don't end. > Also at line 45 a paragraph is staring but it does not make a lot of sense > with a code sample seems to be cut in half. > All in ENG_Custom_Authentication.twiki -- This message was sent by Atlassian JIRA (v6.3.15#6346)