[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

2017-03-29 Thread Peter Cseh (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947230#comment-15947230
 ] 

Peter Cseh commented on OOZIE-2841:
---

Thanks for fixing it [~abhishekbafna]!

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch, 
> OOZIE-2841.amend.patch, OOZIE-2841.wrong.patch, 
> test-patch-reports.after.tar.gz, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

2017-03-29 Thread Abhishek Bafna (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947204#comment-15947204
 ] 

Abhishek Bafna commented on OOZIE-2841:
---

[~gezapeti] I have pushed the contributor change into release-log, in the this 
commit: 
https://github.com/apache/oozie/commit/7c404ad0ea4c61e90e8c86015de25ef196168c29

Thanks. 

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch, 
> OOZIE-2841.amend.patch, OOZIE-2841.wrong.patch, 
> test-patch-reports.after.tar.gz, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

2017-03-28 Thread Abhishek Bafna (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945258#comment-15945258
 ] 

Abhishek Bafna commented on OOZIE-2841:
---

[~gezapeti]  I think this can be committed directly without any amend patch. 
Otherwise, we can take care of this into our next commit. Thanks.

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch, 
> OOZIE-2841.amend.patch, OOZIE-2841.wrong.patch, 
> test-patch-reports.after.tar.gz, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

2017-03-27 Thread Abhishek Bafna (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943596#comment-15943596
 ] 

Abhishek Bafna commented on OOZIE-2841:
---

[~gezapeti] You missed to add the username in the release-log.txt entry. Thanks.
Commit Link: 
https://github.com/apache/oozie/commit/890f69ead827467381983b185fd4fa9a6a0780cd
{{OOZIE-2841 Limit FindBugs diff errors in JIRA comments}}

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch, 
> OOZIE-2841.wrong.patch, test-patch-reports.after.tar.gz, 
> test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

2017-03-27 Thread Peter Cseh (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943440#comment-15943440
 ] 

Peter Cseh commented on OOZIE-2841:
---

+1

Thanks for the contribution! Committed to master!

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch, 
> OOZIE-2841.wrong.patch, test-patch-reports.after.tar.gz, 
> test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

2017-03-27 Thread Andras Piros (JIRA) 

[ 
https://issues-test.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941180#comment-15941180
 ] 

Andras Piros commented on OOZIE-2841:
-

Again, as the whole {{bin/*}} [*is outside {{apache-rat-plugin}} s 
range*|https://github.com/apache/oozie/blob/master/pom.xml#L1924], it's a false 
alarm.

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues-test.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch, 
> OOZIE-2841.wrong.patch, test-patch-reports.after.tar.gz, 
> test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

2017-03-24 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940591#comment-15940591
 ] 

Hadoop QA commented on OOZIE-2841:
--

Testing JIRA OOZIE-2841

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 11 line(s) longer than 132 
characters
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:red}-1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:red}-1{color} patch does not compile
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3729/

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch, 
> OOZIE-2841.wrong.patch, test-patch-reports.after.tar.gz, 
> test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

2017-03-24 Thread Peter Cseh (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940134#comment-15940134
 ] 

Peter Cseh commented on OOZIE-2841:
---

Thanks for the patch [~andras.piros]! 
We're having builds like the last one in OOZIE-1770, with lots of false alarms 
in the report.
Could you tweak this step to make it more robust somehow? Do you have guesses 
why this is happening?

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.wrong.patch, 
> test-patch-reports.after.tar.gz, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

2017-03-23 Thread Andras Piros (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939100#comment-15939100
 ] 

Andras Piros commented on OOZIE-2841:
-

As the whole {{bin/*}} [*is outside {{apache-rat-plugin}} s 
range*|https://github.com/apache/oozie/blob/master/pom.xml#L1924], it's a false 
alarm. [~gezapeti] [~pbacsko] can you pls. take a look?

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.wrong.patch, 
> test-patch-reports.after.tar.gz, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

2017-03-23 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939011#comment-15939011
 ] 

Hadoop QA commented on OOZIE-2841:
--

Testing JIRA OOZIE-2841

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 9 line(s) longer than 132 
characters
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1906
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3723/

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.wrong.patch, 
> test-patch-reports.after.tar.gz, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)