[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479670#comment-16479670
]
Hadoop QA commented on OOZIE-2867:
--
Testing JIRA OOZIE-2867
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2134
.{color:orange}Tests failed at first run:{color}
TestCoordMaterializeTriggerService#testCoordMaterializeTriggerService3
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/549/
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
>Priority: Major
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch,
> OOZIE-2867-5.patch, OOZIE-2867-6.patch, OOZIE-2867-7.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479571#comment-16479571
]
Hadoop QA commented on OOZIE-2867:
--
PreCommit-OOZIE-Build started
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
>Priority: Major
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch,
> OOZIE-2867-5.patch, OOZIE-2867-6.patch, OOZIE-2867-7.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479554#comment-16479554
]
Andras Piros commented on OOZIE-2867:
-
[~dbist13] can you please rebase the patch to current {{master}}? Thanks!
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
>Priority: Major
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch,
> OOZIE-2867-5.patch, OOZIE-2867-6.patch, OOZIE-2867-7.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234193#comment-16234193
]
Artem Ervits commented on OOZIE-2867:
-
[~gezapeti] [~rkanter] all tests pass locally. Can we get this into beta 5.0?
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
>Priority: Major
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch,
> OOZIE-2867-5.patch, OOZIE-2867-6.patch, OOZIE-2867-7.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227195#comment-16227195
]
Hadoop QA commented on OOZIE-2867:
--
Testing JIRA OOZIE-2867
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2049
.Tests failed: 8
.Tests errors: 2
.The patch failed the following testcases:
. testMain(org.apache.oozie.action.hadoop.TestHiveMain)
. testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
. testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
. testImportTablesOverflowBatchSize(org.apache.oozie.tools.TestDBLoadDump)
.
testImportInvalidDataLeavesTablesEmpty(org.apache.oozie.tools.TestDBLoadDump)
.
testImportToNonEmptyTablesCausesPrematureExit(org.apache.oozie.tools.TestDBLoadDump)
. testImportedDBIsExportedCorrectly(org.apache.oozie.tools.TestDBLoadDump)
.Tests failing with errors:
. testAddXIncludeFromReader(org.apache.oozie.util.TestXConfiguration)
. testAddXIncludeFromStream(org.apache.oozie.util.TestXConfiguration)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/156/
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch,
> OOZIE-2867-5.patch, OOZIE-2867-6.patch, OOZIE-2867-7.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090342#comment-16090342
]
Hadoop QA commented on OOZIE-2867:
--
Testing JIRA OOZIE-2867
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 1 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 959
.Tests rerun: 3
.Tests failed at first run:
org.apache.oozie.action.hadoop.TestHdfsOperations,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3977/
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: trunk, 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch,
> OOZIE-2867-5.patch, OOZIE-2867-6.patch, OOZIE-2867-7.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086344#comment-16086344
]
Robert Kanter commented on OOZIE-2867:
--
That was a good idea with the test - better than what I was thinking :)
Here's some more feedback:
# Though given that the returned string is not used, you could have it return
something simpler, like a boolean. In fact, you could refactor
{{handleNonDSTFormatTZNames}} to be a little simpler, and move the log message
to the caller so the return value has a purpose. Something like this:
{code:java}
...
if (!handleNonDSTFormatTZNames(tzId)) {
LOG.warn("GMT, UTC or Region/City Timezone formats are preferred instead of
" + tzId);
}
...
{code}
{code:java}
static String handleNonDSTFormatTZNames(String tzId) {
...
Matcher m = THREE_LETTER_ID_PATTERN.matcher(tzId);
return m.matches() && !tzId.equalsIgnoreCase("UTC") &&
!tzId.equalsIgnoreCase("GMT");
}
{code}
And then update the unit test to match
# Let's rename {{handleNonDSTFormatTZNames}} to something more straightforward
like {{isThreeLetterTZName}}.
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: trunk, 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch,
> OOZIE-2867-5.patch, OOZIE-2867-6.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058009#comment-16058009
]
Artem Ervits commented on OOZIE-2867:
-
ran the failing tests locally and they passed
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: trunk, 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch,
> OOZIE-2867-5.patch, OOZIE-2867-6.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057917#comment-16057917
]
Hadoop QA commented on OOZIE-2867:
--
Testing JIRA OOZIE-2867
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 1 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1969
.Tests rerun: 64
.Tests failed at first run:
org.apache.oozie.action.hadoop.TestJavaActionExecutor,org.apache.oozie.action.hadoop.TestLauncherAM,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3916/
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: trunk, 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch,
> OOZIE-2867-5.patch, OOZIE-2867-6.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057001#comment-16057001
]
Hadoop QA commented on OOZIE-2867:
--
Testing JIRA OOZIE-2867
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 6 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1969
.Tests rerun: 79
.Tests failed at first run:
org.apache.oozie.action.hadoop.TestJavaActionExecutor,org.apache.oozie.jms.TestJMSJobEventListener,org.apache.oozie.action.hadoop.TestLauncherAM,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3915/
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: trunk, 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch, OOZIE-2867-5.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048532#comment-16048532
]
Robert Kanter commented on OOZIE-2867:
--
# On the unit test, I wasn't thinking - you're right. I think this can be done
but it's really messy. Instead, you could make {{THREE_LETTER_ID_PATTERN}}
package private and label it {{\@VisibleForTesting}} and just have the unit
test use it directly. It would be nice to simply call the method, but I think
this is the best compromise.
# I don't think we need the {{seleniumhq}} or {{com.opera}} artifacts, right?
# The nested if statement can be merged into one if statement:
{code:java}
if (m.matches() && !tzId.equalsIgnoreCase("UTC") &&
!tzId.equalsIgnoreCase("GMT")) {
...
{code}
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039563#comment-16039563
]
Hadoop QA commented on OOZIE-2867:
--
Testing JIRA OOZIE-2867
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 6 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1960
.Tests rerun: 72
.Tests failed at first run:
org.apache.oozie.action.hadoop.TestJavaActionExecutor,org.apache.oozie.coord.input.logic.TestCoordInputLogicPush,org.apache.oozie.action.hadoop.TestLauncherAM,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3865/
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033905#comment-16033905
]
Robert Kanter commented on OOZIE-2867:
--
Some feedback:
# In {{DateUtils}}, we should use {{XLog.getLog(getClass());}} to get the logger
# The regex pattern is not correct; there's an extra space. It will currently
match something like {{A }} (capital letter followed by three spaces) instead
of {{ABC}}.
# On the previous point, we should have some unit tests to verify this
functionality
# "preffered" should be spelled "preferred"
# I think the warning should mention that "GMT, UTC, or Region/City are
preferred". I know "Region/City" isn't exactly correct, but in light of
something better, that's the best thing to call it. Most users who hit this
message are likely looking for a non-GMT/UTC timezone and the message doesn't
currently help them for that.
# Instead of having an empty if statement block, let's reverse the logic and
remove the else block
# Let's also try to positively recommend the "Region/City" format in the docs
instead of only negatively recommending not using the three letter formats.
# I think we can omit the sentence about some of the IDs being deprecated
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009078#comment-16009078
]
Hadoop QA commented on OOZIE-2867:
--
Testing JIRA OOZIE-2867
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1936
.Tests failed: 1
.Tests errors: 2
.The patch failed the following testcases:
.
testUpdateConfForTimeLineServiceEnabled(org.apache.oozie.action.hadoop.TestJavaActionExecutor)
.Tests failing with errors:
. testNewUsingACLs(org.apache.oozie.util.TestZKUtilsWithSecurity)
. testCheckAndSetACLs(org.apache.oozie.util.TestZKUtilsWithSecurity)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3824/
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008895#comment-16008895
]
Hadoop QA commented on OOZIE-2867:
--
Testing JIRA OOZIE-2867
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 5 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1936
.Tests failed: 1
.Tests errors: 2
.The patch failed the following testcases:
.
testUpdateConfForTimeLineServiceEnabled(org.apache.oozie.action.hadoop.TestJavaActionExecutor)
.Tests failing with errors:
. testNewUsingACLs(org.apache.oozie.util.TestZKUtilsWithSecurity)
. testCheckAndSetACLs(org.apache.oozie.util.TestZKUtilsWithSecurity)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3823/
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998985#comment-15998985
]
Robert Kanter commented on OOZIE-2867:
--
Thanks for uploading a patch.
Looking into this some more, I think we should recommend _not_ using the
three-letter ids instead of recommending the "Continent/City" ids. There's a
few issues:
# IIRC, the available timezones can vary based on JVM and locale. That's why
Oracle doesn't provide a list of timezones but instead suggests
{{TimeZone.getAvailableIDs()}}.
# There's some additional "continents" that the patch is missing: "Antarctica",
"Canada", "Mexico", "US" (among others) which should work correctly.
# The previous issue ties into the next issue: "Continent/City" isn't really
correct. For instance, "Pacific" or "Indian" aren't continents. I guess
"Region/City" would be more accurate. Unfortunately, Oracle doesn't give this
syntax an official name as far as I can tell. However, there's also some
timezones that are simply country names with no city, like "Israel" or
"Iceland". So that's not really correct either.
The real problem is with the three-letter ids - all other ids are fine.
Besides the DST issue we saw, [the
docs|https://docs.oracle.com/javase/7/docs/api/java/util/TimeZone.html] even
say that some of them are deprecated because they're ambiguous. e.g. CST is
Central Standard Time and China Standard Time.
So I'd suggest these changes:
# Replace {{CONTINENT_PATTERN}} with something like
{{THREE_LETTER_ID_PATTERN="[A-Z]{3}"}} and give the warning when it matches
this; though make sure to still allow okay ones like "GMT" and "UTC". And of
course update the wording of the message and docs to match.
# Can you add a brief explanation to the docs on why we don't recommend using
the three letter ids? Basically that it won't handle DST shifts properly and
maybe an example? (e.g. "America/Los_Angeles" vs "PST" and "PDT")
# Updating the description text for {{oozie info -timezones}} is a good idea
# I don't think we really need the log trace line. The timezone should be
logged elsewhere already.
# Looks like there's a line that's too long
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996902#comment-15996902
]
Hadoop QA commented on OOZIE-2867:
--
Testing JIRA OOZIE-2867
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1935
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
. testGetTimeZoneWithLogging(org.apache.oozie.util.TestDateUtils)
.Tests failing with errors:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3803/
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996788#comment-15996788
]
Artem Ervits commented on OOZIE-2867:
-
[~andras.piros] I'll fix the line length, what about the failing test? Any
suggestions there?
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996286#comment-15996286
]
Hadoop QA commented on OOZIE-2867:
--
Testing JIRA OOZIE-2867
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1935
.Tests rerun: 15
.Tests failed at first run: org.apache.oozie.jms.TestJMSJobEventListener,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3802/
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996279#comment-15996279
]
Andras Piros commented on OOZIE-2867:
-
[~dbist13] can you please upload the patch w/ the failing test case.
I think I would just extend the second sentence on the CLI:
{noformat}
Give the ID to the -timezone argument, and in the coordinator definitions
{noformat}
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format
[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996011#comment-15996011
]
Artem Ervits commented on OOZIE-2867:
-
[~andras.piros] & [~rkanter] I think confusion stems from the fact that oozie
info -timezones actually suggets to use the short name. Should I also change
the output of oozie info -timezones command to emphasize the Continent/City
format?
$ oozie info -timezones
The format is "SHORT_NAME (ID)"
Give the ID to the -timezone argument
GMT offsets can also be used (e.g. GMT-07:00, GMT-0700, GMT+05:30, GMT+0530)
Available Time Zones:
GMT (Africa/Abidjan)
GMT (Africa/Accra)
EAT (Africa/Addis_Ababa)
CET (Africa/Algiers)
> Timezone handling for Coordinators: emphasize "Continent/City" format
> -
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Artem Ervits
> Fix For: 5.0.0
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
