[jira] [Commented] (OOZIE-2879) Remove unused class SLAStore and related classes
[
https://issues.apache.org/jira/browse/OOZIE-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858579#comment-16858579
]
Julia Kinga Marton commented on OOZIE-2879:
---
thank you [~asalamon74] for the contribution! +1, committed to master
> Remove unused class SLAStore and related classes
>
>
> Key: OOZIE-2879
> URL: https://issues.apache.org/jira/browse/OOZIE-2879
> Project: Oozie
> Issue Type: Sub-task
>Reporter: Peter Bacsko
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2879-01.patch
>
>
> While working on OOZIE-2854, I was looking for classes which use
> {{EntityManager}}. There is a class called {{SLAStore}} which uses it, but
> retrieving the call hierarchy revealed that only a test class invokes the
> methods of {{SLAStore}}.
> This class has been unused for a long time - it was deprecated in OOZIE-914
> (see commit:
> https://github.com/apache/oozie/commit/c95c809a55005b44b05f0c496e4a3fd75a26be91),
> so we should remove it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2879) Remove unused class SLAStore and related classes
[
https://issues.apache.org/jira/browse/OOZIE-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857792#comment-16857792
]
Hadoop QA commented on OOZIE-2879:
--
Testing JIRA OOZIE-2879
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [6] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:red}-1{color} There are [6] new bugs found below threshold in
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 207]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
.At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
.This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207]
.At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128]
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3168
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1141/
> Remove unused class SLAStore and related classes
>
>
> Key: OOZIE-2879
> URL: https://issues.apache.org/jira/browse/OOZIE-2879
> Project: Oozie
> Issue Type: Sub-task
>Reporter: Peter Bacsko
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2879-01.patch
>
>
> While working on OOZIE-2854, I was looking for classes which use
> {{EntityManager}}. There is a class called {{SLAStore}} which uses it, but
> retrieving the call hierarchy revealed that only a test class invokes the
> methods of {{SLAStore}}.
> This class has been unused for a long time - it was deprecated in OOZIE-914
> (see commit:
>
[jira] [Commented] (OOZIE-2879) Remove unused class SLAStore and related classes
[
https://issues.apache.org/jira/browse/OOZIE-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857648#comment-16857648
]
Hadoop QA commented on OOZIE-2879:
--
PreCommit-OOZIE-Build started
> Remove unused class SLAStore and related classes
>
>
> Key: OOZIE-2879
> URL: https://issues.apache.org/jira/browse/OOZIE-2879
> Project: Oozie
> Issue Type: Sub-task
>Reporter: Peter Bacsko
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2879-01.patch
>
>
> While working on OOZIE-2854, I was looking for classes which use
> {{EntityManager}}. There is a class called {{SLAStore}} which uses it, but
> retrieving the call hierarchy revealed that only a test class invokes the
> methods of {{SLAStore}}.
> This class has been unused for a long time - it was deprecated in OOZIE-914
> (see commit:
> https://github.com/apache/oozie/commit/c95c809a55005b44b05f0c496e4a3fd75a26be91),
> so we should remove it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2879) Remove unused class SLAStore and related classes
[
https://issues.apache.org/jira/browse/OOZIE-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857397#comment-16857397
]
Andras Salamon commented on OOZIE-2879:
---
[~pbacsko] Do you mind if I take this over?
> Remove unused class SLAStore and related classes
>
>
> Key: OOZIE-2879
> URL: https://issues.apache.org/jira/browse/OOZIE-2879
> Project: Oozie
> Issue Type: Bug
>Reporter: Peter Bacsko
>Assignee: Peter Bacsko
>Priority: Major
>
> While working on OOZIE-2854, I was looking for classes which use
> {{EntityManager}}. There is a class called {{SLAStore}} which uses it, but
> retrieving the call hierarchy revealed that only a test class invokes the
> methods of {{SLAStore}}.
> This class has been unused for a long time - it was deprecated in OOZIE-914
> (see commit:
> https://github.com/apache/oozie/commit/c95c809a55005b44b05f0c496e4a3fd75a26be91),
> so we should remove it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
