[jira] [Commented] (OOZIE-2933) Switch from Findbugs to Spotbugs
[ https://issues.apache.org/jira/browse/OOZIE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049507#comment-16049507 ] Robert Kanter commented on OOZIE-2933: -- +1 > Switch from Findbugs to Spotbugs > > > Key: OOZIE-2933 > URL: https://issues.apache.org/jira/browse/OOZIE-2933 > Project: Oozie > Issue Type: Improvement > Components: build >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: OOZIE-2933-1.patch, OOZIE-2933-2.patch, > oozie-findbugs-pre-commit.txt > > > Because Findbugs hadn't a new release in some time other projects such as > Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch > the current Findbugs implementation to Spotbugs, similar to the changes made > to Hadoop and HBase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OOZIE-2933) Switch from Findbugs to Spotbugs
[
https://issues.apache.org/jira/browse/OOZIE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048936#comment-16048936
]
Hadoop QA commented on OOZIE-2933:
--
Testing JIRA OOZIE-2933
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 6 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1963
.Tests rerun: 79
.Tests failed at first run:
org.apache.oozie.action.hadoop.TestJavaActionExecutor,org.apache.oozie.jms.TestJMSJobEventListener,org.apache.oozie.action.hadoop.TestLauncherAM,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3886/
> Switch from Findbugs to Spotbugs
>
>
> Key: OOZIE-2933
> URL: https://issues.apache.org/jira/browse/OOZIE-2933
> Project: Oozie
> Issue Type: Improvement
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2933-1.patch, OOZIE-2933-2.patch,
> oozie-findbugs-pre-commit.txt
>
>
> Because Findbugs hadn't a new release in some time other projects such as
> Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch
> the current Findbugs implementation to Spotbugs, similar to the changes made
> to Hadoop and HBase.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2933) Switch from Findbugs to Spotbugs
[ https://issues.apache.org/jira/browse/OOZIE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048801#comment-16048801 ] Jan Hentschel commented on OOZIE-2933: -- [~rkanter] Thanks for your comments. I updated the patch to the latest RC version and filed OOZIE-2945 for moving to the GA version as soon as it is available. For the "find-sec-bugs" I opened OOZIE-2946. I didn't include it in this patch to have a better separation. Regarding ReviewBoard: Thanks for the hint. I will keep it in mind. > Switch from Findbugs to Spotbugs > > > Key: OOZIE-2933 > URL: https://issues.apache.org/jira/browse/OOZIE-2933 > Project: Oozie > Issue Type: Improvement > Components: build >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: OOZIE-2933-1.patch, OOZIE-2933-2.patch, > oozie-findbugs-pre-commit.txt > > > Because Findbugs hadn't a new release in some time other projects such as > Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch > the current Findbugs implementation to Spotbugs, similar to the changes made > to Hadoop and HBase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OOZIE-2933) Switch from Findbugs to Spotbugs
[ https://issues.apache.org/jira/browse/OOZIE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048542#comment-16048542 ] Robert Kanter commented on OOZIE-2933: -- Thanks for doing this [~Jan Hentschel], I hadn't realized that findbugs is so old. A few minor things: # Looks like there's an 3.1.0 RC3 now, released not long ago; we may as well use that one. https://github.com/spotbugs/spotbugs/releases # Please file a followup JIRA to update to 3.1.0 GA release once it's out. It's best to not use RCs, but in this case I think it's okay. In any case, we should try to update again once it's GA. # The spotbugs website mentioned this "find-sec-bugs" plugin, which looks for security bugs in Java web apps, which is essentially what Oozie is. It would be great if we could add this plugin while we're here. http://find-sec-bugs.github.io/ Feel free to file this as a followup JIRA if you don't feel like working on it now though. By the way, we typically only use ReviewBoard for large/complicated changes or if someone asks. For simpler fixes, we don't usually bother. > Switch from Findbugs to Spotbugs > > > Key: OOZIE-2933 > URL: https://issues.apache.org/jira/browse/OOZIE-2933 > Project: Oozie > Issue Type: Improvement > Components: build >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: OOZIE-2933-1.patch, oozie-findbugs-pre-commit.txt > > > Because Findbugs hadn't a new release in some time other projects such as > Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch > the current Findbugs implementation to Spotbugs, similar to the changes made > to Hadoop and HBase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OOZIE-2933) Switch from Findbugs to Spotbugs
[
https://issues.apache.org/jira/browse/OOZIE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046418#comment-16046418
]
Hadoop QA commented on OOZIE-2933:
--
Testing JIRA OOZIE-2933
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> Switch from Findbugs to Spotbugs
>
>
> Key: OOZIE-2933
> URL: https://issues.apache.org/jira/browse/OOZIE-2933
> Project: Oozie
> Issue Type: Improvement
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2933-1.patch, oozie-findbugs-pre-commit.txt
>
>
> Because Findbugs hadn't a new release in some time other projects such as
> Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch
> the current Findbugs implementation to Spotbugs, similar to the changes made
> to Hadoop and HBase.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2933) Switch from Findbugs to Spotbugs
[
https://issues.apache.org/jira/browse/OOZIE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046295#comment-16046295
]
Andras Piros commented on OOZIE-2933:
-
Thanks for the contribution [~Jan Hentschel]!
To ensure that your changes do not influence existing behavior, can you please
take a run w/ the pre-commit FindBugs diff job as follows:
{code}
oozie$ bin/test-patch --patch=/path/to/some.patch --dirty-scm
--tasks=FINDBUGS_DIFF --verbose
{code}
> Switch from Findbugs to Spotbugs
>
>
> Key: OOZIE-2933
> URL: https://issues.apache.org/jira/browse/OOZIE-2933
> Project: Oozie
> Issue Type: Improvement
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2933-1.patch
>
>
> Because Findbugs hadn't a new release in some time other projects such as
> Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch
> the current Findbugs implementation to Spotbugs, similar to the changes made
> to Hadoop and HBase.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2933) Switch from Findbugs to Spotbugs
[
https://issues.apache.org/jira/browse/OOZIE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045761#comment-16045761
]
Hadoop QA commented on OOZIE-2933:
--
Testing JIRA OOZIE-2933
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 6 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1963
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
.
testMemoryUsageAndSpeedOverflowToDisk(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)
.Tests failing with errors:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3872/
> Switch from Findbugs to Spotbugs
>
>
> Key: OOZIE-2933
> URL: https://issues.apache.org/jira/browse/OOZIE-2933
> Project: Oozie
> Issue Type: Improvement
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: OOZIE-2933-1.patch
>
>
> Because Findbugs hadn't a new release in some time other projects such as
> Hadoop and HBase already switched to Spotbugs. This ticket proposes to switch
> the current Findbugs implementation to Spotbugs, similar to the changes made
> to Hadoop and HBase.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
