[jira] [Commented] (OOZIE-2943) Fix Findbugs warnings in oozie-sharelib-pig
[
https://issues.apache.org/jira/browse/OOZIE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064574#comment-16064574
]
Peter Cseh commented on OOZIE-2943:
---
+1
> Fix Findbugs warnings in oozie-sharelib-pig
> ---
>
> Key: OOZIE-2943
> URL: https://issues.apache.org/jira/browse/OOZIE-2943
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2943-1.patch, OOZIE-2943-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-sharelib-pig* module:
> {code}
> [INFO]
> org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map)
> makes inefficient use of keySet iterator instead of entrySet iterator
> [org.apache.oozie.action.hadoop.OoziePigStats] At OoziePigStats.java:[line
> 130]
> [INFO] Dead store to klass in
> org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean,
> boolean) [org.apache.oozie.action.hadoop.PigMain] At PigMain.java:[line 335]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMain.handleError(String): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 307]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMain.writeExternalData(String, File): new
> java.io.FileWriter(File) [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 408]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to clean
> up java.io.OutputStream on checked exception
> [org.apache.oozie.action.hadoop.PigMain,
> org.apache.oozie.action.hadoop.PigMain] Obligation to clean up resource
> created at PigMain.java:[line 130] is not dischargedPath continues at
> PigMain.java:[line 131]
> [INFO] org.apache.oozie.action.hadoop.PigMain.handleError(String) may fail to
> close stream on exception [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 307]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to close
> stream on exception [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 130]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI]
> At PigMainWithOldAPI.java:[line 265]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 126]Another occurrence at
> PigMainWithOldAPI.java:[line 219]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to clean up java.io.OutputStream on checked exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] Obligation to clean up
> resource created at PigMainWithOldAPI.java:[line 101] is not dischargedPath
> continues at PigMainWithOldAPI.java:[line 102]
> [INFO]
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 265]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 101]Another occurrence at
> PigMainWithOldAPI.java:[line 242]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 126]Another occurrence at
> PigMainWithOldAPI.java:[line 219]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2943) Fix Findbugs warnings in oozie-sharelib-pig
[
https://issues.apache.org/jira/browse/OOZIE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050150#comment-16050150
]
Jan Hentschel commented on OOZIE-2943:
--
Not sure, if the failing tests are flaky. Locally they are running fine.
> Fix Findbugs warnings in oozie-sharelib-pig
> ---
>
> Key: OOZIE-2943
> URL: https://issues.apache.org/jira/browse/OOZIE-2943
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2943-1.patch, OOZIE-2943-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-sharelib-pig* module:
> {code}
> [INFO]
> org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map)
> makes inefficient use of keySet iterator instead of entrySet iterator
> [org.apache.oozie.action.hadoop.OoziePigStats] At OoziePigStats.java:[line
> 130]
> [INFO] Dead store to klass in
> org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean,
> boolean) [org.apache.oozie.action.hadoop.PigMain] At PigMain.java:[line 335]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMain.handleError(String): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 307]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMain.writeExternalData(String, File): new
> java.io.FileWriter(File) [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 408]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to clean
> up java.io.OutputStream on checked exception
> [org.apache.oozie.action.hadoop.PigMain,
> org.apache.oozie.action.hadoop.PigMain] Obligation to clean up resource
> created at PigMain.java:[line 130] is not dischargedPath continues at
> PigMain.java:[line 131]
> [INFO] org.apache.oozie.action.hadoop.PigMain.handleError(String) may fail to
> close stream on exception [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 307]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to close
> stream on exception [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 130]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI]
> At PigMainWithOldAPI.java:[line 265]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 126]Another occurrence at
> PigMainWithOldAPI.java:[line 219]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to clean up java.io.OutputStream on checked exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] Obligation to clean up
> resource created at PigMainWithOldAPI.java:[line 101] is not dischargedPath
> continues at PigMainWithOldAPI.java:[line 102]
> [INFO]
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 265]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 101]Another occurrence at
> PigMainWithOldAPI.java:[line 242]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 126]Another occurrence at
> PigMainWithOldAPI.java:[line 219]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2943) Fix Findbugs warnings in oozie-sharelib-pig
[
https://issues.apache.org/jira/browse/OOZIE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049188#comment-16049188
]
Hadoop QA commented on OOZIE-2943:
--
Testing JIRA OOZIE-2943
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 6 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1963
.Tests failed: 6
.Tests errors: 2
.The patch failed the following testcases:
. testLoadDump(org.apache.oozie.tools.TestDBLoadDump)
. testMain(org.apache.oozie.action.hadoop.TestHiveMain)
. testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
. testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
.Tests failing with errors:
. testAddXIncludeFromReader(org.apache.oozie.util.TestXConfiguration)
. testAddXIncludeFromStream(org.apache.oozie.util.TestXConfiguration)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3892/
> Fix Findbugs warnings in oozie-sharelib-pig
> ---
>
> Key: OOZIE-2943
> URL: https://issues.apache.org/jira/browse/OOZIE-2943
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2943-1.patch, OOZIE-2943-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-sharelib-pig* module:
> {code}
> [INFO]
> org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map)
> makes inefficient use of keySet iterator instead of entrySet iterator
> [org.apache.oozie.action.hadoop.OoziePigStats] At OoziePigStats.java:[line
> 130]
> [INFO] Dead store to klass in
> org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean,
> boolean) [org.apache.oozie.action.hadoop.PigMain] At PigMain.java:[line 335]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMain.handleError(String): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 307]
> [INFO] Found reliance on default encoding
[jira] [Commented] (OOZIE-2943) Fix Findbugs warnings in oozie-sharelib-pig
[
https://issues.apache.org/jira/browse/OOZIE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049072#comment-16049072
]
Jan Hentschel commented on OOZIE-2943:
--
[~gezapeti] You're absolutely right. I updated the patch accordingly.
> Fix Findbugs warnings in oozie-sharelib-pig
> ---
>
> Key: OOZIE-2943
> URL: https://issues.apache.org/jira/browse/OOZIE-2943
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2943-1.patch, OOZIE-2943-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-sharelib-pig* module:
> {code}
> [INFO]
> org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map)
> makes inefficient use of keySet iterator instead of entrySet iterator
> [org.apache.oozie.action.hadoop.OoziePigStats] At OoziePigStats.java:[line
> 130]
> [INFO] Dead store to klass in
> org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean,
> boolean) [org.apache.oozie.action.hadoop.PigMain] At PigMain.java:[line 335]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMain.handleError(String): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 307]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMain.writeExternalData(String, File): new
> java.io.FileWriter(File) [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 408]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to clean
> up java.io.OutputStream on checked exception
> [org.apache.oozie.action.hadoop.PigMain,
> org.apache.oozie.action.hadoop.PigMain] Obligation to clean up resource
> created at PigMain.java:[line 130] is not dischargedPath continues at
> PigMain.java:[line 131]
> [INFO] org.apache.oozie.action.hadoop.PigMain.handleError(String) may fail to
> close stream on exception [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 307]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to close
> stream on exception [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 130]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI]
> At PigMainWithOldAPI.java:[line 265]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 126]Another occurrence at
> PigMainWithOldAPI.java:[line 219]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to clean up java.io.OutputStream on checked exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] Obligation to clean up
> resource created at PigMainWithOldAPI.java:[line 101] is not dischargedPath
> continues at PigMainWithOldAPI.java:[line 102]
> [INFO]
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 265]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 101]Another occurrence at
> PigMainWithOldAPI.java:[line 242]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 126]Another occurrence at
> PigMainWithOldAPI.java:[line 219]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2943) Fix Findbugs warnings in oozie-sharelib-pig
[
https://issues.apache.org/jira/browse/OOZIE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049061#comment-16049061
]
Peter Cseh commented on OOZIE-2943:
---
I think this change will change the generated JSONs:
{noformat}
-for (String cName : map.keySet()) {
-group.put(cName, map.get(cName));
+for (Map.Entry cName : map.entrySet()) {
+group.put(cName, cName.getValue());
{noformat}
shouldn't it be {{ group.put(cName.getKey(), cName.getValue());}} ?
> Fix Findbugs warnings in oozie-sharelib-pig
> ---
>
> Key: OOZIE-2943
> URL: https://issues.apache.org/jira/browse/OOZIE-2943
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2943-1.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-sharelib-pig* module:
> {code}
> [INFO]
> org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map)
> makes inefficient use of keySet iterator instead of entrySet iterator
> [org.apache.oozie.action.hadoop.OoziePigStats] At OoziePigStats.java:[line
> 130]
> [INFO] Dead store to klass in
> org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean,
> boolean) [org.apache.oozie.action.hadoop.PigMain] At PigMain.java:[line 335]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMain.handleError(String): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 307]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMain.writeExternalData(String, File): new
> java.io.FileWriter(File) [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 408]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to clean
> up java.io.OutputStream on checked exception
> [org.apache.oozie.action.hadoop.PigMain,
> org.apache.oozie.action.hadoop.PigMain] Obligation to clean up resource
> created at PigMain.java:[line 130] is not dischargedPath continues at
> PigMain.java:[line 131]
> [INFO] org.apache.oozie.action.hadoop.PigMain.handleError(String) may fail to
> close stream on exception [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 307]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to close
> stream on exception [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 130]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI]
> At PigMainWithOldAPI.java:[line 265]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 126]Another occurrence at
> PigMainWithOldAPI.java:[line 219]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to clean up java.io.OutputStream on checked exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] Obligation to clean up
> resource created at PigMainWithOldAPI.java:[line 101] is not dischargedPath
> continues at PigMainWithOldAPI.java:[line 102]
> [INFO]
> org.apache.oozie.action.hadoop.PigMainWithOldAPI.getHadoopJobIds(String) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 265]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 101]Another occurrence at
> PigMainWithOldAPI.java:[line 242]
> [INFO] org.apache.oozie.action.hadoop.PigMainWithOldAPI.run(String[]) may
> fail to close stream on exception
> [org.apache.oozie.action.hadoop.PigMainWithOldAPI,
> org.apache.oozie.action.hadoop.PigMainWithOldAPI] At
> PigMainWithOldAPI.java:[line 126]Another occurrence at
> PigMainWithOldAPI.java:[line 219]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-2943) Fix Findbugs warnings in oozie-sharelib-pig
[
https://issues.apache.org/jira/browse/OOZIE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047863#comment-16047863
]
Hadoop QA commented on OOZIE-2943:
--
Testing JIRA OOZIE-2943
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 6 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1963
.Tests rerun: 72
.Tests failed at first run:
org.apache.oozie.command.coord.TestCoordKillXCommand,org.apache.oozie.action.hadoop.TestJavaActionExecutor,org.apache.oozie.action.hadoop.TestLauncherAM,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3883/
> Fix Findbugs warnings in oozie-sharelib-pig
> ---
>
> Key: OOZIE-2943
> URL: https://issues.apache.org/jira/browse/OOZIE-2943
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
> Attachments: OOZIE-2943-1.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-sharelib-pig* module:
> {code}
> [INFO]
> org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map)
> makes inefficient use of keySet iterator instead of entrySet iterator
> [org.apache.oozie.action.hadoop.OoziePigStats] At OoziePigStats.java:[line
> 130]
> [INFO] Dead store to klass in
> org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean,
> boolean) [org.apache.oozie.action.hadoop.PigMain] At PigMain.java:[line 335]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMain.handleError(String): new
> java.io.FileReader(String) [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 307]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.PigMain.writeExternalData(String, File): new
> java.io.FileWriter(File) [org.apache.oozie.action.hadoop.PigMain] At
> PigMain.java:[line 408]
> [INFO] org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to clean
> up java.io.OutputStream on checked exception
> [org.apache.oozie.action.hadoop.PigMain,
> org.apache.oozie.action.hadoop.PigMain] Obligation to clean up resource
> created at PigMain.java:[line 130] is not dischargedPath continues at
