[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[
https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723190#comment-16723190
]
Hadoop QA commented on OOZIE-3397:
--
Testing JIRA OOZIE-3397
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [core].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3099
.{color:orange}Tests failed at first run:{color}
TestPurgeXCommand#testPurgeBundleWithCoordChildWithWFChild3MoreThanLimit
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/946/
> Improve logging in NotificationXCommand
> ---
>
> Key: OOZIE-3397
> URL: https://issues.apache.org/jira/browse/OOZIE-3397
> Project: Oozie
> Issue Type: Improvement
> Components: core
>Affects Versions: trunk
>Reporter: Julia Kinga Marton
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3397-amend-01-01.patch, OOZIE-3397.001.patch,
> OOZIE-3397.002.patch
>
>
> Around the notification sending (NotificationXCommand) there is not so much
> logging. For example if the HTTP call fails, the error is suppressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723089#comment-16723089 ] Hadoop QA commented on OOZIE-3397: -- PreCommit-OOZIE-Build started > Improve logging in NotificationXCommand > --- > > Key: OOZIE-3397 > URL: https://issues.apache.org/jira/browse/OOZIE-3397 > Project: Oozie > Issue Type: Improvement > Components: core >Affects Versions: trunk >Reporter: Julia Kinga Marton >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3397-amend-01-01.patch, OOZIE-3397.001.patch, > OOZIE-3397.002.patch > > > Around the notification sending (NotificationXCommand) there is not so much > logging. For example if the HTTP call fails, the error is suppressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723083#comment-16723083 ] Andras Piros commented on OOZIE-3397: - I'm convinced [~asalamon74] we already have the necessary amount of automatic testing on that part of functionality. +1 (pending Jenkins job for amendment patch 01) > Improve logging in NotificationXCommand > --- > > Key: OOZIE-3397 > URL: https://issues.apache.org/jira/browse/OOZIE-3397 > Project: Oozie > Issue Type: Improvement > Components: core >Affects Versions: trunk >Reporter: Julia Kinga Marton >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3397-amend-01-01.patch, OOZIE-3397.001.patch, > OOZIE-3397.002.patch > > > Around the notification sending (NotificationXCommand) there is not so much > logging. For example if the HTTP call fails, the error is suppressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[
https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722769#comment-16722769
]
Andras Salamon commented on OOZIE-3397:
---
[~andras.piros] I think my tests were really testing {{HttpURLConnection}} and
not {{NotificationXCommand}}. {{NotificationXCommand}} has nothing to do with
certificates, we should not add tests like that.
We might add unit tests for the following scenarios:
# Good and fast connection with response code 200.
# Good and slow ( but faster than timeout ) with response code 200
# Good but slow ( slower than timeout ) with response code 200
# Good connection with response code other than 200.
# Bad connection ( {{IOException}} )
To be honest I don't really see much additional value for these tests. The
first and third cases are already tested in
{{TestWorkflowNotificationXCommand}} and
{{TestCoordActionNotificationXCommand}}. {{sendNotification}} has {{void}}
return value and it does not throw an Exception, so if we want to test it we
need to check it we have to check the content of the log which might not be a
good idea. Or we could extract
[this|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/command/NotificationXCommand.java#L110-L125]
part of the method into a new method and test that method.
> Improve logging in NotificationXCommand
> ---
>
> Key: OOZIE-3397
> URL: https://issues.apache.org/jira/browse/OOZIE-3397
> Project: Oozie
> Issue Type: Improvement
> Components: core
>Affects Versions: trunk
>Reporter: Julia Kinga Marton
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3397-amend-01-01.patch, OOZIE-3397.001.patch,
> OOZIE-3397.002.patch
>
>
> Around the notification sending (NotificationXCommand) there is not so much
> logging. For example if the HTTP call fails, the error is suppressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722238#comment-16722238 ] Andras Piros commented on OOZIE-3397: - [~asalamon74] thanks for testing also those extended HTTPS scenarios manually! Do you think whether it makes sense to cover existing manual test cases w/ unit tests as well? > Improve logging in NotificationXCommand > --- > > Key: OOZIE-3397 > URL: https://issues.apache.org/jira/browse/OOZIE-3397 > Project: Oozie > Issue Type: Improvement > Components: core >Affects Versions: trunk >Reporter: Julia Kinga Marton >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3397-amend-01-01.patch, OOZIE-3397.001.patch, > OOZIE-3397.002.patch > > > Around the notification sending (NotificationXCommand) there is not so much > logging. For example if the HTTP call fails, the error is suppressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[
https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722197#comment-16722197
]
Andras Salamon commented on OOZIE-3397:
---
Thanks for checking [~andras.piros]
A few more manual tests:
Expired certificate:
{noformat}2018-12-15 16:23:19,992 WARN WorkflowNotificationXCommand:523 -
SERVER[SalamonAndras-MBP15.local] USER[-] GROUP[-] TOKEN[-] APP[-]
JOB[007-181215151113456-oozie-andr-W] ACTION[] Notification sending to URL
[https://expired.badssl.com/] failed
javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException:
PKIX path validation failed: java.security.cert.CertPathValidatorException:
validity check failed
at sun.security.ssl.Alerts.getSSLException(Alerts.java:192)
at sun.security.ssl.SSLSocketImpl.fatal(SSLSocketImpl.java:1964)
at sun.security.ssl.Handshaker.fatalSE(Handshaker.java:328)
at sun.security.ssl.Handshaker.fatalSE(Handshaker.java:322)
at
sun.security.ssl.ClientHandshaker.serverCertificate(ClientHandshaker.java:1614)
at
sun.security.ssl.ClientHandshaker.processMessage(ClientHandshaker.java:216)
at sun.security.ssl.Handshaker.processLoop(Handshaker.java:1052)
at sun.security.ssl.Handshaker.process_record(Handshaker.java:987)
at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:1072)
at
sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1385)
at
sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1413)
at
sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1397)
at
sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:559)
at
sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:185)
at
sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1564)
at
sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
at
java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
at
sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:347)
at
org.apache.oozie.command.NotificationXCommand.sendNotification(NotificationXCommand.java:118)
at
org.apache.oozie.command.NotificationXCommand.execute(NotificationXCommand.java:61)
at
org.apache.oozie.command.NotificationXCommand.execute(NotificationXCommand.java:29)
at org.apache.oozie.command.XCommand.call(XCommand.java:291)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:210)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: sun.security.validator.ValidatorException: PKIX path validation
failed: java.security.cert.CertPathValidatorException: validity check failed
at
sun.security.validator.PKIXValidator.doValidate(PKIXValidator.java:362)
at
sun.security.validator.PKIXValidator.engineValidate(PKIXValidator.java:259)
at sun.security.validator.Validator.validate(Validator.java:260)
at
sun.security.ssl.X509TrustManagerImpl.validate(X509TrustManagerImpl.java:324)
at
sun.security.ssl.X509TrustManagerImpl.checkTrusted(X509TrustManagerImpl.java:229)
at
sun.security.ssl.X509TrustManagerImpl.checkServerTrusted(X509TrustManagerImpl.java:124)
at
sun.security.ssl.ClientHandshaker.serverCertificate(ClientHandshaker.java:1596)
... 22 more
Caused by: java.security.cert.CertPathValidatorException: validity check failed
at
sun.security.provider.certpath.PKIXMasterCertPathValidator.validate(PKIXMasterCertPathValidator.java:135)
at
sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:233)
at
sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:141)
at
sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(PKIXCertPathValidator.java:80)
at
java.security.cert.CertPathValidator.validate(CertPathValidator.java:292)
at
sun.security.validator.PKIXValidator.doValidate(PKIXValidator.java:357)
... 28 more
Caused by: java.security.cert.CertificateExpiredException: NotAfter: Mon Apr 13
01:59:59 CEST 2015
at
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722185#comment-16722185 ] Andras Piros commented on OOZIE-3397: - Thanks [~asalamon74] for the amendment patch 001 and the test cases! Wherever it makes sense, can you please cover existing manual test cases w/ unit tests as well? Can you please test manually a few more scenarios (I think it's not applicable to test those automatically): * HTTPS connection, server certificate has been expired * HTTPS connection, server certificate is not trusted * HTTPS connection, self-signed server certificate that isn't part > Improve logging in NotificationXCommand > --- > > Key: OOZIE-3397 > URL: https://issues.apache.org/jira/browse/OOZIE-3397 > Project: Oozie > Issue Type: Improvement > Components: core >Affects Versions: trunk >Reporter: Julia Kinga Marton >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3397-amend-01-01.patch, OOZIE-3397.001.patch, > OOZIE-3397.002.patch > > > Around the notification sending (NotificationXCommand) there is not so much > logging. For example if the HTTP call fails, the error is suppressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[
https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722177#comment-16722177
]
Andras Salamon commented on OOZIE-3397:
---
I've tested several errors using the amend patch:
Invalid protocol
{noformat}
2018-12-15 13:45:53,467 WARN WorkflowNotificationXCommand:523 -
SERVER[SalamonAndras-MBP15.local] USER[-] GROUP[-] TOKEN[-] APP[-]
JOB[001-181215133935787-oozie-andr-W] ACTION[] Notification sending to URL
[invalidproto://invalidproto] failed
java.net.MalformedURLException: unknown protocol: invalidproto
at java.net.URL.(URL.java:600)
at java.net.URL.(URL.java:490)
at java.net.URL.(URL.java:439)
at
org.apache.oozie.command.NotificationXCommand.sendNotification(NotificationXCommand.java:112)
at
org.apache.oozie.command.NotificationXCommand.execute(NotificationXCommand.java:61)
at
org.apache.oozie.command.NotificationXCommand.execute(NotificationXCommand.java:29)
at org.apache.oozie.command.XCommand.call(XCommand.java:291)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:210)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{noformat}
Unknown host:
{noformat}
2018-12-15 13:45:05,507 WARN WorkflowNotificationXCommand:523 -
SERVER[SalamonAndras-MBP15.local] USER[-] GROUP[-] TOKEN[-] APP[-]
JOB[000-181215133935787-oozie-andr-W] ACTION[] Notification sending to URL
[http://thisisawrongurl] failed
java.net.UnknownHostException: thisisawrongurl
at
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:184)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:589)
at sun.net.NetworkClient.doConnect(NetworkClient.java:175)
at sun.net.www.http.HttpClient.openServer(HttpClient.java:463)
at sun.net.www.http.HttpClient.openServer(HttpClient.java:558)
at sun.net.www.http.HttpClient.(HttpClient.java:242)
at sun.net.www.http.HttpClient.New(HttpClient.java:339)
at sun.net.www.http.HttpClient.New(HttpClient.java:357)
at
sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1220)
at
sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1199)
at
sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1050)
at
sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:984)
at
sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1564)
at
sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
at
java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
at
org.apache.oozie.command.NotificationXCommand.sendNotification(NotificationXCommand.java:118)
at
org.apache.oozie.command.NotificationXCommand.execute(NotificationXCommand.java:61)
at
org.apache.oozie.command.NotificationXCommand.execute(NotificationXCommand.java:29)
at org.apache.oozie.command.XCommand.call(XCommand.java:291)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:210)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{noformat}
Working URL, which gives us response code 403 (instead of the expected 200):
{noformat}
2018-12-15 13:46:38,606 WARN WorkflowNotificationXCommand:523 -
SERVER[SalamonAndras-MBP15.local] USER[-] GROUP[-] TOKEN[-] APP[-]
JOB[002-181215133935787-oozie-andr-W] ACTION[] Notification sending to URL
[https://httpstat.us/403]
failed. response code: [403], response message: [Forbidden]
{noformat}
Good URL, which gives us a correct response code after 30 seconds, which is
greater than the 10 seconds timeout:
{noformat}
2018-12-15 14:00:33,902 WARN WorkflowNotificationXCommand:523 -
SERVER[SalamonAndras-MBP15.local] USER[-] GROUP[-] TOKEN[-] APP[-]
JOB[003-181215135150667-oozie-andr-W] ACTION[] Notification sending to URL
[https://httpstat.us/200?sleep=3] failed
java.net.SocketTimeoutException: Read timed out
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
at java.net.SocketInputStream.read(SocketInputStream.java:171)
at
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722129#comment-16722129 ] Julia Kinga Marton commented on OOZIE-3397: --- [~asalamon74] Sure, go ahead. Thank you for fixing it > Improve logging in NotificationXCommand > --- > > Key: OOZIE-3397 > URL: https://issues.apache.org/jira/browse/OOZIE-3397 > Project: Oozie > Issue Type: Improvement > Components: core >Affects Versions: trunk >Reporter: Julia Kinga Marton >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3397.001.patch, OOZIE-3397.002.patch > > > Around the notification sending (NotificationXCommand) there is not so much > logging. For example if the HTTP call fails, the error is suppressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[
https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722128#comment-16722128
]
Andras Salamon commented on OOZIE-3397:
---
The logging does not give too much information if the sending fails with an
{{IOException}}.
If a job is submitted with a wrong URL:
{noformat}
oozie job ... -run -Doozie.wf.workflow.notification.url=http://thisisawrongurl
{noformat}
The log contains the following information:
{noformat}
2018-12-15 13:01:37,369 WARN WorkflowNotificationXCommand:523 -
SERVER[SalamonAndras-MBP15.local] USER[-] GROUP[-] TOKEN[-] APP[-]
JOB[001-181215125708900-oozie-andr-W] ACTION[] Notification sending to URL
[http://thisisawrongurl] failed with exception [thisisawrongurl]
{noformat}
Reopening the issue. Hope you don't mind [~kmarton], I take it over and provide
an amend patch soon.
> Improve logging in NotificationXCommand
> ---
>
> Key: OOZIE-3397
> URL: https://issues.apache.org/jira/browse/OOZIE-3397
> Project: Oozie
> Issue Type: Improvement
> Components: core
>Affects Versions: trunk
>Reporter: Julia Kinga Marton
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3397.001.patch, OOZIE-3397.002.patch
>
>
> Around the notification sending (NotificationXCommand) there is not so much
> logging. For example if the HTTP call fails, the error is suppressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711167#comment-16711167 ] Julia Kinga Marton commented on OOZIE-3397: --- Thank you [~andras.piros] for the review. Committed to master > Improve logging in NotificationXCommand > --- > > Key: OOZIE-3397 > URL: https://issues.apache.org/jira/browse/OOZIE-3397 > Project: Oozie > Issue Type: Improvement > Components: core >Affects Versions: trunk >Reporter: Julia Kinga Marton >Assignee: Julia Kinga Marton >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3397.001.patch, OOZIE-3397.002.patch > > > Around the notification sending (NotificationXCommand) there is not so much > logging. For example if the HTTP call fails, the error is suppressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710246#comment-16710246 ] Andras Piros commented on OOZIE-3397: - Thanks for the contribution [~kmarton]! +1 > Improve logging in NotificationXCommand > --- > > Key: OOZIE-3397 > URL: https://issues.apache.org/jira/browse/OOZIE-3397 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Julia Kinga Marton >Assignee: Julia Kinga Marton >Priority: Major > Attachments: OOZIE-3397.001.patch, OOZIE-3397.002.patch > > > Around the notification sending (NotificationXCommand) there is not so much > logging. For example if the HTTP call fails, the error is suppressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[
https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710237#comment-16710237
]
Hadoop QA commented on OOZIE-3397:
--
Testing JIRA OOZIE-3397
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3100
.{color:orange}Tests failed at first run:{color}
TestCoordActionInputCheckXCommand#testNone
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/940/
> Improve logging in NotificationXCommand
> ---
>
> Key: OOZIE-3397
> URL: https://issues.apache.org/jira/browse/OOZIE-3397
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Julia Kinga Marton
>Assignee: Julia Kinga Marton
>Priority: Major
> Attachments: OOZIE-3397.001.patch, OOZIE-3397.002.patch
>
>
> Around the notification sending (NotificationXCommand) there is not so much
> logging. For example if the HTTP call fails, the error is suppressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[
https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710180#comment-16710180
]
Hadoop QA commented on OOZIE-3397:
--
Testing JIRA OOZIE-3397
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [core].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3100
.{color:orange}Tests failed at first run:{color}
TestPurgeXCommand#testPurgeBundleWithCoordChildWithWFChildWithSubWF2
TestPurgeXCommand#testPurgeCoordWithWFChild1
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/939/
> Improve logging in NotificationXCommand
> ---
>
> Key: OOZIE-3397
> URL: https://issues.apache.org/jira/browse/OOZIE-3397
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Julia Kinga Marton
>Assignee: Julia Kinga Marton
>Priority: Major
> Attachments: OOZIE-3397.001.patch, OOZIE-3397.002.patch
>
>
> Around the notification sending (NotificationXCommand) there is not so much
> logging. For example if the HTTP call fails, the error is suppressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710077#comment-16710077 ] Hadoop QA commented on OOZIE-3397: -- PreCommit-OOZIE-Build started > Improve logging in NotificationXCommand > --- > > Key: OOZIE-3397 > URL: https://issues.apache.org/jira/browse/OOZIE-3397 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Julia Kinga Marton >Assignee: Julia Kinga Marton >Priority: Major > Attachments: OOZIE-3397.001.patch, OOZIE-3397.002.patch > > > Around the notification sending (NotificationXCommand) there is not so much > logging. For example if the HTTP call fails, the error is suppressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710076#comment-16710076 ] Julia Kinga Marton commented on OOZIE-3397: --- Sure [~andras.piros]. The new patch contains that additional log entry. > Improve logging in NotificationXCommand > --- > > Key: OOZIE-3397 > URL: https://issues.apache.org/jira/browse/OOZIE-3397 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Julia Kinga Marton >Assignee: Julia Kinga Marton >Priority: Major > Attachments: OOZIE-3397.001.patch, OOZIE-3397.002.patch > > > Around the notification sending (NotificationXCommand) there is not so much > logging. For example if the HTTP call fails, the error is suppressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[
https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710066#comment-16710066
]
Andras Piros commented on OOZIE-3397:
-
Thanks for the contribution [~kmarton]! Can you please also add a {{DEBUG}}
level message to know about the state or replies? Like \{{Trying for the \{0\}
time out of total \{1\}}}.
> Improve logging in NotificationXCommand
> ---
>
> Key: OOZIE-3397
> URL: https://issues.apache.org/jira/browse/OOZIE-3397
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Julia Kinga Marton
>Assignee: Julia Kinga Marton
>Priority: Major
> Attachments: OOZIE-3397.001.patch
>
>
> Around the notification sending (NotificationXCommand) there is not so much
> logging. For example if the HTTP call fails, the error is suppressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3397) Improve logging in NotificationXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710056#comment-16710056 ] Hadoop QA commented on OOZIE-3397: -- PreCommit-OOZIE-Build started > Improve logging in NotificationXCommand > --- > > Key: OOZIE-3397 > URL: https://issues.apache.org/jira/browse/OOZIE-3397 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Julia Kinga Marton >Assignee: Julia Kinga Marton >Priority: Major > Attachments: OOZIE-3397.001.patch > > > Around the notification sending (NotificationXCommand) there is not so much > logging. For example if the HTTP call fails, the error is suppressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
