[jira] [Commented] (OOZIE-3429) PreCommit FindBugs checking does not work
[ https://issues.apache.org/jira/browse/OOZIE-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803196#comment-16803196 ] Julia Kinga Marton commented on OOZIE-3429: --- It seems that is working now, however the diff tool is not working well, but this is a third party jar and we should replace it in OOZIE-3445, so I am going to close this issue > PreCommit FindBugs checking does not work > - > > Key: OOZIE-3429 > URL: https://issues.apache.org/jira/browse/OOZIE-3429 > Project: Oozie > Issue Type: Bug >Reporter: Andras Salamon >Assignee: Julia Kinga Marton >Priority: Major > > PreCommit FindBugs checking stopped reporting errors one or two months ago. > The first patch of OOZIE-3427 was > [reported|https://builds.apache.org/job/PreCommit-OOZIE-Build/992/consoleFull] > to be good: > {noformat}+1 There are no new bugs found in total. > +1 There are no new bugs found in [client]. > +1 There are no new bugs found in [server]. > +1 There are no new bugs found in [fluent-job/fluent-job-api]. > +1 There are no new bugs found in [webapp]. > +1 There are no new bugs found in [examples]. > +1 There are no new bugs found in [core]. > +1 There are no new bugs found in [docs]. > +1 There are no new bugs found in [tools]. > +1 There are no new bugs found in [sharelib/distcp]. > +1 There are no new bugs found in [sharelib/oozie]. > +1 There are no new bugs found in [sharelib/hive]. > +1 There are no new bugs found in [sharelib/spark]. > +1 There are no new bugs found in [sharelib/pig]. > +1 There are no new bugs found in [sharelib/hcatalog]. > +1 There are no new bugs found in [sharelib/sqoop]. > +1 There are no new bugs found in [sharelib/hive2]. > +1 There are no new bugs found in [sharelib/git]. > +1 There are no new bugs found in [sharelib/streaming]. > {noformat} > Executing the same test locally found one error: > {noformat}+1 PATCH_APPLIES > 0 There are [1] new bugs found in total that would be nice to have fixed. > +1 There are no new bugs found in [tools]. > 0 There are [1] new bugs found in [core] that would be nice to have fixed. > You can find the FindBugs diff here: core/findbugs-new.html > +1 There are no new bugs found in [webapp]. > +1 There are no new bugs found in [fluent-job/fluent-job-api]. > +1 There are no new bugs found in [server]. > +1 There are no new bugs found in [docs]. > +1 There are no new bugs found in [sharelib/pig]. > +1 There are no new bugs found in [sharelib/sqoop]. > +1 There are no new bugs found in [sharelib/hcatalog]. > +1 There are no new bugs found in [sharelib/hive2]. > +1 There are no new bugs found in [sharelib/streaming]. > +1 There are no new bugs found in [sharelib/oozie]. > +1 There are no new bugs found in [sharelib/hive]. > +1 There are no new bugs found in [sharelib/distcp]. > +1 There are no new bugs found in [sharelib/git]. > +1 There are no new bugs found in [sharelib/spark]. > +1 There are no new bugs found in [examples]. > +1 There are no new bugs found in [client]. > > +1 Overall result, good!, no -1s > {noformat} > Checking the output of the precommit shows that the patch is applied (at > least the number of classes are increased): > {noformat}$ diff FINDBUGS_DIFF-{clean,patch}.txt > 541c541 > < [INFO] Compiling 575 source files to > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/classes > --- > > [INFO] Compiling 576 source files to > > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/classes > 568c568 > < [INFO] Compiling 392 source files to > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/test-classes > --- > > [INFO] Compiling 393 source files to > > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/test-classes > ... > {noformat} > I've found one suspicious thing in the precommits logs: > {noformat}[INFO] --- findbugs-maven-plugin:3.0.5:findbugs (findbugs) @ > oozie-core --- > [INFO] Fork Value is true > [java] The following classes needed for analysis were missing: > [java] getSharelibNames > [java] Warnings generated: 781 > [java] Missing classes: 1 > [INFO] Done FindBugs Analysis > {noformat} > This {{getShareLibNames}} warning is not present in the local findbugs output. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3429) PreCommit FindBugs checking does not work
[ https://issues.apache.org/jira/browse/OOZIE-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781822#comment-16781822 ] Andras Salamon commented on OOZIE-3429: --- It seems to me it's working again after OOZIE-3395: https://builds.apache.org/job/PreCommit-OOZIE-Build/1025/ https://builds.apache.org/job/PreCommit-OOZIE-Build/1026/ Maybe we should wait a few more runs, but I think we can close this issue soon. What do you think [~kmarton]? > PreCommit FindBugs checking does not work > - > > Key: OOZIE-3429 > URL: https://issues.apache.org/jira/browse/OOZIE-3429 > Project: Oozie > Issue Type: Bug >Reporter: Andras Salamon >Assignee: Julia Kinga Marton >Priority: Major > > PreCommit FindBugs checking stopped reporting errors one or two months ago. > The first patch of OOZIE-3427 was > [reported|https://builds.apache.org/job/PreCommit-OOZIE-Build/992/consoleFull] > to be good: > {noformat}+1 There are no new bugs found in total. > +1 There are no new bugs found in [client]. > +1 There are no new bugs found in [server]. > +1 There are no new bugs found in [fluent-job/fluent-job-api]. > +1 There are no new bugs found in [webapp]. > +1 There are no new bugs found in [examples]. > +1 There are no new bugs found in [core]. > +1 There are no new bugs found in [docs]. > +1 There are no new bugs found in [tools]. > +1 There are no new bugs found in [sharelib/distcp]. > +1 There are no new bugs found in [sharelib/oozie]. > +1 There are no new bugs found in [sharelib/hive]. > +1 There are no new bugs found in [sharelib/spark]. > +1 There are no new bugs found in [sharelib/pig]. > +1 There are no new bugs found in [sharelib/hcatalog]. > +1 There are no new bugs found in [sharelib/sqoop]. > +1 There are no new bugs found in [sharelib/hive2]. > +1 There are no new bugs found in [sharelib/git]. > +1 There are no new bugs found in [sharelib/streaming]. > {noformat} > Executing the same test locally found one error: > {noformat}+1 PATCH_APPLIES > 0 There are [1] new bugs found in total that would be nice to have fixed. > +1 There are no new bugs found in [tools]. > 0 There are [1] new bugs found in [core] that would be nice to have fixed. > You can find the FindBugs diff here: core/findbugs-new.html > +1 There are no new bugs found in [webapp]. > +1 There are no new bugs found in [fluent-job/fluent-job-api]. > +1 There are no new bugs found in [server]. > +1 There are no new bugs found in [docs]. > +1 There are no new bugs found in [sharelib/pig]. > +1 There are no new bugs found in [sharelib/sqoop]. > +1 There are no new bugs found in [sharelib/hcatalog]. > +1 There are no new bugs found in [sharelib/hive2]. > +1 There are no new bugs found in [sharelib/streaming]. > +1 There are no new bugs found in [sharelib/oozie]. > +1 There are no new bugs found in [sharelib/hive]. > +1 There are no new bugs found in [sharelib/distcp]. > +1 There are no new bugs found in [sharelib/git]. > +1 There are no new bugs found in [sharelib/spark]. > +1 There are no new bugs found in [examples]. > +1 There are no new bugs found in [client]. > > +1 Overall result, good!, no -1s > {noformat} > Checking the output of the precommit shows that the patch is applied (at > least the number of classes are increased): > {noformat}$ diff FINDBUGS_DIFF-{clean,patch}.txt > 541c541 > < [INFO] Compiling 575 source files to > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/classes > --- > > [INFO] Compiling 576 source files to > > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/classes > 568c568 > < [INFO] Compiling 392 source files to > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/test-classes > --- > > [INFO] Compiling 393 source files to > > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/test-classes > ... > {noformat} > I've found one suspicious thing in the precommits logs: > {noformat}[INFO] --- findbugs-maven-plugin:3.0.5:findbugs (findbugs) @ > oozie-core --- > [INFO] Fork Value is true > [java] The following classes needed for analysis were missing: > [java] getSharelibNames > [java] Warnings generated: 781 > [java] Missing classes: 1 > [INFO] Done FindBugs Analysis > {noformat} > This {{getShareLibNames}} warning is not present in the local findbugs output. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3429) PreCommit FindBugs checking does not work
[ https://issues.apache.org/jira/browse/OOZIE-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769245#comment-16769245 ] Andras Salamon commented on OOZIE-3429: --- It was also working for this build: https://builds.apache.org/job/PreCommit-OOZIE-Build/999/artifact/test-patch/reports/TEST-SUMMARY.txt > PreCommit FindBugs checking does not work > - > > Key: OOZIE-3429 > URL: https://issues.apache.org/jira/browse/OOZIE-3429 > Project: Oozie > Issue Type: Bug >Reporter: Andras Salamon >Assignee: Julia Kinga Marton >Priority: Major > > PreCommit FindBugs checking stopped reporting errors one or two months ago. > The first patch of OOZIE-3427 was > [reported|https://builds.apache.org/job/PreCommit-OOZIE-Build/992/consoleFull] > to be good: > {noformat}+1 There are no new bugs found in total. > +1 There are no new bugs found in [client]. > +1 There are no new bugs found in [server]. > +1 There are no new bugs found in [fluent-job/fluent-job-api]. > +1 There are no new bugs found in [webapp]. > +1 There are no new bugs found in [examples]. > +1 There are no new bugs found in [core]. > +1 There are no new bugs found in [docs]. > +1 There are no new bugs found in [tools]. > +1 There are no new bugs found in [sharelib/distcp]. > +1 There are no new bugs found in [sharelib/oozie]. > +1 There are no new bugs found in [sharelib/hive]. > +1 There are no new bugs found in [sharelib/spark]. > +1 There are no new bugs found in [sharelib/pig]. > +1 There are no new bugs found in [sharelib/hcatalog]. > +1 There are no new bugs found in [sharelib/sqoop]. > +1 There are no new bugs found in [sharelib/hive2]. > +1 There are no new bugs found in [sharelib/git]. > +1 There are no new bugs found in [sharelib/streaming]. > {noformat} > Executing the same test locally found one error: > {noformat}+1 PATCH_APPLIES > 0 There are [1] new bugs found in total that would be nice to have fixed. > +1 There are no new bugs found in [tools]. > 0 There are [1] new bugs found in [core] that would be nice to have fixed. > You can find the FindBugs diff here: core/findbugs-new.html > +1 There are no new bugs found in [webapp]. > +1 There are no new bugs found in [fluent-job/fluent-job-api]. > +1 There are no new bugs found in [server]. > +1 There are no new bugs found in [docs]. > +1 There are no new bugs found in [sharelib/pig]. > +1 There are no new bugs found in [sharelib/sqoop]. > +1 There are no new bugs found in [sharelib/hcatalog]. > +1 There are no new bugs found in [sharelib/hive2]. > +1 There are no new bugs found in [sharelib/streaming]. > +1 There are no new bugs found in [sharelib/oozie]. > +1 There are no new bugs found in [sharelib/hive]. > +1 There are no new bugs found in [sharelib/distcp]. > +1 There are no new bugs found in [sharelib/git]. > +1 There are no new bugs found in [sharelib/spark]. > +1 There are no new bugs found in [examples]. > +1 There are no new bugs found in [client]. > > +1 Overall result, good!, no -1s > {noformat} > Checking the output of the precommit shows that the patch is applied (at > least the number of classes are increased): > {noformat}$ diff FINDBUGS_DIFF-{clean,patch}.txt > 541c541 > < [INFO] Compiling 575 source files to > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/classes > --- > > [INFO] Compiling 576 source files to > > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/classes > 568c568 > < [INFO] Compiling 392 source files to > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/test-classes > --- > > [INFO] Compiling 393 source files to > > /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/test-classes > ... > {noformat} > I've found one suspicious thing in the precommits logs: > {noformat}[INFO] --- findbugs-maven-plugin:3.0.5:findbugs (findbugs) @ > oozie-core --- > [INFO] Fork Value is true > [java] The following classes needed for analysis were missing: > [java] getSharelibNames > [java] Warnings generated: 781 > [java] Missing classes: 1 > [INFO] Done FindBugs Analysis > {noformat} > This {{getShareLibNames}} warning is not present in the local findbugs output. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3429) PreCommit FindBugs checking does not work
[ https://issues.apache.org/jira/browse/OOZIE-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769074#comment-16769074 ] Andras Salamon commented on OOZIE-3429: --- I don't really know why, but it was working for OOZIE-3418: https://builds.apache.org/job/PreCommit-OOZIE-Build/994/artifact/test-patch/reports/TEST-SUMMARY.txt {noformat}-1 There are [2] new bugs found below threshold in total that must be fixed. +1 There are no new bugs found in [sharelib/hive2]. +1 There are no new bugs found in [sharelib/spark]. +1 There are no new bugs found in [sharelib/oozie]. +1 There are no new bugs found in [sharelib/pig]. +1 There are no new bugs found in [sharelib/streaming]. +1 There are no new bugs found in [sharelib/hive]. +1 There are no new bugs found in [sharelib/distcp]. +1 There are no new bugs found in [sharelib/hcatalog]. +1 There are no new bugs found in [sharelib/sqoop]. +1 There are no new bugs found in [sharelib/git]. +1 There are no new bugs found in [client]. +1 There are no new bugs found in [docs]. +1 There are no new bugs found in [tools]. +1 There are no new bugs found in [fluent-job/fluent-job-api]. +1 There are no new bugs found in [server]. +1 There are no new bugs found in [webapp]. +1 There are no new bugs found in [examples]. -1 There are [2] new bugs found below threshold in [core] that must be fixed. You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html The most important FindBugs errors are: At FailingConnectionWrapper.java:[lines 357-373]: input must be non-null but is marked as nullable Method invoked at LiteWorkflowValidator.java:[line 185]: Null passed for non-null parameter of com.google.common.base.Objects.equal(Object, Object) in org.apache.oozie.workflow.lite.LiteWorkflowValidator.validateForkJoin(LiteWorkflowApp, NodeDef, NodeDef, String, boolean, Deque, Map, Map) Known null at LiteWorkflowValidator.java:[line 185] {noformat} > PreCommit FindBugs checking does not work > - > > Key: OOZIE-3429 > URL: https://issues.apache.org/jira/browse/OOZIE-3429 > Project: Oozie > Issue Type: Bug >Reporter: Andras Salamon >Assignee: Julia Kinga Marton >Priority: Major > > PreCommit FindBugs checking stopped reporting errors one or two months ago. > The first patch of OOZIE-3427 was > [reported|https://builds.apache.org/job/PreCommit-OOZIE-Build/992/consoleFull] > to be good: > {noformat}+1 There are no new bugs found in total. > +1 There are no new bugs found in [client]. > +1 There are no new bugs found in [server]. > +1 There are no new bugs found in [fluent-job/fluent-job-api]. > +1 There are no new bugs found in [webapp]. > +1 There are no new bugs found in [examples]. > +1 There are no new bugs found in [core]. > +1 There are no new bugs found in [docs]. > +1 There are no new bugs found in [tools]. > +1 There are no new bugs found in [sharelib/distcp]. > +1 There are no new bugs found in [sharelib/oozie]. > +1 There are no new bugs found in [sharelib/hive]. > +1 There are no new bugs found in [sharelib/spark]. > +1 There are no new bugs found in [sharelib/pig]. > +1 There are no new bugs found in [sharelib/hcatalog]. > +1 There are no new bugs found in [sharelib/sqoop]. > +1 There are no new bugs found in [sharelib/hive2]. > +1 There are no new bugs found in [sharelib/git]. > +1 There are no new bugs found in [sharelib/streaming]. > {noformat} > Executing the same test locally found one error: > {noformat}+1 PATCH_APPLIES > 0 There are [1] new bugs found in total that would be nice to have fixed. > +1 There are no new bugs found in [tools]. > 0 There are [1] new bugs found in [core] that would be nice to have fixed. > You can find the FindBugs diff here: core/findbugs-new.html > +1 There are no new bugs found in [webapp]. > +1 There are no new bugs found in [fluent-job/fluent-job-api]. > +1 There are no new bugs found in [server]. > +1 There are no new bugs found in [docs]. > +1 There are no new bugs found in [sharelib/pig]. > +1 There are no new bugs found in [sharelib/sqoop]. > +1 There are no new bugs found in [sharelib/hcatalog]. > +1 There are no new bugs found in [sharelib/hive2]. > +1 There are no new bugs found in [sharelib/streaming]. > +1 There are no new bugs found in [sharelib/oozie]. > +1 There are no new bugs found in [sharelib/hive]. > +1 There are no new bugs found in [sharelib/distcp]. > +1 There are no new bugs found in [sharelib/git]. > +1 There are no new bugs found in [sharelib/spark]. > +1 There are no new bugs found in [examples]. > +1 There are no new bugs found in [client]. > > +1 Overall result, good!, no -1s > {noformat} > Checking the output of the precommit shows that the patch is applied (at > least th