[jira] [Commented] (OOZIE-3567) Oozie ShellAction should support absolute bash file path
[ https://issues.apache.org/jira/browse/OOZIE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991396#comment-16991396 ] Andras Salamon commented on OOZIE-3567: --- [~roeyshemtov] Thanks for the patch, a few suggestions: * Please address the trailing space issue reported by the precommit * Please add unit test for the new method to test both working mode > Oozie ShellAction should support absolute bash file path > > > Key: OOZIE-3567 > URL: https://issues.apache.org/jira/browse/OOZIE-3567 > Project: Oozie > Issue Type: Improvement > Components: action >Affects Versions: 4.2.0, 5.0.0, 5.1.0 >Reporter: Roey Shem Tov >Assignee: Roey Shem Tov >Priority: Major > Labels: patch-available > Fix For: 5.3.0 > > Attachments: > 0001-OOZIE-3567-Oozie-ShellAction-should-support-absolute.patch > > > as related in OOZIE-3320 im opening a new PR (me from different user), still > can`t execute shell from mount at excpected. > > File is not checked to be existed on resolveExecutable, because mount can be > at the workers but not at the oozie servers (very common use). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OOZIE-3567) Oozie ShellAction should support absolute bash file path
[ https://issues.apache.org/jira/browse/OOZIE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990986#comment-16990986 ] Roey Shem Tov commented on OOZIE-3567: -- [~asalamon74] any suggestions ? > Oozie ShellAction should support absolute bash file path > > > Key: OOZIE-3567 > URL: https://issues.apache.org/jira/browse/OOZIE-3567 > Project: Oozie > Issue Type: Improvement > Components: action >Affects Versions: 4.2.0, 5.0.0, 5.1.0 >Reporter: Roey Shem Tov >Priority: Major > Labels: patch-available > Fix For: 5.3.0 > > Attachments: > 0001-OOZIE-3567-Oozie-ShellAction-should-support-absolute.patch > > > as related in OOZIE-3320 im opening a new PR (me from different user), still > can`t execute shell from mount at excpected. > > File is not checked to be existed on resolveExecutable, because mount can be > at the workers but not at the oozie servers (very common use). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OOZIE-3567) Oozie ShellAction should support absolute bash file path
[
https://issues.apache.org/jira/browse/OOZIE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989990#comment-16989990
]
Hadoop QA commented on OOZIE-3567:
--
Testing JIRA OOZIE-3567
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 1 line(s) with trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [4] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:red}-1{color} There are [4] new bugs found below threshold in
[core] that must be fixed.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 206]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
.At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
.java/io/File.(Ljava/lang/String;Ljava/lang/String;)V reads a
file whose location might be specified by user input: At
BulkJPAExecutor.java:[line 206]
.At AuthorizationService.java:[line 189]: At
AuthorizationService.java:[line 192]
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3199
.{color:orange}Tests failed at first run:{color}
TestBlockingInputStream#testLimitedWritingBlockingInputStream
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1265/
> Oozie ShellAction should support absolute bash file path
>
>
> Key: OOZIE-3567
> URL: https://issues.apache.org/jira/browse/OOZIE-3567
> Project: Oozie
> Issue Type: Improvement
> Components: action
>Affects Versions: 4.2.0, 5.0.0, 5.1.0
>Reporter: Roey Shem Tov
>Priority: Major
> Labels: patch-available
> Fix For: 5.3.0
>
> Attachments:
> 0001-OOZIE-3567-Oozie-ShellAction-should-support-absolute.patch
>
>
> as relat
[jira] [Commented] (OOZIE-3567) Oozie ShellAction should support absolute bash file path
[ https://issues.apache.org/jira/browse/OOZIE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989878#comment-16989878 ] Hadoop QA commented on OOZIE-3567: -- PreCommit-OOZIE-Build started > Oozie ShellAction should support absolute bash file path > > > Key: OOZIE-3567 > URL: https://issues.apache.org/jira/browse/OOZIE-3567 > Project: Oozie > Issue Type: Improvement > Components: action >Affects Versions: 4.2.0, 5.0.0, 5.1.0 >Reporter: Roey Shem Tov >Priority: Major > Labels: patch-available > Fix For: 5.3.0 > > Attachments: > 0001-OOZIE-3567-Oozie-ShellAction-should-support-absolute.patch > > > as related in OOZIE-3320 im opening a new PR (me from different user), still > can`t execute shell from mount at excpected. > > File is not checked to be existed on resolveExecutable, because mount can be > at the workers but not at the oozie servers (very common use). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OOZIE-3567) Oozie ShellAction should support absolute bash file path
[ https://issues.apache.org/jira/browse/OOZIE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989874#comment-16989874 ] Roey Shem Tov commented on OOZIE-3567: -- [~asalamon74] can help here why patch is failing? i upload a new one. > Oozie ShellAction should support absolute bash file path > > > Key: OOZIE-3567 > URL: https://issues.apache.org/jira/browse/OOZIE-3567 > Project: Oozie > Issue Type: Improvement > Components: action >Affects Versions: 4.2.0, 5.0.0, 5.1.0 >Reporter: Roey Shem Tov >Priority: Major > Labels: patch-available > Fix For: 5.3.0 > > Attachments: > 0001-OOZIE-3567-Oozie-ShellAction-should-support-absolute.patch > > > as related in OOZIE-3320 im opening a new PR (me from different user), still > can`t execute shell from mount at excpected. > > File is not checked to be existed on resolveExecutable, because mount can be > at the workers but not at the oozie servers (very common use). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OOZIE-3567) Oozie ShellAction should support absolute bash file path
[
https://issues.apache.org/jira/browse/OOZIE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989828#comment-16989828
]
Hadoop QA commented on OOZIE-3567:
--
Testing JIRA OOZIE-3567
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> Oozie ShellAction should support absolute bash file path
>
>
> Key: OOZIE-3567
> URL: https://issues.apache.org/jira/browse/OOZIE-3567
> Project: Oozie
> Issue Type: Improvement
> Components: action
>Affects Versions: 4.2.0, 5.0.0, 5.1.0
>Reporter: Roey Shem Tov
>Priority: Major
> Labels: patch-available
> Fix For: 5.3.0
>
> Attachments:
> [OOZIE-3567]_Oozie_ShellAction_should_support_absolute_bash_file_path.patch
>
>
> as related in OOZIE-3320 im opening a new PR (me from different user), still
> can`t execute shell from mount at excpected.
>
> File is not checked to be existed on resolveExecutable, because mount can be
> at the workers but not at the oozie servers (very common use).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3567) Oozie ShellAction should support absolute bash file path
[ https://issues.apache.org/jira/browse/OOZIE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989816#comment-16989816 ] Hadoop QA commented on OOZIE-3567: -- PreCommit-OOZIE-Build started > Oozie ShellAction should support absolute bash file path > > > Key: OOZIE-3567 > URL: https://issues.apache.org/jira/browse/OOZIE-3567 > Project: Oozie > Issue Type: Improvement > Components: action >Affects Versions: 4.2.0, 5.0.0, 5.1.0 >Reporter: Roey Shem Tov >Priority: Major > Labels: patch-available > Fix For: 5.3.0 > > Attachments: > [OOZIE-3567]_Oozie_ShellAction_should_support_absolute_bash_file_path.patch > > > as related in OOZIE-3320 im opening a new PR (me from different user), still > can`t execute shell from mount at excpected. > > File is not checked to be existed on resolveExecutable, because mount can be > at the workers but not at the oozie servers (very common use). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OOZIE-3567) Oozie ShellAction should support absolute bash file path
[ https://issues.apache.org/jira/browse/OOZIE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989799#comment-16989799 ] Roey Shem Tov commented on OOZIE-3567: -- [~asalamon74] No different at all, I opened OOZIE-3320 (from another user) and saw right now this wasn`t resolved, so i prefer to keep it from here (i changed main user at jira+github). > Oozie ShellAction should support absolute bash file path > > > Key: OOZIE-3567 > URL: https://issues.apache.org/jira/browse/OOZIE-3567 > Project: Oozie > Issue Type: Improvement > Components: action >Affects Versions: 4.2.0, 5.0.0, 5.1.0 >Reporter: Roey Shem Tov >Priority: Major > Fix For: 5.3.0 > > Attachments: > [OOZIE-3567]_Oozie_ShellAction_should_support_absolute_bash_file_path.patch > > > as related in OOZIE-3320 im opening a new PR (me from different user), still > can`t execute shell from mount at excpected. > > File is not checked to be existed on resolveExecutable, because mount can be > at the workers but not at the oozie servers (very common use). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OOZIE-3567) Oozie ShellAction should support absolute bash file path
[ https://issues.apache.org/jira/browse/OOZIE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989775#comment-16989775 ] Andras Salamon commented on OOZIE-3567: --- [~roeyshemtov] What is the difference between OOZIE-3320 and OOZIE-3567? > Oozie ShellAction should support absolute bash file path > > > Key: OOZIE-3567 > URL: https://issues.apache.org/jira/browse/OOZIE-3567 > Project: Oozie > Issue Type: Improvement > Components: action >Affects Versions: 4.2.0, 5.0.0, 5.1.0 >Reporter: Roey Shem Tov >Priority: Major > Fix For: 5.3.0 > > > as related in OOZIE-3320 im opening a new PR (me from different user), still > can`t execute shell from mount at excpected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
