[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655405#comment-17655405 ] János Makai commented on OOZIE-3696: Thank you [~dionusos] for the contribution, the change looks good and I've just pushed it to master. ;) > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: János Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655402#comment-17655402 ] ASF subversion and git services commented on OOZIE-3696: Commit a36bd2f8fa5b471957242727876d8de9f2b317c2 in oozie's branch refs/heads/master from Janos Makai [ https://gitbox.apache.org/repos/asf?p=oozie.git;h=a36bd2f8f ] OOZIE-3696 [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module (dionusos via jmakai) > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: János Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655385#comment-17655385 ] ASF subversion and git services commented on OOZIE-3696: Commit 5e29ce6efdf3ea47dcc7cc7a9caacaa0564fdbf6 in oozie's branch refs/heads/origin/master from Janos Makai [ https://gitbox.apache.org/repos/asf?p=oozie.git;h=5e29ce6ef ] OOZIE-3696 [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module (dionusos via jmakai) > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: János Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652800#comment-17652800 ] Dénes Bodó commented on OOZIE-3696: --- [~jmakai] if you accept my explanation could you please check the change and merge it if possible? Thank you > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: János Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650842#comment-17650842 ] Hadoop QA commented on OOZIE-3696: -- Testing JIRA OOZIE-3696 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any star imports .{color:green}+1{color} the patch does not introduce any line longer than 132 .{color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} Javadoc generation succeeded with the patch .{color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [1] new bugs found below threshold in total that must be fixed. .{color:green}+1{color} There are no new bugs found in [examples]. .{color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. .{color:green}+1{color} There are no new bugs found in [sharelib/hive]. .{color:green}+1{color} There are no new bugs found in [sharelib/hive2]. .{color:green}+1{color} There are no new bugs found in [sharelib/git]. .{color:green}+1{color} There are no new bugs found in [sharelib/distcp]. .{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. .{color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. .{color:green}+1{color} There are no new bugs found in [sharelib/spark]. .{color:red}-1{color} There are [1] new bugs found below threshold in [sharelib/oozie] that must be fixed. .You can find the SpotBugs diff here (look for the red and orange ones): sharelib/oozie/findbugs-new.html .The most important SpotBugs errors are: .At ShellMain.java:[line 93]: This usage of java/lang/ProcessBuilder.init(Ljava/util/List;)V can be vulnerable to Command Injection .At ShellMain.java:[line 91]: At ShellMain.java:[line 90] .At ShellMain.java:[line 92] .{color:green}+1{color} There are no new bugs found in [sharelib/pig]. .{color:green}+1{color} There are no new bugs found in [sharelib/streaming]. .{color:green}+1{color} There are no new bugs found in [server]. .{color:green}+1{color} There are no new bugs found in [docs]. .{color:green}+1{color} There are no new bugs found in [webapp]. .{color:green}+1{color} There are no new bugs found in [core]. .{color:green}+1{color} There are no new bugs found in [tools]. .{color:green}+1{color} There are no new bugs found in [client]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} .Tests run: 3259 .{color:orange}Tests failed at first run:{color} TestLocalOozieClientCoord#testJobsOperations TestBundleRerunXCommand#testBundleRerunInPausedWithError TestCoordActionsKillXCommand#testActionKillCommandDate .For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:green}+1 MODERNIZER{color} {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://ci-hadoop.apache.org/job/PreCommit-OOZIE-Build/175/ > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650720#comment-17650720 ] Hadoop QA commented on OOZIE-3696: -- PreCommit-OOZIE-Build started > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650717#comment-17650717 ] Dénes Bodó commented on OOZIE-3696: --- Thanks [~jmakai] . I think the {{.toLowerCase()}} is not mandatory as the change utilises {{.equalsIgnoreCase()}}. Regarding the test failures: I see tons of Connection Refused in HDFS communication. Locally I couldn't reproduce. Maybe it is some infra issue. I am restarting the check and will investigate if the rerun fails. > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650472#comment-17650472 ] Janos Makai commented on OOZIE-3696: Hi [~dionusos] , could you please check the unit test results? Also, please use .toLowerCase() in your patch set Thanks. > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650011#comment-17650011 ] Hadoop QA commented on OOZIE-3696: -- Testing JIRA OOZIE-3696 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any star imports .{color:green}+1{color} the patch does not introduce any line longer than 132 .{color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} Javadoc generation succeeded with the patch .{color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. .{color:green}+1{color} There are no new bugs found in [client]. .{color:green}+1{color} There are no new bugs found in [webapp]. .{color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. .{color:green}+1{color} There are no new bugs found in [server]. .{color:green}+1{color} There are no new bugs found in [core]. .{color:green}+1{color} There are no new bugs found in [sharelib/spark]. .{color:green}+1{color} There are no new bugs found in [sharelib/hive2]. .{color:green}+1{color} There are no new bugs found in [sharelib/distcp]. .{color:green}+1{color} There are no new bugs found in [sharelib/streaming]. .{color:green}+1{color} There are no new bugs found in [sharelib/hive]. .{color:green}+1{color} There are no new bugs found in [sharelib/git]. .{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. .{color:green}+1{color} There are no new bugs found in [sharelib/pig]. .{color:green}+1{color} There are no new bugs found in [sharelib/oozie]. .{color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. .{color:green}+1{color} There are no new bugs found in [tools]. .{color:green}+1{color} There are no new bugs found in [docs]. .{color:green}+1{color} There are no new bugs found in [examples]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} .Tests run: 2926 .Tests failed : 0 .Tests in error : 84 .Tests timed out : 1 {color:red}-1{color} [ERROR] There are [84] test errors in [core]. Listing only the first [5] ones testCoordActionsGetByActionNumber:org.apache.oozie.executor.jpa.TestCoordJobGetActionByActionNumberJPAExecutor Check console output for the full list of errors/failures {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:green}+1 MODERNIZER{color} {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://ci-hadoop.apache.org/job/PreCommit-OOZIE-Build/174/ > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3696) [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git module
[ https://issues.apache.org/jira/browse/OOZIE-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649842#comment-17649842 ] Hadoop QA commented on OOZIE-3696: -- PreCommit-OOZIE-Build started > [sharelib-git] Fix current SpotBugs discovered issues in Oozie's sharelib-git > module > > > Key: OOZIE-3696 > URL: https://issues.apache.org/jira/browse/OOZIE-3696 > Project: Oozie > Issue Type: Sub-task > Components: build >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Dénes Bodó >Priority: Major > Attachments: OOZIE-3696-001.patch, > Oozie-oozie-sharelib-git-SpotBugs-issues.txt > > > This ticket is created for fixing or filtering the SpotBugs related issues in > Oozie's sharelib-git module. > The exact SpotBugs output is attached for this module. > There are currently 2 SpotBugs discovered issues in this module. -- This message was sent by Atlassian Jira (v8.20.10#820010)