[jira] [Updated] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments
[
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Cseh updated OOZIE-2841:
--
Attachment: OOZIE-2841.amend.patch
> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
> Issue Type: Improvement
> Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch,
> OOZIE-2841.amend.patch, OOZIE-2841.wrong.patch,
> test-patch-reports.after.tar.gz, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times,
> however, there are cases when it's painful that we print out each and every
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say,
> top 5 from a module). This limitation will only be valid for
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains
> unchanged.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments
[
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hadoop QA updated OOZIE-2841:
-
[
https://issues-test.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941180#comment-15941180
]
Andras Piros commented on OOZIE-2841:
-
Again, as the whole {{bin/*}} [*is outside {{apache-rat-plugin}} s
range*|https://github.com/apache/oozie/blob/master/pom.xml#L1924], it's a false
alarm.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
> Issue Type: Improvement
> Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch,
> OOZIE-2841.wrong.patch, test-patch-reports.after.tar.gz,
> test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times,
> however, there are cases when it's painful that we print out each and every
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say,
> top 5 from a module). This limitation will only be valid for
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains
> unchanged.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments
[
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2841:
Attachment: OOZIE-2841.002.patch
New patch that addresses flakiness by issuing:
{noformat}
mvn clean compile test-compile findbugs:check -Dfindbugs.failOnError=false
-Dcheckstyle.failOnViolation=false
{noformat}
> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
> Issue Type: Improvement
> Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch,
> OOZIE-2841.wrong.patch, test-patch-reports.after.tar.gz,
> test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times,
> however, there are cases when it's painful that we print out each and every
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say,
> top 5 from a module). This limitation will only be valid for
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains
> unchanged.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments
[
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2841:
Attachment: OOZIE-2841.001.patch
> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
> Issue Type: Improvement
> Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.wrong.patch,
> test-patch-reports.after.tar.gz, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times,
> however, there are cases when it's painful that we print out each and every
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say,
> top 5 from a module). This limitation will only be valid for
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains
> unchanged.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments
[
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2841:
Attachment: test-patch-reports.after.tar.gz
The output after the patch.
> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
> Issue Type: Improvement
> Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.wrong.patch, test-patch-reports.after.tar.gz,
> test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times,
> however, there are cases when it's painful that we print out each and every
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say,
> top 5 from a module). This limitation will only be valid for
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains
> unchanged.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments
[
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2841:
Description:
In OOZIE-1986 the FindBugs diff functionality was introduced. At times,
however, there are cases when it's painful that we print out each and every
FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA
comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
We'll limit the FindBugs errors to be displayed within a module (let's say, top
5 from a module). This limitation will only be valid for {{TEST-SUMMARY.jira}}
and {{TEST-SUMMARY.txt}} - for {{TEST-SUMMARY-FULL.jira}} and
{{TEST-SUMMARY-FULL.txt}} the output remains unchanged.
was:
In OOZIE-1986 the FindBugs diff functionality was introduced. At times,
however, there are cases when it's painful that we print out each and every
FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA
comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
We'll limit the FindBugs errors to be displayed within a module (let's say, top
5 from a module), and within the whole project (let's say, top 25 from the
whole project). These limitations will only be valid for
{{test-patch/reports/TEST-SUMMARY.jira}} - for {{TEST-SUMMARY.txt}} the output
remains unchanged.
> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
> Issue Type: Improvement
> Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.wrong.patch, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times,
> however, there are cases when it's painful that we print out each and every
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say,
> top 5 from a module). This limitation will only be valid for
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains
> unchanged.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments
[
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2841:
Attachment: OOZIE-2841.wrong.patch
test-patch-reports.before.tar.gz
A patch that has in total 39 must fix FindBugs entries, and alone for {{core}}
it has 18. The state before the fix: all must fix FindBugs entries do appear
within {{test-patch/reports/TEST-SUMMARY.jira}}.
To test:
{noformat}
oozie$ bin/test-patch --patch=/path/to/OOZIE-2841.wrong.patch --dirty-scm
--tasks=FINDBUGS_DIFF --verbose -Dcheckstyle.failOnViolation=false
{noformat}
> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
> Issue Type: Improvement
> Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.wrong.patch, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times,
> however, there are cases when it's painful that we print out each and every
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say,
> top 5 from a module), and within the whole project (let's say, top 25 from
> the whole project). These limitations will only be valid for
> {{test-patch/reports/TEST-SUMMARY.jira}} - for {{TEST-SUMMARY.txt}} the
> output remains unchanged.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
