[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService
[
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2843:
Attachment: OOZIE-2843.007.patch
Addressing [~gezapeti]'s review comments.
> Enhance logging inside ZKLocksService and MemoryLocksService
>
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
> Issue Type: New Feature
> Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch, OOZIE-2843.002.patch,
> OOZIE-2843.003.patch, OOZIE-2843.004.patch, OOZIE-2843.005.patch,
> OOZIE-2843.006.patch, OOZIE-2843.007.patch
>
>
> Sometimes when Oozie tries to acquire lock [via
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
> or
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
> we don't get enough information whether the action succeeded or not. Also
> other details like retry count, timeout applied, etc. are not logged.
> Enhancing logging here would benefit debugging of lock handling within
> {{XCommand}} instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService
[
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2843:
Attachment: OOZIE-2843.006.patch
Addressing review comments.
> Enhance logging inside ZKLocksService and MemoryLocksService
>
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
> Issue Type: New Feature
> Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch, OOZIE-2843.002.patch,
> OOZIE-2843.003.patch, OOZIE-2843.004.patch, OOZIE-2843.005.patch,
> OOZIE-2843.006.patch
>
>
> Sometimes when Oozie tries to acquire lock [via
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
> or
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
> we don't get enough information whether the action succeeded or not. Also
> other details like retry count, timeout applied, etc. are not logged.
> Enhancing logging here would benefit debugging of lock handling within
> {{XCommand}} instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService
[
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2843:
Attachment: OOZIE-2843.005.patch
Shorten one line.
> Enhance logging inside ZKLocksService and MemoryLocksService
>
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
> Issue Type: New Feature
> Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch, OOZIE-2843.002.patch,
> OOZIE-2843.003.patch, OOZIE-2843.004.patch, OOZIE-2843.005.patch
>
>
> Sometimes when Oozie tries to acquire lock [via
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
> or
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
> we don't get enough information whether the action succeeded or not. Also
> other details like retry count, timeout applied, etc. are not logged.
> Enhancing logging here would benefit debugging of lock handling within
> {{XCommand}} instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService
[
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2843:
Attachment: OOZIE-2843.004.patch
Fixing very la(te)st FindBugs warning.
> Enhance logging inside ZKLocksService and MemoryLocksService
>
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
> Issue Type: New Feature
> Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch, OOZIE-2843.002.patch,
> OOZIE-2843.003.patch, OOZIE-2843.004.patch
>
>
> Sometimes when Oozie tries to acquire lock [via
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
> or
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
> we don't get enough information whether the action succeeded or not. Also
> other details like retry count, timeout applied, etc. are not logged.
> Enhancing logging here would benefit debugging of lock handling within
> {{XCommand}} instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService
[
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2843:
Attachment: OOZIE-2843.003.patch
Fixing previous FindBugs diff.
> Enhance logging inside ZKLocksService and MemoryLocksService
>
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
> Issue Type: New Feature
> Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch, OOZIE-2843.002.patch,
> OOZIE-2843.003.patch
>
>
> Sometimes when Oozie tries to acquire lock [via
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
> or
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
> we don't get enough information whether the action succeeded or not. Also
> other details like retry count, timeout applied, etc. are not logged.
> Enhancing logging here would benefit debugging of lock handling within
> {{XCommand}} instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService
[
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hadoop QA updated OOZIE-2843:
-
[
https://issues-test.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2843:
Attachment: OOZIE-2843.003.patch
Fixing new FindBugs error.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
> Enhance logging inside ZKLocksService and MemoryLocksService
>
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
> Issue Type: New Feature
> Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch, OOZIE-2843.002.patch
>
>
> Sometimes when Oozie tries to acquire lock [via
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
> or
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
> we don't get enough information whether the action succeeded or not. Also
> other details like retry count, timeout applied, etc. are not logged.
> Enhancing logging here would benefit debugging of lock handling within
> {{XCommand}} instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService
[
https://issues-test.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2843:
Attachment: OOZIE-2843.003.patch
Fixing new FindBugs error.
> Enhance logging inside ZKLocksService and MemoryLocksService
>
>
> Key: OOZIE-2843
> URL: https://issues-test.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
> Issue Type: New Feature
> Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch, OOZIE-2843.002.patch,
> OOZIE-2843.003.patch
>
>
> Sometimes when Oozie tries to acquire lock [via
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
> or
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
> we don't get enough information whether the action succeeded or not. Also
> other details like retry count, timeout applied, etc. are not logged.
> Enhancing logging here would benefit debugging of lock handling within
> {{XCommand}} instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService
[
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2843:
Attachment: OOZIE-2843.002.patch
Addressing the only FindBugs issue and introducing a new unit test for logging.
> Enhance logging inside ZKLocksService and MemoryLocksService
>
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
> Issue Type: New Feature
> Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch, OOZIE-2843.002.patch
>
>
> Sometimes when Oozie tries to acquire lock [via
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
> or
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
> we don't get enough information whether the action succeeded or not. Also
> other details like retry count, timeout applied, etc. are not logged.
> Enhancing logging here would benefit debugging of lock handling within
> {{XCommand}} instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService
[
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2843:
Attachment: OOZIE-2843.001.patch
Apart from enhancing the logging in those classes, also reworked the
synchronization pattern of {{ZKLocksService.acquireLock()}}: helping ZooKeeper
keep up w/ the load by trying to acquire a lock on a single thread per JVM.
> Enhance logging inside ZKLocksService and MemoryLocksService
>
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
> Issue Type: New Feature
> Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch
>
>
> Sometimes when Oozie tries to acquire lock [via
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
> or
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
> we don't get enough information whether the action succeeded or not. Also
> other details like retry count, timeout applied, etc. are not logged.
> Enhancing logging here would benefit debugging of lock handling within
> {{XCommand}} instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService
[
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2843:
Priority: Minor (was: Major)
> Enhance logging inside ZKLocksService and MemoryLocksService
>
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
> Issue Type: New Feature
> Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
>
> Sometimes when Oozie tries to acquire lock [via
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
> or
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
> we don't get enough information whether the action succeeded or not. Also
> other details like retry count, timeout applied, etc. are not logged.
> Enhancing logging here would benefit debugging of lock handling within
> {{XCommand}} instances.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
