Re: Review Request 64408: OOZIE-2869 amend Ability to add/remove MapReduce jars from action classpath

[Peter Bacsko via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64408/#review193130
---




core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
Line 1564 (original), 1568 (patched)


Is it possible to test this somehow? I know it might not be easy because 
it's a private method... But still, if there's a way to do it, I'd appreciate 
it.


- Peter Bacsko


On dec. 7, 2017, 10 de, András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64408/
> ---
> 
> (Updated dec. 7, 2017, 10 de)
> 
> 
> Review request for oozie and Peter Cseh.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2869 amend Ability to add/remove MapReduce jars from action classpath
> 
> On real clusters, `launcherConf` might not be populated. We fall back to 
> `ConfigurationService.get().getConf()` in such cases.
> Also, by default Hive2 and Java actions should also load MapReduce sharelib 
> files.
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> cab0d8b314cee3d42ee312aeeeccaf10529908d4 
>   core/src/main/java/org/apache/oozie/service/ConfigurationService.java 
> 4707252bef3a232a6e815360a18fe440e16ebdcc 
>   core/src/main/resources/oozie-default.xml 
> 7ec64bc9955b5cd5ce52e25785096fff0c7d3cca 
> 
> 
> Diff: https://reviews.apache.org/r/64408/diff/1/
> 
> 
> Testing
> ---
> 
> All relevant action types on a real cluster.
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 64408: OOZIE-2869 amend Ability to add/remove MapReduce jars from action classpath

[Peter Bacsko via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64408/#review193132
---




core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
Line 1559 (original), 1559 (patched)


This statement is no longer valid: "Subclasses should override this method 
if necessary"


- Peter Bacsko


On dec. 7, 2017, 10 de, András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64408/
> ---
> 
> (Updated dec. 7, 2017, 10 de)
> 
> 
> Review request for oozie and Peter Cseh.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2869 amend Ability to add/remove MapReduce jars from action classpath
> 
> On real clusters, `launcherConf` might not be populated. We fall back to 
> `ConfigurationService.get().getConf()` in such cases.
> Also, by default Hive2 and Java actions should also load MapReduce sharelib 
> files.
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> cab0d8b314cee3d42ee312aeeeccaf10529908d4 
>   core/src/main/java/org/apache/oozie/service/ConfigurationService.java 
> 4707252bef3a232a6e815360a18fe440e16ebdcc 
>   core/src/main/resources/oozie-default.xml 
> 7ec64bc9955b5cd5ce52e25785096fff0c7d3cca 
> 
> 
> Diff: https://reviews.apache.org/r/64408/diff/1/
> 
> 
> Testing
> ---
> 
> All relevant action types on a real cluster.
> 
> 
> Thanks,
> 
> András Piros
> 
>

Review Request 64408: OOZIE-2869 amend Ability to add/remove MapReduce jars from action classpath

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64408/
---

Review request for oozie and Peter Cseh.


Repository: oozie-git


Description
---

OOZIE-2869 amend Ability to add/remove MapReduce jars from action classpath

On real clusters, `launcherConf` might not be populated. We fall back to 
`ConfigurationService.get().getConf()` in such cases.
Also, by default Hive2 and Java actions should also load MapReduce sharelib 
files.


Diffs
-

  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
cab0d8b314cee3d42ee312aeeeccaf10529908d4 
  core/src/main/java/org/apache/oozie/service/ConfigurationService.java 
4707252bef3a232a6e815360a18fe440e16ebdcc 
  core/src/main/resources/oozie-default.xml 
7ec64bc9955b5cd5ce52e25785096fff0c7d3cca 


Diff: https://reviews.apache.org/r/64408/diff/1/


Testing
---

All relevant action types on a real cluster.


Thanks,

András Piros