Re: Review Request 67999: Parsing sharelib timestamps is not threadsafe

2018-08-09 Thread András Piros via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67999/#review207018
---


Ship it!




Ship It!

- András Piros


On Aug. 9, 2018, 8:11 a.m., Denes Bodo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67999/
> ---
> 
> (Updated Aug. 9, 2018, 8:11 a.m.)
> 
> 
> Review request for oozie and András Piros.
> 
> 
> Bugs: OOZIE-3304
> https://issues.apache.org/jira/browse/OOZIE-3304
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> In rare cases the fNumberFormatException occurs while parsing latest sharelib 
> directory names
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/service/ShareLibService.java a901567 
>   core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 
> 5087505 
>   core/src/test/java/org/apache/oozie/service/TestShareLibService.java 
> d244166 
> 
> 
> Diff: https://reviews.apache.org/r/67999/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Denes Bodo
> 
>

Re: Review Request 67999: Parsing sharelib timestamps is not threadsafe

2018-08-09 Thread Denes Bodo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67999/
---

(Updated Aug. 9, 2018, 10:11 a.m.)


Review request for oozie and András Piros.


Changes
---

Eliminated too long line


Bugs: OOZIE-3304
https://issues.apache.org/jira/browse/OOZIE-3304


Repository: oozie-git


Description
---

In rare cases the fNumberFormatException occurs while parsing latest sharelib 
directory names


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/service/ShareLibService.java a901567 
  core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 
5087505 
  core/src/test/java/org/apache/oozie/service/TestShareLibService.java d244166 


Diff: https://reviews.apache.org/r/67999/diff/3/

Changes: https://reviews.apache.org/r/67999/diff/2-3/


Testing
---


Thanks,

Denes Bodo

Re: Review Request 67999: Parsing sharelib timestamps is not threadsafe

2018-08-08 Thread Denes Bodo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67999/
---

(Updated Aug. 8, 2018, 4:58 p.m.)


Review request for oozie and András Piros.


Bugs: OOZIE-3304
https://issues.apache.org/jira/browse/OOZIE-3304


Repository: oozie-git


Description
---

In rare cases the fNumberFormatException occurs while parsing latest sharelib 
directory names


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/service/ShareLibService.java a901567 
  core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 
5087505 
  core/src/test/java/org/apache/oozie/service/TestShareLibService.java d244166 


Diff: https://reviews.apache.org/r/67999/diff/2/

Changes: https://reviews.apache.org/r/67999/diff/1-2/


Testing
---


Thanks,

Denes Bodo

Re: Review Request 67999: Parsing sharelib timestamps is not threadsafe

2018-08-02 Thread Peter Bacsko via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67999/#review206798
---




core/src/test/java/org/apache/oozie/service/TestShareLibService.java
Lines 1045-1048 (patched)


Two big problems:

1. These have no effect on the test - the exception will be thrown on a 
different thread. You have to set a variable which gets examined later.

2. You don't wait for the threads to finish.


- Peter Bacsko


On júl. 20, 2018, 11 de, Denes Bodo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67999/
> ---
> 
> (Updated júl. 20, 2018, 11 de)
> 
> 
> Review request for oozie and András Piros.
> 
> 
> Bugs: OOZIE-3304
> https://issues.apache.org/jira/browse/OOZIE-3304
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> In rare cases the fNumberFormatException occurs while parsing latest sharelib 
> directory names
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/service/ShareLibService.java a901567 
>   core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 
> 5087505 
>   core/src/test/java/org/apache/oozie/service/TestShareLibService.java 
> d244166 
> 
> 
> Diff: https://reviews.apache.org/r/67999/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Denes Bodo
> 
>

Re: Review Request 67999: Parsing sharelib timestamps is not threadsafe

2018-07-31 Thread András Piros via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67999/#review206660
---




core/src/test/java/org/apache/oozie/service/TestShareLibService.java
Lines 1052 (patched)


Nice catch!


- András Piros


On July 20, 2018, 11 a.m., Denes Bodo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67999/
> ---
> 
> (Updated July 20, 2018, 11 a.m.)
> 
> 
> Review request for oozie and András Piros.
> 
> 
> Bugs: OOZIE-3304
> https://issues.apache.org/jira/browse/OOZIE-3304
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> In rare cases the fNumberFormatException occurs while parsing latest sharelib 
> directory names
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/service/ShareLibService.java a901567 
>   core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 
> 5087505 
>   core/src/test/java/org/apache/oozie/service/TestShareLibService.java 
> d244166 
> 
> 
> Diff: https://reviews.apache.org/r/67999/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Denes Bodo
> 
>

Re: Review Request 67999: Parsing sharelib timestamps is not threadsafe

2018-07-31 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67999/#review206659
---




core/src/test/java/org/apache/oozie/service/TestShareLibService.java
Lines 1052 (patched)


Please collect the threads in a List, and later call 'join' on each of 
that, otherwise the test function returns earlier than the threads would do 
it's stuff


- Zsombor Gegesy


On July 20, 2018, 11 a.m., Denes Bodo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67999/
> ---
> 
> (Updated July 20, 2018, 11 a.m.)
> 
> 
> Review request for oozie and András Piros.
> 
> 
> Bugs: OOZIE-3304
> https://issues.apache.org/jira/browse/OOZIE-3304
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> In rare cases the fNumberFormatException occurs while parsing latest sharelib 
> directory names
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/service/ShareLibService.java a901567 
>   core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 
> 5087505 
>   core/src/test/java/org/apache/oozie/service/TestShareLibService.java 
> d244166 
> 
> 
> Diff: https://reviews.apache.org/r/67999/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Denes Bodo
> 
>

Review Request 67999: Parsing sharelib timestamps is not threadsafe

2018-07-20 Thread Denes Bodo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67999/
---

Review request for oozie and András Piros.


Bugs: OOZIE-3304
https://issues.apache.org/jira/browse/OOZIE-3304


Repository: oozie-git


Description
---

In rare cases the fNumberFormatException occurs while parsing latest sharelib 
directory names


Diffs
-

  core/src/main/java/org/apache/oozie/service/ShareLibService.java a901567 
  core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 
5087505 
  core/src/test/java/org/apache/oozie/service/TestShareLibService.java d244166 


Diff: https://reviews.apache.org/r/67999/diff/1/


Testing
---


Thanks,

Denes Bodo